- 20 Mar, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/26faa9f236f4..aa79e2674359 git log 26faa9f236f4..aa79e2674359 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 sergiyb@chromium.org Adapt ChromePerf code to support starting V8 bisects Created with: gclient setdep -r src/third_party/catapult@aa79e2674359 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:904635 TBR=sullivan@chromium.org Change-Id: Icd006f2a1e4575e0e83131136ad2579701b30bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642732}
-
David Tseng authored
Unfortunately, https://chromium-review.googlesource.com/896672 only incompletely hooked up support for this attribute within chrome.automation. This change completes this hookup. Test: in various menus with popups, verify AutomationNode.hasPopup is correctly exposed. Furthermore, verify that ChromeVox indicates a menu item has a submenu (e.g. for the Google image labeling submenu). Change-Id: I44694cccbb827ddb8df5803779adb6b2e1d89034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532662Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#642731}
-
Patrick Monette authored
Changes ModuleEventSinkImpl to take in a callback instead of directly forwarding to the ModuleDatabase. Bug: 943303 Change-Id: I23580fc1fe12d687ec945cb781e45fa8db82f958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529693 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#642730}
-
Joel Hockey authored
Change UnsharePath to take unpersist bool to specify whether path should also be removed from prefs. Change OnUnshare observer to receive vm_name in addition to path. Refactor OnVolumeUnmounted to call UnsharePath with unpersist=false. This is a partial change in advance of full unshare on delete support. Bug: 933564 Change-Id: I1a71e02b1ab72da327f3062ff35097cb1ea77be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530220 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#642729}
-
Carlos Knippschild authored
This reverts commit db066159. Reason for revert: broke external/wpt/clipboard-apis/async-interfaces.https.html Original change's description: > Async Clipboard Tests: Use quotes as per style guide. > > Use ' (single-quotes) for js string quotes, and " (double-quotes) for HTML > string quotes. This was inconsistent before this CL, so make it more > consistent as per the Google JS/HTML style guides. > > Reference: > - https://google.github.io/styleguide/jsguide.html#features-strings-use-single-quotes > - https://google.github.io/styleguide/htmlcssguide.html#HTML_Quotation_Marks > > Change-Id: I794b278b2020a329f6e3ea0deeb6136ae04122c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531710 > Reviewed-by: Victor Costan <pwnall@chromium.org> > Commit-Queue: Darwin Huang <huangdarwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642594} TBR=pwnall@chromium.org,huangdarwin@chromium.org Change-Id: I85f903d44f39c1b448342183a85d2f9934cecf9d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533098Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#642728}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I2c59701f9ab44b3c50ed14e32831f09715ac065f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531880 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#642727}
-
Pavel Yatsuk authored
Add support for touch filtering for buttons obscured by another visible window. This change is needed for migrating permission dialogs to ModalDialogManager. In this change: - Add boolean property FILTER_TOUCH_FOR_SECURITY to ModalDialogProperties - Add logic in ModalDialogView to filter touch events - Propagate the property to ModalDialogView through ModalDialogViewBinder BUG=940046 Change-Id: I6f363f3922c3ba2883f24b376347f305590478a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524909Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#642726}
-
Jonathan Backer authored
This CL modifies gfx::ColorTransform to generate SkSL shaders (https://cs.chromium.org/chromium/src/third_party/skia/src/sksl/README). The main differences between GLSL and SkSL that manifest in this CL are: + SkSL has no precision modifiers: There is no low precision floating point. half is medium precision floating point. + You cannot define functions in an SkSL fragment processor. I have manually inlined repeated code. I use temporary variable "half v" as input and output and trust that the compiler will eliminate it. + SkSL vector types are named <base type><columns>. SkSL matrix types are named <base type><columns>x<rows> + GLSL uses 3 component color. SkSL uses "inout half4 color", which includes alpha. I have modified the code to preserve the alpha channel. I have added a simple SimpleColorSpace.CanParseSkShaderSource that checks that the autogenerated SkSL fragment processor compiles. This CL makes many media/ webkit layout tests pass with SkiaRenderer due to more accurate YUVA->RGBA color conversion (e.g. media/controls/paint-controls-webkit-appearance-none-custom-bg.html) Bug: 908957 Change-Id: I711ff18c441291d150e01604d1fdb2ee4ebee10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504301 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#642725}
-
Wez authored
FuchsiaVideoDecoder is updated to use the new table field accessors, which return references rather than pointers to the data fields. The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org, sergeyu@chromium.org Bug: 944080 Change-Id: I2a2570c0b5b1749060598a3e19cc88b216f361f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531356Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#642724}
-
Evan Stade authored
Bug: 943775 Change-Id: Ic72893c1be5cdc815e14566bb6da942f1a4a1625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532897 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#642723}
-
Yun Liu authored
Need third party library net_sf_kxml_kxml2 for androidx_test_runner_java's dependency which is only used for test code. Sample test from Robolectric: https://cs.chromium.org/chromium/src/third_party/robolectric/robolectric/integration_tests/ctesque/src/androidTest/java/android/app/ActivityInstrTest.java In this test, it shows that androidx.test.rule.ActivityTestRule and androidx.test.runner.AndroidJUnit4 are needed. At least we need androidx.test.rule.ActivityTestRule instead of android.support.test.rule.ActivityTestRule for this feature so that androidx_test_rules_java needed and androidx_test_runner_java is a dependency. New AndroidJUnit4 still needed but we can use androidx.test.ext.junit.runners.AndroidJunit4 I guess since new AndroidJunit4 can load RobolectricTestRunner as runner https://github.com/android/android-test/blob/master/ext/junit/java/androidx/test/ext/junit/runners/AndroidJUnit4.java#L61 Robolectric 4.0 release note: http://robolectric.org/blog/2018/10/25/robolectric-4-0/ Bug: 938716 Change-Id: I42629efcd6ab688bec7c81cdf25e17251d507033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493204 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Conley Owens <cco3@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#642722}
-
Natalie Chouinard authored
Add an action to trigger a force refresh of the Feed from the internals debugging page, without clearing the cache. Bug: 940675 Change-Id: Iaf28eba69a7f611f801a57948bc0e9da4d3f32a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531427Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#642721}
-
Vlad Tsyrklevich authored
Previously cfi-icall was disabled because I mistakenly thought is_cfi=true would enable cfi-icall. Enable it explicitly on the Linux bots, cfi-icall is not yet supported on other platforms. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chromium.try:android_cfi_rel_ng Bug: 942060 Change-Id: Ifb32c38b3a13b120d2fb966920958a23e2502405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532744 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#642720}
-
Carlos Knippschild authored
This reverts commit f5b288f9. Reason for revert: breaking FrameNodeImplDeathTest.AddChildFrameOnCyclicReference in many bots Original change's description: > PM: Elminate CuID in favor of Node* in private IPCs to graph nodes. > > Separate node teardown from destruction by making BeforeDestroyed > virtual and overriding it in concrete node classes. > Tighten up the contracts and enforce a stricter data invariant. > Fix tests and test fixtures to destroy frames before pages. > Add a SequenceChecker to the graph. > > Bug: 910288 > Change-Id: I2e6bd857462b8576212001df8128f273ba4f4d74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532342 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642613} TBR=chrisha@chromium.org,siggi@chromium.org Change-Id: I38dbe774f153f301c78a4487955fee6e32fd42d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910288, 944319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533170Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#642719}
-
Miyoung Shin authored
This is a part of moving manifest implementation to blink. This is the precursor patch before moving content::ManifestParser to blink. Bug: 704441 Change-Id: I1cf7f277f859aaaa7a2e031ab9dba56e74a293cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527951Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642718}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d4719835ad2..48c69a292049 Created with: gclient setdep -r src-internal@48c69a292049 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:897936 TBR=ksakamoto@chromium.org,mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org Change-Id: I3cefa0083b13159563a4504279cef8e5dfa80146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532507Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642717}
-
Julie Jeongeun Kim authored
This is a reland of 4a3a0dbd It updates deps from //chrome/common/BUILD.gn additionally. Original change's description: > Reland "OnionSoup: Move mojom files from public/platform/web to public/mojom folder" > > This is a reland of e656908d > > It updates deps from //content/public/android/BUILD.gn. > > Original change's description: > > OnionSoup: Move mojom files from public/platform/web to public/mojom folder > > > > This CL moves window_features.mojom, commit_result.mojom, > > devtools_frontend.mojom, selection_menu_behavior.mojom and > > remote_objects.mojom from public/platform/web to public/mojom/ > > to gather mojom files to mojom folder and updates paths for these > > mojom files. > > > > Bug: 919393 > > Change-Id: If6df031ed39d70e700986bd13a40d0598257e009 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514434 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#640633} > > Bug: 919393 > Change-Id: I7c0cf251bb1fa336645a6f12d90cf42c3ee837fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523210 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#641399} Bug: 919393 Change-Id: I007a1cdcf839b98b27100b0bebe18c2927401263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525794Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#642716}
-
Scott Violet authored
Perf data indicates deleting the bubble can be expensive. This is because the deletion of a top-level widget triggers synchronous operations with viz. During startup there may be lots of things happening in viz, so, delay deletion for 10 seconds in hopes of things having settled down. BUG=943268 TEST=covered by tests Change-Id: Id1d56997553b01f9cf64a3866c013f20d0b75c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532583Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#642715}
-
Azeem Arshad authored
This CL changes auto-connect toggle label in the cellular settings page to read "Automatically connect to cellular network" instead of "Automatically connect to this network". Screenshot: https://screenshot.googleplex.com/WfAnZq9Ti4c.png Bug: 924236 Change-Id: Ic8bdd03cc73baea5584ed38294553798bdc8c87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531706Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#642714}
-
Paul Meyer authored
This will allow these reports to be processed more consistently, and remove some boilerplate code from each. This patch is part of a larger effort to refactor the reporting code in Blink. Bug: 931863 Change-Id: I2cf86444018a193f2c0a05735090f5727c93dd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532242Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#642713}
-
Allen Bauer authored
As part of an effort to cleanup and normalize the View API, object ownership is one of the least clear aspects. Like the addition of View::AddChildView(std::unique_ptr<>...), this does the same for ScrollView. SetContents and SetHeader take ownership of the view parameter and will delete the old version if a new one is set. This makes this behavior more clear and forces the client code to act accordingly. Bug: 942226 Change-Id: I6397c8c177a3657d1d24d937ba6fb82acbfb7692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526163 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#642712}
-
Aran Gilman authored
Bug: 927857 Change-Id: I563d34e57c8589093878e792fe81ae71e6f2feaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531305 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#642711}
-
dpapad authored
This is in preparation of removing the custom cr.EventTarget implementation in favor of native EventTarget, which requires all subclasses to be ES6 classes, otherwise a runtime "Illegal invocation" error is thrown. Bug: 854268,778674 Change-Id: I542b00b6c3837dd8c0765f0dd489ff79f28e7bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531709 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#642710}
-
Alex Danilo authored
This implements the case when a sub-menu is opened using the keyboard, causing focus to be moved to the first item in the newly opened sub-menu. This CL also hides the sub-menu if the top level menu is being navigated with the arrow keys. navigation of the main menu. Changed existing unit tests to handle the changed focus from main menu to sub-menu. Bug: 941968 Tests: Added unit test to confirm sub-menu gets closed on keyboard Change-Id: I020db000e6bd547433aa44891519159ad5c20619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529498Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642709}
-
John Budorick authored
Follow-up to crrev.com/c/1531705. Also re-adds layout tests to CI. Bug: 943804 Tbr: gbeaty@chromium.org No-Try: true Change-Id: If9997327c7dee35b94898c817acd70697bf2adf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533146Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#642708}
-
Kyle Horimoto authored
Change-Id: Id7c2778b932a6bbbed67d36c5390b64fcfba6a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532905Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642707}
-
Bailey Berro authored
- Renames methods that are called when editting a printer to capture that behavior. - Introduces message to be shown when editing a printer to replace the add message. Bug: 933852 Change-Id: Icbcc2d3c3a77e5880f0d34a956b460d6e1b55a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529873 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#642706}
-
Alexei Filippov authored
BUG=942138 Change-Id: I6cb6577fcd30eaf531deb2c712d213a64992f9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529673Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#642705}
-
Becky Zhou authored
Bug: 944061 Change-Id: I778c38b643a15e2341793b0b096828b67f557c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532729Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642704}
-
Jeffrey Kardatzke authored
This reverts commit ffc0bb9b. Reason for revert: crbug.com/942082 There's a project in process to make use of this data and it was removed just before that started, so we are putting this data back into the feedback reports. Original change's description: > Remove histograms from feedback reports > > Histograms data were added to the feedback reports long > time ago, but they're uncommonly checked and no good use > for them has been found, hence removed. > > BUG=915227 > TEST=File a feedback report and make sure it ends up with > no histogram data. > > Change-Id: Ie8e3540e7afa700ebf4b770c1cee7df729268081 > Reviewed-on: https://chromium-review.googlesource.com/c/1401563 > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620988} Bug: 915227, 942082 Change-Id: I68d59b57cc2483430f39c53e92cf8253ba144956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532365Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#642703}
-
Aran Gilman authored
Bug: 938511 Change-Id: I52a019e87c3a6772d0c3d3fc973876f66a0d275b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532886 Auto-Submit: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#642702}
-
Shawn Anastasio authored
Add definitions for the ppc64 architecture to components/update_client. This change is part of the effort to upstream a set of patches that allow chromium to build and run on ppc64le hosts available here: https://wiki.raptorcs.com/wiki/Porting/Chromium Change-Id: I861dbd5dd0dd5635c2ad232b6b7eb5db7f62f00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532432Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#642701}
-
Clemens Arbesser authored
[Autofill Assistant] Fixed bug where the PR UI was broken after cancelling the add-shipping-address flow. After tapping the 'add' button and then the 'cancel' in the shipping address section of the Autofill Assistant payment request, the UI would become unresponsive due to a missing UI update. Bug: 806868 Change-Id: I7a1e2bcef24e82ca3bffec305536d2307a1f6a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532009Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#642700}
-
Robert Ogden authored
One of several CLs to clean up usage of this pref. Bug: 934399 Change-Id: I28ae94681373e859a3d6ff5eb29d7e9ec0c3f54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529706 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#642699}
-
Tomasz Wiszkowski authored
Bug: 941571,936732,943760 Change-Id: Ideab8fcb349ca48fb79bf353259969e60e600d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520362 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#642698}
-
Nicholas Verne authored
Bug: 943922 Change-Id: Ic4856679c722e4b3c6a87ea6527df2cb8bf9f59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531885Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#642697}
-
Steven Bennetts authored
This is a mechanical move in order to extract GN dependencies for SessionManagerClient. It will also help cleanup the chromeos/dbus directory. ./tools/git/move_source_file.py chromeos/dbus/auth_policy_client.cc chromeos/dbus/auth_policy ./tools/git/move_source_file.py chromeos/dbus/auth_policy_client.h chromeos/dbus/auth_policy ./tools/git/move_source_file.py chromeos/dbus/fake_auth_policy_client.cc chromeos/dbus/auth_policy ./tools/git/move_source_file.py chromeos/dbus/fake_auth_policy_client.h chromeos/dbus/auth_policy ./tools/git/move_source_file.py chromeos/dbus/fake_auth_policy_client_unittest.cc chromeos/dbus/auth_policy For mechanical renames: TBR=sky@chromium.org Bug: 644350 Change-Id: I23e0542cb4892d911fce59304e86b4506f87b114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531575 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642696}
-
Jay Harris authored
This is a follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1529975 Bug: 943362 Change-Id: Ic7845b861bc946af2cd47a17fdac929b94acc104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530499 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#642695}
-
Julien Isorce authored
Set a default value that matches with the parsed primary ID. Also see https://chromium-review.googlesource.com/c/chromium/src/+/618326/ Bug: 788236 Test: http://hr-a.akamaihd.net/test/colorspaceTest/videoplayer.html Change-Id: Ie4ab89403d1a09abc02a645f814a70d626e5fe5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524432Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#642694}
-
Satoshi Niwa authored
BUG=b:128661250 TEST=Manually tested Change-Id: I59a741d33948fd751b7ea6ee420871dd22b560a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532120 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#642693}
-