- 21 Apr, 2020 40 commits
-
-
Sergey Ulanov authored
Added new PlaybackEventsRecorder interface that allows to record media pipeline events. It's implemented only for Fuchsia and logs events that we need to be logged from WebEngine. Bug: 1067068 Change-Id: I7994d41af67f4ec29e5773147ed302bb86b3c3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148037 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#761184}
-
Pavel Yatsuk authored
This CL enables moving SimpleConfirmInfoBarBuilder to chrome/browser/ui/messages/android/ BUG=1056346 R=mdjones@chromium.org Change-Id: I8b37f019d5e0bdeb6fb33614e76e263e4bad8808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113439 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#761183}
-
Chromium WPT Sync authored
Using wpt-import in Chromium eaf12fa2. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." daae887f "CookieStore: Add validation behavior for __Host- prefixed cookies" 502e3797 "ServiceWorker: Fix timeout on client-navigate.https.html" 4f9a3312 "[@property] Determine the registration" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1b33a8083e5fe617a5a8b88a12fae36fbad6b413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159807Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761182}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/09e523d4093e..b8fb3c793d9f git log 09e523d4093e..b8fb3c793d9f --date=short --first-parent --format='%ad %ae %s' 2020-04-21 jalyn@microsoft.com Centralize shortcut titles Created with: gclient setdep -r src/third_party/devtools-frontend/src@b8fb3c793d9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4d0b27de1aa5ad2986b937c9132a664ae1e7c6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159828Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761181}
-
Roberto Carrillo authored
R=bpastene,nodir,chanli Bug: 1048825 Change-Id: I526b462e2896b5c9f855889de770b4e8933efc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158937 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#761180}
-
Xiaohui Chen authored
* Replace the mojom chromeos::assistant::Service interface with a singleton class. * Refactor //chromeos/services/assistant/public/cpp to a component. * Deprecate assistant_service_connection. Let assistant_client_impl own the service instance. Tbr: stevenjb@chromium.org Bug: b:154268518 Change-Id: Ie4c4a513ee0afa3e66baab1d8ba19c5aa6c9e059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157781 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#761179}
-
Nico Weber authored
Bug: 1056290 Change-Id: I3e18eb58bff1a5167a2f28902de0a1e1566232c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159540 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#761178}
-
Wez authored
The implementation of the fuchsia.sys.Runner for Cast apps is refactored to be easier to maintain, in the following ways: 1. Instead of deriving from WebContentRunner and overriding certain behaviours, the CastRunner now instantiates WebContentRunner instances internally, to use to manage CastComponents. 2. CastRunner now implements fuchsia.sys.Runner itself, and manages the PendingCastComponents, prior to creating & handing off CastComponents to be managed by the WebContentRunner(s). 3. The CreateContextParams for the main and isolated contexts are constructed using a common base, rather than copying & filtering the main context parameters, to create parameters for isolated contexts. Bug: 1071544 Change-Id: Ic66ca0a9805e9b00d213c62845e5101ff9dea76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153055 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#761177}
-
Abhijeet Singh authored
The child buttons inside the Quick Answers view, which is itself a button, do not work properly because of the way events are bubbled down the view hierarchy for Quick Answers views. To prevent that, this change will modify the event-handling of the related view by propagating events in a bottom-up fashion instead and stopping at the first child to handle the event to avoid simultaneous firing of container buttons. Bug: b:152922056 Test: On Chrome OS VM. Change-Id: I5e309cf9cecf88e79651a138375025b7120ab2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140995 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
-
Caroline Rising authored
These metrics are useful for measuring changes from the addition of tab hover card images. Bug: 1063920, 1063921 Change-Id: I3321a8b4bb7003a2547cb18639cacc06d0571640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157599Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#761175}
-
Sebastien Marchand authored
Bug: 1060025 Change-Id: I9e855b0f9290a0ac4785f88657d47d19ce250efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159533Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#761174}
-
Sergey Ulanov authored
Bug: 1067068 Change-Id: I75e040216a1d4bef780902e43afc87026726cbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159891 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Yuke Liao authored
This CL sets up mac-chrome official try bot, and one of the use cases is for PGO auto roller to validate the profiles and warm up GOMA caches for other official builders. Bug: 1071576 Change-Id: If5ddd46caeccbb5f793b1768ac9790c117055a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159766 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Tarun Bansal authored
This is no longer in use. Also deletes the UX and logic for fetching the original image. Change-Id: I6cbc062f11bd799c234b178ace0b4f2a53f8b8fe Bug: 1073185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158825Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#761171}
-
Aaron Gable authored
These tests are more like static presubmits -- they have the same result on every platform. On the main waterfall, they're not run on every Mac10.XX Tests bot, just on one of them, so they don't need to be run on 10.15 either. This will allow the Mac10.15 Tests host to be a linux host, since it won't need to directly transfer any build artifacts from the Mac Builder Next build; it will instead be solely triggering isolated swarming tests. Bug: 1057776 Change-Id: If0388f89512f00b7da75e80679eb1de6ee1a7f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159885 Commit-Queue: Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#761170}
-
Noel Gordon authored
In self-review of CL:2143024, I mentioned it was more accurate to test the elider-limit (hidden vs not-hidden) using the <bread-crumb> custom element's |parts| getter. So do that: the elider button should only be shown (not-hidden) if the breadcrumb path has more than 4 components (aka its .parts > 4) and it matches the attached comment exactly. Tbr: adanilo Bug: 1061388 Change-Id: If03446e6e99944a22a50bd8096d4c4608a2d1f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158428 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#761169}
-
Ryan Sturm authored
These histograms all aren't important or they have analogs in UKM, which provides better understanding of the metrics. Bug: 975424 Change-Id: I1d6d9d18dbc08518581843707ed3e31ad04cff23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157903Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#761168}
-
Sebastien Lalancette authored
Also, allow usage of fixed size image to prevent scaling-up the QR code (it becomes too big to be scanned effectively). Sample: https://screenshot.googleplex.com/xYWmsrTzZpD.png Bug: 1064990 Change-Id: Ibd1e7f5f1149e436929ca8c33b1dae7807172411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153391 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#761167}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/efb2133b0dd3..3b8486afd3fe git log efb2133b0dd3..3b8486afd3fe --date=short --first-parent --format='%ad %ae %s' 2020-04-21 bsalomon@google.com Reland "Notify RTC when OpsTask is closed so it can drop ownership" 2020-04-21 bsalomon@google.com Improve selection of target_cpu in android_gdbserver 2020-04-21 bsalomon@google.com Remove unused GrTextureDomain 2020-04-21 lepton@chromium.org SkQP: Fix broken run_skqp_exe 2020-04-21 ethannicholas@google.com Prefixed the names of SkSL token constants. 2020-04-21 kjlubick@google.com Fixing a bug in SkOpEdgeBuilder::walk that causes pathOps to fail when cubic segment is reducable 2020-04-21 bsalomon@google.com Revert "Notify RTC when OpsTask is closed so it can drop ownership" Created with: gclient setdep -r src/third_party/skia@3b8486afd3fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: Ie6d373b4601b25070e13883cb72a53d65fecc7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159283Reviewed-by:
-
Dave Tapuska authored
Calling WebWidget::Close could end up calling ScheduleAnimation back but layer_tree_host_ would be null. Destroying the WidgetBase (which owns the LayerTreeHost) is the last thing that WebWidget::Close does so it is safe to move the assignment after the close. The long term fix here is to remove the layer_tree_host_ pointer from RenderWidget entirely but those patches are yet complete. BUG=1072927 Change-Id: I9d49f7c0f47c69bb8c5e300235bf355ae2cfec1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159745Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#761165}
-
Alexander Cooper authored
This change creates a new target containing only VROrientationDevice. This will allow embedders (and content) to link against just the only VROrientation device so that it doesn't need to link in all of device/vr if that's the only device that it wants/needs. Future work can create components for each device, such that including AR, GVR, or each of the immersive (windows) runtimes can be done independent of each other. Bug: 1070807 Change-Id: I12c8ec78a60e876d820cac881354a088b9843d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154399 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#761164}
-
rbpotter authored
Bug: 1069258 Change-Id: I0eff16da8a4e9008db1a5cf0893a22ff386350a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158319 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#761163}
-
Adam Langley authored
Due to its OpenSSL-based origins, ECDH_compute_key returns the output length or -1 for error, unlike standard BoringSSL functions which are 0/1. This CL fixes the pattern of checking the return value. (Doesn't matter in practice because it doesn't fail unless the private key is on the wrong group.) Change-Id: I87ceb4afa419ae578eed9cbf38edebe7e061570a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159749 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#761162}
-
Dave Tapuska authored
WebInputEvent::Type and WebTouchPoint::State are adjusted in this change. This allows us to alias this enumeration to a mojo defined type that will come in another CL. No functional changes in this CL, largely completed via sed. Change-Id: I1a5a9113396311fc28fff82f86e5169f2111ac0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155014 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#761161}
-
Robert Liao authored
Author: pkasting@chromium.org Examples: tluk@chromium.org Markdown: robliao@chromium.org Change-Id: Id6d0b17f37d4bb8f0e11d67b19487af923592d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158060 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#761160}
-
David Van Cleve authored
Because of a recent design change, key labels are now a BoringSSL implementation detail: the key encoding now contains a key's label, so there's no need to represent it separately in our Chromium-side Trust Tokens code. This change removes the label field from the mojom::TrustTokenVerificationKey struct but retains the label parsing code in the key commitment parser to ensure that the key commitment results we receive are syntactically correct. (There's no reason in principle why the key commitment record format couldn't just use a list now, but it's probably a little close to the initial prototype release to change the schema.) R=csharrison Bug: 1068678 Change-Id: I35e6ab046cf0f98f68cd09b906e5b4ba43bd5bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158968 Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#761159}
-
Alexander Cooper authored
The "is webkit" heuristic only checks that self.internals exists; however, this is also true on chromium. Chromium however does not have an "internals.xrTest", this expands the "is webkit" heuristic to also account for the presence of "internals.xrTest" and thus ensure chromium tests run Fixed: 1072929 Change-Id: Ieba043ba1634b393905e4494d0c59294aa6df12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159320 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#761158}
-
Anders Hartvoll Ruud authored
Bug: 973830 Change-Id: I5d950496834ab17dc8615335c9c4ae25f2a4179b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157528 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#761157}
-
Theresa Wellington authored
BUG=966644 Change-Id: I75bda71622317d90156a81c526ee4b6267d8a785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159755 Commit-Queue: Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#761156}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e981e9f0..e077f600 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia138150a273ac7a383e78ef18a3ef1a75fab7e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159805Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761155}
-
Roman Sorokin authored
Fixed: b/152757184 Change-Id: I94e08fc7234922700881265eaa555a1c77f014f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141092Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#761154}
-
Hesen Zhang authored
- Setup the tile group manager component. - Implemented the load, save and get APIs. - Added unittests. - [UPDATED] Have a big update since initial reviews. Bug: 1068368 Change-Id: I03ebf98f9c67af403d355418cb1304f161bb28e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138161 Auto-Submit: Hesen Zhang <hesen@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#761153}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b009c0643f55..1e113e605b08 git log b009c0643f55..1e113e605b08 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1e113e605b08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib04837f7460b9e586830de7be2cb86433cff4354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159825Reviewed-by:
-
Kurt Horimoto authored
If the modal view is a scroll view containing content views whose |-sizeThatFits:| is not implemented, calling |-sizeThatFits:| on the scroll view will not calculate the same size that it ultimately used when the contents are laid out. This resulted in an incorrect size used for UITableViews with custom cells whose sizing selectors were not implemented. Manually triggering a layout pass enusures that all view resizing resulting from constraint resolution occurs and the content size is calculated correctly. While it is not desirable to manually trigger layout passes, |-modalHeightForWidth:| is only called once when the InfobarModalOverlayCoordinator is started, so it should not have any significant performance implications. Bug: none Change-Id: I57dfe692a0f439896a08ef6ddecef048a388d003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159769 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#761151}
-
Aaron Leventhal authored
In CL:967465 we changed to exposing alertdialog from ROLE_SYSTEM_DIALOG to ROLE_SYSTEM_ALERT, so that unfocused UI bubbles that appear would be spoken by JAWS. However, this caused some permissions dialogs to be spoken twice by JAWS, and caused NVDA not to read ARIA alertdialogs. At a later point, we added xml-roles:alertdialog to these objects. This seems to allow us to change the MSAA role back to ROLE_SYSTEM_DIALOG while retaining the behavior we want for UI dialog bubbles, and also fixing the regressions. ROLE_SYSTEM_DIALOG + xml-roles:alertdialog: - Works with JAWS dialog commands such as Insert+T to read title UI dialog bubbles that don't get focus. - Fixes double speaking of permissions dialogs in JAWS - Works in JAWS 2018, 2019, 2020 - Fixes non-reading of ARIA alertdialog in NVDA - Complies with CORE-AAM spec and consistent with other browsers R=nektar@chromium.org Bug: 1071838,1007103 Change-Id: I116bb936dfd94aabedb269ae28d859956cec43c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154391 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#761150}
-
Renjie Tang authored
Complete the implementation of QuicClientSessionCache to allow multiple TLS session ticket for a single QUIC session. Change-Id: Iff6bbcb74708ac0584662273c0ad01162b597a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155165Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#761149}
-
John Smith authored
This creates the initial set and additionally partially fixes an issue where the NativeThemeRedirectedEquivalenceTest.NativeUiGetSystemColor tests weren't doing the correct thing around the Mac system overrides. On light mode, anything overridden wasn't actually getting to the color pipeline code because of the other returns. In dark mode, the check intended for checking if you were in an incognito window was passing and pushing the code through NativeTheme::GetSystem color without getting the overrides in either mode. This is only a partial fix because there is a broader issue with how the Mac handles light/dark with the NSAppearance. This gets applied at the app or window level so anything that gets a named NSColor actually is still getting a color based on that NSAppearance, not the passed in ColorScheme. This is a bigger architectural question on how/if it can be resolved which will need to be done in a later change. This also moves NSSystemColorToSkColor to skia_utils_mac so it can be used by both the old and new color systems without code duplication. Bug: 1003612 Change-Id: Ifb5166166dafda83f0a97fbb1c2a3b407927b68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147925 Commit-Queue: John Smith <johnsm@microsoft.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#761148}
-
Stephen McGruer authored
The removals were generated by stripping 'external/wpt' from the start of each entry, then running 'ls' for the file or directory from the root of a fresh WPT checkout. Cases where ls failed were then removed. Bug: None Change-Id: I4bd605f105da5cb3bcf87f2d653e7a530124419a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159623Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#761147}
-
Ryan Sturm authored
Since protocols can only be added via script, this behavior can't occur during NoStatePrefetch. Using the inherited functionality is also safe, since it is a no-op. Bug: 1038068 Change-Id: Ie633f94580ae5618fe42b7b017592d3a284071e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158407 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/d304d90ecc17..b599fb88f59e git log d304d90ecc17..b599fb88f59e --date=short --first-parent --format='%ad %ae %s' 2020-04-21 thakis@chromium.org Disable a warning in generated code. Created with: gclient setdep -r src/native_client@b599fb88f59e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066980 Tbr: mseaborn@chromium.org Change-Id: Ifb9b13ade3992e76605c2b3071289acc38ef7612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159827Reviewed-by:
-
