GitLab

Move tough_canvas_cases into rendering folder and refactor page classes
to inherit from RenderingStory.

Bug: 760553
Change-Id: I5cc1a745360968757569b1868be2fb3ddca7222c
Reviewed-on: https://chromium-review.googlesource.com/1078934
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#563010}

Bug: 847271
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I56edc54dcb24fd387944dc1dd937a66348ade484
Reviewed-on: https://chromium-review.googlesource.com/1077053Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563009}

It is not possible to know ahead of time whether or not a
WebContentsView will be embedded in an NSView or a views::View, even
when MacViewsBrowser is enabled (content_shell, for instance, uses the
NSView display path).

Lazily determine if a WebContentsView is to display via its parent
views::View's compositor. When attaching to a views::View for the first
time, clear all content that is being displayed in the NSView (because
it will occlude the views::View) and disable displaying through Cocoa
for the lifetime of the WebContentsView.

When all code that expects to display through Cocoa is updated or
deleted, this lazy determination may be removed.

Bug: 840173
Change-Id: I36c7054ba7c71e6fe94e496e677a9a9be4fb790a
Reviewed-on: https://chromium-review.googlesource.com/1075563Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563008}

Sometimes CQ+2 can fail even when CQ+1 succeeds (e.g. last-minute merge
conflicts). This CL catches this failure properly.

Bug: 817025
Change-Id: Ic6679a7b4797132abd3ecae348644d6e14f73c7c
Reviewed-on: https://chromium-review.googlesource.com/1079889Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563007}

In CPU profile samples delta for the first sample is an offset from
startTime.

BUG=847887

Change-Id: I200eae40770b521545c831f0e6e1ffa311cb7a85
Reviewed-on: https://chromium-review.googlesource.com/1079432Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563006}

No change to production logic, just fixes a mistake with tracing.

I made a copy-paste error when adding TraceEvents for
onSafeBrowsingHit(). This makes sure we end the correct TraceEvent by
using the correct string.

Test: N/A
Change-Id: I7cb58f6ef474d0c38d88093d2e7aca2d66f0e8a0
Reviewed-on: https://chromium-review.googlesource.com/1079888Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563005}

Bug: 847119
Change-Id: I5d7210b131304bf09a431d26aaf64ceae0e10a23
Reviewed-on: https://chromium-review.googlesource.com/1077427Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563004}

The current BlueZ adapter implementation for BLE advertisement does not
unregister advertisements when BluetoothAdapter scoped referenece
pointer is destructed. This cause BluetoothAdapter::advertisements_
queue to increase indeterminately as BluetoothAdapter is a Chrome wide
singleton object. Manually unregister any ongoing advertisement once
CableDiscovery is destructed.

Bug: 846535
Change-Id: If7782132f99e580bfa5f6e9a0da2a116375e6b7c
Reviewed-on: https://chromium-review.googlesource.com/1072929
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563003}

The implementation of this method is folded into BVC.

Bug: 620489
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia28f15d5b2ba55c4d661e2b0a200c143e2a4f296
Reviewed-on: https://chromium-review.googlesource.com/1073916
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563002}

With this change, WebRequest API for WebSocket works when the network
service is enabled.

This CL introduces WebRequestProxyingWebSocket, a proxy which
dispatches WebRequest API events to extensions. This CL modifies
websocket.mojom as following:

 - OnFinishOpeningHandshake is always dispatched. When the renderer
   doesn't have an access to raw cookies access, it drops cookie
   related information from the headers.
 - socket_address and http_version is added to
   WebSocketHandshakeResponse.

This change lacks OnAuthRequired support.

Bug: 721400
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic564518a820e4f010548263863e523062da7345e
Reviewed-on: https://chromium-review.googlesource.com/1068592Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563001}

Text from the spec
(https://drafts.csswg.org/css-contain/#containment-paint):
  "... if the element is an internal table element other than
  'display: table-cell', ... paint containment has no effect."

The patch disables "contain: paint" for internal table elements
except table cells.

BUG=843329
TEST=external/wpt/css/css-contain/contain-paint-014.html
TEST=external/wpt/css/css-contain/contain-paint-015.html
TEST=external/wpt/css/css-contain/contain-paint-016.html
TEST=external/wpt/css/css-contain/contain-paint-017.html
TEST=external/wpt/css/css-contain/contain-paint-018.html
TEST=external/wpt/css/css-contain/contain-paint-019.html

Change-Id: I975950ab72fe5cc5aa106fa5fdafd37c64dd6d85
Reviewed-on: https://chromium-review.googlesource.com/1078868Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#563000}

These tests have been failing for more than a week now. LoadURL doesn't
finish on device on some tests.

Bug: 847948
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I151a3a2d031b4311d17c5c148c635a92e5a1f232
Reviewed-on: https://chromium-review.googlesource.com/1079630
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562999}

See: crrev.com/c/1038141/4/third_party/unrar/src/unpack50frag.cpp#52

Bug: 750327
Change-Id: Ib7bc8fea73f8ca860bb87490fd046f20c55ca8f7
Reviewed-on: https://chromium-review.googlesource.com/1077187
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562998}

In some jumbo build configurations the linker needs
gfx::PrintTo(gfx::Size const&, ...) referenced from
obj/gpu/libtest_support.a
testing::internal::UniversalPrinter<gfx::Size>::Print(
    gfx::Size const&, ...)

This reference might be in dead code that would otherwise (in
non-jumbo builds) have been stripped earlier, but since the
reference apparently is there it's best to have
the dependency as well.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6fe98a5427e5bc30625773bfa73d5b248b34f30a
Reviewed-on: https://chromium-review.googlesource.com/1005340Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#562997}

ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement is no longer
failing on Android. Re-enabling the test.

TBR=kereliuk@chromium.org

Bug: chromedriver:998
Change-Id: I4a3b20065625cc7d17b044b873527a537237b0fd
Reviewed-on: https://chromium-review.googlesource.com/1079894Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562996}

This allows the common (mostly UI) VR code to compile as a component
during component builds.  This speeds the build, but is also a stepping
stone to investigating VR's external symbol dependencies.

BUG=

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I7f1f8b2bd88c436b542389e60d3c07c8e7388310
Reviewed-on: https://chromium-review.googlesource.com/1077075
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562995}

This reverts commit 5af8e7eb.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Reland "Check page exist after dispatch dragstart""
> 
> This reverts commit 67834de4.
> 
> Reason for revert: Causing failures on WebKit Linux Trusty Leak (https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/19550)
> 
> Original change's description:
> > Reland "Check page exist after dispatch dragstart"
> > 
> > This is a reland of 2c03b1bd
> > 
> > The CL was reverted because of failures on the leak bot.
> > However the leak is not cause by the test or the patch.
> > Add the exception for the test for further investigation.
> > 
> > Original change's description:
> > > Check page exist after dispatch dragstart
> > >
> > > frame_->GetPage() may be null. need to check before use GetDragState
> > > This CL reorder the some checks in MouseEventManager::TryStartDrag
> > > to make sure GetPage is valid before start drag.
> > >
> > > Bug: 843502
> > > Change-Id: Ifdf5b20d7132ca4b089c9a5b7652ebbd41370c33
> > > Reviewed-on: https://chromium-review.googlesource.com/1064878
> > > Commit-Queue: Ella Ge <eirage@chromium.org>
> > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#561262}
> > 
> > Bug: 843502
> > Change-Id: I093da085a84eecf2937d522b762b2feeeb1d7947
> > Reviewed-on: https://chromium-review.googlesource.com/1079247
> > Commit-Queue: Ella Ge <eirage@chromium.org>
> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#562953}
> 
> TBR=dcheng@chromium.org,nzolghadr@chromium.org,eirage@chromium.org
> 
> Change-Id: I5546c2b3469ecbf1ad40cc47ab8437075073abd5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 843502
> Reviewed-on: https://chromium-review.googlesource.com/1079968
> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562991}

TBR=dcheng@chromium.org,nzolghadr@chromium.org,adithyas@chromium.org,eirage@chromium.org

Change-Id: I39f2b3b871370c18aa2da4aa6ae6f6c5d6db61d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 843502
Reviewed-on: https://chromium-review.googlesource.com/1079987Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562994}

The in-memory bitmap cache can be reused elsewhere.

Bug: None
Change-Id: I71f593da22afe7eebb98c43d3f93240acf97d237
Reviewed-on: https://chromium-review.googlesource.com/1068126
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562993}

Clang-format only. No functionality or code change.

TBR=jrummell@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7fada73aca62544a47e41401c3812768f3db4f7a
Reviewed-on: https://chromium-review.googlesource.com/1077623
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562992}

This reverts commit 67834de4.

Reason for revert: Causing failures on WebKit Linux Trusty Leak (https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/19550)

Original change's description:
> Reland "Check page exist after dispatch dragstart"
> 
> This is a reland of 2c03b1bd
> 
> The CL was reverted because of failures on the leak bot.
> However the leak is not cause by the test or the patch.
> Add the exception for the test for further investigation.
> 
> Original change's description:
> > Check page exist after dispatch dragstart
> >
> > frame_->GetPage() may be null. need to check before use GetDragState
> > This CL reorder the some checks in MouseEventManager::TryStartDrag
> > to make sure GetPage is valid before start drag.
> >
> > Bug: 843502
> > Change-Id: Ifdf5b20d7132ca4b089c9a5b7652ebbd41370c33
> > Reviewed-on: https://chromium-review.googlesource.com/1064878
> > Commit-Queue: Ella Ge <eirage@chromium.org>
> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#561262}
> 
> Bug: 843502
> Change-Id: I093da085a84eecf2937d522b762b2feeeb1d7947
> Reviewed-on: https://chromium-review.googlesource.com/1079247
> Commit-Queue: Ella Ge <eirage@chromium.org>
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562953}

TBR=dcheng@chromium.org,nzolghadr@chromium.org,eirage@chromium.org

Change-Id: I5546c2b3469ecbf1ad40cc47ab8437075073abd5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 843502
Reviewed-on: https://chromium-review.googlesource.com/1079968Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562991}

HTMLCanvaElement::convertToBlob() is a new promise-based toBlob
API that allows to specify the color space and the pixel format
of the target blob.

Bug: 840372,847436
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I77c8b98ada3a5f9fbef38ad1b86d9ef15fdea570
Reviewed-on: https://chromium-review.googlesource.com/1048169
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562990}

This reverts commit bad54cc3.

Reason for revert: Causing layout test failures on Mac10.11: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/16416

Original change's description:
> [Media Controls] Update loading animation
> 
> This CL updates the media controls loading animation to match the new
> mocks.
> 
> Bug: 839093
> Change-Id: I5b46fb2c52a9421292ecbdb07db2b35958514b1b
> Reviewed-on: https://chromium-review.googlesource.com/1077650
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Commit-Queue: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562897}

TBR=mlamouri@chromium.org,beccahughes@chromium.org,steimel@chromium.org

Change-Id: Ife4efead7e6619180494429b31056793a0ccd871
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839093
Reviewed-on: https://chromium-review.googlesource.com/1079967Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562989}

We should have all potentially supported codecs in the
GetCastEmeSupportedCodecs list. Currently we are missing Vorbis, Opus
and FLAC in there. EME checks IsSupportedMediaFormat first, which will
perform platform-specific codec checks via MediaClient::IsSupported*
APIs, before getting here. So codecs that are not actually supported on
a given platform will be filtered out by MediaClient, but we should
still have them here for platforms that do support them.

Bug: none
Change-Id: Icc5a572c042dca0dda93daaca63761e92b9f0eec
Reviewed-on: https://chromium-review.googlesource.com/1079315Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562988}

This CL adds the first use of std::make_reverse_iterator, inside the
password_manager component at a place where it shortens an awkwardly
long for-loop header.

It also adds std::make_reverse_iterator to the allowed C++14 features.

Bug: 845426
Change-Id: Ief6983c167b3c85a7d52a25555e8157d4d0f0a1c
Reviewed-on: https://chromium-review.googlesource.com/1078758Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562987}

The frozen states and the discarded states are mutually exclusive. The
CL merges the 2 booleans into one "state" column instead, and tracks
the transition states as well.

Instead of creating an new mojo enum for the lifecycle state in
discards.mojom, I have moved the existing enum to to become a mojo enum
that can be used in both locations and avoid conversion.

Bug: chromium:804976
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I32cf0e3f24fc921270533046351f57079be20d5a
Reviewed-on: https://chromium-review.googlesource.com/1054183Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562986}

Also update roll-freetype.sh script to be compatible with sed on macOS.

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/9e345c911714..d45d4b97e6a0

$ git log 9e345c911..d45d4b97e --date=short --no-merges --format='%ad %ae %s'
2018-05-30 prince.cherusker Beautify a3cfed5e87232c933bdc64f43e8ebebcfd18b41b.
2018-05-30 prince.cherusker Fix pointer underflow.
2018-05-30 wl Various minor color fixes.
2018-05-25 ramakrishnan.nikhil [docmaker] Fix missing `Defined in (...)' under Windows/Cygwin.
2018-05-24 apodtele [smooth] Formalize Harmony LCD rendering.
2018-05-22 wl Oops!
2018-05-22 wl [truetype] Reject elements of composites with invalid glyph indices.
2018-05-22 wl * src/truetype/ttgload.c (TT_Load_Simple_Glyph): Trace # of points.
2018-05-20 wl * include/freetype/ftcolor.h: New file.
2018-05-20 apodtele Autoformatting.
2018-05-18 apodtele * include/freetype/internal/ftcalc.h (FT_MSB): Verified `_MSC_VER'.
2018-05-18 wl * include/freetype/internal/ftcalc.h (FT_MSB): Use `_MSC_VER' value.
2018-05-18 wl Minor comment fixes.
2018-05-17 wl s/inline/__inline/ for MSVC.
2018-05-16 wl Add function `FT_Get_GlyphLayers' to access `COLR' table data.
2018-05-15 apodtele [base] Fix mono bitmap presetting (#53896).
2018-05-15 wl [psaux] Fix compiler warning (#53915).
2018-05-15 wl [sfnt] Fix memory leak in handling `COLR' data.
2018-05-15 wl Grammar fixes.
2018-05-15 wl [sfnt] If `COLR' is present, don't assume that all glyphs use it.
2018-05-14 wl * src/base/ftobjs.c (FT_Load_Glyph): Fix signature of `pixel_modes'.
2018-05-14 wl Provide dummy functions if `TT_CONFIG_OPTION_SFNT_NAMES' is not set.
2018-05-13 wl Typo.
2018-05-13 wl * src/base/ftobjs.c (FT_Load_Glyph): Improve tracing.
2018-05-13 shaozhang [sfnt] Preliminary support of coloured layer outlines.
2018-05-12 arkady.shapkin Use MS VC++'s _BitScanReverse to calculate MSB (patch #9636).
2018-05-11 parthwazurkar [pcf]Documentation Typo.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng

PDFium-Issue: pdfium:1099
Change-Id: Ibc333c67c51472020c916f947ab73ef4ec8e83ba
Reviewed-on: https://chromium-review.googlesource.com/1078942Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562985}

Change-Id: Iaaeff35e5910aa2f313e60590365769c80e94ac2
Reviewed-on: https://chromium-review.googlesource.com/1077648Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#562984}

Test is flaky on trybots.

Bug: 847959
Change-Id: I460e0098c824323286ec23daf5ee373369d8da67
No-Try: true
Tbr: mathp@chromium.org, rouslan@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1079826Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562983}

Bug: 846046
Change-Id: Ibb7a8fc2d617f6d77ca148f86857a655ae9d4dc1
Reviewed-on: https://chromium-review.googlesource.com/1077193Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562982}

Calling ToV8 is causing crashes due to missing ScriptState::Scope.

Bug: 836787
Change-Id: I96cd831e13989b4b58d7bb10f97939a01af50976
Reviewed-on: https://chromium-review.googlesource.com/1078819Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562981}

PowerButtonScreenShotController intercepts volume down and uses it as a trigger for taking screen shots while in tablet mode.

This change makes it so that no matter which volume key gets pressed first, KeyAccessibilityEnabler works properly.

It also ensures KeyAccessibilityEnabler stops capturing volume keys (even if one is pressed), if another key gets pressed such as the power button.

Bug: 839154
Test: manual. Press volume down, then volume up and hold. Verify ChromeVox starts. Do the same, until progress tones start playing; then press power button. Ensure tones stop and screen shot is taken.
Change-Id: I2faee6a22e3b4830215778a64e98654f934c57fe
Reviewed-on: https://chromium-review.googlesource.com/1077598
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562980}

Previously, we only showed the focus ring on certain platforms (Mac) or
keyboard accessibility mode.

Now, following the new Material Refresh guidelines, we display the focus
ring on the Omnibox whenever it is focused (and the popup is hidden).

This also simplifies the code a bit, as keyboard accessibility mode is
no longer relevant.

Bug: 844263, 823535
Change-Id: Ic5133463f6e67af5ef6f0512034938e4a19a9972
Reviewed-on: https://chromium-review.googlesource.com/1069690Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562979}

This reverts commit 32cf029f.

Reason for revert: Seems to cause the subsequent tests to fail on the 
passthrough command buffer. Example:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/1247

See issue for more details.

Bug: 847998

Original change's description:
> Fix bugs for blitFramebuffer when we limit src/dst rect size.
> 
> According to WebGL 2 spec. the width/height of src/dst blitting area
> should not exceed the max value that can be stored in an integer.
> 
> Bug: 844308, 830046
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I65833dfacabacc46c5cd3602233926e3e31aa6cf
> Reviewed-on: https://chromium-review.googlesource.com/1061053
> Commit-Queue: Yunchao He <yunchao.he@intel.com>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562748}

TBR=kbr@chromium.org,yunchao.he@intel.com,kainino@chromium.org

Change-Id: I7f351aa0534b4962012b27d29245eab14a07ec24
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 844308, 830046
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1079797Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562978}

This CL adds a check to prevent submission before the
|resource_provider_| has been initialized. This could happen if we get
a signal from VideoFrameCompositor to EnableSubmission before we had
ObtainContextProvider retun back to us.

Bug: 847065
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8b824273613ef147529c2de077bc78d831edf9eb
Reviewed-on: https://chromium-review.googlesource.com/1077201Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562977}

...As the fix for bug 846800 is back in.

Bug: 846702
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifb4ac1fe64091b7ba3f56485dfc753c8900269f9
Reviewed-on: https://chromium-review.googlesource.com/1079257Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562976}

When MD Refresh flag is on, but MacViews was not on, we would hit this
NOTREACHED.

Hitting it has no negative consequence, so we are replacing it with a
base::DoNothing.

Bug: 847646
Change-Id: Icc3b9ee24ef3e268960112013e79d05413683f46
Reviewed-on: https://chromium-review.googlesource.com/1079634Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562975}

Bug: 846541
Change-Id: I42b790888dfc0aabec1402242a5c5b9f624a5d05
Reviewed-on: https://chromium-review.googlesource.com/1078910Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562974}

Increment highest id counter in policy_templates.json to match policy definitions after SyncConsent policy was added.

This is a follow up for:
https://chromium-review.googlesource.com/c/chromium/src/+/1073623

Change-Id: Iee4894d8631dee786713febf3a72a1a33227aca6
Reviewed-on: https://chromium-review.googlesource.com/1079195
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562973}

TBR=smut

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I374f11e1dd9441a75ff17294d59870fac66e5d06
Reviewed-on: https://chromium-review.googlesource.com/1078943
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562972}

LibraryLoader's state and API is split between static/instance variables
and methods. This is messy and needlessly complicates things.

This CL changes static state and methods to instance ones thus turning
LibraryLoader into a proper singleton. Additionally this CL adds missing
locking / 'AlreadyLocked' suffixes to some functions.

Bug: 841403
Change-Id: I694b51ae9ec1dad6f7b94d8e6e9cbed5afd5eba0
Reviewed-on: https://chromium-review.googlesource.com/1069326Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562971}