- 02 Aug, 2018 5 commits
-
-
Lu Chen authored
Add recording of AnchorElementMetrics.*.HrefEngagementScoreExternal. Bug: 850624 Change-Id: I049b5847beb76a80a7c30077373f50079cee061c Reviewed-on: https://chromium-review.googlesource.com/1157551 Commit-Queue: Lu Chen <chelu@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#580003}
-
Renee Wright authored
Bug: 869734 Change-Id: Ie863c125d49c351b79f5b072bc20535a75dd8d6a Reviewed-on: https://chromium-review.googlesource.com/1157963Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#580002}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/68b5e7dbc095..134364159fa8 git log 68b5e7dbc095..134364159fa8 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 jessehall@google.com [mali importer] Add Exynos Mali job event parser Created with: gclient setdep -r src/third_party/catapult@134364159fa8 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2dfb839946b066aa315b73b91f3be6d662200327 Reviewed-on: https://chromium-review.googlesource.com/1159421Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580001}
-
Pedro Amaral authored
The new tab button doesn't have text next to it anymore. Change-Id: Ic489fe7f5c2a83cbf9a7a55497cd2065c715df21 Reviewed-on: https://chromium-review.googlesource.com/1153846Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580000}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3d30a20b118686d63080580579bd474029e12562 Reviewed-on: https://chromium-review.googlesource.com/1159605Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#579999}
-
- 01 Aug, 2018 35 commits
-
-
Evan Stade authored
This means Chrome will enter immersive when the user presses the fullscreen key (F4 on a normal keyboard --- although F4 on a normal keyboard doesn't actually work right now because event rewriters aren't functioning in OopAsh). The way this works in classic Ash is via BrowserWindowStateDelegate, which isn't used in OopAsh. Bug: 640365 Change-Id: I3b7e7a8911c5d8cba48f2d770e74104dba61e9e2 Reviewed-on: https://chromium-review.googlesource.com/1156995Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#579998}
-
Jorge Gil authored
This change adds support for multiple smart actions instead of only one and moves them below the copy/print section and groups them with extensions. Some SEPARATOR logic from https://chromium-review.googlesource.com/c/chromium/src/+/1087724 is reverted (due to the move from top to extensions) and some extra separator cleanup is needed after all actions are loaded. Bug: b/32781610 Change-Id: I7c825e9ef58cc21ed10a49b784e6258a704e2f8b Reviewed-on: https://chromium-review.googlesource.com/1147544Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jorge Gil <jorgegil@google.com> Cr-Commit-Position: refs/heads/master@{#579997}
-
Mathieu Perreault authored
Bug: 842014 Change-Id: Ie645e71c03c71fb7b7ddd7550128eb43bec3bc07 Reviewed-on: https://chromium-review.googlesource.com/1159190Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579996}
-
Sammie Quon authored
1. Removes some unused headers. 2. Updates some comments. 3. Make functions in .cc match order in .h. 4. Removes some left behind headers. 5. Removes or updates some not up to date comments. Bug: none Test: ash_unittests Change-Id: Ia75eb9ece31a41c2bfa9a9d58aef5ec82cf05325 Reviewed-on: https://chromium-review.googlesource.com/1159329 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#579995}
-
Chris Hamilton authored
This adds explicit lifetime management between URLRequestChromeJob and URLDataSourceImpl, by having the job own a shared_refptr to the data source. This allows the data source to be detached from the backend yet remain alive as long as the request job is still alive (which eventually wants to use its i18n template replacements map). BUG=863318 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I84caa70dff1e1c65ac430fca11656e85e4a6eebd Reviewed-on: https://chromium-review.googlesource.com/1156625 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#579994}
-
Takumi Fujimoto authored
The UI Service is not specific to WebUI, so c/b/ui/media_router/ is a more appropriate directory for it. TBR=bauerb@chromium.org Change-Id: I29b150969511a533bba1188f2466160537c28285 Reviewed-on: https://chromium-review.googlesource.com/1159381Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#579993}
-
Darren Shen authored
KeyboardController has the concept of "locked". When the keyboard is locked (e.g. when it is launched from the accessibility menu), the work area of the screen is shrunk, so that only the part above the keyboard is considered 'useable'. Currently, this is implemented in the shelf by observing changes to the keyboard bounds. If the bounds change and the keyboard is locked, we update the work area with the given bounds. While this is correct, whether the keyboard is locked or not should be internal to the keyboard. Instead, shelf should be listening for the *displaced* bounds, which essentially tell observers how much of the screen is now unuseable. Thus, we replace the keyboard bounds in shelf to either the displaced bounds or the occluded bounds, depending on what the shelf actually wants. If the bounds are used for the work area, then it's the displaced bounds. Otherwise, it's the occluded bounds. Change-Id: I7c53d0b2fe8b3b6769ce7113b924def34db2785e Bug: 845780 Reviewed-on: https://chromium-review.googlesource.com/1146530Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#579992}
-
Fredrik Hubinette authored
Frames have more granular information than the container, so let's use the color space from the frames rather than from the container. BUG=870050 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4dd972561dd85f8ddce3ca55a01e34dc3a8cf386 Reviewed-on: https://chromium-review.googlesource.com/1155785 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579991}
-
Victor Costan authored
sql::Connection represents an opened SQLite database. Pedantically, the name is correct. At the same time, it is inconsistent with the naming convention of similar software -- IndexedDB, LevelDB, and WebSQL all use a derivative of "Database" (IDBDatabase, DB, WindowDatabase) to name this concept. Furthermore, most sql::Connection instances have names like "db" and "database". This CL renames the class to sql::Database, reducing the cognitive load caused by dissonances like "sql::Connection db_". TBR=mpearson Bug: none Change-Id: I8abf34016bca236b6e38a772f5848e7ea9bf1c59 Reviewed-on: https://chromium-review.googlesource.com/1157876 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579990}
-
Kyle Horimoto authored
chrome.send() must always be enabled for dialogs, since dialogs rely on chrome.send() to notify their handlers that the dialog should be closed. Bug: 824568 Change-Id: I12325c243e2f2cf04d417ea71b03519bcb3d1159 Reviewed-on: https://chromium-review.googlesource.com/1145580Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#579989}
-
Zach Helfinstein authored
Rename "isInteresting" to "isActionable" for precision. Bug: None Change-Id: I40d6e2c74b80a0717f0c2b864010d5650bd69378 Reviewed-on: https://chromium-review.googlesource.com/1159179Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#579988}
-
Philip Rogers authored
There are several DidUpdateLayout functions but it is not obvious that these are only called when the main frame lays out (see the callsite in Document::LayoutUpdated). I confirmed this locally. This patch renames these to DidUpdateMainFrameLayout so it is more obvious that this is only called for main frame layouts. The comments indicate that DidUpdateMainFrameLayout should only be called with clean layout, but this is not true for the callsite in RenderViewImpl::OnEnablePreferredSizeChangedMode. A TODO has been added to clean up RenderViewImpl::OnEnablePreferredSizeChangedMode. Bug: 868983 Change-Id: I66de3e8c402e7edeff9a8b1e7991716f55b771a8 Reviewed-on: https://chromium-review.googlesource.com/1156991Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579987}
-
Paul Dyson authored
Bug: 841671 Change-Id: Ieb86ea9e6636651edd0655c2721c11ea430f96cd Reviewed-on: https://chromium-review.googlesource.com/1148022Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#579986}
-
Joshua Bell authored
The cookie RFC[1] does not define an encoding for cookie names/values; they are treated as a sequence of octets. The Cookie Store spec[2] mandates treating the octets as UTF-8 encoded. When decoding octet sequences into strings, the decode should be done without treating a leading U+FEFF as a BOM. Add a test to verify this. [1] https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02 [2] https://wicg.github.io/cookie-store/ Bug: 729800 Change-Id: I23b7eb82b35862b8797a203ae6ea86cbd69001d2 Reviewed-on: https://chromium-review.googlesource.com/1159336Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#579985}
-
Johannes Henkel authored
This one is real simple. I've also tweaked the constant for the native default to be of the same type as the fromNative that uses it, so it's slightly easier to read. Change-Id: Iaaa24d4ee9dbf195ec520a568006812d4549f72e Reviewed-on: https://chromium-review.googlesource.com/1158997Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#579984}
-
Peter Kasting authored
Bug: 866671 Change-Id: Ibee4b8efc16008d4d181b3008860858c9d75efa5 Reviewed-on: https://chromium-review.googlesource.com/1157872 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#579983}
-
Min Qin authored
When Download DB is enabled, there is no need to add an incomplete download to history. The only case we need to add it is when extension is used, or it is a save page download. Bug: 842245 Change-Id: I1a1ba64510a73c2ce70a6fd50709e238da6129cf Reviewed-on: https://chromium-review.googlesource.com/1155795 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#579982}
-
Katie D authored
Deprecates obsolete histograms. Adds integration tests for the data migration. BUG=866550 Change-Id: I6fbce5a8725584aa0c550d28449b1c5a9d7a49f5 Reviewed-on: https://chromium-review.googlesource.com/1149013Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#579981}
-
Peter Kasting authored
This seems to affect only the painting of the frame background and Linux caption buttons. In testing the first and from code inspection of the second, both seem to want "the actual height above the toolbar", which doesn't include this overlap. This eliminates an ugly 1 DIP misalignment of the theme background image bottom with the toolbar top in some themes. Bug: 866671 Change-Id: I55d1aea4c3af656ae427373dff9bacc76bb932ab Reviewed-on: https://chromium-review.googlesource.com/1157875 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#579980}
-
Erik Luo authored
Recently, Console message border colors became CSS variables, which are preserved in dark theme by default. This CL fixes the regression by giving explicit dark colors. Screenshot: https://imgur.com/a/7Hj2GXb Bug: none Change-Id: Ib62c8ffa0454303e35699f1d1c70e398a185d52a Reviewed-on: https://chromium-review.googlesource.com/1159208 Commit-Queue: Erik Luo <luoe@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#579979}
-
BUG=762641 TBR=alemate@google.com Change-Id: Id6046d0ff6de24fdc47bac127cf839954fac484b Reviewed-on: https://chromium-review.googlesource.com/1159350Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579978}
-
Alexander Alekseev authored
This CL routes onBeforeShow event to the oobe-dialogs, that are not subnodes of another Polymer object. Bug: 828999 Change-Id: Id2cee750d2364e53052133bbea7d27ea2c1ca0a2 Reviewed-on: https://chromium-review.googlesource.com/1157912Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#579977}
-
Alexander Alekseev authored
Bug: 828999 Change-Id: I2be47264b2b3140e777b6d711e36b87bfa40daed Reviewed-on: https://chromium-review.googlesource.com/1157914Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#579976}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af27deaf0199..0da902e4fde4 Created with: gclient setdep -r src-internal@0da902e4fde4 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I80b93ee2a297c48dba14242221b4ad3c6fa85ce6 Reviewed-on: https://chromium-review.googlesource.com/1159026Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579975}
-
Scott Violet authored
I removed the ScreenProvider interface a while back, so naming the file screen_provider doesn't make sense anymore. BUG=none test=none Change-Id: Ie53dca7acd9aae61a1f196c240397c7fc78255bb Reviewed-on: https://chromium-review.googlesource.com/1159264Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#579974}
-
Bernhard Bauer authored
* Provide default implementations for newly added methods for dismissing and describing items. * Split out base classes for SimpleListObservable and SimpleRecyclerViewMcp that support partial updates. SimpleListObservable and SimpleRecyclerViewMcp now internally use Void for the payload type to indicate that partial updates are not supported. * Decouple ChildNode and InnerNode from the content suggestions code by parameterizing them. In a future CL they should be moved out of the ntp.cards package and renamed. Bug: 805070 Change-Id: I1b996d8af4c85e07bdf45e435eb045a626669ba2 Reviewed-on: https://chromium-review.googlesource.com/1109973Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#579973}
-
Peter Boström authored
css3/filters/effect-drop-shadow-hw.html is flaky on Linux (times out). Disable it during investigation. Bug: chromium:862806 Tbr: sugoi@chromium.org Change-Id: If662eca90584c819efb002881ae17aef7e7be637 Reviewed-on: https://chromium-review.googlesource.com/1159272Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#579972}
-
Yue Li authored
Bug: None Test: Local compile Change-Id: Id996eaa35211587410d4871c9ed55247683c6edc Reviewed-on: https://chromium-review.googlesource.com/1159392Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#579971}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6af2bfe03baf..3c868f436bc0 git log 6af2bfe03baf..3c868f436bc0 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 treehugger-gerrit@google.com Merge "Propagate tracing session to the producers" Created with: gclient setdep -r src/third_party/perfetto@3c868f436bc0 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Icb5cf81188b120569f22b07a4819ce457cf8bd82 Reviewed-on: https://chromium-review.googlesource.com/1159028 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579970}
-
Stephen McGruer authored
Before this CL TimeDelta had saturation behavior for translating from/to other values, but had clamping behavior for its computation. That is, invariants like the following did not hold: TimeDelta::Max() - TimeDelta::FromSeconds(1) == TimeDelta::Max() This CL fully implements saturation behavior, such that TimeDelta::Max() and TimeDelta::Min() are treated as positive and negative infinity regardless, with all the expected mathematical consequences. The one exception is that adding/subtracting a saturated TimeDelta to a TimeClass is still undefined. This was left undefined because we are not yet making a statement on whether TimeClass should be considered to have clamping or saturating behavior for values outsied of range. See the linked bug, or also the discussion at https://groups.google.com/a/chromium.org/forum/#!topic/platform-architecture-dev/S4umX2sOvrk Bug: 869387 Change-Id: I2b3f98c69e7fc5030a6e210d75409d667b73c5ac Reviewed-on: https://chromium-review.googlesource.com/1155264 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#579969}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2563fc3895f2..0562ff4f6e2e git log 2563fc3895f2..0562ff4f6e2e --date=short --no-merges --format='%ad %ae %s' 2018-08-01 tsepez@chromium.org Bounds check lineSrc in JBig2_Image.cpp. 2018-08-01 rharrison@chromium.org Add in support for using .evt in make_expected.sh Created with: gclient setdep -r src/third_party/pdfium@0562ff4f6e2e The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:867501 TBR=dsinclair@chromium.org Change-Id: I9e03617e8c2be4be678a25c82fac6bff19e722ae Reviewed-on: https://chromium-review.googlesource.com/1159241Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579968}
-
Daniel Zhang authored
user queries. Current iteration: 1. Autocomplete queries will only autocomplete if it is confident in a url or text query (no apps or answer cards). 2. Autocomplete is based off of the first result view in the SearchResultPageView. 3. Up/Down/Left/Right/Tab keys all trigger autocomplete. Bug: 865543 Change-Id: I8be9ba36f4bb79bc250b64d289919bd898144862 Reviewed-on: https://chromium-review.googlesource.com/1141118 Commit-Queue: Daniel Zhang <oxyflush@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#579967}
-
Jacob Dufault authored
I am not aware of any features which still require this. Bug: 836119 Change-Id: Id423a3dd6bafd6cbf11786a20e8e6776792ea739 Reviewed-on: https://chromium-review.googlesource.com/1131822Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579966}
-
Ryan Hamilton authored
Change-Id: I567c131eaedfe6c232afb61afb74b83da19c7017 Reviewed-on: https://chromium-review.googlesource.com/1150685 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#579965}
-
Emil A Eklund authored
Tbr: atotic@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I33fb8d23fbb36138045d3281442046992d9e69ee Reviewed-on: https://chromium-review.googlesource.com/1159270Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#579964}
-