GitLab

A null ExtensionGalleriesHost was left in the map, prevent it from being inserted.

BUG=155845
TEST=See comment 5 of bug.


Review URL: https://chromiumcodereview.appspot.com/11188015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162394 0039d316-1c4b-4281-b951-d872f2087c98

R=jamesr@chromium.org
BUG=154451


Review URL: https://chromiumcodereview.appspot.com/11183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162393 0039d316-1c4b-4281-b951-d872f2087c98

Plumb RunFileChooser to the embedder's WebContentsDelegate so if the embedder is allowed to show
a file chooser, then so is the guest.

BUG=143801
TEST=<input type="file"> in guest

Review URL: https://chromiumcodereview.appspot.com/11098056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162392 0039d316-1c4b-4281-b951-d872f2087c98

###
Reason:
chromeos-chrome-24.0.1300.0_alpha-r1: ui/base/x/x11_util.cc: In function 'int ui::CoalescePendingMotionEvents(const XEvent*, XEvent*)':
chromeos-chrome-24.0.1300.0_alpha-r1: ui/base/x/x11_util.cc:1449:14: error: 'ui::ValuatorTracker' has not been declared
chromeos-chrome-24.0.1300.0_alpha-r1: ui/base/x/x11_util.cc:1450:15: error: 'ui::ValuatorTracker' has not been declared
chromeos-chrome-24.0.1300.0_alpha-r1: ui/base/x/x11_util.cc:1483:18: error: 'ui::ValuatorTracker' has not been declared
chromeos-chrome-24.0.1300.0_alpha-r1: ui/base/x/x11_util.cc:1484:19: error: 'ui::ValuatorTracker' has not been declared
chromeos-chrome-24.0.1300.0_alpha-r1: make: *** [c/Release/obj.target/ui/ui/base/x/x11_util.o] Error 1
###

This shares the movement event coalescing from RootWindowHostLinux, which
was disabled to make initial bringup easier.

BUG=146077


Review URL: https://chromiumcodereview.appspot.com/11192009

TBR=erg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11185026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=151255
TEST=unit test & visual


Review URL: https://chromiumcodereview.appspot.com/11087037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162390 0039d316-1c4b-4281-b951-d872f2087c98

BUG=145783


Review URL: https://chromiumcodereview.appspot.com/11193014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162389 0039d316-1c4b-4281-b951-d872f2087c98

The fix for 153077 (10977088) was reverted because the ash_unittests failed for non ChromeOS. The only change is that I moved "#if defined(OS_CHROMEOS)" to encompass the whole newly added test:
AcceleratorControllerTest.DisallowedAtModalWindow
in file:
ash/accelerators/accelerator_controller_unittest.cc

see also: 
http://code.google.com/p/chromium/issues/detail?id=156227
https://codereview.chromium.org/11189021

http://code.google.com/p/chromium/issues/detail?id=153077
https://chromiumcodereview.appspot.com/10977088/

http://code.google.com/p/chromium/issues/detail?id=134093
https://chromiumcodereview.appspot.com/10993067/

BUG=156227
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11189021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162388 0039d316-1c4b-4281-b951-d872f2087c98

Some code checked the resizability of the window and used it to key a change in
window style. For app windows, we always want a very particular window style,
so we check for the remove_standard_frame Widget::InitParams option and ignore
the resize flag.

Also, change the shell window NonClientHitTest code to not return HTTOPLEFT and
friends when the window is non-resizable.

R=ben@chromium.org
BUG=155219


Review URL: https://chromiumcodereview.appspot.com/11154007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162387 0039d316-1c4b-4281-b951-d872f2087c98

BUG=152181


Review URL: https://chromiumcodereview.appspot.com/10987039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162386 0039d316-1c4b-4281-b951-d872f2087c98

R=dgrogan@chromium.org
BUG=113118


Review URL: https://chromiumcodereview.appspot.com/11193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162385 0039d316-1c4b-4281-b951-d872f2087c98

There was a bug in the Flash code that caused a render crash. To reproduce the crash you had to do the following:
  - run on a Retina device
  - disable accelerated compositing
  - enable click to play
In this case playing a flash video would crash the renderer.

The problem was that we were incorrectly calculating the scaled rect of a bitmap.

For example, when the pixel size of the bitmap is 1x1 the scaled size should be 0x0. Instead we were rounding up and returning a scaled valeu of 1x1.

Fix was to use ToEnclosedRect instead of ToEnclosingRect.

BUG=155309
TBR=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11146009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162384 0039d316-1c4b-4281-b951-d872f2087c98

PPB_Font_Dev.GetFontFamilies() is a sync operation that waits for GetFontListAsync() to finish on the FILE thread in the browser process.
If the thread is busy, it could hang for quite a while.
Some Pepper Flash hangs are caused by this.

BUG=155931
TEST=None


Review URL: https://chromiumcodereview.appspot.com/11143028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162383 0039d316-1c4b-4281-b951-d872f2087c98

When app windows are maximized the normal window frame is replaced with a
special AppNonClientFrameViewAura. This adds a test for frame replacement
on maximize, restore and minimize.

BUG=156093
TEST=added test to browser_test AppNonClientFrameViewAuraTest


Review URL: https://chromiumcodereview.appspot.com/11192004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162382 0039d316-1c4b-4281-b951-d872f2087c98

This shares the movement event coalescing from RootWindowHostLinux, which
was disabled to make initial bringup easier.

BUG=146077


Review URL: https://chromiumcodereview.appspot.com/11192009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162381 0039d316-1c4b-4281-b951-d872f2087c98

- External extensions are installed initially disabled.
- Global error appears in menu, which will show an install dialog when clicked.

TBR=sky@chromium.org
BUG=137469,131510

Review URL: https://chromiumcodereview.appspot.com/11150002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162380 0039d316-1c4b-4281-b951-d872f2087c98

The tests that use this code path no longer need the experimental API permission. For better testing this flag should be removed.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11147017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162379 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162378 0039d316-1c4b-4281-b951-d872f2087c98

Also adds DEPS to keep chromeos dependencies out of ash/system

This is part of an effort to move chromeos network management code from src/chrome/ to src/chromeos.

BUG=154856

Review URL: https://chromiumcodereview.appspot.com/11039034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162377 0039d316-1c4b-4281-b951-d872f2087c98

Use RejectAuthenticatingClient instead of DisconnectAllClients to reject incoming clients on curtain mode activation errors.

If we DisconnectAllClients from within the CurtainingHostObserver's OnClientAuthenticated callback, it will ultimately cause OnClientDisconnected callbacks for all HostStatusObservers to run *immediately*, before the OnClientAuthenticated for the next observer in the queue are called. This can cause the OnClientDisconnected callback for that observer to run *before* its OnClientAuthenticated callback.

For example, if HostUserInterface is enabled, a remote client tries to connect to the console, and curtaining fails, this will cause the local disconnect window to stay up after the client is rejected (before the Hide() call for the disconnection runs before Show()).

BUG=156254

Review URL: https://chromiumcodereview.appspot.com/11187017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162376 0039d316-1c4b-4281-b951-d872f2087c98

behind a flag

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11018013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162375 0039d316-1c4b-4281-b951-d872f2087c98

BUG=152702


Review URL: https://chromiumcodereview.appspot.com/11151029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162374 0039d316-1c4b-4281-b951-d872f2087c98

BUG=151685

Review URL: https://chromiumcodereview.appspot.com/11148035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162373 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11065022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162372 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@google.com

Review URL: https://codereview.chromium.org/11196018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162371 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162370 0039d316-1c4b-4281-b951-d872f2087c98

TBR=csharp@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11189017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162369 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107201
TEST=no visible change


Review URL: https://chromiumcodereview.appspot.com/11190014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162368 0039d316-1c4b-4281-b951-d872f2087c98

We are switching away from Profile, and content::BrowserContext is preferred
over it.

BUG=144783
R=sky@chromium.org

Review URL: https://codereview.chromium.org/11116015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162367 0039d316-1c4b-4281-b951-d872f2087c98

The inputs to the calculator model were called "events". Comments in
http://crreview.com/11099051 indicate this causes confusion when those
are mixed with the totally different DOM events also used in view.js.
With this change, the calculator model inputs were renamed "inputs" to
avoid that confusion. No functionality was changed and tests pass after
the test.


Review URL: https://chromiumcodereview.appspot.com/11189023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162366 0039d316-1c4b-4281-b951-d872f2087c98

retry of https://codereview.chromium.org/11187005/

R=ben@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/11192007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=156261
TBR=ddorwin


Review URL: https://chromiumcodereview.appspot.com/11188025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=154964
Test=See bug

Review URL: https://chromiumcodereview.appspot.com/11099011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162363 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107201
TEST=no visible change


Review URL: https://chromiumcodereview.appspot.com/11191008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162362 0039d316-1c4b-4281-b951-d872f2087c98

Previously, computation of the interval resulted in a negative value
in under certain circumstances, which resulted in a DCHECK failure.
This patch fixes the problem.

BUG=154363
TEST=Log in using a large Drive account; open Files.app and go to Drive; The number of fetched files was updated smoothly

Review URL: https://chromiumcodereview.appspot.com/11192027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162361 0039d316-1c4b-4281-b951-d872f2087c98

M D DLS: Dead store to imageUrl in
org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest.testCalledForImage()
At AwContentsClientShouldInterceptRequestTest.java
M D DLS: Dead store to onPageFinishedCallCount in
org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest.testOnLoadResourceCalledWithCorrectUrl()
At AwContentsClientShouldInterceptRequestTest.java
M D SF: Switch statement found in
org.chromium.android_webview.AwContents$IoThreadClientHandler.handleMessage(Message)
where default case is missing  At AwContents.java
M P SIC: Should
org.chromium.android_webview.test.AwContentsClientShouldIgnoreNavigationTest$TestAwContentsClient$ShouldIgnoreNavigationHelper
be a _static_ inner class?  At
AwContentsClientShouldIgnoreNavigationTest.java

Java only change and android bots are happy.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11196016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162360 0039d316-1c4b-4281-b951-d872f2087c98

Even if there's an entry that doesn't have a valid extension ID, we
should allow the remaining entries to be processed.

BUG=chromium:131065
TEST=unit test

Review URL: https://chromiumcodereview.appspot.com/11183029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162358 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=sky


Review URL: https://chromiumcodereview.appspot.com/11183026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162357 0039d316-1c4b-4281-b951-d872f2087c98

TsfEventRouter is used for catching tsf related events and forwarding to observers.
This class is not used at this moment. This will be used for implementing Omnibox suggestion on Metro UI.
This patch only affects on Metro UI and never affects on classic UI on Win8 or prior.

BUG=151901, 141820
TEST=Manually done on Win8 classic and metro mode.

Review URL: https://chromiumcodereview.appspot.com/11148012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=154253


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162123

Review URL: https://chromiumcodereview.appspot.com/11141024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162355 0039d316-1c4b-4281-b951-d872f2087c98

Rename SurfaceState to MemoryManagerState. The state in this structure is used only by the GPU memory manager, so the name should reflect this. 

Move GpuCommandBufferStubBase state is used only by the GPU memory manager into MemoryManagerState.


Review URL: https://chromiumcodereview.appspot.com/11187010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162354 0039d316-1c4b-4281-b951-d872f2087c98