- 03 Aug, 2018 40 commits
-
-
Keishi Hattori authored
If you pass a placement only object to WTF::Bind, the Trace method will not be called. It can result in the on-heap objects referenced from the object, collected prematurely. In this case the backing for PaymentInstrument::icons_ had this problem. In this CL we wrap the PaymentInstrument in a GarbageCollected class so we can use a Persistent on it. Bug: 869887 Change-Id: I2ae75c3652f52a898dac422c2c867c388d170f88 Reviewed-on: https://chromium-review.googlesource.com/1158668 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580435}
-
Mohamed Amir Yosef authored
This CL enables more integration tests for bookmarks to run against USS archiecture. Bug: 516866 Change-Id: Icece27bdf1b2070ca72d667b1a70e623c45c315f Reviewed-on: https://chromium-review.googlesource.com/1158691 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580434}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eae13a4b34cc..e16a2e80be66 git log eae13a4b34cc..e16a2e80be66 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 vovoy@chromium.org Look up wpr archives by story name only 2018-08-02 zmo@chromium.org Hookup finder_options.browser_options.wpr_mode for gpu integration tests. Created with: gclient setdep -r src/third_party/catapult@e16a2e80be66 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:810616,chromium:867155 TBR=sullivan@chromium.org Change-Id: I18bcbd9dffcaadf0d66ca2ccc92ee7be45238e82 Reviewed-on: https://chromium-review.googlesource.com/1161146Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580433}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/578ef2847b72..84dd183a82c3 git log 578ef2847b72..84dd183a82c3 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 aljabri@amazon.com Implement Color Filters for SKIA SVG backend Created with: gclient setdep -r src/third_party/skia@84dd183a82c3 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I79395f4e00bcbf1841197f8e9f935886cbd31ed3 Reviewed-on: https://chromium-review.googlesource.com/1161346Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580432}
-
David Black authored
The molecule icon is originally centered horizontally in its parent. On delivery of the first query response, it animates to align left in its container. I did not animate the greeting/progress indicator views in this CL because they are going to have to move to a separate parent. This is because they need to be laid out on top of the UiElementContainerView, not inside of it. Otherwise, they will push down the response UI elements when visible. See bug for spec/demo. Bug: b:112161077 Change-Id: Ib46cebb0172e6ac64bf0b0966e2082f3e17f20f8 Reviewed-on: https://chromium-review.googlesource.com/1161383 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#580431}
-
David Black authored
We have a contract with the server that TTS will be after all UI responses. When the server breaks this contract, we currently crash. We should not crash when server breaks contract but we will ignore the unexpected responses. Bug: b:112158958 Change-Id: I560c647584bee2ee3fcbce74c2f77b8124fa3d82 Reviewed-on: https://chromium-review.googlesource.com/1161390 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#580430}
-
David Black authored
When the mic time's out, we should NOT clear the answer for the previous query to present an empty response. Instead, we should treat it as if the timed out query did not occur and retain the prior view/model state. Bug: b:112146822 Change-Id: I5a403ae071c5a17def3c77b9ae3503d755a70a60 Reviewed-on: https://chromium-review.googlesource.com/1161007 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#580429}
-
kristipark authored
Hide the settings menu if a theme is installed and custom links is not enabled. Bug: 869702 Change-Id: If8fe8d2382ab92f7c8f44795548e1f3e34e2c690 Reviewed-on: https://chromium-review.googlesource.com/1159681 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580428}
-
Robert Sesek authored
GetKeyEquivalentAndModifierMaskFromAccelerator() computes the key equivalent for menu items. If the key equivalent is inherently shifted (e.g. + and }), do not include Shift in the modifier flags, since it is already encoded in the equivalent. Including it in the flags results in Shift being required in addition to the key. Bug: 867788 Test: Cmd+Plus zooms the page, as well as Cmd+Shift+Plus. Change-Id: I3536d7652804f77a14b51197cdf5f49d6defc77d Reviewed-on: https://chromium-review.googlesource.com/1157224Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#580427}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I51800268a9406760ff8058719e75bc0f33e3c093 Reviewed-on: https://chromium-review.googlesource.com/1161480Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#580426}
-
Andrew Moylan authored
Also fix 'bug' where service name was being used instead of interface name in MethodCall (though they are the same string ...) Bug: 782499 Change-Id: I81fb4e2bf9e093b4c58984c47b993fbbd9c30c1c Reviewed-on: https://chromium-review.googlesource.com/1160833Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580425}
-
Jinsuk Kim authored
Should have been deleted by https://crrev.com/c/689054. Bug: 704323 Change-Id: I8f09d44fb10a05e4088c8416af3a5d2fa67461c4 Reviewed-on: https://chromium-review.googlesource.com/1159551 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#580424}
-
Mounir Lamouri authored
Bug: 870493 Change-Id: I0ef3b6ea0c83cea18de59a7a8c135a8c445b6479 Reviewed-on: https://chromium-review.googlesource.com/1161460Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#580423}
-
Ben Pastene authored
These deps were embedded in //:chromiumos_preflight. This moves them to a separate target at //chromeos:cros_chrome_deploy for easier reuse. And add it to telemetry tests. Bug: 836447 Change-Id: I786a6827c610c33b19c8027fb227026c22f3d319 Reviewed-on: https://chromium-review.googlesource.com/1157645Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#580422}
-
Kyle Milka authored
Fade in the background image only once it's fully loaded. In order to make this work the custom background is now its own element, and not part of the page body. Bug: 859373 Change-Id: I77c2e87b45dc378b7d53ea9165b29be88eb0a395 Reviewed-on: https://chromium-review.googlesource.com/1155826 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580421}
-
Alan Cutter authored
This CL adds the HostedAppButtonContainer to OpaqueBrowserFrameView for hosted app (including PWA) windows. This brings hosted app windows in line with Windows 10 and is in preparation to do the same for Linux. This change is hidden behind the DesktopPWAWindowing flag. No theme color: https://bugs.chromium.org/p/chromium/issues/attachment?aid=351013&signed_aid=DKxP-apBa2Tk8wt4cMG6Lw==&inline=1 Light theme color: https://bugs.chromium.org/p/chromium/issues/attachment?aid=351014&signed_aid=WvEQ9H_tFU9xhHODR8SOrA==&inline=1 Dark theme color: https://bugs.chromium.org/p/chromium/issues/attachment?aid=351015&signed_aid=C7Y4ZEgoFwKF5ECOmFVHEA==&inline=1 Bug: 854479 Change-Id: I058bcd139532ddcbea223a6cb1a391d13a16e8ab Reviewed-on: https://chromium-review.googlesource.com/1156117 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#580420}
-
Zhongyi Shi authored
Add a new test in QuicChromiumClientSessionTest to verify path degrading during crypto handshake will be detected. Bug: 790547 Change-Id: If39cf0fcf342372669f951fef758334e9520ccea Reviewed-on: https://chromium-review.googlesource.com/1161491Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580419}
-
Xi Cheng authored
Bug: 851163 Change-Id: I4655ce7f882983bfd671ec27dfb9d54c62f0e166 Reviewed-on: https://chromium-review.googlesource.com/1161333Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#580418}
-
Artur Khachatryan authored
Updeted to run Java tests for the latest Selenium repository Change-Id: I6581416af1147f3f0d49b3436c295eeb0504b833 Reviewed-on: https://chromium-review.googlesource.com/1112298Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580417}
-
Trent Apted authored
Bug: 867700 Change-Id: Icab0365cfaeb5a8a5c6daaffcc21db3437cc8e14 Reviewed-on: https://chromium-review.googlesource.com/1158105Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#580416}
-
Miguel Casas authored
This CL adds a CanvasRenderingContext::IsOriginTopLeft() method that is used to indicate if the canvas origin of coords -top left corner- and the CanvasResource origin -low left corner- differ and need reconciliation. IsOriginTopLeft() is usually false if the context IsAccelerated(); for WebGL cases the framebuffer can be flipped itself instead: this is marked by the presence of a context flag. IsOriginTopLeft() is true in this case. This CL wires this info to CanvasResourceDispatcher::PrepareFrame() so that the DrawQuad is marked appropriately. On some platforms (intel) only non-flipped quads can be promoted to overlays (enabling front buffer rendering). Running with the patch makes the webgl demo [1] show up as overlay on both nautilus and scarlet (needs at least 10925 OS). Canvas2D still OK. [1] https://codepen.io/miguelao/full/WKZaqd Bug: 869922 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idbe2bf4901c8f71b3fe0b596f5e7c3e3f0ae0df6 Reviewed-on: https://chromium-review.googlesource.com/1159185Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#580415}
-
Pavel Feldman authored
Change-Id: I724548b02b574864c482b900376d5a25ba1dab7c Reviewed-on: https://chromium-review.googlesource.com/1159986Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#580414}
-
Kyle Horimoto authored
Previously, the button was not hooked up to anything. Now, clicking the button results in a call to the MultiDeviceSetup service, which completes the retry attempt. Bug: 824568 Change-Id: I0de5ead024f63dda2cb3a26dfb07a987ab54b877 Reviewed-on: https://chromium-review.googlesource.com/1159202 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#580413}
-
Andrew Moylan authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/6d8535d43743..a2a458bd5d69 $ git log 6d8535d43..a2a458bd5 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 qiyuh bluetooth: Add kStackSyncQuitting as bluetooth adapter property 2018-07-27 amoylan Rename to org.chromium.MachineLearning Created with: roll-dep src/third_party/cros_system_api R=derat@chromium.org Change-Id: I2fcb56b27c664d5ad7e1d0cd149cf4962e4f6656 Reviewed-on: https://chromium-review.googlesource.com/1160829Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580412}
-
Takuto Ikuta authored
This is for more than 30 mins compile steps like below builds. 2978s https://ci.chromium.org/b/8939325304285978864 2782s https://ci.chromium.org/b/8939363044758981744 2702s https://ci.chromium.org/b/8939330795897045200 2595s https://ci.chromium.org/b/8939375915479218880 2548s https://ci.chromium.org/b/8939363618226431392 Bug: 804251 Change-Id: I0b2526a12712079080a38ca72e82f9a9a32d524a Reviewed-on: https://chromium-review.googlesource.com/1160139Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#580411}
-
Renee Wright authored
Bug: 862609 Change-Id: I27594afaa4b128ff0ae8e6009ff5c88eb22c69f3 Reviewed-on: https://chromium-review.googlesource.com/1160123Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#580410}
-
Fady Samuel authored
Compositing.CompositorFrameSinkSupport.SubmitResult will never be hit with OOP-D. This CL fixes that. Bug: 865179 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id123904da50aa02fb3997ecaeac7078654fca4fd Reviewed-on: https://chromium-review.googlesource.com/1161481Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580409}
-
Ryan Tseng authored
"HOME" doesn't always exist as a envvar https://stackoverflow.com/questions/4028904/how-to-get-the-home-directory-in-python Bug: 869249 TBR: jbudorick Change-Id: I13f381d12ac75f3ec45b9736b980b30e32e602af Reviewed-on: https://chromium-review.googlesource.com/1157648Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#580408}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Id2b4a3db66c2f98d166740e424a5ae9783c49dbf Reviewed-on: https://chromium-review.googlesource.com/1161563 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580407}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cdda2f0c..f6db395a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie94e593280d5cb99cf1c373b42710d761c23ab96 Reviewed-on: https://chromium-review.googlesource.com/1161294Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580406}
-
Alan Cutter authored
This CL adds a null check to RenderViewContextMenu::AppendLinkItems() ensuring we have an associated Browser before attempting to use it. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1158110 without using TestWebContents (which results in a bad downcast). Bug: 869280 Change-Id: I6799f0c746c0cdca941e1235ac476f4e1d8a1f0e Reviewed-on: https://chromium-review.googlesource.com/1160121Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580405}
-
Jinsuk Kim authored
UserDataFactory in WebContents interface ended up not being used by embedder but all within contents layer. This CL hides the interface by moving it to WebContentsImpl. Change-Id: I8ee92891c71cca6892a83757b0ed22c7d53a707d Reviewed-on: https://chromium-review.googlesource.com/1159559Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#580404}
-
Trent Apted authored
The ExifParser constructor was missing a comment causing the compiler to ignore all the other annotations. Closure didn't complain about the constructor itself missing a comment because it's never invoked as a constructor by name. It's passed as a factory to registerParserClass(). Bug: 860355 Change-Id: I12bf8bf1c0b3ac9c5b4825e22a58558121258fa9 Reviewed-on: https://chromium-review.googlesource.com/1160061Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#580403}
-
Pawel Osciak authored
This reverts commit 7528f618. Reason for revert: disable the feature by default while related issues are being investigated (b/111781384). Original change's description: > Enable VA-API-based HW VP8 encoding by default. > > Flip the VaapiVP8Encoder flag to enable VA-API based HW VP8 encoder by > default. > > BUG=794608 > TEST=veatest, apprtc > > Change-Id: If99f825788786dc4cc2be8c4f7a3908d04023368 > Reviewed-on: https://chromium-review.googlesource.com/1080436 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Pawel Osciak <posciak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564004} TBR=posciak@chromium.org,xhwang@chromium.org,sandersd@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 794608,b:111781384 Change-Id: I35232863ca5b96285994cb03553548b0b72ff169 Reviewed-on: https://chromium-review.googlesource.com/1160181Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#580402}
-
Andrew Moylan authored
We are collapsing the ModelProvider interface into the top-level MachineLearningService interface. ModelProvider's sole method LoadModel becomes a method of MachineLearningService. This reflects the corresponding Chromium OS change: crrev.com/c/1158091. (The changes are safe to perform simultaneously as no clients call this interface yet.) Bug: 836095 Change-Id: Ia30be3ff176a72f2873c589ad1bc8e5c53248031 Reviewed-on: https://chromium-review.googlesource.com/1160138Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580401}
-
Kunihiko Sakamoto authored
Mark virtual/new-remote-playback-pipeline/media/controls/text-track-menu-pointer-selection.html as slow Tbr: mlamouri@chromium.org No-Try: true Bug: 865262,869906 Change-Id: Ib28e65954d6b9d0e0d24f3598d6b4da7dc274153 Reviewed-on: https://chromium-review.googlesource.com/1160832Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580400}
-
Eric Stevenson authored
Also fix incorrect usage of json.dump(). Change-Id: I5b02f9fead661f84d68eec8126101cc26c6110af Reviewed-on: https://chromium-review.googlesource.com/1159929 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580399}
-
Tim Song authored
Change-Id: Ic3aef8ab7e798680c0c572131f569dc93c9b4bdf Reviewed-on: https://chromium-review.googlesource.com/1161100Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#580398}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I048cf0c93b510568630e112087069d30ba76d5cd Reviewed-on: https://chromium-review.googlesource.com/1161564Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#580397}
-
Robert Ma authored
No-Try because tests haven't been imported. TBR=foolip No-Try: True Bug: 870526, 870528 Change-Id: I72df4669a5f22d7676ac289eb0c208633b6b019c Reviewed-on: https://chromium-review.googlesource.com/1161559Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#580396}
-