- 20 Sep, 2019 40 commits
-
-
François Doray authored
This adds a historical_histogram_data.md file in which data from the ThreadPool.NumTasksRunWhileQueuing.* histogram is reported. Actions to improve the situation described by this histogram are recommended. Bug: 906079 Change-Id: I4872b6e0c38979161547c8e40ff3125bb971d50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804789 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#698464}
-
Henrique Ferreiro authored
Convert the implementation and all users of the mojom::OmniboxPageHandler and OmniboxPage interfaces. Bug: 955171 Change-Id: Ida97b44d4b34f01af1cd8f9784e02f794041fcd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808842 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#698463}
-
Elly Fong-Jones authored
This change: 1) Makes DesktopMediaListView un-focusable; it gives no useful indication of focus and provides no behavior when focused so it primarily serves to confuse. Note that it does have an OnKeyPressed handler, but that is invoked while its child views (the sources) are focused so that behavior remains. 2) Makes DesktopMediaSourceView use the menu selected foreground color rather than the focused border color to indicate selection. Using the latter led to the appearance of a focus ring on the selected element even when the involved source view does not have focus. 3) Makes DesktopMediaSourceView use a focus ring to indicate focus rather than an old-style dashed focus rectangle. 4) Removes DesktopMediaPickerViewsTest.ListViewHasInitialFocus since the list view is no longer supposed to have focus initially (or ever) Bug: 982226 Change-Id: I0118313883eec60c2685662e9cc9c672bccd18b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811758 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698462}
-
chrome://autofill-internalsDominic Battre authored
This CL chrome://autofill-internals to Chrome on iOS as well as web_view on iOS. Bug: 928595 Change-Id: I416cbce554ee4a0e9930f3c3a51da8c98166357d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807244Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#698461}
-
Mugdha Lakhani authored
now that we're using BackgroundTaskScheduler everywhere, since version 76, for this purpose. This was previously attempted several months ago but was deemed too soon: https://chromium-review.googlesource.com/c/chromium/src/+/1601264 Add logic to migrate any existing scheduled GCMNetworkManager tasks to BackgroundTaskScheduler. Update C++ logic, remove feature name, and update tests that use BackgroundSyncLauncher. Bug: 924490 Change-Id: Idf791117267a5c4c0aabc3bb213ec3354cf54ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809310 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#698460}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/feee1e4c3671..fb59a6aa3f71 git log feee1e4c3671..fb59a6aa3f71 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 mbonadei@webrtc.org Return `const char*` from ToString(RTCErrorType error). 2019-09-20 nisse@webrtc.org Delete dead code inside #ifdef WEBRTC_ISAC_FIX_NB_CALLS_ENABLED Created with: gclient setdep -r src/third_party/webrtc@fb59a6aa3f71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I0aa6becabd89ca649bcdb2b972e9c4ac6e1d2dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815686Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698459}
-
François Doray authored
Since the blocking and non-blocking have been merged, there is no need to report data for blocking tasks in separate histograms. This CL also makes passing an |histogram_label| to the constructor of ThreadPoolImpl optional. If no |histogram_label| is provided, no histograms are recorded. This CL takes advantage of that to not record histograms from TaskEnvironment. Bug: 1002318, 995496, 982145, 980409, 972890, 972888, 972883 Change-Id: Ib192f80fc7a706780f0e75bed14df6b58a7db9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813780 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the discards::mojom::DetailsProvider, GraphChangeStream and GraphDump interfaces. Bug: 955171 Change-Id: I907a35b6175b6c0b8bf45fab141d58fa2ae6baeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805666 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#698457}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0d86a5801e4d..8b762286def9 git log 0d86a5801e4d..8b762286def9 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 vapier@chromium.org cros_build_lib: drop unused traceback helper Created with: gclient setdep -r src/third_party/chromite@8b762286def9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I496814180f2296ebcc7c6fe6bd95a53d56742ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816371Reviewed-by:
-
Marc Treib authored
TBR=afakhry@chromium.org Bug: 1006101 Change-Id: Ic9fce0ed5078d8a9e5854b6a1e0e19fe46757877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816464Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#698455}
-
Hans Wennborg authored
Ran `tools/clang/scripts/upload_revision.py 13bdae8541c3fc5acf6ee7de78ec5ab8446848e4`. Binary-Size: crbug.com/1006159, 70KB growth due to afdo heuristics change Bug: 1005146 Change-Id: I057b3095a61b1886b8fc4f00e2f31566362ba9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814797 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#698454}
-
Henrique Ferreiro authored
This CL ports BindInterfaceInGpuProcess to accept a mojo::PendingReceiver and makes the minimum changes to get all users to compile. This is required for later CLs that depend on this function. Bug: 955171 Change-Id: Ib70d2b5612d7905fabde2e7aeff941c4d219f302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801146 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
-
Tanisha Mandre authored
-Normalise the 'region of interest' rectangle to make it usable by the Vision request. - Retrieve the rect from the Preview Overlay View to ensure it is only being received from view related files and doesn't need the camera connection to be setup. Bug:1005216 Change-Id: I2d66fe77dee961ee44387bd42aea7df72f1cf48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810531 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#698452}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 37e6b29e. With Chromium commits locally applied on WPT: cc2a9ab7 "Add missing step_func in wpt/svg/animations/scripted/onhover-syncbases.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I70fa921aa7b4db9abfb2f5fd55fa49ed959222ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816389Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698451}
-
Darren Shen authored
sending_key_event was used to determine whether a key event is being sent from the IME extension. However, we already have a property on the event called kPropertyFromVK that stores this, so we can just remove sending_key_event. Bug: 1005619 Change-Id: I5978c16efe83652f6202e80cf0dd6d1b40c76a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814586Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#698450}
-
Henrique Ferreiro authored
Convert the implementation and all users of the downloads::mojom::PageHandlerFactory, PageHandler and Page interfaces. Bug: 955171 Change-Id: I49c00905b4b3b2df318b0b0147b84bb04ca8f48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805642Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts SerialPort{Ptr, Request} in services, extensions and content to the new Mojo type, and uses pending_receiver<SerialPort> in serial.mojom. Bug: 955171 Change-Id: I6911df8bd057e0e7e8fa81ce00273c4cd049de6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810441 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Kent Tamura <tkent@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#698448}
-
Alexander Timin authored
Expose main bfcache events (StoreDocument / RestoreDocument / Evict) and reasons behind them (CanStoreDocument result with the motivation) in traces. R=arthursonzogni@chromium.org CC=hajimehoshi@chromium.org Change-Id: Idb2b18fab180108247bb17f091650b4877222643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805640 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698447}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1a76aa53c06f22d86cdc2b15b796988c9ddcce17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816637Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e24557f51eec..feee1e4c3671 git log e24557f51eec..feee1e4c3671 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 saza@webrtc.org Add flag to APM to force multichannel even with AEC3 Created with: gclient setdep -r src/third_party/webrtc@feee1e4c3671 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I68508531e89a78738891ecd296ca8ed7a8a3d046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815683Reviewed-by:
-
Christopher Gunadi authored
Wire up dialog to Ansible management service. States are added to modify strings and buttons based on events that happened. Tests for successful and unsuccessful dialog flow. TEST: browser_tests --gtest_filter="*CrostiniAnsibleSoftware*" BUG: 998097 Change-Id: I19d0693a068efeb5b9b6af7a0b04c4ee0ad38ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789229 Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#698444}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3d2c1e9..3c70b7fb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I251626b427671c75997c46df0086f0892b9b038b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816385Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698443}
-
Maksim Sisov authored
This CL is just a code move and does not bring any functionality changes. It's responsibility of PlatformWindows to do restacking now. The API is optional and default implementation is provided. Bug: 990756 Change-Id: Ife24422206ca3aee2ee23e4d5276bc7eba6bb551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813348 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#698442}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b7485bb77fc6..0d86a5801e4d git log b7485bb77fc6..0d86a5801e4d --date=short --no-merges --format='%ad %ae %s' 2019-09-20 vapier@chromium.org config: rework our use of the async property Created with: gclient setdep -r src/third_party/chromite@0d86a5801e4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Icbf2c3cc9c0dff82f7f206656859d7ba76bc323f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816597Reviewed-by:
-
Marc Treib authored
This reverts commit 77b39a3b. (It effectively also reverts a later shaderc roll, https://chromium-review.googlesource.com/c/chromium/src/+/1815159) Reason for revert: Speculative revert, *might* have broken WebGPUDecoderTest on Mac10.11, see linked bug. Bug: 1006181 Original change's description: > Roll DEPS for shaderc and dawn > > There is a breaking API change in shaderc, so these need to be rolled > together to have the break and fix land atomically. The autorollers > will not successfully roll either of these repos independently. > > Change-Id: I75633ce8826c6698cd65a6d99c600111e76ca0d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813919 > Commit-Queue: Ryan Harrison <rharrison@chromium.org> > Commit-Queue: dsinclair <dsinclair@chromium.org> > Auto-Submit: Ryan Harrison <rharrison@chromium.org> > Reviewed-by: dsinclair <dsinclair@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698105} TBR=rharrison@chromium.org,dsinclair@chromium.org,cwallez@chromium.org,kainino@chromium.org Change-Id: Ifd01732eba389adcd31373f0db108858eb34ba89 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815121 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Before this patch: PasswordFormManager used own a |new_blacklisted_| form to signal that the current form has been just blacklisted which was getting cleared upon updates in underlying PasswordStore. After this patch: A boolean is introduce to book keep this information until the data are refreshed from the store. Follow up patches will clean things a little bit more to simplify the Save/Update logic. Change-Id: I775b799a90eaf9fd4964848154168f6ba7283dd0 Bug: 1004783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807329Reviewed-by:
-
arthursonzogni authored
Make about:srcdoc to inherit CSP from its parent. Bug: 1001982 Change-Id: I5e750a8d821e6a8e8cc81e6c8a0feeb7583de020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789541Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698438}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b819e877d74f..2126635fbb7e Created with: gclient setdep -r src-internal@2126635fbb7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib9245bcbfb86342f45730833bed5d29d8bfe6555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816577Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698437}
-
Mohamed Abdelhalim authored
This is the 8th CL of multiple CLs to remove the usages of NavigationHandleImpl completely and replace it with NavigationRequest. This CL removes usages of NavigationHandleImpl::frame_tree_node(). Bug: 995268 Change-Id: I1069073c64f2faa8cc3ef707a92460cd61a67d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810958 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#698436}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a7a721e7. With Chromium commits locally applied on WPT: cc2a9ab7 "Add missing step_func in wpt/svg/animations/scripted/onhover-syncbases.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I634b8d3931fd29ddd7cbc84c222c9c042f5902e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816382Reviewed-by:
-
Anton Bikineev authored
GarbageCollectedFinalized class was removed from BlinkGC in afdb2e7a. Now finalization of GCed type relies solely on C++ type system without the need to manually specify it. This change removes all the checks related to incorrect use of GarbageCollectedFinalized from the plugin. Bug: 990913 Change-Id: I53c73b59a51de407afc6d38fb873f607fec056d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814819Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#698434}
-
Marina Ciocea authored
When the shared tab navigates to a new URL, update the label on the tab sharing infobars to reflect the new name of the shared tab. Bug: 999170 Change-Id: I025a8bb2a958bf73cd921a5337c7dc64ee6428ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816537Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#698433}
-
Javier Ernesto Flores Robles authored
Get the original browser state so the user can save credit cards while on incognito. Bug: 1005912 Change-Id: If683a7ae9cf1b9a9da24eebcfd6c50f2f27e838c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816500 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Both Bindings.cssWorkspaceBinding.uiLocationToRawLocations and well as Bindings.debuggerWorkspaceBinding.uiLocationToRawLocations resolve locations to non-existing CSS and Script locations. This patch fixes Bindings.debuggerWorkspaceBinding.uiLocationToRawLocations to not do this anymore, and hacks Bindings.cssWorkspaceBinding.uiLocationToRawLocations to not do it for formatted sources anymore. For the ultimate fix, we need to get the end position for inline CSS from the back-end. This will allow us to clean-up the hack as well. The significance of this change is that it enables precise coverage gutters for inline CSS and inline scripts. Bug: chromium:1004203, chromium:1005708, chromium:1005789 Change-Id: Ieadb2aef7e610ecec35e28f5f1cc4516a28a0780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814299 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#698431}
-
Hiroki Nakagawa authored
After https://crrev.com/c/1813638, CreateForTesting() no longer touches any private stuff of WebEmbeddedWorkerImpl, and just calls the constructor with null values. That should be inlined in the test for code simplicity. Bug: n/a Change-Id: I329931ff7fc1bb1365ea2028477ec80f8256e114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813797Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#698430}
-
Alex Chau authored
- As part of DeviceInfo migration work we have created a enum in sync proto, which should be used as the source of truth - Migrated all usage of SharingDeviceCapability to proto enum, and replaced bitmask with Set<Enum> - GetDeviceCandidates now takes a single required_feature instead of bitmask, as it's now per feature so only one is required Bug: 991971 Change-Id: I0f2516d71321ab69928d474418deca33e9ad58f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814359Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#698429}
-
Finnur Thorarinsson authored
Bug: 1004762, 860467 Change-Id: I2b86eb3011805b33db45e2447b49524527164ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813326Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#698428}
-
redatawfik authored
- Allow the tool bar to be shown only if "AutofillCreditCardTableViewController" is presented. Bug: 1003899 Change-Id: Id3661216af02eeb3f0365398b56ab59f9b977727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813497 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the media.mojom.AudioOutputStreamProviderClient interface, and adapt unit tests. Bug: 955171 Change-Id: I8791ab3d52f134d7ec29ea9703709641e40edc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803286 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
-
Marc Treib authored
This reverts commit d76a27dd. Reason for revert: Seems to have broken ~all the browser_tests and interactive_ui_tests on ChromeOS, see crbug.com/1006165 Original change's description: > Enable the flag of scrollable shelf by default > > This CL enables scrollable shelf as default. It will be landed after > discussion with other team members. > > Bug: 1002576 > Change-Id: I4dab5b81bf6418d5cc066f2763b4b5862ebff716 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790755 > Commit-Queue: Andrew Xu <andrewxu@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698284} TBR=manucornet@chromium.org,andrewxu@chromium.org Change-Id: Ie19273c5fd4187c67dc0646278e04eb04fce3eb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002576, 1006165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816540Reviewed-by:
-
