GitLab

This is the last of CRWWebDelegate methods used by CRWWebController, removing it
will allow deleting the CRWWebDelegate entirely.
Also removed it from Tab and from PreloadController which were implementing them.
The logic of handling external apps is now entirely moved to AppLauncherTabHelper
which is a policy decider and is attached to the web state used by the CRWWebController.

Bug: 850760, 681867, 674991
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2df6282ae561eef2e1da8fac605f42dbfe4cb97b
Reviewed-on: https://chromium-review.googlesource.com/1124942
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578447}

https://skia.googlesource.com/skia.git/+log/897f256413c1..c4db8708c903


git log 897f256413c1..c4db8708c903 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 ziadb@google.com SkAR Java: refactored SkARUtil (now PaintUtil)
2018-07-26 ziadb@google.com SkAR Java: refactored SkARMatrix.java (now CanvasMatrixUtil.java)
2018-07-26 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 203b26f27d00..dbd1612782f5 (1 commits)
2018-07-26 ziadb@google.com SkAR Java: better UI for finger painting
2018-07-26 herb@google.com Centralize bitmap glyph positioning
2018-07-26 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-07-26 brianosman@google.com Correctly distinguish hairline paths in the SW path renderer's cache
2018-07-26 fmalita@chromium.org Update android_build_app Gradle output location
2018-07-26 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@c4db8708c903

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: Ib7d3c4cb282503e528c14ef0043b74b49a95b03e
Reviewed-on: https://chromium-review.googlesource.com/1151968Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578446}

https://webrtc.googlesource.com/src.git/+log/e4db6a151806..ed1dcf9f2327


git log e4db6a151806..ed1dcf9f2327 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 mbonadei@webrtc.org Enable clang::find_bad_constructs for call/ (part 1).


Created with:
  gclient setdep -r src/third_party/webrtc@ed1dcf9f2327

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8ee83b94330beb6325018cb012ba3ff22c674eb9
Reviewed-on: https://chromium-review.googlesource.com/1151847Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578445}

Make the APIPermission enum more difficult to break by adding explicit
numbers to each entry (to avoid having anyone insert something anywhere
but the bottom) and add a unittest to verify the contents match the
enums.xml file.

Also fix the enums.xml file, which was missing the kSystemPowerSource
entry.

Bug: None

Change-Id: I12e6e0deb7221d7a96524e972f7039b43bdb317f
Reviewed-on: https://chromium-review.googlesource.com/1150405
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578444}

Required for network servicification.

BUG=844965

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If09ae972d4e4c0d0015f862774410d99bbe9b876
Reviewed-on: https://chromium-review.googlesource.com/1143709
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578443}

Bug: 867594
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6e3b94e187996b7b153932041074704bd2fb5895
Reviewed-on: https://chromium-review.googlesource.com/1150805Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578442}

Builds on the highlighting code to display highlights in the pie chart.
The hightlights appear as bars along the chart, similar to the diff
view.

Bug: 847599
Change-Id: I5dc0f163ebaa5d46b331b084391e6e09645e5dd3
Reviewed-on: https://chromium-review.googlesource.com/1152090Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#578441}

Most compositing properties should follow the activation flow
instead of being plumbed directly from LayerTreeHost to LayerTreeHostImpl.
This CL is one of many to move properties over to following the activation
flow.

This CL moves the viewport_visible_rect property used to determine how much
to raster to follow the activation flow.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I05ac2b28b8d593eee01904b0bba7f3809cc0492e
Reviewed-on: https://chromium-review.googlesource.com/1150734Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578440}

OnLostResources() was being used in two different ways. First, it was
used when the shared main thread context provider was lost. Second, it
was used to tell when the GPU process was lost (with OOP-D only). This
CL splits this into two different functions, as the actions required in
both cases are different.

OnLostVizProcess() is only needed for OOP-D where we want to let
DelegatedFrameHost know the renderer surface has been destroyed.

The only functional change here is that sometimes
DelegatedFrameHost::OnLostResources() would get called without OOP-D on
Chrome OS. This is because Chrome OS is the only platform that uses the
shared main thread context without OOP-D. Even on Chrome OS shared main
thread context didn't always exist because it's created on demand for
exo/fastink. Not doing anything in OnLostSharedContext() shouldn't be a
problem, if we had to evict the renderer surface on GPU crashes it would
cause problems on all other platforms that use DelegatedFrameHost where
OnLostResources() was never called.

Bug: 827242
Change-Id: Ideebba3c712a2e1ebaf3c852d9aa7721cb1d40d3
Reviewed-on: https://chromium-review.googlesource.com/1150456Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578439}

Using kSystem means it conflicts with other system level landers, such as
the laser pointer.

BUG=867483
TEST=covered by tests

Change-Id: I40581e6ae8716e333d1e64ecd2ae8ebbcbf1936d
Reviewed-on: https://chromium-review.googlesource.com/1151546Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578438}

The LazyLineBreakIterator::IsBreakable method works by comparing a given
position with the next following breakable position. This is inefficient
as well as unnecessary. Instead limit the scan to the given position + 1
as that still allows comparsion of the supplied and the resulting value.

Similarly, the LazyLineBreakIterator::NextBreakOpportunity method always
scans until the end of the string, even if that is past the threshold of
the section of the string processed. By introducing a version that takes
a length parameter, and changing ShapingLineBreaker::ShapeLine to use it
instead of the unbounded one, the scope of the forward scan can therefor
be limited to the length of the line being processed.

These two changes dramatically speed up line breaking both in legacy and
LayoutNG, especially for large text blocks with few break opportunities.

Test: perf_tests/paint/appending-text.html, perf_tests/layout/long-line-nowrap.html

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7a4186510f4451219dd026e8f3ab1ed0c86fa3c2
Reviewed-on: https://chromium-review.googlesource.com/1150853Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578437}

Bug: 479898
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I3d1b89fc33ebae27f6ab4007eceffb9eb6134ef6
Reviewed-on: https://chromium-review.googlesource.com/887598
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578436}

This reverts commit f002a96e.

Reason for revert: Dirk bisected the chromeos asan failures and it appears this is the culprit. The output from the failing bots isn't particularly helpful as it doesn't have symbols. Here's a recent failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28402

BUG=867826

Original change's description:
> Remove libcpp_is_static
> 
> This change makes libc++ a shared_library iff is_component_build=true, just like
> all other components.  This has the advantage that the RPATH doesn't need to be
> set in sanitizer (non-component) builds just so binaries can find libc++.so.
> This CL also changes RPATH to be set iff is_component_build=true.
> 
> Needs buildtools CL:
> https://chromium-review.googlesource.com/c/chromium/buildtools/+/1142370
> 
> TBR=dpranke,jochen
> R=​thakis
> BUG=850682
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;luci.chromium.try:linux_chromium_asan_rel_ng;luci.chromium.try:linux_chromium_tsan_rel_ng
> 
> Change-Id: I96e74da6d907659b939a0f229693bbd2a6d9140a
> Reviewed-on: https://chromium-review.googlesource.com/1119098
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578085}

TBR=thakis@chromium.org,pcc@chromium.org,thomasanderson@chromium.org

Change-Id: Ieec9ae83b7c12004521358cf71eb2d09fdfc7a09
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850682
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;luci.chromium.try:linux_chromium_asan_rel_ng;luci.chromium.try:linux_chromium_tsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1151917Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578435}

- Rename `repository` to `libs` in order to stop git complaining about
  previously ignored *.info files being overwitten (since we are now
  including them in the repo) when cherry picking
  - Nice side benefit of resetting to -cr0 for packages

- Add gms libraries, previously defined in
  `build/secondary/third_party/android_tools/BUILD.gn`

- Add `third_party/android_deps/Android_SDK_License-December_9_2016.txt`
  - This is used for all gms dependencies which require this license
  - Taken from `https://developer.android.com/studio/terms`

- Pass in output file directly to `aar.py`

- Add .info files to the repository and remove from `.gitignore`

- Increment crX suffix for CIPD packages in order to avoid duplicate
  tags

- Add OWNERS in each package's subdirectory under `libs` so that future
  version upgrades will not require full review, but new packages will
  still go through full third_party review.

Bug: 865020, 865065, 863547
Change-Id: I91cc400d02ce83e0195d8aab3f76939d6ddcb120
Reviewed-on: https://chromium-review.googlesource.com/1142189Reviewed-by: Grace Kloba <klobag@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578434}

BUG=724399,b:70905156

Review URL: https://chromiumcodereview.appspot.com/10535049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141295 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit 49e4b033)
Signed-off-by: Gabriel Marin <gmx@chromium.org>

Change-Id: I5a22ef15a79748fb123609c793c96acbdbe903e1
Reviewed-on: https://chromium-review.googlesource.com/1130778
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578433}

...and also the related *password_value_is_default fields in
PasswordForm. These are only set and never read.

Bug: 845426
Change-Id: I87e686d2cfb588cb94a50e8a6395a7b19b7b82d5
Reviewed-on: https://chromium-review.googlesource.com/1149878Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578432}

Was called AutofillProfileEnabled
Is now called AutofillAddressEnabled

Bug: 860526
Change-Id: Ic2b31c4a108a01049c59b1e6ccad62a7760c2cd9
Reviewed-on: https://chromium-review.googlesource.com/1150699Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578431}

https://chromium.googlesource.com/catapult.git/+log/721613b08607..933672b6cfa1


git log 721613b08607..933672b6cfa1 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 bsheedy@chromium.org Reland "Handle stale directories when pushing files"
2018-07-26 benjhayden@chromium.org Fix a few typos in Descriptor.
2018-07-26 dtu@chromium.org [pinpoint] Add "Win 10 Perf" to list of Pinpoint bots.
2018-07-26 simonhatch@chromium.org Telemetry - Start xvfb when running snapit tests.
2018-07-26 wangge@google.com Modified Script to Parse Time from Arguments
2018-07-26 dtu@chromium.org [pinpoint] Add Job name field.


Created with:
  gclient setdep -r src/third_party/catapult@933672b6cfa1

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:862845,chromium:863995,chromium:825434,chromium:863390,chromium:867722
TBR=sullivan@chromium.org

Change-Id: I3f2cf3e0fdfe04a7f75b86519204fda3988625e6
Reviewed-on: https://chromium-review.googlesource.com/1151905Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578430}

Referencing SurfaceManager::GetLatestInFlightSurface in surface activation instead of fallback surface.

Use SurfaceManager::LatestInFlightSurface in Surface::ActivateFrame to use the latest in-flight
surface as the active reference instead of fallback. This allows for better garbage collection
of surfaces and optimize the notion of fallback surface.

Bug: 857575
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I4f597e431866b3a9886c04b982101199fd4011d7
Reviewed-on: https://chromium-review.googlesource.com/1149092
Commit-Queue: Andre Kaba <akaba@google.com>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578429}

Moves some utility functions for URL filtering from
chrome/browser/supervised_users into components/policy. These will
continue to be used by supervised users, but can now also be used for
policy (namely the upcoming safe sites filter implementation).

Largely a refactoring. The only tangible difference is that the re2
regex objects used to be per-profile but are now global (static):
They used to be members of SupervisedUserURLFilter (which was owned by
the per-profile SupervisedUserService) but are now part of the
singleton EmbeddedURLExtractor helper.

Alternatively, we could create a new //components/url_filter component
with per-profile EmbeddedURLExtractor services, but that seemed like
overkill for a couple utility functions.

Bug: 819405
Change-Id: I4f8313f46778447e123f0021dc3a32cb4598f58c
Reviewed-on: https://chromium-review.googlesource.com/1117884Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578428}

This is a reland of ad191cb7

The fix is changing the build deps of the proto target from
"override_lite_runtime_plugin" to the new "override_lite_runtime".

This only makes sense after https://crrev.com/c/1128249 lands.

Original change's description:
> Add fuzzer for FormStructure::ProcessQueryResponse
>
> Also adds:
> -fuzzing support for protos at components/autofill/core/browser/proto
> -ProcessQueryResponse method to FormStructure class.
>
> Bug: 834707
> Change-Id: I831e012c0a5569f663d6bd435c7c24d7a6f6a524
> Reviewed-on: https://chromium-review.googlesource.com/1125847
> Commit-Queue: Uladzimir Miniailau <miniailau@google.com>
> Reviewed-by: Vaclav Brozek <vabr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572609}

Bug: 834707, 860750
Change-Id: Iab758495777a3d41ce58d0454c36877a3888440e
Reviewed-on: https://chromium-review.googlesource.com/1129019Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578427}

Gives 4dp of whitespace back to the user (in Refresh) by using
TOOLBAR_ELEMENT_PADDING. This unifies the bookmark item spacing with
toolbar items.

Bug: chromium:848631
Change-Id: I20c2ea5735f93a4db2d7c7e6c218ed4bd528c458
Reviewed-on: https://chromium-review.googlesource.com/1152029
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578426}

This adds working WEBGL_multiview extension integration to the
passthrough command buffer. It's not implemented in the validating
command buffer. The implementation is built completely on top of
ANGLE_multiview, and doesn't support native OVR_multiview as a
backend.

This doesn't yet include support for opaque framebuffers either. That
is intended to be done as a follow-up.

The extension is set as a draft extension so it is not enabled by
default. It can be enabled with the --enable-webgl-draft-extensions
flag.

BUG=864524
TEST=WebGL conformance tests

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3153bfa3e5fcb6a9e044c8b0762a8a400b728c7a
Reviewed-on: https://chromium-review.googlesource.com/1140299
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578425}

Recently some positive regular expressions were added to the filter.
When combined with the existing negative filters this resulted in
no tests running.

Keep the file a pure blacklist.

TBR=estade@chromium.org

Bug: 867965
Test: mash_browser_tests on bot
Change-Id: I20b0bc01935fef188c3e21f877a8ad2754dc2250
Reviewed-on: https://chromium-review.googlesource.com/1151765
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578424}

This CL adds support for the referrerpolicy attribute on <script>
elements, remove WPT expectation files for now-passing tests, and
add TODOs for setting the referrer and referrer policy members
separately in module script fetching code.
I2S: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/jfd4knvCiio/qcf5uaspBQAJ

R=kinuko@chromium.org, kouhei@chromium.org, nhiroki@chromium.org, yhirano@chromium.org, yoav@yoav.ws

Bug: 841673
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0fca6a11806fe3c4dc994e5610270edd21467034
Reviewed-on: https://chromium-review.googlesource.com/1146065
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578423}

Write to NULL will trigger a Clang compile warning and the compiler may
optimize and turn it into a non-op.
int* -> volatile int* to fix this.

Original BUG=127724

BUG=724399,b:70905156

Review URL: https://chromiumcodereview.appspot.com/10392109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137251 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit 59ba0417)
Signed-off-by: Gabriel Marin <gmx@chromium.org>

Change-Id: Ida066f00891c47ee5c42fd272ad976cb3f45572e
Reviewed-on: https://chromium-review.googlesource.com/1130777
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578422}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c55015f7..4a0d5f35

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I32d60266c17a1601258d5d9fabdec38d9372d186
Reviewed-on: https://chromium-review.googlesource.com/1151807Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578421}

Somehow r562248 caused a regression whereby it should have been strictly
more performant, the only difference is the potential static
initializer (which if incorrectly initialized could result in it being
non-zero? and somehow cause the timer to be fast?).
Let's try to suppress it.

R=fdoray@chromium.org

Bug: 848255
Change-Id: I21111ddd4c069b9171badc58fc4a1914bb068641
Reviewed-on: https://chromium-review.googlesource.com/1090794Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578420}

ChildProcessData was holding a raw ProcessHandle which meant that there
was no guarantee that the handle would be valid when it was used. This
change switches to a ScopedHandle on Windows, with the associated
duplication of the handle, so that it is guaranteed to be valid. This
fixes a frequently encountered use of an invalid handle that was
detected by Application Verifier. This change also adds a CHECK to
base::GetProcId to check for use of invalid handles even when not using
Application Verifier.

ChildProcessData::handle is now a private member so all references to
it were updated to use accessors.

When ChildProcessData::SetHandle is called the handle is duplicated.
When a ChildProcessData object needs to be copied an explicit
Duplicate function is called.

An IsHandleValid helper function was added.

An invalid test was removed because it was triggering the CHECK in
base::GetProcId.

Bug: 417532,821453,865805
Change-Id: I7e38140335c0140536919341f011f144f150c88f
Reviewed-on: https://chromium-review.googlesource.com/1145767
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578419}

This is because on some platform (e.g. Windows), the way to implement abort()
is different so chrome's crash service can not detect the crash but treat as
normal exit. See http://code.google.com/p/chromium/issues/detail?id=118665 for
some detail.
In this implementation, a segment fault will be triggered and this will be
treated as crash on all platforms.

Original BUG=127724

BUG=724399,b:70905156

Review URL: https://chromiumcodereview.appspot.com/10384117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137013 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit b6da6b18)
Signed-off-by: Gabriel Marin <gmx@chromium.org>

Change-Id: I169e44a30d0238073c8c7687d0e9b3d0e15a0158
Reviewed-on: https://chromium-review.googlesource.com/1130776Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578418}

It's more IME code than general views code.

Bug: none
Test: none
Change-Id: I572dc2c7be0d428760781f44a6678ea684b5f41c
Reviewed-on: https://chromium-review.googlesource.com/1151964Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578417}

BUG=867025

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4d6abf4ecfb611a23214d96cd2bfe410c0529476
Reviewed-on: https://chromium-review.googlesource.com/1149003Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578416}

This is:
  s/base::TaskPriority::BACKGROUND/base::TaskPriority::BEST_EFFORT/g
  git cl format
applied to //src.

This CL only touches cases explicitly prefixed with base:: to avoid
namespace conflicts should there be any. Will handle non-prefixed in a
follow-up CL.

TBR=robliao@chromium.org

Bug: 863341
Change-Id: Idad34a7ecca01644af155ab779eedb3a87544fc0
Reviewed-on: https://chromium-review.googlesource.com/1148546Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578415}

The reason for the crash was that BeforeTranslateInfoBarController calls
TranslateInfoBarDelegate::ShowNeverTranslateInfobar() in order to show the
"never translate infobar which expects the existing translate infobar to be
owned by an instance of InfoBarManager. However InfoBarManagerImpl's lifetime
is tied to the WebState and it may be destroyed due to navigation.

Bug: 867097
Change-Id: Ibf4f6ad15971897a2ac844fa602f961748ec848e
Reviewed-on: https://chromium-review.googlesource.com/1151618Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578414}

It appears that all failures of telemetry_perf_unittests and telemetry_unittests
when running VizDisplayCompositor have either been fixed, or since disabled as
the tests where more general failures.

This updates the isolated script for running these with Viz to no longer have
any skipped tests.

This only affect the Linux Viz FYI bot

TEST=telemetry_unittests_viz, telemetry_perf_unittests_viz

Bug: 799594
Change-Id: I7fafbe3c5ccb7b41fefb08f630c531c26dbba47c
Reviewed-on: https://chromium-review.googlesource.com/1151720Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578413}

1. Enlarge folder icon to reveal partially hidden inner items when a
   dragged item is hovering the icon. To do this, we create two icon:
   unclipped and clipped icon. unclipped icon is only used inside
   AppListItemView to show the animation while clipped icon is
   provided by AppListItemView::GetIconImage().
2. Enlarge preview circle when a dragged item is hovering non-folder
   icon.
3. Add mask layer to folder's background view so that it clips the
   top icons in folder opening and closing animation.

Specs: https://screenshot.googleplex.com/ORnHSj8JYd1

Demo: https://drive.google.com/open?id=1pFna0cXFzMJ2Hqliq-T2EFbra2bkRaNw
(With animation duration 10X)

Bug: 860824
Change-Id: I174629a373bd398de418f8f66f2ad5b902d72c60
Reviewed-on: https://chromium-review.googlesource.com/1138641Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578412}

That is, accelerators should read ",", not "Comma".

Bug: 867732
Change-Id: I7dec0af8475b420cbc4e793fecc823378b04f3ad
Reviewed-on: https://chromium-review.googlesource.com/1151649Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578411}

This cl also removes TouchscreenFlingInProgress function that is no
longer needed.

Bug: 249063
Change-Id: Icc939d654cdfe0cf38c843933f2fd469f843b74c
Reviewed-on: https://chromium-review.googlesource.com/1145784Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578410}

Only show Data Saver main menu item if it's already allowed by the current conditions AND the user has saved 100KB.

Change-Id: I94363f7810d7529bf6975d9e50e1d5d142807a3e
Bug: 867197
Reviewed-on: https://chromium-review.googlesource.com/1149271Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578409}

This method is never accessible cross-origin, so by definition, it can
only be invoked on a local frame.

Change-Id: I9fd8c436a8169dcad8e1c1c7bfd213c7696337b1
Reviewed-on: https://chromium-review.googlesource.com/1151064Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578408}