GitLab

Fully migrate PointerEventFactory to WebPointerEvent
by removing the last API that was expecting
WebMouseEvent.

Bug: 814471
Change-Id: Id4bebab1eefae842f7e368e0e2b328127f65e43f
Reviewed-on: https://chromium-review.googlesource.com/929861Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540331}

Launch bug: crbug.com/758005
Finch config: cl/187340325, cl/187517800

Change-Id: Ib47934856cc50d90dd71a2fea7e5a31fb9b02eb5
Reviewed-on: https://chromium-review.googlesource.com/940197Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540330}

Bug=None

Change-Id: Ic321c7b366891fba569b2a96d50f9293ee507a25
Reviewed-on: https://chromium-review.googlesource.com/941590
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540329}

This CL adds the initial count for download files.

The metric is recorded when Android code loaded the history database
records.

Bug: 817220
Change-Id: I571ecbca2aacc3a2be863cdf36310b32569fabe1
Reviewed-on: https://chromium-review.googlesource.com/941519
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540328}

Bug: 705114
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I3f092caca160715854324acf58590c18e65a7281
Reviewed-on: https://chromium-review.googlesource.com/922940
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540327}

The icon represents download state (not started, in progress, success,
error).

UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2b7a689b42_0_0

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3ab857e8f1ab6b615102aa704c3b848072f88ff7
Reviewed-on: https://chromium-review.googlesource.com/944504
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540326}

Also restores missing metric on pre-ui-refresh NTP, and adds action items to
first user action recorder.

Bug: 805635
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I75581d1e7fbee2b80fc7cbbea3ac82f4e5dbb64f
Reviewed-on: https://chromium-review.googlesource.com/941361
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540325}

This extracts the logic for categorizing network errors as retry-able proxy errors to proxy_fallback.cc.

It is a bit awkward to have a single function in this file, however it serves as a good place to document general proxy fallback behaviors, and the more logic from proxy fallback could be moved here in the future.

Bug: 817052
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic6356c4de3012c41a4bc91feb1e71b5586330fa0
Reviewed-on: https://chromium-review.googlesource.com/940626Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540324}

Bug: 729800
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I57c1ec0fbb6ec96164376d63c3cb5cfc30b5a610
Reviewed-on: https://chromium-review.googlesource.com/943402Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540323}

This CL adds a nullptr check for NavigationController in
LoginHandler::Observe().

Bug: 817968
Change-Id: I08d9de516f7d3e788e644c38173ecb969ef8cb58
Reviewed-on: https://chromium-review.googlesource.com/944255Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540322}

This reverts commit d13a7e92.

Reason for revert: Invalid config

Original change's description:
> Add Windows Release CI builders to milo
> 
> Adds the compile builder, and the tester.
> 
> Bug: 790710, 790644
> Change-Id: I83de37258aadc8d8e79cde3c32baca9d7d994c98
> Reviewed-on: https://chromium-review.googlesource.com/940431
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540314}

TBR=hinoka@chromium.org,nodir@chromium.org,tandrii@chromium.org,martiniss@chromium.org

Change-Id: Ic6c39527288cc97f06fad1846cb5f6596b213563
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 790710, 790644
Reviewed-on: https://chromium-review.googlesource.com/944607Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540321}

Results of diagnose_bloat:
StaticInitializersCount
        -2 count count
MonochromePublic.apk_Breakdown (-19,164 bytes)
       -84 bytes Native resources (no l10n) size
    -2,301 bytes Zip Overhead
       +87 bytes Non-compiled Android resources size
   -12,400 bytes Native code size
        -4 bytes Package metadata size
    -5,806 bytes Java code size
    +1,344 bytes Compiled Android resources size
MonochromePublic.apk_Specifics
   -34,572 bytes normalized apk size
   -12,400 bytes main lib size
   -15,408 bytes main dex size

Bug: 785118, 764446
Change-Id: I645134b61ef818a547a4eae239c067758d06fcf4
Reviewed-on: https://chromium-review.googlesource.com/943942
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540320}

Bug: None
Change-Id: I12ed377d2cbab940a9f45a5d71777144166f69d8
Reviewed-on: https://chromium-review.googlesource.com/943931Reviewed-by: Meggin Kearney <mkearney@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540319}

Roll in the most recent version of:
testharness.js, testdriver.js, idlharness.js and webidl2.js

Some baselines are adjusted accordingly (mostly due to
https://github.com/w3c/web-platform-tests/pull/9051).

Bug: 685854
Change-Id: Ic74431ad0bbbc13e0c9ab2fa8bb4701f69806d32
Reviewed-on: https://chromium-review.googlesource.com/941915Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540318}

histogram. Also rename the enums to be readable, as per the histogram
team's advice.

BUG=815241

Change-Id: Ic4a15efed46f367b2500ef5e553645323355020a
Reviewed-on: https://chromium-review.googlesource.com/944262
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540317}

All these tests pass locally and on the bots so removing.

Bug: 789184
Change-Id: I5b04ccdee8c39837d0f31ead05f206b00069e59c
Reviewed-on: https://chromium-review.googlesource.com/944010Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540316}

In HandleScheduleOverlayPlaneCHROMIUM assign values to local variables
from the correct command parameters.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idcba758ac7088af9ba141f8e9eec05023237a4d7
Reviewed-on: https://chromium-review.googlesource.com/928561Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540315}

Adds the compile builder, and the tester.

Bug: 790710, 790644
Change-Id: I83de37258aadc8d8e79cde3c32baca9d7d994c98
Reviewed-on: https://chromium-review.googlesource.com/940431Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540314}

Bug: 817656
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5faf83e3b1eae38ed977716a1329bfddb3fb271c
Reviewed-on: https://chromium-review.googlesource.com/943925
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540313}

Now that base::MakeUnique is no more, we don't need this anymore.

Bug: 755727
Test: git cl upload
Change-Id: Ia90edbd28bbaca79afa5aa554677855e3b98cdfd
Reviewed-on: https://chromium-review.googlesource.com/944511Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540312}

Bug: 749879
Change-Id: Iff4a6e047b029bb12fa225bbf2cdeffc9172a1b7
Reviewed-on: https://chromium-review.googlesource.com/941966Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540311}

Bug: 812428
Change-Id: I8561fce9eb8a2da3cf45530ccf1494d6182f48d5
Reviewed-on: https://chromium-review.googlesource.com/942226
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540310}

https://github.com/w3c/web-platform-tests/tree/master/accname

All the tests in this directory are manual. And worse, they can run to
complete but produce flaky outputs (and hence block the importer).

Skip them as we don't need these at the moment.

No-Try: True
Change-Id: I7719de411dadffe5077b405f1d0b3905105d6639
Reviewed-on: https://chromium-review.googlesource.com/944506Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540309}

This cl contains the following changes:
- Add video detector observers to mojo VideoDetector in order to be notified
about the video start/end activities.
- Fix a bug to reset suspend reason upon SuspendDone.

Bug: 784232
Change-Id: If626b6971413c3bc78687e3391e671766aa0fbde
Reviewed-on: https://chromium-review.googlesource.com/942649Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540308}

The "glGetQueryObject(GL_QUERY_RESULT_AVAILABLE) blocks unexpectedly on
Adreno" issue is fixed in Android 8.1, un-blacklist it on that version.

According to Qualcomm, the issue affected Adreno 4xx and newer, and
penghuang@ also saw it on Adreno 3xx on Android K (4.x). The extension
is separately blacklisted by entry id=112 for Adreno 3xx, but only on
Android 5.0 and up, so it seems cleanest to apply the blacklist to
all of Adreno 3xx/4xx/5xx for the blocking issue.

For consistency, also disable GL_EXT_disjoint_timer_query_webgl2 for the
pre-existing Adreno blacklist entries. If the underlying calls are
broken, this is expected to affect both variants.

BUG=477514,750306,764526

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iace887cb6e168d691329ff5aaf29634e509ab5c0
Reviewed-on: https://chromium-review.googlesource.com/941549Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540307}

Gtest will use operator<< which is available for all build
targets for most classes that had PrintTo(). The extra binary code
for operator<< is small, and will be removed from binaries if not
used.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I588f303293fb2c4d0f3e72093fed27c3d3aea75b
Reviewed-on: https://chromium-review.googlesource.com/941964
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540306}

Reference to a WeakPtr was to a WeakPtr that was deleted in
certain cases. Fixed by just making a copy.

Bug: 817866
Change-Id: I9fae68d018c4178a8224b3e79ab44c8a1282be87
Reviewed-on: https://chromium-review.googlesource.com/943983Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540305}

The previous API, OnReceivedSyncFavicon(), received a parameter
|icon_bytes| that was actually only used in tests. This prevented the
visit time from being updated (in-memory).

While fixing this, we move some code (the loop that iterates all
navigations of a sync_pb::SessionTab) to favicon_cache.cc, to make
SessionsSyncManager smaller and couple FaviconCache's API more with
how it is actually used (single caller).

Bug: 817348
Change-Id: I8fb7457177e298759f40e0bcf8d576ffc9fb7f9a
Reviewed-on: https://chromium-review.googlesource.com/940136Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Nicolas Zea (slow) <zea@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540304}

Test video:
https://drive.google.com/file/d/1x3lFo4c7QE912uDUTGzal3Fd8s6UDL-H/view?usp=sharing

Will persist payment app's icon in the following up CL.

Bug: 782270
Change-Id: Ib1ebebcac224033b4272c4e5cfaf3c3997b730f0
Reviewed-on: https://chromium-review.googlesource.com/941988Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540303}

This is a helper class that will be useful during Chromium's migration
to the "network" service (see crbug.com/773295). Given a
net::URLRequestContextGetter, this class creates a NetworkContext for
the NetworkService instance hosted in content, and uses it to create
URLLoaderFactories that can be created on any thread.

Currently, to ease the transition, this class is designed to be
instantiated anywhere a net::URCG might otherwise be used, wrapping the
net::URCG instance. Currently, it lives in chromecast/browser/ because
of the content dependencies in its implementation.

When the "network" service is ready, this class can be removed.

BUG=773295
BUG= b/73881919

Change-Id: I30601b837e3c960cab49b4e4024f9c69cceca05e
Reviewed-on: https://chromium-review.googlesource.com/943594
Commit-Queue: Stephen Lanham <slan@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540302}

Simple moving the files, no logic change

Bug: 803135
Change-Id: I5d9d551eac5f4298c951d6090df6c0a72b9c30e8
Reviewed-on: https://chromium-review.googlesource.com/941725Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540301}

This cl adds two user actions to Keyboard Shortcut Viewer (KSV):
1. The times user creates a new window of Keyboard Shortcut Viewer.
2. The times user enters search mode in Keyboard Shortcut Viewer.

Bug: 768932
Test: can see the counts in chrome://user-actions.
Change-Id: Id04f20c755def88f6f360d3c66ac1417180d5a94
Reviewed-on: https://chromium-review.googlesource.com/938381Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540300}

Change-Id: Ia189dd201e5cd504e8190d88da20a8aab541a450
Reviewed-on: https://chromium-review.googlesource.com/944184Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540299}

While migrating I'm introducing a temporary target. Eventually this
temporary target will become the real one.

BUG=714018
TEST=none

Change-Id: Iaf1ed6577e595c031f491099ad249ce8595d7169
Reviewed-on: https://chromium-review.googlesource.com/942661Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540298}

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I934fc0408ad71ac27cd1eb52bef62a4fa3036150
Reviewed-on: https://chromium-review.googlesource.com/943982
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540297}

This is a reland of 5e06564a

Original change's description:
> Add the LaunchUninstallFlow() function
>
> This function uses automation to automatically write the name of a
> program into the search box of the Apps & Features page.
>
> Bug: 717696
> Change-Id: Ifc6a1be295a3d06ac33f394dcf3fc4688bd4a907
> Reviewed-on: https://chromium-review.googlesource.com/907590
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540209}

TBR: grt@chromium.org, dpapad@chromium.org
Bug: 717696
Change-Id: I9048a36c52113311496abe5d2d5d1ac3fe3c79fc
Reviewed-on: https://chromium-review.googlesource.com/944202Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540296}

Desktop swaps content and description because it displays the field
side-by-side.  With VR showing them above and below, we should never
have been doing this swap.

BUG=
R=tiborg

Change-Id: I19087eb29d4a2e0e2f4fa38d059b809dabb04922
Reviewed-on: https://chromium-review.googlesource.com/944186Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540295}

Expands the management of plugins to consider origin when assigning
a process. Only passes empty origins at present, so no observable
change expected.

Bug: 809614
Change-Id: I129495ddc94c86dc1c4aa1b3a7942354eabe59d4
Reviewed-on: https://chromium-review.googlesource.com/915182
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540294}

Steps:
1. Tried on mac10.13_blink_rel.
2. Filtered out text failures.
3. Rebaselined these tests on Mac ports only.

Bug: 774301
Change-Id: I00135964604158bf0925dd19f25820f450e005ad
Reviewed-on: https://chromium-review.googlesource.com/941914
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540293}

At the most basic level, the invariant we want to maintain for surface
synchronization is:

Change in device scale factor or Change Compositor Viewport Size =>
Change in LocalSurfaceId

Browser side we always start with a valid initial local surface ID even
before we have a valid physical backing size. We shouldn't send a valid
LocalSurfaceId to the renderer if we don't have a physical backing size.

Bug: 814690
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Idc7f391d511615309732f792ff620a9fb7073d07
Reviewed-on: https://chromium-review.googlesource.com/941736Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540292}