- 26 Feb, 2019 40 commits
-
-
mrefaat authored
This reverts commit 8605ee1f. Reason for revert: Broke chromium build, details in crbug.com/936211 Original change's description: > Enable -Wextra-semi in iOS builds. > > Bug: 926235 > Change-Id: I1c9f46a30392258e553a51d1033fde4d41e04210 > Reviewed-on: https://chromium-review.googlesource.com/c/1489180 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635612} TBR=thakis@chromium.org,sdefresne@chromium.org Change-Id: I7bd6ed7e9758c6b5b82d2408e4f79fc9d9993bac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 926235 Reviewed-on: https://chromium-review.googlesource.com/c/1490443 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#635762}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c08497af77b7..a502bde5ced6 git log c08497af77b7..a502bde5ced6 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 rsavitski@google.com heapprofd client: shared sampler & client lifetime tracking Created with: gclient setdep -r src/third_party/perfetto@a502bde5ced6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:120468745 TBR=perfetto-bugs@google.com Change-Id: I0ec0581e1c05c7eaaa40661a741f2629711f5f47 Reviewed-on: https://chromium-review.googlesource.com/c/1490094Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635761}
-
Nick Diego Yamane authored
Currently, XkbKeyboardLayoutEngine::DifficultKeyboardCode performs unnecessary re-computation of XKB masks for Shift and AltGr modifiers when trying to decode key codes. This change proposes an optimization consisting on pre-computing and caching those masks only once, when the keymap is set, then saving some cpu cycles when decoding difficult keysyms/chars. R=spang@chromium.org Bug: 896640 Change-Id: Ifad7511f94312777d057930caf37b5c96ffbbad8 Reviewed-on: https://chromium-review.googlesource.com/c/1489951Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#635760}
-
Tim Song authored
A recent refactor changed the default ink drop logic, which caused a regression in ToggleButton: https://chromium-review.googlesource.com/c/chromium/src/+/1367186 All InkDropViewHosts now get a InkDropMask (default is a rounded rect). This change breaks the ToggleView as it effectively gets clipped to the view bounds. BUG=921485 Change-Id: I2fb1d5f1bb4981945fc93160fc75de9e533e1794 Reviewed-on: https://chromium-review.googlesource.com/c/1487079 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#635759}
-
Koji Ishii authored
This patch changes `text-overflow: ellipsis` to create the truncated ShapeResultView from ShapeResultView without creating intermediate ShapeResult, using the mechanism added in r633612 (CL:1477141). This saves memory by not creating actual sub RunInfo. This change also fixes an issue in offset computation in ShapeResultView::ForEachGraphemeClusters. This is discovered by this change because before this change, RunInfoPart always points to the full range of RunInfo. Some utility functions to compute character index are added. I hope they can be better structured to abstract differences between ShapeResult and ShapeResultView, but doing so is deferred to future patches as I understand it better. Bug: 636993 Change-Id: Ib2e501829051ca44f7aaccac4856ffce5618ba23 Reviewed-on: https://chromium-review.googlesource.com/c/1478319 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#635758}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fe3d4978886b..54c4772e855c git log fe3d4978886b..54c4772e855c --date=short --no-merges --format='%ad %ae %s' 2019-02-26 chrisforbes@google.com Fix point rendering 2019-02-26 chrisforbes@google.com OpAccessChain: Remove pointer walking inside loop 2019-02-26 sugoi@google.com Replace uses of sw::Surface with vk::ImageView in the Renderer Created with: gclient setdep -r src/third_party/swiftshader@54c4772e855c The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124177079,chromium:b/124388146 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I167e11a1440bde632f5ec4bfc52d7ee2ff8e8ed8 Reviewed-on: https://chromium-review.googlesource.com/c/1490092Reviewed-by:
-
Liquan(Max) Gu authored
Currently FCP++ is hooking to pre-paint tree walk for the image nodes, Instead, it should hook to the paint stage. Text nodes have finished this change in https://chromium-review.googlesource.com/c/chromium/src/+/1470732. Now we should do the same for the image nodes. Specifically, the painters that the ImagePaintDetector hooks to include: * BoxPainter * SVGImagePainter * ImagePainter Bug: 924301 Change-Id: Id1c05bc38b7967908b78b26b74d1e8f2e8376aac Reviewed-on: https://chromium-review.googlesource.com/c/1477348 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635756}
-
Yusuf Ozuysal authored
1) Add back button support :) - Adds a OverviewModeController that also gives the owner the APIs to show and hide the Overview. - Adds an internal implementation in ChromeTabbedActivity that will hold on to an overridable Controller and use that for all signaling. Every component gets the Container class and never changes it. - Extend the API for RecyclerView to support not animating hide and show - Have GridMediator implement controller and the Coordinator hand that off with a public API when needed. - Have the TabbedActivity explicitly own the Grid component and override the Controller. - Replace all calls related with Controller using LayoutManager with related Controller calls. 2) Makes sure the grid always shows the current tab when shown. 3) Disables swiping from toolbar to show the StackLayout and ToolbarSwipeLayout. (I will try to see if there is a path to enabling ToolbarSwipeLayout without adding a ton, but for now this is the most "elegant solution") BUG=934564 Change-Id: Ic778d2e2c158ba5e089f22d829f321f42e0e7684 Reviewed-on: https://chromium-review.googlesource.com/c/1484734 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635755}
-
John Chen authored
ChromeDriver uses object caches for use while calling JavaScript functions. The data structure was designed to allow a separate cache for each shadow DOM, but that feature was never used, and objects in shadow DOMs have always been stored in the main page cache. This CL removes unused code, and resolves differences between test expectancies and actual code behavior. It prepares for future changes to make the object cache standard compliant. Bug: chromedriver:1461 Change-Id: I10fcd94a7fd2359cc43fe6bc7241d36647e9d744 Reviewed-on: https://chromium-review.googlesource.com/c/1485011 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#635754}
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Patch is updating BitrateAdjuster to @IntDef with form common with other Chrome @IntDef: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface BUG=919666 Change-Id: Id80ae65a9a57c4d4a47ce8b14db120d493eb4ace Reviewed-on: https://chromium-review.googlesource.com/c/1488092Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#635753}
-
Xiaocheng Hu authored
This reverts commit ae50f0f0. Reason for revert: Suspect of causing failure of PageLoadMetricsBrowserTest.InputEventsForClick https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%207%20Tests%20x64%20%281%29/49373 Original change's description: > Unify input delay computations for UMA, UKM, and EventTiming > > This CL moves the input delay computations for UKM to further down the > pipeline to where they are computed for EventTiming. After this CL, the > same types of events are logged by both UMA/UKM and EventTiming. The > WebViewTest is fixed so that the artificial events move further enough > down the pipeline. The tests checking for pointerCancels are no longer > applicable since these only applied to the UMA/UKM computations, per > issue 924278. > > By unifying input delay computation, this CL also fixes frame > attribution for the UMA/UKM input delays: PageWidgetDelegate does not > know the target frame (before, it would tell the root that an event has > occurred even if it occurred in an iframe. > > Bug: 897656, 925130 > Change-Id: I27dba1cbb82ad780d21166a5469001e266612a78 > Reviewed-on: https://chromium-review.googlesource.com/c/1476070 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635687} TBR=tdresser@chromium.org,dtapuska@chromium.org,holte@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,npm@chromium.org Change-Id: Ibeaa1eb0cd197fee80383a9c7ce5beb63964a713 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897656, 925130, 936200 Reviewed-on: https://chromium-review.googlesource.com/c/1490401Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635752}
-
Aga Wronska authored
Error state is shown after unsuccessful access code validation and cleared when user changes input (deletes or updates input field content). Backspace behavior was updated accordingly. Pressing backspace when input field has text deletes the text but does not move focus to the previous field. Pressing backspace on empty input field moves focus to the previous field. Bug: 911326 Test: ParentAccessViewTest Change-Id: I2860c0d02dee6f7aba95fcdaaa3271b98a25c07c Reviewed-on: https://chromium-review.googlesource.com/c/1477878 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#635751}
-
Zhenyao Mo authored
Note that the CL that's merged back to M73 already had the correct bug ID. BUG=932879 TEST=bots TBR=sunnyps@chromium.org NOTRY=true Change-Id: I7f647b56eda402ee2e383f35f867e0ba16664c90 Reviewed-on: https://chromium-review.googlesource.com/c/1490398 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635750}
-
Kurt Horimoto authored
Bug: 932148 Change-Id: I24e6b181842913d8da3d02c10e1816636a01454d Reviewed-on: https://chromium-review.googlesource.com/c/1490194 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#635749}
-
Akihiro Ota authored
This test ensures that the correct start/end positions of rich text attributes are reported when moving through editable text by character. This test covers bold, italic, underline, strike through, font size, font family, and font color attributes. Bug: 934962 Change-Id: I96221751a18a63b19b822fa592b6901880675209 Reviewed-on: https://chromium-review.googlesource.com/c/1483672Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#635748}
-
Lei Zhang authored
Change-Id: Ia0410a18633083e99f89f71e9787afc53ba7f475 Reviewed-on: https://chromium-review.googlesource.com/c/1489518Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#635747}
-
John Budorick authored
Tbr: gbeaty@chromium.org,xiaochengh@chromium.org No-Try: true Bug: 934885 Change-Id: Id64c9055e18147297177cf2283918984147c2699 Reviewed-on: https://chromium-review.googlesource.com/c/1490516Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#635746}
-
Mark Cogan authored
This CL cleans up tab grid metric names and regularizes how they are called. All tab grid metrics are now named "TabGrid*". "Regular" is used instead of "NonIncognito" in metric names. Straightforward renames are as follows: (All of the original names for these metrics were defined in the internal actions.xml file and will be obsoleted) MobileStackViewCloseTab -> MobileTabGridCloseControlTapped MobileTabSwitcherHeaderViewSelectDistantSessionPanel -> MobileTabGridSelectRemotePanel MobileTabSwitcherOpenNonIncognitoTab -> MobileTabGridOpenRegularTab MobileTabSwitcherOpenIncognitoTab -> MobileTabGridOpenIncognitoTab MobileTabSwitcherCloseNonIncognitoTab -> MobileTabGridCloseRegularTab MobileTabSwitcherCloseIncognitoTab -> MobileTabGridCloseIncognitoTab MobileTabReturnedToCurrentTab -> MobileTabGridDone (The original names for these metrics were not defined anywhere!) MobileTabSwitcherPresented -> MobileTabGridEntered MobileTabSwitcherDismissed -> MobileTabGridExited Some metrics that were tracked separately in the old stack view and table tab switcher are here consolidated into a single metric: MobileTabSwitcherHeaderViewSelectIncognitoPanel, MobileStackViewIncognitoMode -> MobileTabGridSelectIncognitoPanel MobileTabSwitcherHeaderViewSelectNonIncognitoPanel, MobileStackViewNormalMode -> MobileTabGridSelectRegularPanel The metrics for tab creation are now separated to distinguish use of the new tab button and the keyboard shortcuts. The relevant code is also restructured for this. MobileTabSwitcherCreateNonIncognitoTab -> MobileTabGridCreateRegularTab, MobileTabGridCreateRegularTabKeyboard MobileTabSwitcherCreateIncognitoTab -> MobileTabGridCreateIncognitoTab, MobileTabGridCreateRegularTabKeyboard Bug: 856965 Change-Id: I3d78e2bb27ce2db46a4b4e7a1c32017742fcc514 Reviewed-on: https://chromium-review.googlesource.com/c/1475486 Auto-Submit: Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635745}
-
Eric Foo authored
Approved by johnchen Bug: 790300 Change-Id: I8e65aa3e5e6233d99bb89902497feab65719161f Reviewed-on: https://chromium-review.googlesource.com/c/1485019 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635744}
-
Eric Foo authored
Bug: 868213 Change-Id: Id4b43008fb3078052d75ff020f0cc10c1e475099 Reviewed-on: https://chromium-review.googlesource.com/c/1490014 Commit-Queue: Eric Foo <efoo@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#635743}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a7e0cc8291d3..4efdb5120090 git log a7e0cc8291d3..4efdb5120090 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 thestig@chromium.org Tidy CheckUnSupportAnnot(). 2019-02-26 thestig@chromium.org Move FX_ParseStringString() into an anonymous namespace. 2019-02-26 thestig@chromium.org Test bad inputs for newly added annotation APIs. 2019-02-26 thestig@chromium.org Add GetAnnotDictFromFPDFAnnotation() helper function. 2019-02-26 thestig@chromium.org Simplify checks in newly added annotation APIs. 2019-02-26 thestig@chromium.org Make PartitionAlloc more like Chromium's. 2019-02-26 thestig@chromium.org Update PartitionAlloc from Chromium at r629284. Created with: gclient setdep -r src/third_party/pdfium@4efdb5120090 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I351aa3e580088e2dc066107e5a69f8b9755329a4 Reviewed-on: https://chromium-review.googlesource.com/c/1488962Reviewed-by:
-
Caleb Raitto authored
Bug: 879208 Change-Id: Ie57908edc90261202f7bfb82a9963403358df7b8 Reviewed-on: https://chromium-review.googlesource.com/c/1423351 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635741}
-
Sergey Ulanov authored
Previously runner scripts always requried --host parameter when using a device that's already provisioned. Now this parameter is optional. When --ssh-config parameter is specified without --host then the script will try to discover an already provisioned device and connect to that device using the specified SSH config. Change-Id: I63e7bb7c5b55ebaa79ed22066ad180fa7e15cc34 Reviewed-on: https://chromium-review.googlesource.com/c/1489430Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635740}
-
Tommy Martino authored
Per discussions with ftirelo@ about ensuring sufficient OWNERS coverage among current team members, I'm requesting to be added as an OWNER of this directory. Change-Id: Idc8a68bfced50ae9e371e3b899f9958bdbd4c41c Reviewed-on: https://chromium-review.googlesource.com/c/1489898Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635739}
-
Sean Gilhuly authored
HitTestDataBuilder is checking that the start() and end() of a surface range have the same FrameSinkId before including the surface quad in hit test data. This can prevent OOP-IFs from being clicked during the first four seconds after a page navigation. Instead, remove this check. If there is no surface available for the end FrameSinkId, then an async hit test will be used to target input events. Bug: 926194 Change-Id: I574bf104cd3524973152035e59701a0105908fa9 Reviewed-on: https://chromium-review.googlesource.com/c/1465078Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#635738}
-
Sven Zheng authored
We can't access the flake log anymore, but I tested both locally and CQ dry run. The test should be stable now. Bug: 854294 TEST: 100/100 pass locally. 100/100 pass on dry run: https://chromium-review.googlesource.com/c/chromium/src/+/1487832 https://chromium-swarm.appspot.com/task?id=433f61c47f1daa10 Change-Id: Ifc4d84b82ea7531654fd1002503d2ce91db7edaa Reviewed-on: https://chromium-review.googlesource.com/c/1488053Reviewed-by:
-
Ryan Sturm authored
This CL adds reporting Data savings based on original content length header vs content length header in the HTTPS Server previews URLLoader implementation. Bug: 921757 Change-Id: I38ac67b43b3fd1bc17f27a4ec7e0a8a65229cc81 Reviewed-on: https://chromium-review.googlesource.com/c/1488062 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#635736}
-
Karolina Soltys authored
To avoid unnecessarily scheduling onPostExecute, we make this method abstract and the classes which don't need to override it will now extend a new subclass of AsyncTask called BackgroundOnlyAsyncTask, which doesn't trigger post-execution. For the calls which could easily be converted from AsyncTask directly to PostTask, we do that instead. Bug: 863341 Change-Id: I50f9ebc790fcfbc7ec2fdd6bdb6dfb6cda7f24dc Reviewed-on: https://chromium-review.googlesource.com/c/1477592 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#635735}
-
Robert Kaplow authored
It shouldn't have been removed, just marked obsolete. Bug: 0 Change-Id: I0b6bc2eec96b4360621ab07fbed8e721d1cf8b7e Reviewed-on: https://chromium-review.googlesource.com/c/1489178Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#635734}
-
Ryan Sturm authored
When the request has been on the network for 30 seconds, the HTTPS Preview URLLoader implementation should fallback to default behavior for the URL hop. Bug: 935771 Change-Id: Id76e8d116ef32d86bd7c311022723f93a6fb4c04 Reviewed-on: https://chromium-review.googlesource.com/c/1488117 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Aran Gilman authored
Bug: 927857 Change-Id: I2ede0f2ce37046f9bb8430c2d5c5cec9ce23a0f2 Reviewed-on: https://chromium-review.googlesource.com/c/1487194 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635732}
-
Luciano Pacheco authored
CL:1213585 copied these strings to //chrome/app strings, however it hasn't deleted from //ui/chromeos/ui_chormeos_strings.grd. This causes issues if both resources headers are loaded in the same file, which will happen with Files app CL:1484961 Change-Id: Id66a383a1a874c292cf10e41f08b9a25a27b8058 Reviewed-on: https://chromium-review.googlesource.com/c/1488483 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#635731}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c48681e58d6..f12d67517903 git log 0c48681e58d6..f12d67517903 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 fmalita@chromium.org [skottie] Shape blending mode support 2019-02-26 bsalomon@google.com Remove legacy types/methods from SkDeferredDisplayList recorder. 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0546b5380780..9f20dd777b50 (1 commits) 2019-02-26 egdaniel@google.com Add support for VK_IMAGE_LAYOUT_PRESENT_SRC_KHR in skia vulkan. 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2ff3639d85d7..024f271ae0c7 (1 commits) 2019-02-26 stani@google.com Pass render target VkImage in GrVkDrawableInfo 2019-02-26 herb@google.com Make ARGB fallback use common strike lookup 2019-02-26 halcanary@google.com gn/core.gni: add headers 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9a16248dedf3..2ff3639d85d7 (1 commits) Created with: gclient setdep -r src/third_party/skia@f12d67517903 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/115613038 TBR=scroggo@chromium.org Change-Id: Ifc16549603291417183cebf44e37d6a76080a9fe Reviewed-on: https://chromium-review.googlesource.com/c/1488619Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0546b5380780..46d32e0fcd84 git log 0546b5380780..46d32e0fcd84 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 jmadill@chromium.org Use Chromium mirror for rapidjson. 2019-02-26 jmadill@chromium.org Add draw call perf test using 5 vertex arrays. Created with: gclient setdep -r src/third_party/angle@46d32e0fcd84 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I381ef943a1f6f14ff127aeb91e4c42b3893612c1 Reviewed-on: https://chromium-review.googlesource.com/c/1489512Reviewed-by:
-
danakj authored
The WebLayerTreeView is a shortcut past the WebWidgetClient that is not needed now that we always composite. This works toward eliminating this extra API layer. More importantly this helps us Close/Restart the WebWidget parts of WebViewImpl by not requiring plumbing 2 pointers with slightly different lifetimes (WebLayerTreeView is created inside the Init of the WebWidgetClient). This will help avoid a bunch of complexity in creating WebFrameWidgets and other WebWidgets. R=avi@chromium.org, enne@chromium.org, jbroman@chromium.org Bug: 912193 Change-Id: I54213dd153bbda634965d5a6528a1b864c9ceae3 Reviewed-on: https://chromium-review.googlesource.com/c/1489516Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#635728}
-
Xiaocheng Hu authored
Tbr: xiaochengh@chromium.org NoTry: True Bug: 936165 Change-Id: I4a12810a4ab69a99f30f5115584e1b149f2dc390 Reviewed-on: https://chromium-review.googlesource.com/c/1490055Reviewed-by:
-
Khushal authored
R=ellyjones@chromium.org Bug: 889328 Change-Id: Ia3b457dcfe44f69e8a2f5846d9e660b555bce402 Reviewed-on: https://chromium-review.googlesource.com/c/1488573 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#635726}
-
Takumi Fujimoto authored
In CastSessionClient::HandleParsedClientMessage(), do an early exit to avoid checking invalid session IDs. Also remove a redundant early exit. Bug: 935767 Change-Id: Id293dbcfb3eb4696e49dc8cb3fedb91b63de23a5 Reviewed-on: https://chromium-review.googlesource.com/c/1487804Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#635725}
-
Sam Maier authored
This ensures that after the overridden UI thread tests run, the overridden UI thread is cleaned up so tests that follow have a normal UI thread. TBR: yfriedman Bug: 908174 Change-Id: Ia433e98534823646065e296556b4ac09a836022e Reviewed-on: https://chromium-review.googlesource.com/c/1489474 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
The functions are simple, and getting rid of the function call overhead should be a good thing. Change-Id: I419eaf5726eeacd8e69327f6649d69d717dde11e Reviewed-on: https://chromium-review.googlesource.com/c/1484782 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#635723}
-
