GitLab

Consolidate two very similar functions; ui::WindowsKeyCodeForGdkKeyCode and ui::KeyboardCodeFromXKeysym.

Add some X keysym names that are handled by the former function to the latter.

BUG=103511
TEST=ran try


Review URL: http://codereview.chromium.org/8803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113976 0039d316-1c4b-4281-b951-d872f2087c98

Made changes to enable the button only on below conditions
1) If pref is user editable. In this case event.value['disabled'] would be false.
2) If pref is user editable and it does'nt hold a default value. In this case event.value['controlledBy'] would be recommended.
3) Otherwise if controlledBy is empty or null.

BUG=106592
TEST=None.


Review URL: http://codereview.chromium.org/8883015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113975 0039d316-1c4b-4281-b951-d872f2087c98

* Remove empty Linux & Win implementations of the class.
* Rename files and unit test to be Mac only.
* Rename namespace SpellCheckerPlatform -> SpellCheckerMac
* Surround usage in crossplatform files with #ifdef OS_MACOSX as a temporary measure (a future step will be to remove the calls entirely from these files).

BUG=69944
TEST=Spelling correction feature should continue to work as expected on Mac/Win/Linux .


Review URL: http://codereview.chromium.org/8890022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107158
TEST=none
TBR=epoger

Review URL: http://codereview.chromium.org/8911002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107154
TEST=none
TBR=thestig@chromium.org

Review URL: http://codereview.chromium.org/8914004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113971 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106966
TBR=cmp
Review URL: http://codereview.chromium.org/8910002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113970 0039d316-1c4b-4281-b951-d872f2087c98

- Update Linux size expectations to recent range of my code addition.
Review URL: http://codereview.chromium.org/8913001

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/8914003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113969 0039d316-1c4b-4281-b951-d872f2087c98

fixed by r113954.

BUG=106402
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/8914002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113968 0039d316-1c4b-4281-b951-d872f2087c98

Happening in a new place after a refactoring.

BUG=102255
TEST=none
TBR=rdsmith

Review URL: http://codereview.chromium.org/8914001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113967 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8913001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113966 0039d316-1c4b-4281-b951-d872f2087c98

I added a bunch of pepper code that pushed us over the previous limit. I also added several links to the perf instructions since it took me a while to figure this out.
Review URL: http://codereview.chromium.org/8910001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113962 0039d316-1c4b-4281-b951-d872f2087c98

- Improve RenderTextWin font fallback.

Don't use SCRIPT_UNDEFINED in the case of font fallback,
unless font fallback actually fails to return a script
that can display the characters. This fixes the problem
of some scripts not being properly displayed.

This actually makes RenderTextWin properly validate whether
a text position accepts a cursor, which caused several tests
to fail and revealed some additional issues in RenderTextWin.

The CL includes some modifications to address this.

Some tests are disabled under XP, see:
http://crbug.com/106450

Also, fixes some lint warnings.

BUG=90426
TEST=Run chrome.exe --use-pure-views and paste some Bengali
text into the omnibox. It should show up properly.
Review URL: http://codereview.chromium.org/8575020

TBR=asvitkine@chromium.org

TBR=thakis@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113960 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104142
TEST=none
TBR=joi

Review URL: http://codereview.chromium.org/8900002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/8894033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/8892023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113957 0039d316-1c4b-4281-b951-d872f2087c98

- Improve RenderTextWin font fallback.

Don't use SCRIPT_UNDEFINED in the case of font fallback,
unless font fallback actually fails to return a script
that can display the characters. This fixes the problem
of some scripts not being properly displayed.

This actually makes RenderTextWin properly validate whether
a text position accepts a cursor, which caused several tests
to fail and revealed some additional issues in RenderTextWin.

The CL includes some modifications to address this.

Some tests are disabled under XP, see:
http://crbug.com/106450

Also, fixes some lint warnings.

BUG=90426
TEST=Run chrome.exe --use-pure-views and paste some Bengali
text into the omnibox. It should show up properly.
Review URL: http://codereview.chromium.org/8575020

TBR=asvitkine@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113956 0039d316-1c4b-4281-b951-d872f2087c98

window.open() in BackgroundContents was failing in M17 because we were no longer
hooking ShowCreatedWindow() and forwarding the request to our delegate.

Now that BackgroundContents wraps a real TabContents, we now hook AddNewContents()
and pass it off to our Delegate to open a new window.

BUG=105992
TEST=instructions in bug.


Review URL: http://codereview.chromium.org/8899019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113955 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a leak because the completion callbacks were not getting run on
resource destruction. This leaves the calling code waiting for the callbacks
with leaked data associated with the callback.

This patch just always runs the callbacks with PP_ERROR_ABORTED. I tweaked the
callback code to use the (newer than the original code) "run and clear"
completion callback macro which also cleans up the code a little.

BUG=106402

Review URL: http://codereview.chromium.org/8801027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113954 0039d316-1c4b-4281-b951-d872f2087c98

[ Reland of 113565 http://codereview.chromium.org/8764003 ]

This splits apart the old in-process implementation into a new object in shared_impl that does most of the general tracking. This alllows that code to be shared by the proxy.

BUG=http://crbug.com/101154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113953 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113946 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8890067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106876,106915
TEST=see bug

Review URL: http://codereview.chromium.org/8879046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113943 0039d316-1c4b-4281-b951-d872f2087c98

1) Add spdy/2.1 as a supported NPN protocol.
2) Advertise that chrome supports spdy/2.1 when --flow-control (spdy
flag) is enabled. 
3) When SPDY protocol is negotiated, enable flow_control in
spdy_session if spdy/2.1 is negotiated as NPN protocol. 

BUG=106911
R=willchan
TEST=network unit tests and if possible test with SPDY 2.1 server
with command line flag --flow-control.

This CL is same as the following CL. Implemented changes suggested
by willchan in the following review.
http://codereview.chromium.org/8890044/
Review URL: http://codereview.chromium.org/8892026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113942 0039d316-1c4b-4281-b951-d872f2087c98

This is a partial speculative fix to stabilize the run times of the delete
portion of the perf test.

BUG=107034,107040
TEST=


Review URL: http://codereview.chromium.org/8892028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113941 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8772071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113940 0039d316-1c4b-4281-b951-d872f2087c98

GTK: Add TRACE_EVENTs around gtk ui events so select tasks related to the GTK user interface show up on the chrome://tracing hierarchical profiler.

These were useful for tracking down tab changing speed problems.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8800029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113939 0039d316-1c4b-4281-b951-d872f2087c98

Clean up some call sites to take advantage of relaxed
semantics.

Also add comment clarifying usage of EnumSet::Iterator.

BUG=
TEST=


Review URL: http://codereview.chromium.org/8895008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Panel*Test.*


Review URL: http://codereview.chromium.org/8892020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113937 0039d316-1c4b-4281-b951-d872f2087c98

Fixes crash on JS dialog popups from the extension bubbles.

Check for child HWND in WidgetFocusChangeListener::OnNativeFocusChange.
Code from BubbleWidget in browser_bubble_win.cc (crrev.com/112278)

See Issue 106958 for Aura, the dialog&bubble close early without crashing.

BUG=106723,106958
TEST=The js alert extension attached to the issue doesn't crash, popup works on non-aura.

Review URL: http://codereview.chromium.org/8879045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113936 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107070
TBR=cmp@chromium.org

Review URL: http://codereview.chromium.org/8897023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113935 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107070
TBR=cmp@chromium.org

Review URL: http://codereview.chromium.org/8895021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113934 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8872038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113930 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113929 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23770
TEST=None


Review URL: http://codereview.chromium.org/8890017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113928 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bashi


Review URL: http://codereview.chromium.org/8893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113927 0039d316-1c4b-4281-b951-d872f2087c98

In crrev.com/113111 I checked in code that reads a app state boolean from an 
ExtensionSyncData object which is uninitialized. This fixes the initialization
for the relevant constructor, and also limits reading that value to only when
the extension is an app.

BUG=106549
TEST=valgrind run of ExtensionService sync-related unit_tests should come back
clean

Review URL: http://codereview.chromium.org/8899010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113926 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/8887001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106013,106228
TEST=Verify zoom-in/zoom-out work correctly on PDF documents.
Review URL: http://codereview.chromium.org/8896009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113923 0039d316-1c4b-4281-b951-d872f2087c98

Add Pass(), which implements move semantics, to scoped_ptr, scoped_array, and scoped_ptr_malloc.

This modification to the scopers implements the "moveable but not copyable" semantics that were introduced in C++11's unique_ptr<>.

With this, is now possible to use scopers as an argument type or a return type.  This signifies, in the type system, transfer of ownership into a function or out of a function respectively.  Calling, or returning such a function MUST use the temporary resultin

This distinction makes it possible to avoid the implicit ownership transfer issues of auto_ptr, but still allow us to have compiler enforced ownership transfer.

Also adds a Passed() helper that allows using a scoper with Bind().

BUG=96118
TEST=new unittests

Original review URL: http://codereview.chromium.org/8774032

Review URL: http://codereview.chromium.org/8897005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113922 0039d316-1c4b-4281-b951-d872f2087c98

Split --aura-windows into --aura-workspace-manager and --aura-translucent-frames.
Also fixed a bug where the window frame was still opaque despite the latter flag.

BUG=106890
TEST=manual, run with all combinations of above flags


Review URL: http://codereview.chromium.org/8890036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113921 0039d316-1c4b-4281-b951-d872f2087c98