- 09 Sep, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 91d331cf. With Chromium commits locally applied on WPT: 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" 9d7721df "Strip the fragment directive and update scroll-to-text WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iecdc3dbdbdcd9548ec6fad9152b6049f6da528fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792843Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694768}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/97a7d404..26505d54 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0d16f742cd9dae6d9c4a1d5f1979bb06b40db881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792842Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694767}
-
Friedrich Horschig authored
By increasing the vertical threshold, we ensure that the user has 80dp left even if the keyboard accessory is showing. Since we considered the accessory height in addition to that threshold in our sheet height calculations, the latter needed an update. FYI: I intend to merge this CL into M78. Bug: 1002002 Change-Id: I447667e69a493ca9da238a8a38ada012733dabf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790883Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#694766}
-
Andrew Grieve authored
This reverts commit 3455d426. Reason for reland: restored proper dependent CL TBR=boliu@chromium.org,agrieve@chromium.org,iclelland@chromium.org Bug: 1000510 Change-Id: I5df68e7d90894a558b35bde90be9b8248eb8c7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788019 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694765}
-
Sylvain Defresne authored
The PrimaryAccountManager used to store just the CoreAccountId of the authenticated account and to fetch the extended information from the AccountTrackerService. This could result in missing information if the account is removed from the AccountTrackerService while the authenticated account is not yet cleared. This should not have been a problem as it should not happen in production however some regression where found during the introduction of IdentityManager. To fix those inconsistencies, IdentityManager was changed to cache the information about the primary account. This however meant that two objects are now storing the same information. Also the value passed to GoogleSignedOut() method could still be inconsistent. This CL removes the cache from IdentityManager and instead move it to PrimaryAccountManager. This was not possible at the time due to complex inheritance in PrimaryAccountManager (formerly SigninManager). After this change, the information is stored in PrimaryAccountManager and updated by IdentityManager when information is updated in the AccountTrackerService (AccountTrackerService does not use Observer but instead a callback which can only have one target, this target is IdentityManager::OnAccountUpdated). The CL also remove PrimaryAccountManager::SetAuthenticatedInfo() as it is equivalent to calling AccountTrackerService::SeedAccountInfo() followed by PrimaryAccountManager::SignIn(). Bug: 862619 Change-Id: I5f0d7a13f6886c2d1f5db5b83d967f60380d206f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782173 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#694764}
-
Aaron Tagliaboschi authored
Fix issue where asynchronous validation requests (specifically, revalidation on stale-while-revalidate requests) result in a duplicate value for client hint headers (i.e. `Sec-CH-UA: Chromium 76, Chromium 76` instead of `Sec-CH-UA: Chromium 76`) Bug: 959611 Change-Id: Iac16b84b129108b9ebe1258e11722cdc9eaa52de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645455 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#694763}
-
Rakib M. Hasan authored
The tags generated for the Android OS version name have changed in telemetry. We also need to update the tags in gpu tests. Bug: chromium:999335 Change-Id: I44f7af062a80c5cf5035d908893c712b07c4b837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790477 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694762}
-
Jérôme Lebel authored
Unified consent feature flag is always on, so the pre-unity UI can be removed. Pre-unity UI removed in: - bookmarks - content suggestions - first run - sign-in promo - recent tabs Bug: 951313 Change-Id: I1ffd95c420bab229f930ea6b14e7e6ca6ecca637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787545Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#694761}
-
Andrew Grieve authored
It was meant to denote removed symbols, but doesn't really work. We'll track re-adding the feature in crbug/978307 Bug: 978307 Change-Id: Ide015ea4ca24ed57ca4f1f5d95363b21deb96bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790791 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#694760}
-
Mugdha Lakhani authored
Add some instrumentation tests for Background Sync. We currently don't have any that run on Android, and this CL bridges that gap. A previous attempt was made at this here: https://chromium-review.googlesource.com/c/chromium/src/+/1534160 but it worked by fluke, since our test devices happened to have network connectivity. That can't be guaranteed so this CL mocks out network connection type. It also mocks out BackgroundTaskScheduler because the last attempt was failing to get the BackgroundTaskScheduler delegate for Android L and below. This was because Google Play services isn't up to date on our test devices. Bug: 996664 Change-Id: I904664a87e31439a65c0f9a04a1c9c4b21d03bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768321 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#694759}
-
Rune Lillesveen authored
TBR=kojii@chromium.org Bug: 953479 Change-Id: I6738e1fb082f3dbf0275c3913b6f987e6f2be7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790107Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694758}
-
Rune Lillesveen authored
TBR=schenney@chromium.org Bug: 1002049 Change-Id: I6488f6376a3fa41c1cc9358b6c83f04d8313d4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792864Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#694757}
-
redatawfik authored
1- Move two methods "ExtractCreditCardNumber" and "SubstituteSimilarCharactersInRecognizedText" from mediator to Util file. 2- Write a unit test for the two methods. Change-Id: Ie6e191cf06e4ae23d9993ded738dc374ec1c8790 Bug: 984545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782802Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#694756}
-
Sami Kyostila authored
This is a reland of 0bf621ef Original change's description: > base: Remove temporary "WithTraits" task API wrappers > > Now that everyone has been migrated to the renamed > PostTask/CreateTaskRunner APIs, we can remove these temporary wrappers. > > TBR=gab@chromium.org > (to apply side-effects of mechanical change in //base) > > Bug: 968047 > Change-Id: I69c53abd899f37586f23ec295ffcc9bf12042c4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752787 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693695} TBR=gab@chromium.org (reland without changes) Bug: 968047 Change-Id: I1969ecad2af1527b14e4c8160e16156cde31cf45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790105 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#694755}
-
Henrique Ferreiro authored
Convert the implementation and all users of the blink::mojom::FileSystemCancellableOperation, FileSystemOperationListener, ReceiverSnapshotListener and FileSystemManager interfaces. Bug: 955171, 978694 Change-Id: I69305173de67148fc2708e5a31e106e525d340de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773146Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#694754}
-
Sergey Ulanov authored
DisplayResourceProvider wasn't calling ResourceFence->Set(). Because of this the fence wasn't signaled in SkiaRenderer::FinishDrawingQuadList() when it is necessary. As result GpuMemoryBufferVideoFramePool kept re-allocating new GPU memory buffers instead of reusing them. As result the system would run out of memory very quickly when playing video. Bug: 1001296 Change-Id: I390bfb63455b7e4b2bfa61717450d3f30bc05303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790275 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#694753}
-
Sebastien Marchand authored
The Memory Instrumentation service isn't available in unit_tests, this add a check to verify that the service exists before trying to calling it. Change-Id: I6f4ceb28fe828b8229888bbff5d58a445051cd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783304Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694752}
-
Fredrik Söderquist authored
This reorders the construction sequence so that the created subtrees or nodes are inserted after they've had their attributes (and other things) set. In the context of the bug referenced the interesting bit is setting the is-fallback-image flag on the HTMLImageElement before inserting it. Bug: 1000273 Change-Id: Ica4d7d50709c9338b4df6e3c4a4ce1f22d5c3924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789811 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#694751}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/omnibox. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. Edit: Revert changes to HQPPerfTestOnePopularURL which needs base::ThreadPool now. R=jdonnelly@chromium.org Bug: 891670 Change-Id: I625d146aca749921b09a9af2ec8ed68d355bcf10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786756 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694750}
-
Rohit Rao authored
This new functionality is hidden behind both a GN arg (enable_run_ios_unittests_with_xctest) and a commandline switch (--enable-run-unittests-with-xctest), in order to default it to off until the bots are updated to properly run XCTest-based unittests. The iOS test runner is updated to run in one of two modes. When --enable-run-unittests-with-xctest is false (the default), behavior is unchanged; TestSuite::Run() calls UIApplicationMain(), then the UIApplicationDelegate calls TestSuite::Run() again, which actually runs the tests when invoked the second time. When the switch is set to true, the second invocation of TestSuite::Run() is made by our XCTestCase subclass rather than by the application delegate. Xcode provides the ability to run XCTests and XCUITests from the commandline, but does not provide any other way to install and run an app outside of this test-based workflow. (We had an alternative that used third party libraries, but they no longer work on iOS 13.) This makes it difficult to install and run GoogleTest-based tests on iOS devices, since they run as a single self-contained application, but it would not be practical to drop GoogleTest support on iOS. Instead, we are exploring invoking these tests via XCTest, which would allow us to use Xcode's tooling but still run the same GoogleTest-based tests as on other platforms. BUG=635509 Change-Id: I26c67d9c7e16a744f43a20f2d8c5839ca8b3c31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787593Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#694749}
-
Jan Wilken Dörrie authored
This change changes the const overload of Value::GetList() to return a span<const Value> rather than a const std::vector<Value>&. This serves two purposes: 1) It improves encapsulation, as returning a span allows for other list storages than std::vector. 2) It improves memory safety, since span<T>::operator[] CHECKs whether the passed in index is within bounds. std::vector<T>::operator[] does not do this. A similar change will be applied to the mutable overload of Value::GetList() in a follow-up CL. TBR=blundell,stevenjb,reillyg,rohitrao,rsleevi Bug: 646113, 990059 Change-Id: I0ee0d27b3b99f80b83c97acc2ca9efd4f5c81b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786638 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#694748}
-
Adithya Srinivasan authored
This reverts commit b2b10c51. Reason for revert: Causing test failures on Webkit Linux Leak. Bug: 1002059 Original change's description: > Make ScriptValue Traceable > > We made ScriptValue Traceable to replace SharedPersistent > with TraceWrapperV8Reference in a follow-up CL. > > In this CL, most of the changes are just: > - Replace Vector<ScriptValue> with HeapVector<ScriptValue> because > ScriptValue has a Trace method. > - Add a trace method for ScriptValue because ScriptValue is traceable. > - Add a trace method for ScriptPromise because it has a ScriptValue. > > We recommend you to mainly check > - script_value.h where I add VectorTraits. > - script_promise.h where I add VectorTraits. > - v8_callback_function.py where I add a code to generate HeapVector. > - v8_types.py > * Add ScriptValue and ScriptPromise to "is_traceable==True" > which is used to generate Trace method for ScriptValue and ScriptPromise. > * Add ScriptValue and ScriptPromise to "is_gc_type==True" > which is used to generate HeapVector instead of Vector. > > Bug: 998994 > Change-Id: I595a87636464e9fbf30533373995b61c89e464b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787483 > Commit-Queue: Rika Fujimaki <rikaf@google.com> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694681} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,keishi@chromium.org,kouhei@chromium.org,rikaf@google.com Change-Id: I52e6298abaf785bba63ffcdd49c77308c603b0dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792866Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#694747}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f2674da4bbc..78fb80a2b328 git log 4f2674da4bbc..78fb80a2b328 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 reed@google.com share private iterator/helpers for building paths Created with: gclient setdep -r src/third_party/skia@78fb80a2b328 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I74fb7e29a97fa9806a8ee8d27930025cf98c985a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694746}
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce, and removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 714018 Change-Id: Id5caaee0bd00721b4463880d6ba3c8121d533468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778548 Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694745}
-
Maxim Kolosovskiy authored
CVC are detected with two types of heuristics: 1) CVC field is the field that contains the value used to unmask a server card. 2) CVC field is the field that contains a CVC-like value (3 or 4 digits) and it is not an expiratino year field. Learn more in |HeuristicallyFindCVCField|. In order to distinguish (1) and (2), this CL set |properties_mask| to |KNOWN_VALUE| if (1). TBR=koerber@chromium.org Bug: 993704 Change-Id: Ifa475320cfe82fdec730d1547d3f551c0f717ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787783Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#694744}
-
Martin Šrámek authored
The test is already completely disabled on Mac. Related tests were previously disabled in https://chromium-review.googlesource.com/c/chromium/src/+/1792037 TBR: rego@igalia.com Bug: 1001936 Change-Id: Iba8d8351123b446c7f8a76f6d4cbab6981a486d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792863Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#694743}
-
Xida Chen authored
This CL makes a paint worklet that uses a non-registered custom property to be painted on the compositor thread. Bug: 996723 Change-Id: I0d8afce0ba4008a585fcf83184a51782cc51af3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788319Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694742}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/renderer/media/webrtc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. Edit: Revert changes to tests that use a ChildProcess (requires full TaskEnvironment) R=sergeyu@chromium.org Bug: 891670 Change-Id: I2b3cffbd2341f0d331f752542534ebcfe8254271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786951 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#694741}
-
Martin Šrámek authored
TBR: ntfschr@chromium.org Bug: 1001499 Change-Id: I9bcd4dd17b46485c9ff0ac788438059fcd281a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791153 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#694740}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4d6b2691bd5d..ee3d995091da git log 4d6b2691bd5d..ee3d995091da --date=short --no-merges --format='%ad %ae %s' 2019-09-09 nisse@webrtc.org New class VideoReceiver2, a trimmed-down vcm::VideoReceiver Created with: gclient setdep -r src/third_party/webrtc@ee3d995091da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ia3e4c3eef45328c551a9781d1e1b0e8e012edf86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792726Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694739}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/content_settings. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=msramek@chromium.org Bug: 891670 Change-Id: Icbf7ec34d5cec0751a115c88cddb1e57ad7afa64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786746 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694738}
-
Robbie Gibson authored
See the attached bug for a screenshot. Bug: 1002040 Change-Id: I3143aec972fe6cd172ab1de625d51c3e02159d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790884Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#694737}
-
Marc-Antoine Ruel authored
Add apks/ChromeModernPublic.aab to the known failure. This should turn 'Deterministic Android' and 'Deterministic Android (dbg)' back green. .aab doesn't have effect at the moment, as --use-isolate-files is currently passed in by the recipe. Add a note about eventually using gn directly. Bug: 972075 Bug: 939984 Change-Id: Iccfbd7cc614fbfab441fa189a7d4eb0c086b97ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649142 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694736}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/base/ime. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=yhanada@chromium.org Bug: 891670 Change-Id: I33f045fb6999ffc600ca04255547512bd81861d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786748 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694735}
-
Julie Jeongeun Kim authored
This CL converts DataPipeGetterPtr to new Mojo types. It also updates traits which uses DataPipeGetterPtr. Bug: 955171, 978694 Change-Id: I947fc8d4ce489f50045e2353db59445792deb6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787659 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#694734}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types in P2PSocketManager::StartNetworkNotifications function. - Apply pending_remote to the first arguement of StartNetworkNotifications. Bug: 955171 Change-Id: I3d5900c322e40d36383ced855e4b60228e27925b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788419Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#694733}
-
Gauthier Ambard authored
Before this CL, the current session was saved when the page was loaded. The page is loaded when the main frame has finished loading its content. When there is a push state event, this callback isn't called. This CL changes it to store the current session when the navigation is finished, which happens when the item is committed. Bug: 998563 Change-Id: Ibc77d38cf4e130477471161d28a4d6cb6c03365f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778483Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#694732}
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce, and removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 714018 Change-Id: I6296434bcb2b82ebca81c06e84b3bd9d56fe40f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778551Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Cr-Commit-Position: refs/heads/master@{#694731}
-
Miyoung Shin authored
This CL converts BluetoothInternalsHandlerRequest in chrome to the new Mojo type. Bug: 955171 Change-Id: I5a04f8653dbc53022ff52171fc2569a373c5743e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788768 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#694730}
-
Lowell Manners authored
With this CL, every time scheduer_tracked_features changes, if the document has become uncacheable, we evict it from the BackForwardCache (if it is in the cache). Change-Id: Ic7a6693344687951c70d0e6d580f3ebb4a272fec Bug: 996267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784601Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#694729}
-