- 08 Jul, 2020 40 commits
-
-
Rainhard Findling authored
* This CL aligns the Chrome cleaner child element behavior with the latest mocks for all states except the "safe" states, which will be updated in a separate CL. Bug: 1087263 Change-Id: Ie2b05f879aa6b03ceff97d83f3376a701eedadb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276253 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#786277}
-
Victor Hugo Vianna Silva authored
This is a preparation to allow the user to choose which passwords to save in the 'save unsynced credentials' bubble. To do so, we will modify ManagePasswordsUIController::SaveUnsyncedCredentials() to take the vector of credentials as a parameter. BubbleObserver::AcceptSaveUnsyncedCredentialsPrompt() fakes the user accepting the bubble in this integration test. If it is kept in the new design, it would need to take the credentials as a parameter as well, which renders some expectations in this test completely artificial. So, after this CL, the test no longer verifies that accepting the bubble stores the credentials in the profile store. Instead it only verifies that the bubble is opened. The saving logic is still covered by unit tests in ManagePasswordsUIController. Bug: 1098672 Change-Id: I7a1d752b67934e31d968ac23475026fc0cdc4af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287315 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#786276}
-
Andrew Grieve authored
This reverts commit fb07fcff. Reason for reland: Not changing target_sdk_version for angle tests Original change's description: > Revert "Android: Bump default target_sdk_version 24 -> SDK used to compile" > > This reverts commit b7fb15b1. > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1099849 > > Original change's description: > > Android: Bump default target_sdk_version 24 -> SDK used to compile > > > > Why do this? > > * It's best practice to target the latest sdk, so this makes for a > > better default. > > * Many targets were neglecting to ever update this value TBR=boliu@chromium.org,torne@chromium.org,agrieve@chromium.org,behdadb@chromium.org Bug: 1099849 Change-Id: I95f36a2b88d2e7ad1d90222f25192c9a915550ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280981Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#786275}
-
Oleh Lamzin authored
Add bluetooth info to the probe service. Bug: b:158658869 Change-Id: Ic17d533e877dd1be3804587ca6126125dec7b869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275880 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#786274}
-
Reilly Grant authored
This change converts callbacks related to Bluetooth Classic service creation from base::Callback to base::OnceCallback. There should be no functional change. Bug: 834319 Change-Id: I99917e7e03a65013f23f4ebd607e1d7eb6a5da64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286589 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786273}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b81007941c4..cdb7febb0552 2020-07-08 fmayer@google.com Merge "Keep track of whether client disconnected because of timeout." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1329f16d4364f9dcb021cd7f992b2778e15e89e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287146Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786272}
-
Polina Bondarenko authored
IsRunningAsSystemCompositor must return false, because input should be disabled on ozone platform headless. BUG=b:160309778 TEST=manual Change-Id: I8a97b166b42a581a275c305355f0c4434e5adbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276426Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#786271}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5ba63704754faf862e2ef31a934c89463a147980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786270}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7cbda52a2db8..0c87b32429bf 2020-07-08 omerkatz@chromium.org heap: Add metric for time that cannot be moved to concurrent thread If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986235 Tbr: rmhasan@google.com Change-Id: I88dd95fac0446cb6db66811b834cf23a23ee5fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287144Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786269}
-
Oleh Lamzin authored
Add stateful partition info to the probe service. Bug: b:158658869 Change-Id: Ie90406b06a790424c1f2771d6f718a16914a6591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275442 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#786268}
-
Sylvain Defresne authored
If a variable was initialised to an empty string, it would be generated as `variable = ` instead of `variable = ""` when the args.gn file was generated, breaking `gn gen`. Convert the string to the correct format. Bug: none Change-Id: I6268623c3e6cd2c27bfdfc167a4a77779e01962f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282566 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786267}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/473c9f4cd9b2..5a33f21a483b 2020-07-08 robertphillips@google.com Remove a Chrome staging flag If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1097484 Tbr: mtklein@google.com Change-Id: I7807b4fdab1a992326968ee0267a470a5b09d4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287139Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786266}
-
Stephen Chenney authored
The test is passing now, for some reason. TBR: fs@opera.com Bug: 1102917 Change-Id: Iaddc423007f9442e951ec20a02c4d29a2eabfdc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287710Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#786265}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/14522a51c8d5..d07980440d45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huanzhong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1090397,chromium:1094282,chromium:1102355,chromium:1102832 Tbr: huanzhong@google.com Change-Id: I5befb23a958540e76f3b102c4922116f70159a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287136Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786264}
-
Oleh Lamzin authored
Add fan info to the probe service. Bug: b:158658869 Change-Id: Icfb3eea6af1999956cc854ef22f4ece6be42cb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275441 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#786263}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e6a6e45f3af0..a3f6dc2fadb4 2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from db06fce926b0 to 2a164e9680a5 (3 revisions) 2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from e8b96e86fe2e to 3bae90706d26 (2 revisions) 2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f5ed7a69d5d6 to 29c9135d06f1 (3 revisions) 2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from abc9dff824c3 to 68bfbc219497 (1 revision) 2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f6f11215cd93 to 28159ee9c8e3 (1 revision) 2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 6a4da9da4215 to 7afbc0c8be3f (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Iab10a4ce2eefef05c6cb6aa867292d6c0166269b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786262}
-
Oleh Lamzin authored
Add backlight info to the probe service. Bug: b:158658869 Change-Id: I9c9e19bbc3ee8f46517f9b06faf314280d40e823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274877 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#786261}
-
Oleh Lamzin authored
Add memory info to the probe service. Bug: b:158658869 Change-Id: I8763da7aeb1ed0047c115306180ba1e55ff2f084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274619 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#786260}
-
Brian Sheedy authored
Makes the Android instrumentation tests and GPU pixel tests report both a public and internal Gold triage link. These links should be equivalent for most use cases, but in cases where there are internal results (such as when testing on an internal repo), such results will only be available on the internal instance if logged in with an @google.com account. Bug: 1077274 Change-Id: I7d1964b9fdbce27860f6111a35184c82da16d308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285323Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#786259}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594187879-ea779e343e40d01b4c7f0171da17c012b1babef3.profdata to chrome-mac-master-1594209491-cc6e4c4037ca65c106edfe531375742086a02040.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I69c2d4270a702a00cfd26f78bc56bfdcd81d3945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287142Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786258}
-
Renato Silva authored
Fix the label to match the enum of the geolocation on the marketing opt-in screen. Bug: 1101239 Change-Id: Ia75f6214d3e4fc090f21de139b208fc21fc86622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274635 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#786257}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7622be0544b0..83fe1bc34d80 2020-07-08 enrico.galli@intel.com D3D12: Added default optimized clear color to resource creation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib5bad87aa7a5c50fc6b876fd1591220b5f8f01a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287137Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786256}
-
Titouan Rigoudy authored
Bug: 986744 Change-Id: Ie9e32528fa1f8590ffb3d0534cc133e452c8bbc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270320 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#786255}
-
Yunke Zhou authored
Bug: 1102928 Change-Id: Ia61d67aa02227840144d6b5bff4964287ca17083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287590 Commit-Queue: Yunke Zhou <yunkez@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786254}
-
Guido Urdaneta authored
This is a spec-compliance change. This CL also adds some improvements to the blink MediaDevices unit test. Bug: 1101860 Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#786253}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594187879-ebfd6a43efdbcc89fbe635e86e12f487d90a9077.profdata to chrome-win32-master-1594202362-b0a6f43d52064bea3bb530e07058a845cbb3d6d1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I1d380712e7e289118a6dc43b125543164ec20bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287133Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786252}
-
Morten Stenshorne authored
CL:2280583 rebaselined expectations to LayoutNG's liking. :) TBR=chrishtr@chromium.org Bug: 1100711 Change-Id: Ib604818c5acc79a9b1ad421a9dc9bccb809cb826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287591Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#786251}
-
Edward Jung authored
In consulation with other writing teams removing 'share' as it could cause possible confusion with it's usage within Google products and on Android. Change-Id: I0a827a87257c0dde217a682f53dc4e2518ce286e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282753Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#786250}
-
Sylvain Defresne authored
This reverts commit aafd725a. Reason for revert: Breaks downstream checkout. Original change's description: > [ios] Add --landmines-path to build/landmines.py script > > Chrome on iOS has some internal landmines and uses a forked version > of build/landmines.py for that to allow using a separate landmines > file. > > Add a --landmines-path parameter to build/landmines.py script in > order to remove the forked version and instead use the shared one. > > Bug: 1033067 > Change-Id: Iac668c5877ae181442078cda7ce8e727f91104b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283582 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786218} TBR=dpranke@google.com,sdefresne@chromium.org Change-Id: Ic3e9ba6b7b56c4d4fb0ae28a158897d1a593b972 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287302Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#786249}
-
Oleg Davydov authored
Policy implementations for OffHours and SessionLengthLimit use OneShotTimer for measuring time. This timer uses clock like device's uptime and therefore is paused when device is suspended, which leads to the problem: if device was suspended during the session, session length limit is not applied correctly, the same may happen with off hours. This commit changes timers used for these policies to a WallClockTimer, which takes possibility of suspend/resume into account and binds to the "real" time. As part of it, this commit changes TimeTicks to Time in numerous of places, notable one is the session.start_time pref, which now will store internal representation of Time, not TimeTicks. Bug: 1095645 Change-Id: Ia4950561f695053091b36f1ed481807c6d0ed6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274395Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#786248}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/faef2531ecbb..0b81007941c4 2020-07-08 lalitm@google.com tp: add support for opting out of query output checks in shell If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I59815e0506382f9246532ae12c612daaf1a25f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786247}
-
Oleh Lamzin authored
Add timezone info to the probe service. Bug: b:158658869 Change-Id: I21e8d3d21ebcad4d0b49da0022597df95cb8502c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274618 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#786246}
-
Oleh Lamzin authored
Add CPU info to the probe service. Bug: b:158658869 Change-Id: I6b1ab0c812f32e905074b1be10e56e9b72ca304c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274403Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#786245}
-
Patrick Brosset authored
Corresponding front-end CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2279485/ Bug: 1100384 Change-Id: Ib0dba6dfed055b6a4987a7182976c07fab8c3ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278853 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#786244}
-
John Abd-El-Malek authored
-remove unused methods -move process-specific methods to browser or renderer interfaces -add comment to ContentBrowserClient method that's used by Qt Change-Id: I3ff5ccbfe9fdf24e42aff87d98979ca749cc8e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285320Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#786243}
-
Ulan Degenbaev authored
The V8ReduceConcurrentMarkingTasks flag will be used in Finch experiment. Bug: v8:10442 Change-Id: I2cb6d0a8445f4eeb9fcbad9ecb8595542d50fc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283219Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786242}
-
My Nguyen authored
Bug: 1102561 Change-Id: I0dcacb9a22c8c85b0eb22d1c7ef6552d54c609fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282733Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#786241}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594014961-b33fec47337d1f487e4dacf5d1b618dace5d3422.profdata to chrome-win64-master-1594187879-6eac15fcdfb0a939dbcd47aeb2bfde0b77cd75b2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifd154a12a84d74549e8a10305b410fa94939f852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786240}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41acf46e02a1..14522a51c8d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huanzhong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1090397,chromium:1094282,chromium:1102355,chromium:1102832 Tbr: huanzhong@google.com Change-Id: I6cc7090c6e1d0925cf0a0a00233693fb82e15d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286788Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786239}
-
Mirko Bonadei authored
When is_asan=true is used, the set of exported symbols differs from a normal release build. This CL adds a .def file only for x64 builds since it looks like Chromium doesn't have an x86 bot with this configuration. Bug: 1102581 Change-Id: I01fe5cc22aa6719e765d790b624f335b0dcc23a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287292 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#786238}
-