- 28 Aug, 2020 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 41f8db90. With Chromium commits locally applied on WPT: 40203c99 "Fix typo in feature policy README" 41f8db90 "[LayoutNG] Correct border painting for fieldset fragmentation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id42d4c2ba34f0d3a224f0879c7ede49712261422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382150Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802761}
-
Koji Ishii authored
Legacy and NGPaintFragment ignores empty rects (i.e., width and height are zero) even when their offsets are outside of the frame rects. This patch changes |NGInkOverflow| to match the behavior. Note, the behavior of `backdrop-filter` using the visual rect for inline boxes look questionable and weird, probably needs a separate fix, but it helped to find the change of the ink overflow in r784976 <crrev.com/c/2269389>. Filed crbug.com/1123089 for the `backdrop-filter` issue. The 3 rebaselines for paint/invalidation were incorrectly rebaselined by r789685 crrev.com/c/2300667 due to this issue. Bug: 1122021 Change-Id: Ida5fc770963efedd219eecf602c2f33dfec51b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379444 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802760}
-
Dana Fried authored
This CL: - sets throbber height equal to location bar height - ensures that the throbber paints over the border and not under it - fits border in 24x24px space with padding around (same as other toolbar icon heights) - uses 12pt font by default In order to accommodate double-digit numbers using system fonts, we shrink the font slightly when there are 10 or more tabs. See: https://docs.google.com/presentation/d/1vhfCoRyOyyCrj_0ZVHthV1aW8aPReFiqGUEXiqAj9mo/edit#slide=id.g90c8105bab_0_15 Change-Id: Ica739933f8b36ab56f644666979f02b3124a92d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374665Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#802759}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Nightly/media_app_202008280800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/MnmDAUwQadNlsA_kV1-e9jcBLwfneTyY3-p7R76j8GAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/165878563 Tbr: media-app@grotations.appspotmail.com Change-Id: I6669e68b0614657031f7b47781a2f302b2e6b9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380649Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802758}
-
Himanshu Jaju authored
- Adds a SingleThreadTaskRunner for WebRTC medium to allow jingle calls - Replaces SequencedTaskRunner with SingleThreadTaskRunner for platform SingleThreadExecutor impl Bug: 1122532 Change-Id: I611ef85ec96fbcad3eeb160fd74b9e688edfc5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379727Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Auto-Submit: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#802757}
-
Xianzhu Wang authored
This is based on the feedback in https://docs.google.com/spreadsheets/d/1DAtdbGy7XZCC_1_IXHXZKx568pw0eDlVETCtJBexqZc/edit#gid=0. This feature is not supposed to be enabled for web tests. Bug: 1121839 Change-Id: I2713381e147dabf7b24090738afd1cd02e7c53b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380313Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#802756}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I910a6047ad1c87164f2cb5cb3abf6bc1808d26f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382059Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#802755}
-
Yao Xiao authored
This reduces the overall memory. And hopefully it could fix the regression introduced by https://chromium-review.googlesource.com/c/chromium/src/+/2324204, which could allocate a regex for every input element. Bug: 1116302 Change-Id: I00f1fa7ad07664d5ab799e760483034c1a1594fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357464 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#802754}
-
Josh Nohle authored
Removed all occurrences of "master" terminology in device_sync directory. The only risky change could be to the cryptauth_api.proto. However, the changed field name is only used for v1 Enrollment, which is not currently used on ToT; v2 Enrollment has been enabled by default for a few milestones. Ideally, even the renamed field will be removed when v1 Enrollment is completely shut down server side. Bug: 1123072 Change-Id: Ia33c5acf7382512b17c33a46f215bcb324151c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382219 Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#802753}
-
Darwin Huang authored
This improves readability, and is part of modernizing ui/base/dragdrop. This is also recommend by the style guide, per: https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs Refactoring change only. No functional changes expected. Change-Id: I3b4e5145bf7bc682fa356fe1ea1b37448cd5bd25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378886 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802752}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47ebbfa449fd..7bc80aa34110 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mek@google.com,tinazwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mek@google.com,tinazwang@google.com Change-Id: Id98d36c752fc9fad3c6b1787e7e77cad30a6c3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381936Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802751}
-
Marijn Kruisselbrink authored
Bug: 1121422 Change-Id: Icd7eeb702f9143c0670170d80da19645f6350900 Tbr: agawronska@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382206Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#802750}
-
Matthew Mourgos authored
Bug: 1122723 Change-Id: I861fd0f8fd6ae76863fd1828829d62549ca53eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368423 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802749}
-
Solomon Kinard authored
The purpose of this CL is flake mitigation. This paragraph relates to running each apitest 3000x apiece. These are crashes even when the test is only succeed(). The flake rate is around 1.3% with unrelated crashes. Relevant tests seem to have a similar heuristic. Dave mentioned it might be good to file a bug for it. Flakiness may have been caused by instantly checking tab url. This CL leverages a TabListener object to await tab updates. Once a tab has been updated, the url can be chekced more reliably. A queue of depth one was implemented here not expecting more than that. For the normal test, didPerformQuery cannot be run first/parallel due to race condition errors where two succeed occur simultaneously when the test framework was only expecting one, causing error. These tests pass locally, as did the previous version. The previous version was run with `--gtest_repeat=20`, in addition to this version. Bug: 1119846 Change-Id: Idcb3a3aa82e4ce9df7a36da9a69071634c1a6ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368147 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#802748}
-
Vladimir Levin authored
This patch renames an enum to eliminate any ambiguity between CompositorRenderPass and AggregatedRenderPass. Future patches will also rename the types used. R=weiliangc@chromium.org, magchen@chromium.org Bug: 1106418 Change-Id: I523a85d4220d892a5028b1570411e792bf64879f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380092Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802747}
-
manukh authored
Adds a param `RichAutocompletionAutocompleteNonPrefixShortcutProvider`. Similar to `RichAutocompletionAutocompleteNonPrefix`, it enables non-prefix AC, but only for shortcut suggestions. This may address unwanted non-prefix AC being distracting. Additionally, adds a chrome://flags flag `Omnibox Rich Autocompletion Promising Combinations` with the 4 most promising combinations of the existing 3 Rich AC flags. This will help begin fishfood experiments without asking users to setup multiple flags with over a dozen variations. Bug: 1062446 Change-Id: Ida29a36858e472c671c9724a381cf8fccde2ea34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380321 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#802746}
-
Illia Klimov authored
Bug: 1123026 Change-Id: Ia12abb01c45cfb1897821bd42f4c4236f95bf1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380658Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#802745}
-
Marijn Kruisselbrink authored
Tbr: mkwst@chromium.org Bug: 1122582 Change-Id: Id173a8569096ffba5d6bc0f711446b2f96948924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382061 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#802744}
-
Elaine Chien authored
Bug: 747034 Change-Id: I6d7a449c0919b4fe2f0d1c1ed29276131dc4b9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380738Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Elaine Chien <elainec@chromium.org> Cr-Commit-Position: refs/heads/master@{#802743}
-
ckitagawa authored
Fix a crash I encountered locally. We don't need to do this cleanup and it can cause a crash if the file manager can't be acquired. Change-Id: I66e34e4f2afc6d0c884a5129775ce292ec6c4859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382215Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#802742}
-
Danyao Wang authored
Teach the browser to generate a WebAuthn challenge that is a SHA-256 hash over transaction data. Also added a test page that automates expectation updating for the unit test. Bug: 1121020 Change-Id: Ic5515135eb8724eedc49d966f3986b0a48bbd519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381096 Commit-Queue: Danyao Wang <danyao@chromium.org> Auto-Submit: Danyao Wang <danyao@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802741}
-
Sorin Jianu authored
When updatersetup.exe without an argument, or when updater.exe --install is run, it only installs the updater. As a post-condition, the updater must be made active. This change is calling ControlService::Run(), which has the result of starting the COM server, mode check the install, and promote it to active, if needed. As a side effect, an update check is performed. Bug: 1122739 Change-Id: I820304d4674d35e00a8000d6701c9326e32618a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380492 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#802740}
-
Wez authored
Allow the test batch a grace period after which all of its processes and jobs must have terminated. Bug: 1094369 Change-Id: Ia2df0ea4e3fdfbd8c6b99b3c7268171db79f33cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360079 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#802739}
-
David Tseng authored
AccessibilityControllerImpl::UpdateFeatureFromPref-> case FeatureType::kSwitchAccess: with !enabled never calls SyncSwitchAccessPrefsToSignInProfile(); Call it when the resulting dialog is closed with user accepting yes to close. R=anastasi@google.com, dmazzoni@chromium.org Fixed: 1122768 Change-Id: I3822dc5d98c201effb0cde2e5ad5005e8a20cc05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382011Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802738}
-
minch authored
Add the logic for syncable dark/light switcher. Enable/Disable the dark mode through the feature pod in system tray will update the preference for this user on other devices too. Login screen will be done in a follow up cl. Bug: 1106012 Change-Id: Idbbc3f5652effdc7590713fc5687e031e3d97dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373134 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#802737}
-
Andrey Kosyakov authored
Bug: 1114636 Change-Id: Iba3865206d7e80b363ec69180ac05e20b56aade2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380855Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#802736}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15826356..8aa817bf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0c608fddcbd705ec88f42fdf01ffb6b75ea93c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382230Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802735}
-
Leonid Baraz authored
Since EncrypedRecord represents not only data but also sequencing information, rely on it everywhere, including the unittests. Extend test to verify sequencing too. Bug: b:153364303 Bug: 1078512 Change-Id: I04dfe6bb9c1bbaac92f34363b26e149011dc9502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380498 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#802734}
-
Prashant Nevase authored
Replace WTF::HashSet by std::map. Bug: 1091095 Change-Id: Ieb445f6ef98486668b6241f800895af9607c963f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214731Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#802733}
-
Jeffrey Cohen authored
The upload screenshot tool now optionally captures screenshots for translated strings in the downstream clank directory. This allows engineers who are adding strings to features located in the clank directory to integrate with the existing translation tooling. Bug: 1122780 Change-Id: I348caf20c09cf22a0924d154ef4bdcc7902e70af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380328Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802732}
-
Emily Stark authored
Make it more obvious that the policy is experimental and subject to change. Change-Id: I8a78625f9c35a2927a0e441870397c2f3fdd95fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378754Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#802731}
-
Adam Ettenberger authored
This is a reland of 8f92c37d Revert CL : https://chromium-review.googlesource.com/c/chromium/src/+/2346996 Reason for revert: causing build failure: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/15547? Original change's description: > Fix Role::kButton name invalidation when descendant text is modified > > This CL addresses a bug where Role::kButton, and possibly other roles > that derive their name from descendant contents, were not firing > Text Changed when a descendant Node.TEXT_NODE modifies its text |data|. > > ax_object_cache_impl.cc : > - When firing a text changed event, also fire a text changed event for > the first ancestor that derives its name from descendant contents. > This ensures the nodes are invalidated, send appropriate text changed > events, and the changes are serialized to the browser process AXTree. > > browser_accessibility_manager_win.cc : > - FireUiaTextContainerEvent made it possible to fire text events more > than once for a given text provider so it has been removed. > - Instead, populate a set |text_changed_events_| which contains the > text providers via |GetUiaTextPatternProvider| and fire the UIA text > events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents > - |text_selection_changed_events_| could also potentially end up with > the same double-event problem, so it uses GetUiaTextPatternProvider > now as well. > - Removing usage of std::unordered_set based on the guidance in > base/containers/README.md. In general these sets shouldn't grow large > enough to benefit from being unordered. > > AX-Relnotes: Fix bug where after updating the content of complex button might not notify ATs, causing the wrong accessible name to be announced. > Bug: 1105262 > Change-Id: I02dc7798686b09f780c90af52aeb2e36fe8fe048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296564 > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796464} Bug: 1105262 Change-Id: Idfafd2e7f886d4d27b735d143ceaa0f33607f7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346933 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#802730}
-
Jeroen Dhollander authored
This is the main controller for the bloom feature. The current implementation is incomplete, but it performs the first steps of the Bloom interaction: * Fetch the access token * Request a screenshot from the user (currently stubbed) * Start the Assistant interaction which should open the Assistant UI (currently stubbed). Bug: b/165356952 Tests: chromeos_components_unittests --gtest_filter="BloomController*.*" Change-Id: If2860c46c8c03d72290d04ae24e0a78585fd63ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364812 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802729}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/33a6332a9232..d7c4e9418e36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3990cc28824a82bf9edba6ae52b8939d34d669a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382291Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802728}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d7c4e9418e36..b1e3f57ef7c0 2020-08-28 lalitm@google.com Merge "perfetto: fix documentation for unix socket and simplify ipv6 handling" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7297b812021d241e0b1672b5fe9b03e73d4de4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380648Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802727}
-
Tibor Goldschwendt authored
This is more consistent with the GN targets of other WebUIs. + Move module_wrapper.* to modules/. This is a reland of e2431d75. Downstream has been fixed to work with this CL. Original change's info: > Change-Id: I23be97df455e8cb0a9ed35b15b184902b3fa1a9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376529 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802008} TBR=dpapad@chromium.org Change-Id: I6db4ed44fc6bb6fc9e85a9a5e671238b23df009a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382212Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#802726}
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: I5253597f59fad15243fc62e0001765d48f693b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377736 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#802725}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/43c78abe0440..fc1eb95f39a3 2020-08-28 mtklein@google.com second-guess AVX-512 opts 2020-08-28 mtklein@google.com add missing include 2020-08-28 bsalomon@google.com Remove use of texture swizzle in GL backend. 2020-08-28 mtklein@google.com add suggested `override` 2020-08-28 brianosman@google.com Don't run glesnarrow on Mali400 bots If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I8e4ee4229a0f30557ebc1fa62ab8fac605806d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380647Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802724}
-
Christopher Cameron authored
Create a blink::Picture::ScopedSharedImage structure, which will keep a SharedImage alive as long as it is alive. This will be used to pass a SharedImage from the hardware decoder across to the VTVideoDecodeAccelerator. The PictureBufferManager is where the decision about use of SharedImage will be made. It will be sent to the VTVideoDecodeAccelerator by specifying an empty PictureBuffer. Bug: 1108909 Change-Id: Iabb71b1b69dd922dc44aca3821f243fcdd22c6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377419 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#802723}
-
Karandeep Bhatia authored
PopulateItem is used when parsing arrays. We should never be parsing arrays of optional types (which are represented as std::unique_ptr). Remove these overloads. BUG=None Change-Id: Ia29ef89bd555cbfad10b92e9963e4fda431495a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380322 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802722}
-