GitLab

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6266012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71907 0039d316-1c4b-4281-b951-d872f2087c98

css from ainslie@

BUG=63843
TEST=visual

Review URL: http://codereview.chromium.org/6369006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63842
TEST=none

Review URL: http://codereview.chromium.org/6325011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71904 0039d316-1c4b-4281-b951-d872f2087c98

Delete strings from .grd files that are at least 6 months old and aren't used anywhere.

BUG=none
TEST=compile

Review URL: http://codereview.chromium.org/6293012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71903 0039d316-1c4b-4281-b951-d872f2087c98

  The default value is true.

* Add --disable-interactive-form-validation flag and about:flags interface

The interactive form validation feature might cause web site
compatibility issues.  So we provide a way to disable it just in case.

BUG=45804,54368
TEST=manual; Open the URL "data:text/html,<form><input required></form>", click
  the input field, and press ENTER key.
 - A validation message is shown by default
 - If you run Chrome with --disable-interactive-form-validation, no validation
   message is shown and the form is submitted.
 - If you enable "Disable HTML5 interacrive form validation" flag on
   about:flags, no validation message is shown and the form is submitted.
Review URL: http://codereview.chromium.org/6329005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71902 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a problem where if the model fetch is still running when the
ClientSideDetectionService is destroyed, the URLFetcher is not deleted.
This could potentially cause the OnURLFetchComplete callback to be called
on a deleted ClientSideDetectionService object.

Now the model fetcher will always be deleted, and we will also make sure to
destroy the ClientSideDetectionService before tearing down the IO thread
(since the URLFetcher dtor can post messages there).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6298004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71901 0039d316-1c4b-4281-b951-d872f2087c98

Don't start with Search visible, since it can cause the code that shows specific sub pages to be confused when prefs are opened to a specific URL, and leave search as the root page.

Also fixes an exception during initialization on non-ChromeOS machines.

BUG=69613
TEST=Opening prefs to a subpage by URL should show the right parent page, not Search.

Review URL: http://codereview.chromium.org/6374005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71900 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70006,70039
TEST=none

Review URL: http://codereview.chromium.org/6246011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71899 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6271011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71898 0039d316-1c4b-4281-b951-d872f2087c98

Also, bump NaCl in deps to pull in new version of NaCl, which
has now migrated to non-dev audio.

Review URL: http://codereview.chromium.org/6281007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68516
TEST=greener tree

Review URL: http://codereview.chromium.org/6322005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64800
TEST=none

Review URL: http://codereview.chromium.org/6314011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71895 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jknotten

Review URL: http://codereview.chromium.org/6294007

TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/6304012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71894 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jknotten

Review URL: http://codereview.chromium.org/6294007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71892 0039d316-1c4b-4281-b951-d872f2087c98

negotiate it.  This is used for debugging.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6291004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6246010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71890 0039d316-1c4b-4281-b951-d872f2087c98

1) Sub-menus should expose as much as possible without needing to be scrolled up when the dock is showing at the bottom.
2) Fix how menu bottom is misplaced and window is foreshortened when that last scroll-up is performed (for a menu which fits on the screen after being completely scrolled up).
3) Align the right edge of the menu with the right edge of the bookmark bar button from which it springs.
4) Tighten up the menu item spacing.

BUG=54701,69418,69346,59057
TEST=1) Place window near bottom of screen with dock showing. Pop up a folder menu (one which will completely fit on the screen after being fully scrolled up) and scroll fully up. Verify that the bottom it properly placed and all folder contents are shown. Verify that the menu right edge is aligned with the right edge of the button.
2) Have a bookmark folder menu with a submenu near the bottom. Pop up the folder menu and then the submenu. Verify all of the submenu appears.
3) All BookmarkBarFolderControllerTests menu unit tests pass.
4) All BookmarkBarFolderControllerMenuTests menu unit tests pass.

Review URL: http://codereview.chromium.org/6257005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71889 0039d316-1c4b-4281-b951-d872f2087c98

the source of truth for windows (though I'd swear I'd seen files used
somewhere recently too).

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6344009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71888 0039d316-1c4b-4281-b951-d872f2087c98

is sent out from IE in case Chrome is the default renderer for IE.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=70138

BUG=70138
TEST=As described in the bug at this point. Unit tests for this will follow.


Review URL: http://codereview.chromium.org/6279006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71887 0039d316-1c4b-4281-b951-d872f2087c98

The recent style change added another class to the buttons, exposing this latent bug.

BUG=None
TEST=Clicking the delete button in a DOMUI prefs list should delete the item.

Review URL: http://codereview.chromium.org/6372005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71886 0039d316-1c4b-4281-b951-d872f2087c98

This allows touch devices to be grabbed when events from the mouse/keyboard are
grabbed. This also exposes TouchFactory, which will eventually be used in more
places.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6300007

TBR=sadrul@chromium.org
Review URL: http://codereview.chromium.org/6349008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581
TEST=trybots

Review URL: http://codereview.chromium.org/6249007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71884 0039d316-1c4b-4281-b951-d872f2087c98

The reason of this bug is:
Because of some reason, ibus will send a fake event to the application for each real key event. These extra fake key events apparently confuse those web apps. This CL tries to suppress those extra key events faked by ibus, while keeping the behavior of other input methods unaffected as much as possible.
It's a hacky workaround. Hope it won't cause any other problem.

BUG=chromium-os:6582
TEST=See bug report.

Review URL: http://codereview.chromium.org/6336003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71883 0039d316-1c4b-4281-b951-d872f2087c98

the link is unsuccessful but not replace the old program.

TEST=webgl conformance tests pass
BUG=none

Review URL: http://codereview.chromium.org/6242006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71882 0039d316-1c4b-4281-b951-d872f2087c98

In order to better log mixed-scripting issues I want to get the URL into
Chrome land. This involves a WebKit change ([1]) but, by making this
change first, we can decouple of the two changes.

[1] https://bugs.webkit.org/show_bug.cgi?id=52384

BUG=none
TEST=compile

http://codereview.chromium.org/6272003/

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68682
TEST=compiles

Review URL: http://codereview.chromium.org/6314010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71880 0039d316-1c4b-4281-b951-d872f2087c98

This allows touch devices to be grabbed when events from the mouse/keyboard are
grabbed. This also exposes TouchFactory, which will eventually be used in more
places.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6300007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71879 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6278009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71878 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69289
TEST=none

Review URL: http://codereview.chromium.org/6292009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71877 0039d316-1c4b-4281-b951-d872f2087c98

When code was moved from browser.cc to browser_navigator.cc, the logic for
spawning popup windows was either mis-copied or copied from a different code
path; any browser of TYPE_APP (e.g. TYPE_APP_POPUP) should create popup windows
of TYPE_APP_POPUP.

BUG=chromium-os:11040
TEST=See issue + UI auto tests

Review URL: http://codereview.chromium.org/6296011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71876 0039d316-1c4b-4281-b951-d872f2087c98

TBR=wtc

BUG=67928
TEST=JingleSessionTest.* should pass on XP bot

Review URL: http://codereview.chromium.org/6338010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71875 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jknotten

Review URL: http://codereview.chromium.org/6286004

TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/6372004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71874 0039d316-1c4b-4281-b951-d872f2087c98

Move SSL resources out of browser\security\resources into browser\resources alongside the rest of the resources (and interstitials).
Review URL: http://codereview.chromium.org/6326007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71872 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jknotten

Review URL: http://codereview.chromium.org/6286004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71871 0039d316-1c4b-4281-b951-d872f2087c98

- Adds spacing under the header on all subpages (preventing, e.g., lists from abutting the header underline)
- Aligns the "Add" button to the left edge of the list above it, and adds space between the two.
- Fixes the left-side padding of the new <select> style.

BUG=None
TEST=Spacing on startup page manager subpage should be better.

Review URL: http://codereview.chromium.org/6299011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71869 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6368008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71867 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6359002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71866 0039d316-1c4b-4281-b951-d872f2087c98

truth for linux only).
Updating FILES to the right name, just for good measure.

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/6354008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71865 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70166
TEST=none
Review URL: http://codereview.chromium.org/6287005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71862 0039d316-1c4b-4281-b951-d872f2087c98

(This was a TODO for phajdan.jr).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6354005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71861 0039d316-1c4b-4281-b951-d872f2087c98