- 06 Aug, 2018 40 commits
-
-
Toni Barzic authored
Most of the callers to CrOSComponentManager::Load expect the callback to be called on the UI thread (the same as the thread from which the method was called)- the only exception is CrostiniManager, which does not assume the callback is called on the UI thread, but still just relays the callback result back to UI thread. Currently, callbacks are run using base::PostTask, which post the callback to the task runner. To make the behavior of the method match the expectations, use ThreadTaskRunnerHandle::Get to get the current task runner, and use it to asynchronously run the callback. Bug: None Change-Id: I9f365a11ba2634154488c580615ceede59e2a9d3 Reviewed-on: https://chromium-review.googlesource.com/1163071 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#580903}
-
Thomas Tangl authored
Add metric to record the suppress reason when the consent bump should not be shown. Additional changes: - Don't show consent bump when any on-by-default privacy setting was off during migration. Bug: 858870, 863948 Change-Id: Iac7bbb6b8d1d332db3439b2f96c6035ed255e6b3 Reviewed-on: https://chromium-review.googlesource.com/1162233 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#580902}
-
Peter Beverloo authored
Change-Id: I980ed5d43a3afef2d96a3702bc9f7129c68950ab Reviewed-on: https://chromium-review.googlesource.com/1163605Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580901}
-
Weidong Guo authored
1. Flip the feature flag. 2. Fix test errors. Bug: 865139 Change-Id: Ibbb7c5e6fa1f94a419015591c318a2b2a1905809 Reviewed-on: https://chromium-review.googlesource.com/1142441 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580900}
-
Balazs Engedy authored
The test was observed to be flaky. Bug: 870852 Change-Id: I3163111ba26e30d0864ff3a52a1ab21e64137725 TBR: nednguyen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1163678Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580899}
-
Wez authored
TBR=rch Change-Id: Ic149856ad452e82c1eafc69057b01865ac98335e Reviewed-on: https://chromium-review.googlesource.com/1162741Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580898}
-
Weidong Guo authored
Suggestion chips replace suggested apps, expand arrow is moved and apps grid's layout id changed, so focus is broken. Changes: 1. Up and down key will move focus to previous/next row in apps grid. If the target focus index is invalid, shift it to the nearby valid index. 2. Disable focus of suggestion chips when folder is opened. 3. Fix test errors. Bug: 859644 Change-Id: Iaf9707b44f6d72a181a26ce5bc34612f26e01aaf Reviewed-on: https://chromium-review.googlesource.com/1161494Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#580897}
-
sebsg authored
Bug: 853688 Change-Id: Ibac26f2adab7a360d866e3abc75b36f0bab8ab51 Reviewed-on: https://chromium-review.googlesource.com/1152085 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#580896}
-
Jérôme Lebel authored
The user consent can never be given when no user is connected. In the EarlGrey test, first the user should be logged in, and then the user consent can be set. TBR: sczs Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5beeea0d4b05032f8d940883dc92a3523f81dc55 Reviewed-on: https://chromium-review.googlesource.com/1163717 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580895}
-
Farah Charab authored
No longer using experiment_only_when_loading in SchedulingSettings configuration. Change-Id: Ia1ebbdc513c677c884c3be656a976deb2ef4435f Reviewed-on: https://chromium-review.googlesource.com/1162332 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580894}
-
Ted Choc authored
Ensure both displays are on before allowing multi-display. BUG=824954 Change-Id: If235135d3dfbfa6c42f31bd30c0a3deba145f33f Reviewed-on: https://chromium-review.googlesource.com/1162912Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#580893}
-
Michael Lippautz authored
- Prepare V8PerIsolateData for holding V8HeapController. - Harden existing tests to swap in the expected visitor/controller. This way it is possible to test ScriptWrappableVisitor while already running on a different embedder heap tracer. Change-Id: I169de233a4dd9886d153e7d97ca63e7caee0d809 Bug: chromium:843903 Reviewed-on: https://chromium-review.googlesource.com/1160656 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#580892}
-
Charlie Andrews authored
TBR=sullivan@chromium.org Bug: 859514 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I7b6c0203596df67d668c18a084039c1832b3f52b Reviewed-on: https://chromium-review.googlesource.com/1162628Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#580891}
-
Manuel Rego Casasnovas authored
When we integrated content alignment in the track sizing algorithm (r566412) we forgot to do it too when the 2nd pass is needed. The patch is very simple and just adds the calls to apply content alignment in LayoutGrid::RepeatTracksSizingIfNeeded() for each axis. The spec also mentions it in the new 3 and 4 steps: https://drafts.csswg.org/css-grid/#algo-overview So the new code just aligns with the spec. BUG=870634 TEST=external/wpt/css/css-grid/alignment/grid-content-alignment-second-pass-001.html Change-Id: Iccbcea5da1011eae37b4923bb78334cddc76d027 Reviewed-on: https://chromium-review.googlesource.com/1161925Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#580890}
-
Marc Treib authored
This replaces the "Summary" field (which used to contain state + disable reasons) by separate "Transport State" and "Disable Reasons" fields, and also introduces a new "Is Sync Feature Enabled" field. Bug: 856179 Change-Id: I65e3c203faeb1c4b0193b01ce509e541817aef7e Reviewed-on: https://chromium-review.googlesource.com/1162238 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580889}
-
Nico Weber authored
TBR=jchinlee Bug: 869503 Change-Id: Ice82ca146c5c7d1dea36725d7e9170e5a22fabda Reviewed-on: https://chromium-review.googlesource.com/1163311 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#580888}
-
Florent Castelli authored
The transactionId field is now required in the WebIDL, so the proper error is now a TypeError. Bug: 803494 Change-Id: Iaf49c2cd192b8ac99678acb74a163670f4c93893 Reviewed-on: https://chromium-review.googlesource.com/1163666 Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#580887}
-
Marina Ciocea authored
Temporary disable flaky tests on Linux until we figure out the root cause for the failures: - CallWithAudioDebugRecordings - TwoCallsWithAudioDebugRecordings Bug: 871182 Change-Id: I331a9d96a4dd2d2a300f1e5a068913d31ea3314d Reviewed-on: https://chromium-review.googlesource.com/1163616Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#580886}
-
Fabio Tirelo authored
Change-Id: Ic0858a6106dc3c3b00cfa092b649bb14b83b3e4d Reviewed-on: https://chromium-review.googlesource.com/1163641Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#580885}
-
Mohamed Amir Yosef authored
Before this CL, BookmarkModelObserverImpl assumed that bookmark nodes creation notification must arrive before update notification which isn't true. Considering the following secnario: 1. New bookmark added. 2. BookmarkModel notifies all the observers about the new node. 3. One observer A get's notified before us. 4. Observer A decided to update the bookmark node. 5. BookmarkModel notifies all observers about the update. 6. We received the notification about the update before the creation. 7. We will get the notification about the addition later and then we can start tracking the node. For example, BookmarkLastVisitUpdater::BookmarkNodeAdded() updates the node metainfo. After this CL, any update notification for an untracked node is ignored. A later creation notification should take care of that node. Bug: 516866,867036 Change-Id: I16801891759c756a7d1f8e18e932929f67d1759b Reviewed-on: https://chromium-review.googlesource.com/1162323 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580884}
-
Ross McIlroy authored
Adds kHitIsolateCacheWhenStreamingSource. BUG=chromium:865098 TBR=delphick@chromium.org Change-Id: I9112410a1ddf9b9f56667a7880152d306d4a2612 Reviewed-on: https://chromium-review.googlesource.com/1163672 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580883}
-
Owen Min authored
Move the verfication of enrollment failure into teardown because test body is skipped as Chrome quit during launch. Also remove the runloop in the test because the enrollment process blocks Chrome launch process which also blocks the browser test. Bug: 871238 Change-Id: Ic886ac50b4c4cc215e2cad33294b43f308e17322 Reviewed-on: https://chromium-review.googlesource.com/1161465 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#580882}
-
chrome://flagsSebastien Seguin-Gagnon authored
That field should not get autocomplete suggestions. Change-Id: Ie711c8d15cffb612e55dfcc057db8a7a4ef8eb19 Reviewed-on: https://chromium-review.googlesource.com/1156912Reviewed-by:
Grace Kloba <klobag@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#580881}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2e77f54f46e8..12fb9cfeee07 git log 2e77f54f46e8..12fb9cfeee07 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 ethannicholas@google.com added SkSL saturate() function Created with: gclient setdep -r src/third_party/skia@12fb9cfeee07 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I5aed12e5730e3cae7d9dae34c106ef25694b2fb4 Reviewed-on: https://chromium-review.googlesource.com/1163114Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580880}
-
Owen Min authored
Screenshot: https://drive.google.com/file/d/1ipME4JlplC_99fQzx6lukvmHUyA3MUfG/view?usp=sharing Bug: 856242 Change-Id: I5f70c8b697de5b310019258ad79c27f975b7ce36 Reviewed-on: https://chromium-review.googlesource.com/1162342Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580879}
-
Manuel Rego Casasnovas authored
Two of the failures are related to stacking contexts: * external/wpt/css/css-contain/contain-paint-021.html * external/wpt/css/css-contain/contain-layout-016.html The other one was a mistake that has been already fixed in WPT (see https://github.com/web-platform-tests/wpt/pull/12314): * external/wpt/css/css-contain/contain-paint-001.html TBR=eae@chromium.org BUG=870811,868102,870157 Change-Id: I60e89decd2f939d1d9a850a1b8b556d31658e872 Reviewed-on: https://chromium-review.googlesource.com/1163673Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#580878}
-
Andrii Shyshkalov authored
R=maruel@chromium.org Expand-Timezone-Coverage: Yes No-Try: True Change-Id: I420e4e804ec107b079187f23acec18516052714a Reviewed-on: https://chromium-review.googlesource.com/1163636Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#580877}
-
Daniel Vogelheim authored
These tests follow the format currently under discussion here: https://github.com/WICG/origin-policy/pull/39 Bug: 751996 Change-Id: Ief33c794498cb3ed84dac670ecff4ddc366b9592 Reviewed-on: https://chromium-review.googlesource.com/1130531Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#580876}
-
Peter Beverloo authored
Change-Id: Ib7db0bbf5298c9b3bde3a6d949df92de3daad6e2 Reviewed-on: https://chromium-review.googlesource.com/1163606Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580875}
-
Balazs Engedy authored
The test is flaky on Mac as well. Bug: 704980 Change-Id: I6d56312bd8ffb8fffe6911535a0029d95a27812a TBR: mseaborn@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1163676 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580874}
-
Kevin Bailey authored
Spacebar normally inserts a space into the Omnibox. If the cursor (or selection) is at the end of the text and the tab switch button is "focused", instead activate the button. Bug: 780835 Change-Id: I121f72bf3a979213d0506da1168a7658be84e706 Reviewed-on: https://chromium-review.googlesource.com/1160597Reviewed-by:
Justin Donnelly (OOO until Aug 13) <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#580873}
-
Hirokazu Honda authored
This CL does (1) remove unused RenderingHelper::GetGLDisplay(), (2) move local static functions to noname namespace, (3) omit RenderingHelperParams' constructors and desturctor. BUG=chromium:834170 TEST=VDA unittest at kevin Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibe5b2207c3eb794266f6cbc5d4796debefe165ad Reviewed-on: https://chromium-review.googlesource.com/1126742 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#580872}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/46671402fff3..15f0a12b8309 git log 46671402fff3..15f0a12b8309 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 sakal@webrtc.org Allow releaseCallback to be null in JavaI420Buffer#wrap. Created with: gclient setdep -r src/third_party/webrtc@15f0a12b8309 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ica16ef226bbba659684029768a075bab43fb97a2 Reviewed-on: https://chromium-review.googlesource.com/1163111Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580871}
-
Elly Fong-Jones authored
If a menu has rounded corners, the vertical margin should always be exactly the radius of that corner, to avoid visual glitches when the top or bottom items are highlighted. Bug: 868037 Change-Id: Iab35de0b5be4152da1f24927c4a7f6bdef92a0d9 Reviewed-on: https://chromium-review.googlesource.com/1161101Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#580870}
-
nednguyen authored
Bug: 870673 Change-Id: I024d5bcad65d4d714c38066c71fcca352d21fda9 Reviewed-on: https://chromium-review.googlesource.com/1163623 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580869}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/64f2b4dce29f..5968caf4e5f6 git log 64f2b4dce29f..5968caf4e5f6 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 primiano@google.com Add interactive trace_processor_shell + fix mac build 2018-08-06 fmayer@google.com Do not compile memory profiler for Chromium. 2018-08-04 michaschwab@google.com Add brushing via scrollwheel on overview timeline 2018-08-04 michaschwab@google.com Add DragGestureHandler, use in Overview and PanAndZoomHandler 2018-08-04 michaschwab@google.com Merge "Reduce passing sizes, more styling in CSS" 2018-08-03 primiano@google.com Merge "perfetto-ui: Remove the special mechanism for local files" 2018-08-03 treehugger-gerrit@google.com Merge "Fix compilation error for Chrome" 2018-08-03 primiano@google.com Merge "trace_processor: Refactor in order to implement global ordering." 2018-08-03 dproy@google.com Draw gridlines in core code and remove width from extension 2018-08-03 treehugger-gerrit@google.com Merge "Add StringInterner for heapprofd." 2018-08-03 hjd@google.com perfetto-ui: Fix up/down icons 2018-08-03 hjd@google.com Merge "perfetto-ui: Rename MithrilEvent to RedrawableEvent" 2018-08-02 michaschwab@google.com Fix Cpu Slices Width 2018-08-02 michaschwab@google.com Improve Design, Move Towards Mock 2018-08-02 primiano@google.com Merge "Add reorder track buttons" 2018-08-02 primiano@google.com Merge "Allow brushing everywhere instead of only via handles" 2018-08-02 primiano@google.com Merge "Remove backend directory" 2018-08-02 dproy@google.com Merge "[perfetto-ui] Remove backend directory" 2018-08-02 dproy@google.com Delete virtual canvas context 2018-08-02 dproy@google.com Plumb published track data to track frontend 2018-08-02 treehugger-gerrit@google.com Merge "Add record reader for heapprofd." Created with: gclient setdep -r src/third_party/perfetto@5968caf4e5f6 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id7c30a61b3f20eb864057470e612ba8776ee34f6 Reviewed-on: https://chromium-review.googlesource.com/1163113 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580868}
-
Hans Wennborg authored
Bug: 746975, 869850 Change-Id: Ic8c2b3be2b20dd07494a25641dee2634322dad14 Reviewed-on: https://chromium-review.googlesource.com/1163662 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580867}
-
Nico Weber authored
Bots seem to not use it, and humans can look at tools/determinism/deterministic_build_whitelist.pyl directly. Bug: 314403,664868 Change-Id: I286b28bb622df8d1910fa75f24bcf61439a3fe60 Reviewed-on: https://chromium-review.googlesource.com/1163317 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#580866}
-
Jochen Eisinger authored
BUG=801973 R=msarda@chromium.org Change-Id: Ic139c3dcab4299bc7c9f8c8f174262ae9c706272 Reviewed-on: https://chromium-review.googlesource.com/1163516Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580865}
-
Hirokazu Honda authored
RenderingHelper::CreateTextureRef should encapsulate creating TextureRef, not only creating texture id. Thanks to this, RenderingHelper don't need to publicize a function to close a created texture. BUG=chromium:834170 TEST=VDA unittest on veyron_minnie and eve Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I21db66ef8505bd5ae67c0546ed2fd84890b011eb Reviewed-on: https://chromium-review.googlesource.com/1122071 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#580864}
-