GitLab

If SHELL is not set then make will search PATH for sh.exe. If it is found, it
will use that instead of cmd.exe. If the sh.exe exists in a path with a space,
the command will fail to run.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/806283003

Cr-Commit-Position: refs/heads/master@{#309450}

BUG=444563
TBR=creis@chromium.org

Review URL: https://codereview.chromium.org/804923003

Cr-Commit-Position: refs/heads/master@{#309449}

BUG=444596
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/802473003

Cr-Commit-Position: refs/heads/master@{#309448}

* ActivityDelegate takes in classes instead of Strings
  so that you can do isInstance on them.

* TabDelegate introduces a new function for creating Tabs
  in a specific case.

BUG=443773

Review URL: https://codereview.chromium.org/819743002

Cr-Commit-Position: refs/heads/master@{#309447}

This is a preliminary CL for upcoming Polymer update.

BUG=440039
TEST=manually, hotrod pairing works

Review URL: https://codereview.chromium.org/819633002

Cr-Commit-Position: refs/heads/master@{#309446}

BUG=444578
TEST=none
R=nasko@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/818833004

Cr-Commit-Position: refs/heads/master@{#309445}

BUG=443377

Review URL: https://codereview.chromium.org/820583002

Cr-Commit-Position: refs/heads/master@{#309444}

It tests device list updating mechanism mocking GCD server. Test code loads into a dummy page and
interacts with instance of DevToolsBridgeClient via dedicated command handler.

It also adds infrastacture for testing establishing sessions in future (ability to handle commands
sent from background_worker.html and create PeerConnection will help with it).

BUG=383418

Review URL: https://codereview.chromium.org/791083005

Cr-Commit-Position: refs/heads/master@{#309443}

BUG=148383, 242503, 170739, 166857
TBR=earthdok@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/791033005

Cr-Commit-Position: refs/heads/master@{#309442}

BUG=440675
TEST=no change
R=mdempsky@chromium.org, thakis@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/821453003

Cr-Commit-Position: refs/heads/master@{#309441}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cfaac60..dd080bd

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/823623002

Cr-Commit-Position: refs/heads/master@{#309440}

When we're profiling methods, we get back the address of the methods.  ICF
aliases several methods to the same address, which makes the order profile less
correct for other configurations which might make different ICF decisions.

Review URL: https://codereview.chromium.org/802583004

Cr-Commit-Position: refs/heads/master@{#309439}

For input type attribute in radio state with menu as parent is '?'.
A '?' in a cell indicates the data has yet to be provided.

ARIA role menuitemradio: A checkable menuitem in a set of elements with role menuitemradio,
only one of which can be checked at a time.

The behavior of input type in radio state with menu as parent seems similar with ARIA role menuitemradio.

A spec bug has been filed for this https://www.w3.org/Bugs/Public/show_bug.cgi?id=27041

This CL depends on https://codereview.chromium.org/651893002/

This CL also depends on https://codereview.chromium.org/634533002/ for fix related to android.view.MenuItem

BUG=422879

Review URL: https://codereview.chromium.org/652103002

Cr-Commit-Position: refs/heads/master@{#309438}

Add a virtual method InfoBarManager::CreateConfirmInfoBar that allow the
embedder to use UI specific implementation of ConfirmInfoBar. Port all
client code to use this virtual method instead of the static method
ConfirmInfoBarDelegate::CreateInfoBar.

Implements the InfoBarService::CreateConfirmInfoBar method for the
different UI (views, android, cocoa) and for TestInfoBarManager.

BUG=386171
TBR=jam@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/812823002

Cr-Commit-Position: refs/heads/master@{#309437}

BUG=
TBR=robertphilips

Review URL: https://codereview.chromium.org/821713002

Cr-Commit-Position: refs/heads/master@{#309436}

because there are some tests failing there (see 1 & 2).
Fixing these may take some time and we're keen to gather
performance metrics over the Christmas period.

We'll fix the WebView or ChromeOS problems in the new
year.

ATTN Sheriffs: This patch will expose flakiness in
css3/filters/effect-reference-rename.html there is a patch
in review to fix that:

https://codereview.chromium.org/787563003

[1] http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/39248
[2] http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/9441

BUG=432129,444572,444574

Review URL: https://codereview.chromium.org/819623002

Cr-Commit-Position: refs/heads/master@{#309435}

BUG=440252

Review URL: https://codereview.chromium.org/816693003

Cr-Commit-Position: refs/heads/master@{#309434}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6cc53f3..d582cab

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/819863003

Cr-Commit-Position: refs/heads/master@{#309433}

BUG=440675
TEST=no change
R=mdempsky@chromium.org, nasko@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/814403003

Cr-Commit-Position: refs/heads/master@{#309432}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1111d8c..cfaac60

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/786953006

Cr-Commit-Position: refs/heads/master@{#309431}

It has been flakily failing on ASAN builds for a while now.

BUG=

Review URL: https://codereview.chromium.org/824693003

Cr-Commit-Position: refs/heads/master@{#309430}

Introduce web::TestWebThreadBundle that delegates to
content::TestBrowserThreadBundle until web::WebThread
has a proper implementation on iOS.

Build public/test/test_browser_thread_bundle.cc on iOS.

BUG=442292

Review URL: https://codereview.chromium.org/814533002

Cr-Commit-Position: refs/heads/master@{#309429}

BUG=386788

Review URL: https://codereview.chromium.org/465853004

Cr-Commit-Position: refs/heads/master@{#309428}

BUG=435130, 439941

CL based on https://chromereviews.googleplex.com/

TBR=jennyz@chromium.org

Review URL: https://codereview.chromium.org/783963002

Cr-Commit-Position: refs/heads/master@{#309427}

(according to issue 444343 there can be nested frameworks)

BUG=444343
TBR=earthdok@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/823573002

Cr-Commit-Position: refs/heads/master@{#309426}

BUG=444540

Review URL: https://codereview.chromium.org/819083002

Cr-Commit-Position: refs/heads/master@{#309425}

Currently these tests are utilizing the content::RenderViewTest as the base class
whereas all other *_browsertest.cc are using ChromeRenderViewTest as the base class.

Due to this, the migration of inline CSS to GRD being done in [1] is failing
for browsertests target as listed here [2] in the build log.

In order to fix this, these tests should use the ChromeRenderViewTest as their base class.
In doing so, the ChromeRenderViewTest loads ChromeContentClient which in turn loads the correct
pak file i.e. resources.pak required for the migration.

This CL adds the extensions/DEPS rule to allow the inclusion of chrome_render_view_test.h.

[1] https://codereview.chromium.org/573553002
[2] http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/14184

Review URL: https://codereview.chromium.org/818563003

Cr-Commit-Position: refs/heads/master@{#309424}

The viewer would crash because MojoMain was moved into a html_viewer
namespace. The MojoMain should remain in the default namespace.

BUG=444099

Review URL: https://codereview.chromium.org/816463005

Cr-Commit-Position: refs/heads/master@{#309423}

Due to this test currently being a browser_test, its causing issues in migration of inline CSS
resources to be part of GRD resources [1]. In order to fix this, this test has to be a component_browsertests.

BUG=283846

R=jochen@chromium.org
R=blundell@chromium.org

[1] https://codereview.chromium.org/573553002

Review URL: https://codereview.chromium.org/819573002

Cr-Commit-Position: refs/heads/master@{#309422}

TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/816373002

Cr-Commit-Position: refs/heads/master@{#309421}

Cr-Commit-Position: refs/heads/master@{#309420}

BUG=
TBR=robertphilips@google.com

Review URL: https://codereview.chromium.org/824633002

Cr-Commit-Position: refs/heads/master@{#309419}

|oobe_timer_| kept running after StopDetection() call. So in fact demo mode
detection remained active.

BUG=439956
TEST=Run 'chromeos=1' debug build with options --derelict-detection-timeout=10 --derelict-idle-timeout=10 --oobe-timer-interval=10. Enroll into enterprise domain, wait for 10 seconds at "Your device has successfully been enrolled." screen. Nothing should happen.

Review URL: https://codereview.chromium.org/821013002

Cr-Commit-Position: refs/heads/master@{#309418}

BUG=370433
TEST=unit_tests, components_unittests
R=avi@chromium.org

Review URL: https://codereview.chromium.org/814833007

Cr-Commit-Position: refs/heads/master@{#309417}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/59fc6ad..1111d8c

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/819043002

Cr-Commit-Position: refs/heads/master@{#309416}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/49a9dd4..59fc6ad

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/806223007

Cr-Commit-Position: refs/heads/master@{#309415}

R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/797503003

Cr-Commit-Position: refs/heads/master@{#309414}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/802003004

Cr-Commit-Position: refs/heads/master@{#309413}

One more follow-up patch for
https://codereview.chromium.org/761923004/#msg18
https://codereview.chromium.org/814513003/

- Split EmbeddedWorkerDevToolsManager into two, Shared- and ServiceWorkerDevToolsManager, and made them inherit from EmbeddedWorkerDevToolsManager
- Renamed EmbeddedWorkerDevToolsAgentHost to WorkerDevToolsAgentHost
- Renamed EmbeddedWorkerDevToolsManager to WorkerDevToolsManager

BUG=443470
TEST=SharedWorkerDevToolsMangerTest\*

Review URL: https://codereview.chromium.org/817653002

Cr-Commit-Position: refs/heads/master@{#309412}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3b40ee6..6cc53f3

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/817993002

Cr-Commit-Position: refs/heads/master@{#309411}