- 06 Jan, 2020 40 commits
-
-
Caleb Rouleau authored
Apparently since nexus5x is running Android M, these results are not useful to Angle developers. R=jmadill@chromium.org, ynovikov@chromium.org Bug: 1030840 Change-Id: I1883bba49c8b471cc73746dcc15dfaf8764c6e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986971Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#728604}
-
Xianzhu Wang authored
Add the container's paint offset to resizer's visual rect to ensure correct invalidation on change of paint offset. Bug: 1036824 Change-Id: I4fc5caa2364c62d415dd54cb54f42bdca525ea81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986431Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728603}
-
Gabriel Marin authored
We have been collecting only LBR callstacks for microarchitectures that support LBR call-stack mode. While LBR callstacks work in the absence of frame pointers, the LBR buffer is populated only while the profiling is enabled. Because we collect profiles for short periods of time, the callstacks are missing the lower stack frames, making them less suitable for performance debugging. Collect both FP and LBR callstacks for these microarchitectures. Restructured the commands initialization code to define the perf events commands separately based on microarchitecture, to limit the explosion of cases when all commands are defined together. Shortened command names by removing 'Record' from their prefixes. BUG=b:144819387 Change-Id: I2ec2b2b2b6bb42bbbfaf023380c6e3bd675f2b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982787Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#728602}
-
Ian Clelland authored
These tests were flaking on the Win7 bot, and have been disabled for now. Bug: 1039250 Change-Id: I5e31822fbc197a4c661fb1af46319a9138a9a573 TBR: rayankans@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988590Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#728601}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a5a89d8b8dd5..32eff228855c git log a5a89d8b8dd5..32eff228855c --date=short --first-parent --format='%ad %ae %s' 2020-01-06 lalitm@google.com trace_processor: delete unused tables Created with: gclient setdep -r src/third_party/perfetto@32eff228855c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I10c42eb30b4cc5d9d72ee25468397ff82b179f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728600}
-
Xinghui Lu authored
This CL: 1. Set SYNC_PASSWORD_REUSE_WARNING_ENABLED to true on Android. 2. Move enterprise reporting extension code under OS specific flag. 3. In page_info_strings.grdp, include password protection strings on Android. Next CLs: Implement modal dialog on Java side, and wire it with native code. Bug: 1036042 Change-Id: I9ad2fd1c4288ab06aa1ac7653d4215775d6658c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979595Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728599}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bddaf4b27a80..ce09fb43963c git log bddaf4b27a80..ce09fb43963c --date=short --first-parent --format='%ad %ae %s' 2020-01-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-06 fmalita@chromium.org [skottie] cleanup: move transform & camera adapters to own CUs 2020-01-06 jlavrova@google.com Fix a bug with unresolved text 2020-01-06 csmartdalton@google.com Add a commandline flag to force offscreen rendering in viewer 2020-01-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-06 bsalomon@google.com Handle insane number of glyphs in GrAtlasTextOp. 2020-01-06 mtklein@google.com minor SkVMBlitter TODOs Created with: gclient setdep -r src/third_party/skia@ce09fb43963c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1018511 Tbr: jvanverth@google.com Change-Id: I02971bc5abd2b8428e471c0a6e6203425ac765f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987208Reviewed-by:
-
Adrienne Walker authored
This code was added as a part of idb mojo-ification in this patch: https://codereview.chromium.org/2727733004#msg2 From comments in that code from three years ago, this cleanup is only a potential optimization to close pending transactions that would be aborted anyway. It seems fine in the short term to remove this optimization. This does bring up some future questions about how the renderer/browser will communicate with IndexedDBDispatcherHost (which will almost live in storage service), and in that world it will be easy to hook this back up if needed by adding a mojo disconnect handler. Bug: 1015212 Change-Id: Ie02f7c7a925b2296d7403fa542852e912e329246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986915Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#728597}
-
Mason Freed authored
In [1], two tests were disabled for Mac/Win because they give different accessibility trees in blink mode when run on Mac/Win vs other operating systems. In this CL, these two tests are separated out for Mac/Win so that they can have different blink baselines. [1] http://crrev.com/c/1967608 Fixed: 1038813 Change-Id: I8fb0a54fbba21e855779ca20670fdc071b59239d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986617 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#728596}
-
Philip Rogers authored
recorded_viewport is only used as a temporary in PictureLayer::Update. Change-Id: I60697e3d5e83d9634f09081fddd7fa6093cd328a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988589 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728595}
-
Ali Juma authored
This increases the timeout used when waiting for a web state after switching to desktop or mobile mode from 10 seconds to 15 seconds. The previous value (10 seconds) had been chosen since that was sufficient to fix flake locally when this test was converted to EG2. Bug: 1037663 Change-Id: I37c56cb30ab1158b36c95d88a53b2e45ea009cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988488Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#728594}
-
Koji Ishii authored
Following bot results are included. 838 839 840 841 842 843 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I4d172226ac2046939bc95d5147e3ce36a070a386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980607Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#728593}
-
Gauthier Ambard authored
This CL sets up the new design of the security page info, creating the flag and the files needed. - The existing PageInfoVC is renamed LegacyPageInfoViewController - A new PageInfoViewController is created - A new PageInfoCoordinator is created - A features file is created (with the feature inside) - BrowserCoordinator is instantiating the old/new coordinator based on the feature - The call to display PageInfo depends on the feature state Bug: 1038919 Change-Id: Ia42620e99c0343a7ee8bdc5838145aa9c5ed4f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986825 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#728592}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf50f7748442..ed0cc5f6fd8e git log cf50f7748442..ed0cc5f6fd8e --date=short --first-parent --format='%ad %ae %s' 2020-01-06 gbeaty@chromium.org Add flag to "git cl format" to avoid invoking clang-format. 2020-01-06 gbeaty@chromium.org Fix the --no-python flag for git cl format. 2020-01-06 ehmaldonado@google.com presubmit_support: Add timeout to presubmit tests. 2020-01-06 ehmaldonado@google.com depot_tools: Remove third_party/httplib2. 2020-01-06 dbeam@chromium.org Exclude ES imports from long lines check 2020-01-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ed0cc5f6fd8e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1028829,chromium:979330 Tbr: agable@chromium.org Change-Id: Ica8ccd14e0743fea67077c009802f1ab97d300a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988370Reviewed-by:
-
Carlos IL authored
Bug: 1037147 Change-Id: I775c6a40cf8adc2433f0daf34d58cb4722586845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988586 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#728590}
-
Carlos IL authored
Most mixed content autoupgrade histograms will be used for the mixed image autoupgrade launch targeted for 81, this CL extends them to 82 so we have a buffer to monitor data. This also marks MixedAutoupgrade.Websocket.Status as obsolete since we are no longer doing autoupgrades for websockets (and the histogram is no longer being recorded as a result). Bug: 1037596, 1037150, 1037149, 1037148 Change-Id: I7ae1a22c82f68a1d9413f8298bba783f66b889d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987189 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
-
Chris Mumford authored
MainThreadSchedulerImpl::update_policy_closure_ was already initialized using base::BindRepeating, so switching the definition to use base::RepeatingClosure. Bug: 1007835 Change-Id: I27a780a3bc7e501a19d1c08bdb7df35ea5ae8b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982795Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#728588}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d3a10a0399c1..2478e62054cf git log d3a10a0399c1..2478e62054cf --date=short --first-parent --format='%ad %ae %s' 2020-01-06 khokhlov@google.com Reland "Reland "Reland "[Telemetry] Make proto trace format the default""" 2020-01-06 sullivan@chromium.org Add rect based speed index back to loading metric. Created with: gclient setdep -r src/third_party/catapult@2478e62054cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028612 Tbr: nuskos@google.com Change-Id: Iab794a9c4a87ecf655d36d319eff2d4512662b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988489Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1031d2c65b5e..3311ef65680e git log 1031d2c65b5e..3311ef65680e --date=short --first-parent --format='%ad %ae %s' 2020-01-06 j.vigil@samsung.com update date comments to 2020 Created with: gclient setdep -r src/third_party/angle@3311ef65680e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I40b49f28e0d3f64b523956b92f0fb992c1ae701b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988163Reviewed-by:
-
Andrey Kosyakov authored
This switches from using ThreadScheduler::Current()->DeprecatedDefaultTaskRunner() (which happens to be null in workers) to an ExecutionContext-specific task runner. Bug: 1022796, 957651 Change-Id: I19b290f8c3fa758906ba89faa695a9ce57684aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986921 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#728585}
-
Kurt Horimoto authored
InfobarBannerOverlayCoordinator is a coordinator that will be shared amongst all infobar banners. InfobarBannerOverlayMediator is a superclass that implements behavior shared amongst all InfobarTypes, such as setting the consumer, dispatching responses for user interaction events, and setting up the overlay completion response. This CL also introduces the response infos necessary for banners: - InfobarBannerConfirmButtonTapped is dispatched to notify the model layer that the main button on a confirm infobar banner was tapped. - InfobarBannerModalButtonTapped is dispatched to notify the model layer that the modal button was tapped. - InfobarBannerCompletion is used a completion response and stores whether the dismissal was user-initiated. Bug: 1030357 Change-Id: Icb19d2a7322fd6c765c19812c02d46dcba07b97c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986449 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#728584}
-
Peter Kasting authored
Many callers want to do things like "if the link would open in the current tab, open in a new foreground tab instead". This provides a simple way to do that. Bug: none Change-Id: Ia49088031543905ad4d1d0122a8656c675a33e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986122 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728583}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b11f995..1ca8124e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e4a53b083406b3579bf444890619c199b6444ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988295Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728582}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3716c2068ef3..19b43a602225 git log 3716c2068ef3..19b43a602225 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 bclayton@google.com IDs: Move inline impls below class. 2020-01-06 bclayton@google.com Pipeline: Store builtins on SpirvRoutine... 2020-01-06 bclayton@google.com Style: clang-format the tests source too 2020-01-06 bclayton@google.com Merge changes Id1120acb,Ifc6afcda,I8b5da04a,I9389ad9e,I35d60f68 Created with: gclient setdep -r src/third_party/swiftshader@19b43a602225 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If2425c68f953732fe9d61fa7eb96b88c24f9171a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988491Reviewed-by:
-
Samuel Huang authored
Courgette's ARM support was complex and was never used (except for helping to prototype Zucchini's ARM flow, which is WIP). Recently the code is also causing Fuzzer issues. Therefore we deem it better to just remove the code. This CL performs superficial removal of ARM code. For compatibility, the enums enum ExecutableType { EXE_ELF_32_ARM = 3; } enum EncodedProgram::OP { MAKE_ELF_ARM_RELOCATION_TABLE = 7; } are deprecated and commented out, without changing other values. Bug: 1012592 Change-Id: Iad3a3c9e41470eef8ff004591e6ed42ea4315d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986211Reviewed-by:Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#728580}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d0015fb415a4..25b001799ea6 git log d0015fb415a4..25b001799ea6 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 aerotwist@chromium.org Adds known errors to include expanded namespace Created with: gclient setdep -r src/third_party/devtools-frontend/src@25b001799ea6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ief430cbb8fcee159be6507a6637bc982b08a9796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988502Reviewed-by:
-
Avery Musbach authored
When you start dragging a window from overview and drag to another display, the drop target on the destination display shall be in the correct position according to MRU order. Test: ash_unittests All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.DropTargetPositionTest/0 Bug: 961170 Change-Id: I5eb0dd2e7ce94654c13810b3bb0e5adfb468a707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984753 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#728578}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3d45c872224d..3a46886a357c Created with: gclient setdep -r src-internal@3a46886a357c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:992974 Tbr: jbudorick@google.com Change-Id: Id08835d46a5b9d2e9e79ae318e2b3d54d47fe215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988501Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728577}
-
Mia Glaese authored
MVP with the same functionality as the current TabswitcherModeTTPhone Toolbar, except for the animations. Screen videos here: https://drive.google.com/drive/folders/1bqxiTsr5SSX2p73eZrLao7GRA5ZwIkLw?usp=sharing In follow up CLs: Add animations. Dynamically remove Google logo depending on screen width. Dynamically change toolbar with OverviewModeState. Add identity disc. Bug: 1025296 Change-Id: I6b48b7854088469638a2a4cb22829f24c1e98fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975051Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#728576}
-
Dave Tapuska authored
When a vtable was added to WebKeyboardEvent in crrev.com/547be407 the CFI bot started failing because it was in fact detecting a bad cast. The test never failed before because the cast was to super class that the pointer was actually of and CFI couldn't detect this. BUG=836826 Change-Id: I4dac686561120ec5d363ddccdd47b29629d7389a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988247Reviewed-by:
-
Lucas Furukawa Gadani authored
This tests used to fail without viz enabled, but now viz is launched on ChromeOS as of r726484. Bug: 1006633 Change-Id: I0809e9dca62b3e0b5b3e8e3ee014675279ee6ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980506Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8db9eccc0baf..40801e31ed0c git log 8db9eccc0baf..40801e31ed0c --date=short --first-parent --format='%ad %ae %s' 2020-01-06 johnkslang@users.noreply.github.com Merge pull request #2050 from ShchchowAMD/built_in_MaxVector Created with: gclient setdep -r src/third_party/glslang/src@40801e31ed0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Id7d6e06d5ab333ed7ca84b5561d4de80b4931a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988162Reviewed-by:
-
François Doray authored
The crash stack on the bug is in non-TabManager code. Let's see if the test passes when re-enabled. This CL also: - Splits the test in 2 tests to avoid timing out (local tests show that we can time out when having too many navigations in the same test). - On ChromeOS, allows discarding of the active tab in the last focused browser window if that window is not visible. Previously, the active tab in the last focused browser window was not discardable, even if the window was not visible. Bug: 772839 Change-Id: I18552a16361c8beb4d48409227b727a40cc40ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972570 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#728572}
-
Tarun Bansal authored
These tests check the Prerender implementation which has been replaced by NoStatePrefetch. Prerender used to load the full webpage while NoStatePrefetch only runs preload scanner and fetches subresources found by preload scanner. No JavaScript is executed. This makes it possible to remove some of these deprecated browsertests. Change-Id: I02bbea1494de0c67ee0447887df98a069538726b Bug: 846318,755921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985166Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#728571}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6be45ec41f27..bddaf4b27a80 git log 6be45ec41f27..bddaf4b27a80 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 mtklein@google.com in gm/skvm.cpp, Fade doesn't need to wrap a shader 2020-01-06 jcgregorio@google.com Don't use CIPD_PKG_CPYTHON for P30. Created with: gclient setdep -r src/third_party/skia@bddaf4b27a80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I82d06c0b31318a0e7ca95997326537bbdcadecb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988495Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0a29f6fe80ef..a5a89d8b8dd5 git log 0a29f6fe80ef..a5a89d8b8dd5 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 lalitm@google.com Merge "perfetto: force linkstatic for all cc_library targets" 2020-01-06 lalitm@google.com Merge "trace_processor: add parsing and ingestion of mm_id of rss_stat" 2020-01-06 lalitm@google.com Merge "ui: fix process slice track" Created with: gclient setdep -r src/third_party/perfetto@a5a89d8b8dd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I741cc1c846b169633704554f08d7e0c1f9d8f1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988494Reviewed-by:
-
Olivier Li authored
Bug: 546640 Change-Id: I44db98e1cc68a91407c783b84dc2f79ce3aba432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978040 Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#728568}
-
Stephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=sadrul@chromium.org,vmiura@chromium.org BUG=1039344 Change-Id: Ib4d1567010f972ad1d58305f2d17d0430e45039f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985677Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728567}
-
Rakesh Soma authored
per [1]. [1] https://docs.google.com/document/d/1zDUlxBwkhNXBQRNifEjK2fylRKE7WmYALej1u-bzshk Change-Id: I641595027b2e4571d44431486ac2ef2105b586c6 Bug: 1038515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973359Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#728566}
-
Stephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=mythria@chromium.org,ulan@chromium.org BUG=1039295 Change-Id: I418cf1c1be64257871972520008cf61749fa6032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988546Reviewed-by:
-
