GitLab

This CL marks InputEventPrediction.Accuracy metrics obsolete and also
removes related code.

The Accuracy.Scroll.* metrics is replaced by new prediction metrics
introduced in crrev.com/c/1764409
Mouse* and Touch* are lack of use now so they are safe to remove.
Similar new metrics will be add for Mouse/Touch too.

Bug: 988625
Change-Id: Ic86de9e27c370f7ea5f6b01880b899ff11fd6867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849093
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707921}

In http://crbug.com/957175, wanderview@ added an optimization for
BlobReader where it would add an extra hop when finishing a stream.
Many blobs size mojo::DataPipe to exactly fit the blob size, and so
this can be quite common.

As SourceStreamToDataPipe is going to be used in this CL
(https://chromium-review.googlesource.com/c/chromium/src/+/1830360),
that optimization needs to be carried forward.

Bug: 1012869,957175
Change-Id: I9f7fc006b633a248fe3b726ac78d1fe4773472a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862253Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707920}

Bug: 989131
Change-Id: I2245020cc33911dfba7e1bc1942168c3321b5e58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869338
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707919}

This reverts commit a88c5fe6.

Reason for reland: The test was/is flaky on that bot in the first place,
                   the name change just makes it look different.

Original change's description:
> Revert "Adjust tests for upcoming cross-site cookie requirements"
>
> This reverts commit 83b71438.
>
> Reason for revert: SitePerProcessSSLBrowserTest.UnloadHandlersArePowerful*
> failing on Android. Please see bug.
>
> Bug: 1014956
> Original change's description:
> > Adjust tests for upcoming cross-site cookie requirements
> >
> > They will need to be marked explicitly and secure, so adjust some tests to
> > be over SSL and mark those cookies appropriately
> >
> > Bug: 1006816
> > Change-Id: I6da53ea64a7c03530335913fadb9099992e8ca33
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863389
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#706108}
>
> TBR=avi@chromium.org,morlovich@chromium.org
>
> Change-Id: I982bc1590171f92883000c8315d3be77f7b35b9f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1006816
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865249
> Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
> Cr-Commit-Position: refs/heads/master@{#706453}

TBR=avi@chromium.org,parastoog@google.com,morlovich@chromium.org

Change-Id: I51c863c89ade36edddc4b1b7a3f16d82c9f855f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1014956, 1006816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866614Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707918}

Per instructions on the Unido design doc [1], this is the first step in
the process of creating a new Unido feature:

1) Add a new SharingMessage to the proto and update metrics mapping
2) Add your new SharingFCMHandler in SharingService constructor
3) Add a new feature in DeviceInfoSpecifics.EnabledFeatures
4) Add your enabled feature to SharingDeviceRegistration
5) Use SharingService to list device candidates, and use the new SendMessageToDevice to send messages

Steps (2-5) will follow in separate CLs, to ease reviewing and ease
other features tracking how to integrate.

[1] https://docs.google.com/document/d/1tvrKCEOaQuZv_j6j61ij_r9sjFlI25x8M8rIRL1DTsA/edit#

Design Doc: https://docs.google.com/document/d/1da8CjO71DlFbBzDcSosFRXTvDsKII_XMCohpZLQ_QbM/edit?userstoinvite=himanshujaju%40google.com&ts=5da89bb1&actionButton=1

Bug: 1015645
Change-Id: If41831a2e71ec88b4771c739be18fd17c18ac6f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867444
Auto-Submit: Sam Goto <goto@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707917}

Spec: https://w3c.github.io/webrtc-svc/
Intent to implement: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/--ZpYlTo6LE/h0RzUIWkAAAJ
Chrome dashboard: https://www.chromestatus.com/feature/5769626174619648

Bug: 986069
Change-Id: Ia8f2cb90ec26eb83528f0f45acbc5ccbdf2ad030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868989Reviewed-by: Florent Castelli <orphis@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707916}

This allows custom implementations that can share base functionality.
This is needed since instances must be created to control both web views
and cast apps.

Bug: b/136460199
Test: Compile cast_shell
Change-Id: Id19507b3127f4bd2071e02f4b2cd4ec931c7ea71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872466Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#707915}

This reverts commit 3692f7b0.

Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg/1638

Original change's description:
> [web_engine] Add "web_engine_shell" standalone executable.
> 
> Implements a simple standalone executable which will launch a fullscreen
> browsing session and navigate it to a given URL. Similar to
> content_shell, but using Web Engine instead.
> 
> The flow is kept deliberately simple and linear so it can serve as a
> functioning code sample for aspiring embedders of Web Engine.
> 
> The shell can be used to test arbitrary static data, which is sourced
> from //fuchsia/engine/test/shell_data and hosted under the content URL
> fuchsia-dir://shell-data/ .
> 
> The shell can also optionally request that the DevTools server be
> started at a port specified on the command line.
> 
> Bug: 1016485
> Change-Id: I09ad56f20553acc83fbf38924fa3e8d8a98a1200
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869887
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707911}

TBR=ddorwin@chromium.org,kmarshall@chromium.org

Change-Id: Ib38a55b43411e01d49fffdf92f268fdf3c4db187
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1016485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872719Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707914}

In crbug.com/1012775 we are unifying how trivial 3d transforms are
handled across platforms by making them not a compositing hint. This
caused performance regressions on tough_compositor_cases which were
using trivial 3d transforms as a compositing hint.

This patch updates tough_compositor_cases to be more explicit about
layer triggers by using "will-change: transform".

Bug: 1012775, 1016320
Change-Id: I1734e885ec287d1ca608f7a70674b8b0f74b6b36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872177
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707913}

This is a reland of 18c60acc

This should not be flaky anymore after http://crrev.com/c/1869849

Original change's description:
> [WebLayer] Implement executeScript() on BrowserController
>
> This adds a way to execute javascript in WebLayer. The script will be
> executed in a weblayer isolate that will not be able to access any
> scripts from the page.
>
> Change-Id: Ia17bd8476b5d9247d5761f0af24cd4d61edaccb2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867300
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707455}

TBR=sky@chromium.org

Change-Id: I6b1e1763b0a89345a5d0b96d2f42170978343695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872658Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707912}

Implements a simple standalone executable which will launch a fullscreen
browsing session and navigate it to a given URL. Similar to
content_shell, but using Web Engine instead.

The flow is kept deliberately simple and linear so it can serve as a
functioning code sample for aspiring embedders of Web Engine.

The shell can be used to test arbitrary static data, which is sourced
from //fuchsia/engine/test/shell_data and hosted under the content URL
fuchsia-dir://shell-data/ .

The shell can also optionally request that the DevTools server be
started at a port specified on the command line.

Bug: 1016485
Change-Id: I09ad56f20553acc83fbf38924fa3e8d8a98a1200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869887
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707911}

The 99th percentile of TouchpadPinch latency exceeds the 100ms max.
This patch updates to TouchpadPinch2 with a max of 1 second, or 1000ms.

Change-Id: I58bcc7fd8ee441043bdb0482f15e58c70368f954
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834679Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707910}

Use ProfileManagerObserver::OnProfileAdded instead.

Also worth noting that this removes an obsolete superclass from
UserCloudPolicyManagerChromeOS, i.e. KeyedService. Both KeyedService
and ConfigurationPolicyProvider have a "virtual void Shutdown()"
so this removes that collision (not that it was doing any harm).

Bug: 268984,171406
Change-Id: Ia0b3dd4dd34a0f62e84dd057928d61c5677231d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854525
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707909}

Bug: 952034
Change-Id: I6debbcb4e8474cacdcd8b5add471a9c04c0a4dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853862
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707908}

When a navigation to the wrong URL begins, the prerender in
NavigationPredictor should be stopped, and no new prerenders should
begin. Due to mojo magic, it is hard to stop the case of a navigation
starting followed by load event finishing followed by commit. As such,
that case will still begin a prerender, but it should be relatively
rare.

Bug: 1016212
Change-Id: I1e406c877dd7c8d73d8d29efdbcfc2bde35bbdc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872744Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707907}

Change-Id: Ie1d9dadc454b36fdd4bf1c3f07e336fd49536f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872739Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707906}

crrev.com/c/1863950 introduced a visibility check, that causes multitasking
tests to fail.  Since the goal of 1863950 was to migrate to EG2 and keep the
tests the same, removing visibility check here.

Bug: 1016283
TBR: eugenebut@chromium.org
Change-Id: I45e7fff55fce5fd987dc712931809bad442bf164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872565
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707905}

The original CL caused flakiness of /virtual/threaded/animations/animationworklet* tests
(crbug.com/1014966). The reason for the flakiness is change in timing of main thread effect local
time update.

Reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1826872
The reverted CL is in Patchset 1.
Patchset 2 fixes the tests by explicitly waiting for the effects to change.

This CL changes how local time of composited worklet animations is updated on main thread:
instead of polling local time on main thread, the local time is posted via animation events
by the composited thread to the main thread.

Design document: https://docs.google.com/document/d/1vUxaKBLDHQv9ACJUQJH4RXjuQTlWIsSiAFYkMrjccyc/edit?usp=sharing

Changes made:
- Expanded AnimationEvent to support worklet animation time update event type.
- Reused existing mechanism of posting animation events to the main thread to support new
  event type.
- Removed "peek" logic.
- Enabled tests that previously failed.

Bug: 943787
Change-Id: I9a2965f204cad15b405be82305c38788c0eafd62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864518Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707904}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1d2ab0dfbb1b..d578b2973f62

git log 1d2ab0dfbb1b..d578b2973f62 --date=short --no-merges --format='%ad %ae %s'
2019-10-21 chrome-bot@chromium.org Update config settings by config-updater.
2019-10-21 shaochuan@chromium.org Make betty-pi-arc-release non-experimental

Created with:
  gclient setdep -r src/third_party/chromite@d578b2973f62

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I0d6bc00b0fd0565be50a6808d2d6cefc3b972f9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872238Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707903}

https://webrtc.googlesource.com/src.git/+log/72cc71cd70d4..eef5e4ffc239

git log 72cc71cd70d4..eef5e4ffc239 --date=short --no-merges --format='%ad %ae %s'
2019-10-21 mbonadei@webrtc.org Remove dep between test:test_support and rtc_base_approved.
2019-10-21 ssilkin@webrtc.org Reset end-of-frame flag in non-VCL packet.
2019-10-21 danilchap@webrtc.org Avoid DEPRECATED_SingleThreadedTaskQueueForTesting::CancelTask in VideoAnalyzer
2019-10-21 danilchap@webrtc.org Clarify NetworkControl interface: result of each function must be used
2019-10-21 danilchap@webrtc.org Update call Rampup tests not to rely on DEPRECATED_SingleThreadedTaskQueueForTesting
2019-10-21 jakobi@webrtc.org Change failing rtc::dchecked_cast to rtc::saturated_cast.

Created with:
  gclient setdep -r src/third_party/webrtc@eef5e4ffc239

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:999807,chromium:None,chromium:1016147
Change-Id: I2ef7e4c518655482bcfca9b90757a353c3c8baa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872235Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707902}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63aaa927a3c7..e5b6f3adef16


Created with:
  gclient setdep -r src-internal@e5b6f3adef16

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I577532fb8f460aefc0ddaf948068c7f1fbdff2d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872122Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707901}

https://chromium.googlesource.com/angle/angle.git/+log/4a80ba25e67b..f228038ddeb4

git log 4a80ba25e67b..f228038ddeb4 --date=short --no-merges --format='%ad %ae %s'
2019-10-21 courtneygo@google.com Treat Pixel 2 XL and Pixel 2 the same

Created with:
  gclient setdep -r src/third_party/angle@f228038ddeb4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@google.com

Bug: None
Change-Id: I2e7b544d2a6602264d9c22625ed57e5f4aeeb05b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872123Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707900}

This reverts commit 55a4bb68.

Reason for revert: Causing crashes - crbug.com/1016233

Original change's description:
> Kill quiet permission requests if a new request is made
> 
> Bug: 1014026
> Change-Id: I5fe93b9bc7b39873900d9e15dcba66dfddd7c4ef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860015
> Commit-Queue: Andy Paicu <andypaicu@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706445}

TBR=engedy@chromium.org,andypaicu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1014026
Change-Id: I4e0f0120e3f7d2b9711d122bb186012c5d06464d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871632Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707899}

Use enum class instead of enum for ShadowType
enum class is more type safety.

Bug: 940736
Change-Id: Ib816aa59a3b1ad67738050a1b9d5fd00b7140482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868535
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707898}

Only invalidate for  high contrast and dark mode if the system colors
changed, if the preferred color scheme changed, if the state of high
contrast changed, or if the state of dark mode changed.

Bug: 970285
Change-Id: I6da9787b84ba3790a94df5b961c6e1ec2a762270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869758Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707897}

When closing the last incognito tab, the incognito page is no longer
the active page. It should be updated.

Bug: 1011054
Change-Id: If2df5c8398bbc13ea533652296dbf124a63d650c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872158
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707896}

Bug: 1014959
Change-Id: I4c6d1ef64376815412082a7c430f8df929598d26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869670Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707895}

These timeouts are ancient. The test infrastructure has its own
timeouts, which should make these obsolete. Also, this may help with
https://crbug.com/869227, where starting the Python test server
times out.

Bug: 869227
Change-Id: I9ea4f3174bcaa86daf09b965c82921432d8d556a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869717
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707894}

Ux requirement

Change-Id: If4d4e4320dc88d6d4380a7154cf105109834c3b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867629Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@google.com>
Cr-Commit-Position: refs/heads/master@{#707893}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cf414fd4..91b5a03b

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Icce8c0213eb9d124c1d70f80475e1ebfc0a3a8d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871893Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707892}

These histograms are useful to diagnose regressions to
Startup.FirstWebContents.NonEmptyPaint2. In particular, we need these
histograms to analyze the impact on the ongoing project of merging
chrome.dll and chrome_child.dll.

Per discussion with rkaplow@:
"startup performance is important enough that the barrier to have then
be very long lived is low. Plus - they are the opposite of spammy. So
I would keep them unless you don't think they'll ever be useful."

Bug: 969963, 972795
Change-Id: Ice95c0e6ff68b0762a345119e5f95d3a8dfa5f19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872313
Auto-Submit: François Doray <fdoray@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707891}

HasFinishedInitialSetup() is expected to be removed and replaced by
IsFirstSetupComplete().
Replacing HasFinishedInitialSetup() in:
  + first_run_egtest.mm
  + settings_table_view_controller.mm

Bug: 951313
Change-Id: Id509a68e0bbb72702c7df8e3581f64c7996ccb51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833610Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707890}

Instructions for enabling Android shortcuts:
https://developer.android.com/guide/topics/ui/shortcuts/creating-shortcuts

This is the first step for enabling shortcuts. The server will populate
shortcuts.xml depending on the Manifest shortcuts provided (and also
generate additional string resource files).

Bug: 1010471
Change-Id: I2e0a6118a22869766e4b5e849dabc6533cd2d306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864805Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707889}

Currently the usual way to turn a CommandDispatcher pointer into
something that can have methods called on it is to static_cast() it
into id<Protocols>, which compiles but has no runtime correct check.

+conformsToProtocol: can't be used here, since that just checks a class
interface, and doesn't work on a dynamic object like CommandDispatcher.

This CL adds a function-like helper macro for use with CommandDispatcher.
It does both typecasting and a runtime check that the dispatcher can
handle the methods in the protocol.

A macro is necessary to generate the correct static_cast expression that
matches the protocol whose methods are being checked. Believe me, if
there was another way to do this, I'd use it,

The helper matches the behavior of ObjCCastStrict, returning nil and
DCHECKing if the dispatcher doesn't handle the specified protocol.

Note that while the dispatcher's startDispatchingToTarget:forProtocol:
method doesn't handle protocols that the passed protocol conforms to,
CallableDispatcher does, so composite protocols can be used when the
callable needs to conform to multiple protocols.

Change-Id: I49953ed89d76cbe6e714abec226161f927ebb60f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866751
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707888}

Bug: 1016045
Change-Id: I001e8fde3058b318f81af9061f3747e10f5e39f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870050Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707887}

This reverts commit 9b44d19a.

Reason for revert: This was reverted to revert a upstream change that
breaks lsan/msan bots. The upstream change with the fix has landed,
so reverting this.

Original change's description:
> Revert "overview: Clipping for windows using new grid layout."
> 
> This reverts commit 9ed68bfb.
> 
> Reason for revert: Revert to revert upstream change
> https://chromium-review.googlesource.com/c/chromium/src/+/1872011
> 
> Original change's description:
> > overview: Clipping for windows using new grid layout.
> >
> > Extracts parts of the regular grid layout function into a helper, which
> > is then used by the new grid layout function.
> >
> > Test: manual
> > Bug: 1011973
> > Change-Id: I7bdf40227bbd1df467ea9d56bc84e58b01c12f33
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867271
> > Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#707460}
> 
> TBR=xdai@chromium.org,sammiequon@chromium.org
> 
> No-Try: true
> Bug: 1011973
> Change-Id: I675fb57809d190ca9266d012885269dcea2401c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872012
> Commit-Queue: Ella Ge <eirage@chromium.org>
> Reviewed-by: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707787}

TBR=xdai@chromium.org,sammiequon@chromium.org,eirage@chromium.org

Change-Id: I30fda5ce6ec77e08cd6d1978fefa74a4c65dc850
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1011973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872567Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707886}

Tests in OverviewWindowDragControllerDesksPortraitTabletTest used to
return early if kShelfHotseat feature is enabled by default.

This CL makes this test suite parametrized and runs is with
kShelfHotseat enabled and disabled. Enabled branch still
returns early, but disabled runs normally.

Bug: 1011128
Test: OverviewWindowDragControllerDesksPortraitTabletTest
Change-Id: Ic705435207bb26c8dd98f8debad0960ec25c339c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871733Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707885}

After the removal of the LongTaskV2 flag, SubTaskAtrribution is never
used. This CL removes the class and related code.

Bug: 738493
Change-Id: I2ecb5146bc6375daa6d131ed700fc0b257282186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869013
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707884}

Test flaky on Mac and Linux debug bot

TBR=masonfreed@chromium.org

No-Try: true
Bug: 1016457
Change-Id: I7a09aade8fedcc3dd21ab06a2d1af379706e6d98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871637Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707883}

This reverts commit f72a8099.

Reason for revert: in-flight conflict with
734ea5e7

Original change's description:
> WebLayer: add tests for DownloadDelegate
> 
> Credit to sky@ for EventUtils.java (salvaged from
> 47bd294d, which got reverted)
> 
> Bug: none
> Change-Id: Iadb75c6b9c77185536c753504b6cefa1ba4796de
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866987
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707864}

TBR=sky@chromium.org,estade@chromium.org

Change-Id: I5d2d6604fb0e2e633ac65109d23da7eb2826e6a1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872746Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707882}