- 25 Jan, 2018 40 commits
-
-
Tsuyoshi Horo authored
This CL implements the following classes: - SignedExchangeHandler - WebPackageLoader - WebPackageRequestHandler But Currenly SignedExchangeHandler doesn't implement any CBOR parsing logic nor verifying logic. It just behaves as if the passed body is a signed HTTP exchange which contains a request to "https://example.com/test.html" and a response with a payload which is equal to the original body. The added LayoutTest "origin-signed-response.html" must pass only when SignedHTTPExchange feature is enabled. Bug: 803774 Change-Id: I53d397d7cdfe79d48d6891db65ab1a1e12100b92 Reviewed-on: https://chromium-review.googlesource.com/869872 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#531921}
-
Peter Boström authored
This is a cleanup remaining from previous refactoring that renames several dialogs to a shorter/more concise name. TBR=tapted@chromium.org Bug: chromium:654115 Change-Id: Ib404d65fc8b19d42cbcd9f5731a300759badd6e1 Reviewed-on: https://chromium-review.googlesource.com/885001 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#531920}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/62619cb4a9ae..8d63750dfb6f $ git log 62619cb4a..8d63750df --date=short --no-merges --format='%ad %ae %s' 2018-01-25 perezju [Telemetry] Migrate Android browser and profile directories Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9635b2a2b8f033a9a0298af3007f64f3885eb171 Reviewed-on: https://chromium-review.googlesource.com/886647 Commit-Queue: <catapult-deps-roller@chromium.org> Reviewed-by: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531919}
-
Koji Ishii authored
ResolveWidth and ResolvedHeight expects border-box of content size, but ComputeFullAbsoluteWithChildBlockSize gives content-box and causes DCHECK failures when the size is less than border+padding. This patch fixes it to pass border-box instead. Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia7bd0d89e35cf156dae78b59fe069d7d56e1539c Reviewed-on: https://chromium-review.googlesource.com/886042Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#531918}
-
Misha Efimov authored
Bug: 714018 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id80f9e1c804ad5026e16060d351ac438e191a8fc Reviewed-on: https://chromium-review.googlesource.com/868712Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#531917}
-
Mike Klein authored
While attempting to s/SK_BUILD_FOR_WIN32/SK_BUILD_FOR_WIN/g, I stumbled upon this define for bzero. Skia doesn't use bzero, and there's no good reason for skia/ext to use it either. Change-Id: I12cbc5d40c17491fe1d648540655fad156196549 Reviewed-on: https://chromium-review.googlesource.com/884007Reviewed-by:
Mike Reed <reed@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#531916}
-
Raphael Kubo da Costa authored
The include has not been necessary since commit 0921e831 ("Remove non-standard DeviceOrientation Event initializers"). R=timvolodine Change-Id: Ib134195872c395343e785e76cef21db861338fcb Reviewed-on: https://chromium-review.googlesource.com/886701Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#531915}
-
Vasilii Sukhanov authored
The test is missing expectations. 'Failure' doesn't suppress it amd 'Missing' isn't allowed. TBR=foolip@chromium.org NOTRY=true Bug: 805463 Change-Id: I0aad9cd95f47ee3c5c967d817711330ed4c68761 Reviewed-on: https://chromium-review.googlesource.com/887061Reviewed-by:
-
Emily Hanley authored
TBR=charliea@chromium.org NOTRY=true Bug: 805922 Change-Id: I8da65a3eb71a3523f507805da980bca2077ab389 Reviewed-on: https://chromium-review.googlesource.com/886653Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#531913}
-
Sadrul Habib Chowdhury authored
Switch the tab_switching benchmark to use the new TBMv2 metric for measuring tab-switching latency. BUG=802104 Change-Id: I7ab9610811b842feacf3a28845a2b267de4bfd20 Reviewed-on: https://chromium-review.googlesource.com/886003Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#531912}
-
Vasilii Sukhanov authored
GalleryBrowserTest.StopStartSlideshowOnDrive GalleryBrowserTest.OpenSingleImageOnDownloads TBR=yamaguchi@chromium.org Bug: 804413 Change-Id: I2c9e7874b8858bc9786f48fff2f3685871abae3f Reviewed-on: https://chromium-review.googlesource.com/886702 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Matthew Jones authored
This change allows theme colors to be used properly when Chrome modern design is enabled. BUG=803091 Change-Id: Id91790cc85b88f77a9affdc2c95e944b56c0f896 Reviewed-on: https://chromium-review.googlesource.com/884111 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#531910}
-
Daniel Nicoara authored
On certain platforms (ie: samus) BGRA isn't supported by the display controller. Default to a more common format (BGRX) for now. Long term we need to add a way to query for the format to avoid crashing when the default format isn't supported by the board. Bug: None Test: Ran ozone_demo on samus Change-Id: Id43aec73ece86b0b856fe69eb84abdb3687e15b6 Reviewed-on: https://chromium-review.googlesource.com/884323Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#531909}
-
Andrew Grieve authored
No behavior change expected. Change-Id: I8ae7a9889022040f911ccad9bb0cd535b7da8f9c Reviewed-on: https://chromium-review.googlesource.com/881528Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#531908}
-
Devlin Cronin authored
There are no more uses of ChromeUIThreadExtensionFunction. Remove it, and have ChromeAsyncExtensionFunction inherit directly from UIThreadExtensionFunction. Bug: 634140 Change-Id: I5a941792a8d1e2ee07d0603903c7ca52daab65ef Reviewed-on: https://chromium-review.googlesource.com/883976 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#531907}
-
Nicolas Pena authored
This CL does the following to increase WTF::TimeTicks usage: * Change the monotonic times in DocumentLoadTiming to TimeTicks. This change propagates to other Timing classes, and conversions to double are used to stop the propagation outside of timing related classes. Bug: 803956 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie718f6f1996008bd8cdb20b2a7254595e0b018d9 Reviewed-on: https://chromium-review.googlesource.com/881602 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531906}
-
Misha Efimov authored
Bug: 804891 Change-Id: I1329a27ab71dce901d8494ffeb06aecb61ab5da9 Reviewed-on: https://chromium-review.googlesource.com/881662Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#531905}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/2e551f6bc5f2..2d8e432a9e50 $ git log 2e551f6bc..2d8e432a9 --date=short --no-merges --format='%ad %ae %s' 2018-01-22 oetuaho Add ImmutableString to encapsulate some compiler strings Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I335784fb44c917ffe592ed0ece2cfd3b20366914 Reviewed-on: https://chromium-review.googlesource.com/886644Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531904}
-
Vasilii Sukhanov authored
WebViewAPITest.TestWebRequestAPIWithHeaders WebViewAPITest.TestLoadStartLoadRedirect TBR=lazyboy@chromium.org NOTRY=true Bug: 805903 Change-Id: Ib0d31c11dabaab317c97786c2e1eed6cf9a374ba Reviewed-on: https://chromium-review.googlesource.com/886942Reviewed-by:
-
Vasilii Sukhanov authored
external/wpt/mimesniff/mime-types/parsing.any.html external/wpt/mimesniff/mime-types/parsing.any.worker.html TBR=ortuno@chromium.org Bug: 800359 Change-Id: I139aa13a2484fba22e8db3fca8f4b3a38ca2a506 Reviewed-on: https://chromium-review.googlesource.com/886704Reviewed-by:
-
Joe Medley authored
Change-Id: Ie3307ac56cab921488e0c957e3c1d8cf3d1fdb54 I'm the DevRel tech writer who documents new APIs. I've added watches that help me monitor what I document. Change-Id: Ie3307ac56cab921488e0c957e3c1d8cf3d1fdb54 Reviewed-on: https://chromium-review.googlesource.com/886521Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#531901}
-
Eric Boren authored
Change-Id: I5511ee29c462124726dd66c11af1e5d0193dea8a Reviewed-on: https://chromium-review.googlesource.com/881763 Commit-Queue: Eric Boren <borenet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531900}
-
Gauthier Ambard authored
This CL changes the location bar such as its mediator is observing the currently active WebState and update the omnibox state accordingly. This is done so the BVC doesn't have to send update commands to the location bar through the toolbar. Bug: 803383 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id1ba13fc1c37e7c1a5a351dbd52c6859b44ce80c Reviewed-on: https://chromium-review.googlesource.com/883444 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#531899}
-
Colin Blundell authored
This CL changes FakeSigninManager to go through SigninManager to fire signin and signout observer callbacks. The reason is that an upcoming CL will add some more events that need to happen around the firing of these callbacks, and it is better to have that added code have to live only in SigninManager rather than be duplicated in FakeSigninManager. Bug: 654990 Change-Id: I9de195e0f1bb69754b04e578978ebe85791a6a0f Reviewed-on: https://chromium-review.googlesource.com/883529Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#531898}
-
Koji Ishii authored
Following bot results are included. 3278 3283 3287 3292 3298 3300 3307 3311 3313 146 lines were removed and 94 lines were deflaked by consecutive results since 3240. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3cdcca037dd68a2f6adbe250fcf2a2e00d5e0654 Reviewed-on: https://chromium-review.googlesource.com/884121 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#531897}
-
Mostyn Bramley-Moore authored
This should fix jumbo builds after https://chromium-review.googlesource.com/878627 Bug: 803102 Change-Id: I3a171acb28cf1a0927137e764530b31ece1f29de Reviewed-on: https://chromium-review.googlesource.com/886601Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#531896}
-
Allen Bauer authored
Change link to help (question mark) vector icon. Removed close (X) button from ConfirmBubbleView dialog bubble. TBR=lazyboy@chromium.org Bug: 654139 Change-Id: I99e58f98d449d83b0aaea3aa49acfd71912a6ea5 Reviewed-on: https://chromium-review.googlesource.com/871183 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531895}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/b9b07eaf281a..beabdcb49810 $ git log b9b07eaf2..beabdcb49 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I11f8027caa211d572c5c0c1a90256a4ee401ae5f Reviewed-on: https://chromium-review.googlesource.com/886642Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#531894}
-
Mounir Lamouri authored
Bug: None Change-Id: I834310cc536a57d6a1ab0ac86dc2ee8b78856812 Reviewed-on: https://chromium-review.googlesource.com/885764Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#531893}
-
Tommy Steimel authored
This CL adds a check in MediaControlsImpl::MaybeShow to only update the overlay play button when we're not paused for scrubbing. This fixes a bug where the overlay play button would appear on Android during scrubbing. Bug: 781721 Change-Id: If49ef77d2b4d9303d0fe147e51e622000751e8e3 Reviewed-on: https://chromium-review.googlesource.com/884761Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#531892}
-
Friedrich Horschig authored
By enabling the feature PasswordSearch, a search icon will appear in the action bar in Chrome > Settings > Save Passwords. Clicking the icon will trigger a search box that hides non-password views. Every newly typed letter will instantly filter passwords which don't contain the query. Ignores case. Update: instead of adding a new white icon, the ic_search is recolored. Update: merged with WIP crrev/c/868213 Bug: 794108 Change-Id: I9b4e3c7754bb5b0cc56e3156a746bcbf44aa5bd3 Reviewed-on: https://chromium-review.googlesource.com/866830 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This is a reland of 2e4eab14. Doesn't appear to be at fault for crbug.com/803517 as suspected. Original change's description: > Reland "Make many base:: classes constexpr default constructible" > > This is a reland of d74c23a2 > Original change's description: > > Make many base:: classes constexpr default constructible > > Same CL but extracted scoped_refptr changes to separate CL. > > > > > Bug: 800760 > > Change-Id: Ib713771347283825ff53a8517b38a8abccd9d1bb > > Reviewed-on: https://chromium-review.googlesource.com/860157 > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#528805} > > Bug: 800760 > Change-Id: Ia989d978f632075c21f11cd81687f52b9e2bd2ca > > TBR=dcheng@chromium.org > > Change-Id: Ia989d978f632075c21f11cd81687f52b9e2bd2ca > Reviewed-on: https://chromium-review.googlesource.com/863622 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528934} TBR=dcheng@chromium.org Bug: 800760, 803517 Change-Id: Ic987b883e6ccacaa0b2e26b55d875cf4b484a5cc Reviewed-on: https://chromium-review.googlesource.com/886323 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#531890}
-
kylechar authored
For not OOP-D, when destroying a viz::Display there is a sync IPC in CommandBufferProxyImpl::DisconnectChannel() that ensures the GL context/surface that draw to the platform window are destroyed. The platform window is destroyed after that sync IPC which ensures the GPU doesn't try to swap to a buffer that doesn't exist. Currently for OOP-D, HostFrameSinkManager sends an async IPC to the GPU process asking it to destroy the viz::Display. The browser process destroys the platform window after sending the async IPC. The GPU may try to swap to a buffer that doesn't exist and error/hang/crash. Add a sync IPC, only used in the case of root CompositorFrameSinks, that guarantees the GL context/surface are destroyed. This eliminates a big source of GPU hangs/crashes with --enable-features=VizDisplayCompositor. Bug: 777594 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I70e9b031e80de233856194f1beaa9377f332c3c0 Reviewed-on: https://chromium-review.googlesource.com/874724 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531889}
-
Raphael Kubo da Costa authored
Nullable<T> has not been used in the code since commit dc5d9051 ("Add PermissionDescriptor to the permissions Mojo interface"). R=mlamouri Change-Id: I31646df8e77abf5a271a27731215ef8e041208ec Reviewed-on: https://chromium-review.googlesource.com/885847 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL fades out the primary toolbar controls during fullscreen progress. It doesn't change the location bar as it needs a special treatment. Bug: 804730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibaf8982f41c9b2e0841de6359db4f95436d39330 Reviewed-on: https://chromium-review.googlesource.com/883524 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#531887}
-
stkhapugin@chromium.org authored
Before this CL, BVC is Toolbar's delegate, which is a LocationBarControllerImpl's delegate. We would like for the LocationBarCoordinator to own LBControllerImpl fully. For this, the LocationBarCoordinator needs to become its delegate. However, the delegate is mostly forwarding commands to BVC. So after this CL: 1. BVC is the delegate for LBCoordinator. 2. BVC calls Toolbar methods for Toolbar to react to events in LB. 3. LocationBarCoordinator is delegate for LBControllerImpl. 4. Remove old TODO and related ivar in BVC. Bug: 785253, 244366 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7a735ed60a54c040437a91ff225f0c6c31e0e799 Reviewed-on: https://chromium-review.googlesource.com/881165 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#531886}
-
Egor Pasko authored
Not sure which ones would be more useful for end metrics later, let's see. Bug: 760498 Change-Id: I46a878ebf3a65ed164fa8df95b2846ed04cbde83 Reviewed-on: https://chromium-review.googlesource.com/883449 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#531885}
-
Ioana Pandele authored
The alert is displayed after the user taps on the Export passwords... button. Change the message to comply with the latest mocks. Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I778f5000f16b18c62f42bea4307a62a91ab079fc Reviewed-on: https://chromium-review.googlesource.com/886363Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#531884}
-
Mostyn Bramley-Moore authored
Change-Id: I07ce4c92bb0cb427f3cd2f1b18d48a0e15021de5 Reviewed-on: https://chromium-review.googlesource.com/883288 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#531883}
-
David Bokan authored
This fixes the attached bug since the cause is that the XTest pointer is generating window crossing events (XI_Leave/XI_Enter) when implicitly capturing the pointer for the slave device. For physical devices, these events are generated only for the master pointer. This CL fixes it by letting the crossing events pass through the filtering checks applied by ShouldProcessXI2Event. pointer_device_lookup_ stores only the master pointers so this filters out the test slave. I haven't been able to determine what makes the XTest pointer but the fix makes sense since window crossing events only make sense on a pointer and in that case we should always use the master. Bug: 683434 Change-Id: Id96dacb6db49a95fae33105de2fcfe2b9f8d1b44 Reviewed-on: https://chromium-review.googlesource.com/883601 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#531882}
-
