- 16 Jul, 2020 40 commits
-
-
Justin Cohen authored
Change-Id: Ia74705629553f7070108f76642d40cdbb7838dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300868 Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#789138}
-
Brian Sheedy authored
Refactors the GPU Telemetry code to do the following: 1. Move arguments that are used more than once to constants in a new file. 2. Standardize how browser arguments are determined. Now, tests only call either CustomizeBrowserArgs() or RestartBrowserIfNecessaryWithArgs() with any non-default args to use. The base class now handles application of child class-specific default arguments using the GenerateBrowserArgs() class method. 3. Move the --disable-metal-test-shaders argument to be applied to all GPU tests, not just WebGL ones. Bug: 1085899, 1090480 Change-Id: I9f73d5953420cb5b5c8bd3f71d4b091751a92595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300801 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#789137}
-
Scott Violet authored
ThumbnailDatabase takes a HistoryBackendClient, but it doesn't actually use it. This removes the unnecessary argument/field. BUG=1076463 TEST=covered by tests Change-Id: Ib1566a8ec2cd5eb5e3c61c2d3d3950eb20ca05d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299856 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#789136}
-
Marijn Kruisselbrink authored
Adds an assertion to idlharness to check the name attribute of methods, and fixes the bindings code to make sure we actually set the name correctly. Bug: 1106097, 1097814 Change-Id: I73dea7b96a94a9b2925c23156e6ef8146291cbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300824Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#789135}
-
Yue Zhang authored
This CL adds e2e test to cover item 1.6.2 and 1.6.3 in https://testtracker.googleplex.com/testplans/details/32981. Bug: 1105511 Change-Id: I029399c0ccbbc0d64975042c2a4915fdbe172bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289937 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789134}
-
Kristi Park authored
This should be OS_CHROMEOS, not OS_LINUX. TBR=reillyg@chromium.org Bug: 1069695 Change-Id: Ib1c3e42ee0110fca5a14d256ca00db2ff737a5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303032Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#789133}
-
Robert Ma authored
Manual import due to https://crbug.com/1106413. Manual changes in disable-site-isolation-trials: * Add two expectations for two new tests * Drive-by: clean up some stale expectations Using wpt-import in Chromium 39d5e00d. With Chromium commits locally applied on WPT: 1adfdd4d "[COOP] Fix typo in test name" f19f3404 "[Sheriff] Revert "Deflake preservesPitch tests"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools ksakamoto@chromium.org, npm@chromium.org, yoavweiss@chromium.org: external/wpt/resource-timing mek@chromium.org: external/wpt/webmessaging mlamouri@chromium.org: external/wpt/screen-orientation NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Bug: 933880, 1106413 Change-Id: Ie829dbb479195ebe94ab9f662578db453b6841ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303349Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#789132}
-
Henrique Nakashima authored
Tweak values so that the movement starts faster and is not clunky while dragging a node. Bug: 1093962 Change-Id: Iff07bf983919315b1b62f4cf629408ca25df07ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300809 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789131}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/59d6160bf267..71892ba52d17 2020-07-16 cduvall@chromium.org Revert "Set WebView implementation for any WebView APK" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1105096,chromium:1106385 Tbr: oysteine@google.com Change-Id: Ic823e81f40839c8067f24136ba30e7e018321ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303089Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789130}
-
Anastasia Helfinstein authored
Show options for text input before options for scrolling. AX-Relnotes: n/a. Bug: None Change-Id: Ic477d71cd19274da5ccbe71cff68a3b2e5bab4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292701 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#789129}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 85-4181.3-1594028802-benchmark-85.0.4183.22-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.26-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie259fd70251726208087ad8e19f72476553bfa2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303093Reviewed-by:
-
Harry Cutts authored
These mice's HID descriptors claim that they have full keyboards, when actually they're just normal mice. On tablets, this meant that the on-screen keyboard didn't show up with one of the mice connected, preventing text from being entered. Adding them to the blocklist fixes the issue. Tested with all the Microsoft and Logitech mice except the M500s and M185/M187. (The others had been previously identified by Works with Chromebook testing.) (Yes, the mouse is actually just called "Microsoft Bluetooth Mouse", I'm not just being vague: https://microsoft.com/en-us/p/microsoft-bluetooth-mouse/8qbx2w3xsp2h ) appears. Bug: none Test: Connect mouse, touch a text box, and check the on-screen keyboard Change-Id: I7913aebf685334dedafaef90943e9e62d630cde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298327Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#789127}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I4ce5e2e67ab7bb52036f1dbd264ea1af01c694ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302394Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I95687570d1d473b562ad19c37d3b8b3686b87e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302234Reviewed-by:
-
Henrique Nakashima authored
Move them to chrome/browser/tab:java, from where they can be used by other modules. Bug: 1090048 Change-Id: I6a99ffa0974d426b6cc3e8304d30f76242eacf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246983 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#789124}
-
Colin Blundell authored
Bug: 1082230 Change-Id: Iac0fc26a34858508ba1730ed5985c24de56b764b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302989Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#789123}
-
Oriol Brufau authored
Grid items can get an override for their containing block size, which for example can affect percentage resolution. However, sometimes we need to clear such overrides, which can be checked using ShouldClearOverrideContainingBlockContentSizeForChild. That's already done in LogicalHeightForChild, used by MinContentForChild and MaxContentForChild. But when the min track sizing function is 'auto', the code may use MinLogicalSizeForChild instead of LogicalHeightForChild. And MinLogicalSizeForChild didn't check if the override had to be cleared. This patch makes it perform the check. Bug: 1103592 Change-Id: Ie6012b5099c4988217228352dc552f7437f738d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299354Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#789122}
-
Tomasz Wiszkowski authored
This change pushes existing overscroll detection mode further up the call chain to allow OmniboxSuggestionsRecyclerView to call up keyboard on overscroll if the suggestions list does not contain enough elements to be scrollable in full-screen mode. Bug: 1106150 Change-Id: Icabd061b7a118516bdd9af6364f00761ab32edd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301180Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#789121}
-
Alex Gough authored
High level sandbox policy is now housed in //sandbox/policy. This is part of moving the service manager back into //content. Bug: 1097376 Change-Id: If71f2097d54eb440325e1705e0045d943fe4df39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289219Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#789120}
-
Albert J. Wong authored
This is necessary to prevent reduce refcount thrashing when AtomicStrings become threadsafe. This CL is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 See this design doc for more details on the larger motivation for this change: https://docs.google.com/document/d/1hp7h6zfD5S6mnMI4cHe1PpacRnb2rNpRRkn1gBBJHuQ/edit#heading=h.erv1bv18t616 Bug: 1083392 Change-Id: Ib6f3a71d0153cc8cff178597e4e9cbd18cd38ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285518 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#789119}
-
Clark DuVall authored
Note: I will convert base::Bind calls to base::BindOnce all at once once all the uses of Callback and Closure are converted in //chromeos/network. Bug: 1007660 Change-Id: I252be683ed8119d412314dc4ead072518f846aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288340 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789118}
-
Ben Pastene authored
This reverts commit 3f4100fe. Reason for revert: crbug.com/1106435 Original change's description: > Reland "Split the cros_boards gclient var into two for fetching QEMU images." > > This is a reland of 8f372d5f > > Reason for reland: > - All hand-rolled DEPS-consuming apps have been updated. > - No changes in this CL between original & reland. > > Original change's description: > > Split the cros_boards gclient var into two for fetching QEMU images. > > > > This will help with the TODO at: > > https://source.chromium.org/chromium/chromium/src/+/master:build/config/chromeos/rules.gni;drc=ded9eb5153bb13b3f8821a6fa6fac6b3f0f590fd;l=22 > > > > It will also remove the need for hard-coding the names of all these > > QEMU-compatible boards. > > > > Bug: 937821 > > Change-Id: Iab180fc012bd694b4908ba0654da93d42e2274fa > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265498 > > Commit-Queue: Ben Pastene <bpastene@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#786005} > > Bug: 937821, 1103538 > Change-Id: I6124b41f5032d9daffd4b9747ec3a974b19c6db4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299469 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788734} TBR=thakis@chromium.org,dpranke@google.com,erikchen@chromium.org,bpastene@chromium.org Change-Id: I9b3b7d8a2f8b5b91211bf74fdd7d609766068196 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 937821 Bug: 1103538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303037Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#789117}
-
Xianzhu Wang authored
This is a follow-up of crrev.com/c/2300832. For more information, see https://groups.google.com/a/chromium.org/g/blink-dev/c/_COjLyfAEO0/m/1kC0sNuMAgAJ Change-Id: I2fabe47f3ef855b5087f78f11d844cf432625924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299474 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#789116}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I640fb35df261845cd3869c446d8b927384ec19b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302769Reviewed-by:
-
ckitagawa authored
If there is no GUID for the root frame the IPC will fail due to sending a null token. This CL ensures that doesn't occur. Change-Id: I5861a96f244c77592e595d922cae0e183103f92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300260 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#789114}
-
Brandon Goddard authored
This CL is a follow up to it's parent: https://crrev/c/2278408 This adds webtests to validate the highlightJSON generation for the new grid tool. However, it is dependent on a change to the elements_test_runner in the devtools-frontend, and cannot be added until it's parent lands, the devtools-frontend updates dependencies and the testrunner file, and those changes are merged back into src. Bug: 1047356 Change-Id: I483e5f81635b0d0ff3cf8019c2fe98155b5cf960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288337 Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#789113}
-
Scott Violet authored
There are a couple of things still remaining, but those will be a bit more fiddly. TEST=covered by tests BUG=1097644 Change-Id: If9c62187088b1fce2c432607c808b4e5b6426d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300623Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789112}
-
Andrew Grieve authored
Bug: 1041930 Change-Id: I47904f3b846edee39ba714a32abd884759f5eff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300607Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#789111}
-
Nick Harper authored
Removal was requested via email and domain control verified via DNS TXT record challenge. Change-Id: Ic048f6549d3cfc27131019b2099cdf05c4d56039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302770 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#789110}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0449293b6768..f224f744249c 2020-07-16 primiano@google.com docs: fix broken link If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3bd1f27a5072e7a98dbb811f021d91b18ee592b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302669Reviewed-by:
-
Alexander Cooper authored
Converts classes/methods that used/depended on platform_util's OpenOperationCallback to be used as a OnceCallback. Bug: 1007635 Change-Id: I1cebeb9e5eb46723cc101f65380a325513798367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297688 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/359283989608..11bfeb307c4e 2020-07-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f831fc29..ef63f40c (788907:789011) 2020-07-16 fippo@sip-communicator.org opus: take SILK vad result into account for voice detection If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2be12574794ddddc9b5b8d4e42fd9c42b428dffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302671Reviewed-by:
-
Pavol Drotar authored
Users required the ability to change the color of the navigation bar divider which looked inconsistent in custom tabs when both the contents of a web app and nav bar were the same color. This CL extends CustomTabNavigationBarController to set the divider color, and extends CustomTabIntentDataProvider to contain the divider color. Test: Added a new test file CustomTabNavigationBarControllerTest.java to test possible combinations of setting navigation bar and divider colors. Bug: 1021436 Change-Id: I2077c44c3be5f8fe2c842884e4f85ce70b1376b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297394Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Pavol Drotár <pavoldrotar@google.com> Cr-Commit-Position: refs/heads/master@{#789106}
-
Joe DeBlasio authored
Bug: 960819 Change-Id: I32c76062fccf6bb6926a0099dbe6f3014b2d8caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302730 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#789105}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/21731f72a587..c139b630a30b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sahel@google.com,rhalavati@google.com Change-Id: I332ca3fa419e6fffecd4e6abe6526f86b26e9494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302396Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789104}
-
Ted Meyer authored
We need to substring it before we make copies so that we don't OOM when copying large media data-urls. Bug: 1090752 Change-Id: I2d1ddaf10484837a1e9cc98d0a0860e6fbb542b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299854 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#789103}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fade2847b875..ced0044c7c5c 2020-07-16 tvanderlippe@chromium.org Make devtools_module only visible to same-file targets 2020-07-16 alexrudenko@chromium.org Add imported font families to autocompletion If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I056f4156758d519783ff3bb3a7c088b21a822e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302398Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds util::ranges implementations of the algorithms found in [alg.remove] and [alg.unique]. Bug: 1071094 Change-Id: If549459c70accf4356c34ad7ae5324f06305eaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301976 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#789101}
-
Sven Zheng authored
Bug: 1104291 Change-Id: I0575da358e95ea49ddf19af8ea84987cddcf9cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300987Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#789100}
-
Evan Stade authored
The P SDK is available for direct use now. Bug: 1095714 Change-Id: I0357d8c5060871895dbf4a080cf71778e3a867bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296892Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#789099}
-
