- 07 Sep, 2020 40 commits
-
-
Yuki Shiino authored
Supports [CSSProperty] IDL extended attribute in order to support CSS properties. There are 1,215 CSS properties, so it's worth optimizing the property installation of CSS properties to reduce the APK size. CSS properties are currently implemented as named properties, but they will soon be implemented as IDL attributes conforming to the spec. Then, the APK size increase will be ~9KB with this patch (~300KB without this patch). Bug: 1075980, 1075981 Change-Id: Id0410d57737ae106ead95d01a89661a6942fc0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391180 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#804746}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/27e1867266a0..848503c434c0 2020-09-07 lalitm@google.com Merge "Roll trace processor" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I01e170507148a2ebdc8747d770a749b6dfc11d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395800Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804745}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 50b469fa. With Chromium commits locally applied on WPT: 53efc876 "Reland "webrtc: add wpt test that setCodecPreferences changes the sdp"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Icf63cfd75404e0a90a54a2e208cb11807aa01bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395975Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804744}
-
Mohamed Amir Yosef authored
Bug: 1108422 Change-Id: Ibd90ebd7d1504caf85adf73cacfcbf1cdc5952b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379191 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#804743}
-
Mirko Bonadei authored
Follow up for https://chromium-review.googlesource.com/c/chromium/src/+/2391155 since now the test are failing to run. Bug: 1123704 Change-Id: Ic9d0ba8d558e06acf2de2a1f5984ab6c8ad6c838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395757Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#804742}
-
Hajime Hoshi authored
This CL adds two HistoryNavigation UKMs * BackForwardCache.BlocklistedFeature * BackForwardCache.BrowsingInstanceNotSwappedReason for further analysis. The UKM privacy doc is: https://docs.google.com/document/d/1GDsehNwMEHXef_o2XqNbsXk2F0pdhXt1khVVE4cRcLw/edit?usp=sharing Bug: 1122491 Change-Id: I1a98db768dd97b8224caa03db700667c84ff980e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374916 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#804741}
-
Viktor Semeniuk authored
This change adds possibility to copy website, username and password to the pasteboard. Before copying password reauth is required. Bug: 1122993 Change-Id: Ib41c1bb77b335a91ca54d0d6dada850a727fcb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379739 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#804740}
-
Clovis PJ authored
Now called FakeDeviceProvider, existing separately with exposed header, to allow for reuse elsewhere. Also moved test dependents into 'test_support', out of unittest target. Cleaner + allows for reuse. Change-Id: I76ca2f2c6de68bb27cf254907e3d7d9a87518ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368558 Commit-Queue: Clovis PJ <clovispj@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#804739}
-
Yuki Shiino authored
service-worker-gc was testing things without waiting for a GC completion, and this patch fixes it making service-worker-gc wait for a GC completion. Bug: 1124977 Change-Id: Idf8a1d5338808689a62b82a88c86e4194d9fa811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395456 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#804738}
-
Chris Lu authored
This is a reland of 5f4895f5 Original change's description: > [ios] Turn on FullscreenControllerBrowserScoped by default > > Bug: 790886 > Change-Id: Ide1eee5634376b90cfa820bb61644c871969ff86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358589 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Auto-Submit: Chris Lu <thegreenfrog@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800354} Bug: 790886 Change-Id: I279349dd1b45de347600c26e8d32e5d9d33b5b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395695Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#804737}
-
nancylingwang authored
ARC app.mojom is modified to return the foreground and background files separately to generate the ARC app standard icon on the Chromium side, so modify the fake app instance to return the foreground and background data to keep consistent with the mojom change, and the ARC side return value. DD: go/appservice-adaptive-icon BUG=1083331 Change-Id: I9147be31ffbea4fa2d647fe90667a09a8781feeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389742Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804736}
-
Mario Sanchez Prada authored
This CL migrates these two legacy IPC messages out of view_messages.h to the {Local,Remote}MainFrameHost mojo interfaces from Blink, by using the newly defined method UpdateTargetURL() in both interfaces (required to work both when the main frame in the renderer is local or remote). Additionally, this CL moves the UpdateTargetURL() method present in RenderViewHostDelegate into RenderFrameHostDelegate, now that the IPC message will be now received in the browser process by a RenderFrame, instead of being handled by RenderViewHost as it was the case before. Last, the UpdateTargetURLWithInvalidURL unit test has been moved out of RenderViewBrowserTest and into WebViewTest, as that reflects better the situation in the renderer side now, and also to get friend access to the |target_url_| private attribute, which is now part of WebViewImpl. Bug: 993189, 1047464 Change-Id: Ib97ee5270221efc48d50138cf3f075619430d063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387801Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#804735}
-
Rohit Agarwal authored
the Account picker dialog. Screenshots: https://screenshot.googleplex.com/5jsm3NaA2M3VdFh Bug: 1125472 Change-Id: Ia662f40ba8ac234a07bd3a0c10ef048c1c0d5d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395775Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#804734}
-
Tymofii Chudakov authored
Added category-default-setting-radio component for managing content settings, which should substitute the toggle-based category-default-setting component. The functionality is presersed. Bug: 1113642 Change-Id: I4f168f9f5a774349386e482952590979b0ba10e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297505 Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#804733}
-
Changhao Han authored
This UMA will expire after M87. Bug: chromium:1096230 Change-Id: Ia7522f98de4d273d625fe06e3fd89a49358ca207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390221 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804732}
-
Dominic Battre authored
TBR=sadrul@chromium.org Bug: 1115376 Change-Id: I2245dfb061fba74f29e4702c79f537253bfe3d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395656Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#804731}
-
Paula Vidas authored
FCM registration token can become invalid. This CL re-requests the token once a day and notifies token observers in case token has become invalid. Code is mostly copied from the old invalidations implementation (components/invalidation/impl/fcm_network_handler.*). Change-Id: I67ad7e4f315e38bc8d34710ca4551ebd2e080ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391071 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#804730}
-
Raphael Kubo da Costa authored
This new attribute indicates whether a sentinel object has been released or not. While here, move the dispatching of the "release" event to a separate method so that we can really change |release|'s value and dispatch the event in a separate, queued task. Additional web tests have been sent directly to WPT in https://github.com/web-platform-tests/wpt/pull/25271. Spec PR: https://github.com/w3c/screen-wake-lock/pull/279 ChromeStatus entry: https://chromestatus.com/feature/5632527123349504 Intent to Prototype and Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/1V6Ss1VABko/m/Y3Nl0vHIAQAJ Fixed: 1122518 Change-Id: Iff39ec3db630fa959e6c3c82b9c5ee8df93b681c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379740 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#804729}
-
Victor Costan authored
The distinction between kShared and kExplicit is large enough that there are significant readability advantages to having the default be explicit in the code. Bug: 1125315 Change-Id: I34c479032b90124c88eadac8897c6d579dbd1554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394197Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#804728}
-
Saurabh Nijhara authored
Child user is not enterprise managed and hence, should follow the policy behavior similar to that for an unmanaged user if the unmanaged_user_restricted flag is not set in the policy. If the flag is set the policy has same behavior for all users. This change is for ChromeOS only. Bug: 1124225 Change-Id: I777c1d811a55659957b127d865eb5b4d20accf3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390060 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804727}
-
Alice Wang authored
This CL enables back-pressing on incognito interstitial in web sign-in bottom sheet to return to the expanded account list. Bug: 1122007 Change-Id: I916e30f4a48db28316ecba37480a6d2fb4be5e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392456Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804726}
-
Antonio Sartori authored
After https://crrev.com/c/2310416 removes usage of NavigationRequest::set_response_headers_from_testing from the NavigationSimulatorImpl, it is now feasible to drop the NavigationRequest::response_headers_from_testing, as this CL does. Change-Id: I8ea4f24e47ba9a98d5c6bc32d5fb15b1e51af4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312097 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#804725}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c430851777c3..aa2b76a46973 2020-09-07 dberris@chromium.org [pinpoint] Reorder Makefile If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: I3ef3e909535a90b316e1dc55491989282782c407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395795Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804724}
-
Takashi Toyoshima authored
ThrottlingURLLoader has a cross-origin redirect supporting code for BlinkCORS as the redirect can be permitted by the BlinkCORS checks. As OOR-CORS is fully enabled, this is not needed any more. Bug: 1001450, 1053866 Change-Id: Ide21bae90f058bbbfe08dd0014526681c2e09a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395477 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#804723}
-
Ye Kuang authored
This allows us to pass in isolatedserver host to https://source.chromium.org/chromium/infra/infra/+/master:recipes-py/recipe_modules/isolated/api.py Bug: 894045 Change-Id: I8be297ae601e45f1cf9b5422c4a5d996cf4e5662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395300 Commit-Queue: Ye Kuang <yekuang@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#804722}
-
Benoit Lize authored
subtle::SpinLock is a spinlock, which has clear shortcomings. Replace it with base::Lock for the partition lock in PartitionAlloc. As this was the last user of subtle::SpinLock, remove it as the same time. Note to perf sheriffs: If there is a regression in range, this is likely the cause, as the fast path is likely still slower in base::Lock vs base::subtle::SpinLock. Bug: 1061437 Change-Id: Idbc4968cfd2fa50bdb1a2468657f4a3da6e29aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390066Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804721}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599363987-ba52081c82a210e6aa85eb56ee13d29c8c469598.profdata to chrome-win64-master-1599458176-11e2917dc2d8682a1e6ca50080f9502cff8643cc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I73f7eb7376b56c07eecf629e1fa408ceb78bee06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395578Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804720}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d0fe7d37d678..611a52108b01 2020-09-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4a41204d8175 to 72f6b99c29f2 (7 revisions) 2020-09-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7a93e029 to fd16dd07 (142 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: If01b5c5ebc5bfdae158059605e1260022e5addb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395066Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804719}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a070dd18d79d..9218ba277ab5 2020-09-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: If3f9de9606dbef6f6284c66d7e524fbd71d13b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804718}
-
Swapnil authored
Change-Id: Iece3b62d60f61bccbeb5e47a04e1447de652814b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387761Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#804717}
-
Mohamed Adel authored
This CL removes an unused header, histogram_functions. Bug: None Change-Id: I1b96ab271f0b08984eedb400c31514767de0ebf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395736Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#804716}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f184cb61cea6..3cdd19d95d7e 2020-09-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c934ea57 to b3510742 (149 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Id89c4aef79609d08dbf7e3428723d08e6f866741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804715}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9de988b61cfc..ca6b6027b480 2020-09-07 szuend@chromium.org [ts] Type-check sdk/CSSRule.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1d7ca050b442a68d772743c3d8523a4b77fd7118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395065Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804714}
-
Kent Tamura authored
to layout_slider_track.{h,cc} respectively. This CL has no behavior changes. Bug: 1040826 Change-Id: Ia56c1df2671ea637b89305be01801a32c84b9c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395139 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804713}
-
Fredrik Söderqvist authored
Convert various parsing functions to use the dispatch helper rather than open-coding it. Most of the conversion is trivial, but some cases require minor changes to signatures. One SVGTransformList required a bit larger rework. Change-Id: Ib0c03613c9fb7a498b8945050ac7ee6db84b4c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390919Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#804712}
-
Tanmoy Mollik authored
If MOBILE_IDENTITY_CONSISTENCY feature flag is enabled, this screen will use the same icon as the one AccountPickerDialog is using. This cl creates a reference test to make sure that new code will not override the old view when the flag is not enabled. Bug: 1107423 Change-Id: I9aa21bbc90dc71a9aac3fda3bf6a8e51aa09e963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367871Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#804711}
-
Kenichi Ishibashi authored
This CL removes ServiceWorkerMetrics dependency from ServiceWorkerStorage by embedding UMA recordings into it. ServiceWorkerStorage will be moved to //components/services/storage but ServiceWorkerMetrics will remain //content. This means that ServiceWorkerStorage cannot use ServiceWorkerMetrics. This CL also applies histogram guidelines (//tools/metrics/histograms/README.md). Bug: 1016064 Change-Id: I79ba99c096fc422166b0f0f23d27728804701113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394899Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804710}
-
Alice Wang authored
This CL adjusts the view heights of sign-in general error and sign-in auth error screens. Bug: 1124616, 1124619 Change-Id: If6f52dfd33083fdbcb1e38a3db98e39c60718e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391084Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804709}
-
Alex Ilin authored
GoogleAPIKeysTest.OverrideAllKeysUsingConfig reads the config info into the GaiaConfig singleton. The state of this singleton must be reset after the test to not affect other tests running within the same process. Fixed: 1123464 Change-Id: I3f2603153c30b87905f071a76eb20412a75c8ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390749Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804708}
-
Aleks Totic authored
Another subtle bug related to adjusting table cells writing mode. The problem is that Layout code keep track of orthogonal LayoutBoxes. This list must be kept in sync after cell changes its writing mode. Previous fix took care of keeping track of table cell, but did not consider table cell's children. Table cell's children could either become a root, or stop being a root. This fix updates the root state of table cell's children. Thank you clusterfuzz! Bug: 1124997 Change-Id: If8c123ba3172f505ea1dc2494a7b53c4a7290e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393618 Auto-Submit: Aleks Totic <atotic@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#804707}
-