GitLab

Since NonThrowableExceptionState, TrackExceptionState, NoExceptionStateAssertionChecker and IgnorableExceptionState create no wrapper, we don't need to fix those exception state with empty context.

We need to fix ExceptionState. To ensure that all ExceptionStates are fixed, added ASSERT to ExceptionState::throwSecurityError and ExceptionState::throwDOMException.

BUG=369451

Review URL: https://codereview.chromium.org/311733003

git-svn-id: svn://svn.chromium.org/blink/trunk@175463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No substantive changes to generated bindings:
just reorders the constructors on global objects b/c split
between core and modules.

This almost completes splitting the build!
(Only remaining step is to split global objects, at which
point I can eliminate the bindings/generated.gyp)

Global constructors from modules are in bindings_core b/c
they affect core bindings (due to partial interfaces), with
FIXMEs to move them to bindings_modules.

R=haraken
BUG=358074

Review URL: https://codereview.chromium.org/310563004

git-svn-id: svn://svn.chromium.org/blink/trunk@175462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL makes DocumentWriter GarbageCollectedFinalized.

BUG=357163

Review URL: https://codereview.chromium.org/314953002

git-svn-id: svn://svn.chromium.org/blink/trunk@175461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376753

Review URL: https://codereview.chromium.org/299393007

git-svn-id: svn://svn.chromium.org/blink/trunk@175460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175443

BUG=378489
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/312103002

git-svn-id: svn://svn.chromium.org/blink/trunk@175459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ActiveParserSession, NestingLevelIncrementer, and PumpSession are allocatable
only on stack. We can make m_document Member<> without trace().

BUG=357163

Review URL: https://codereview.chromium.org/313033003

git-svn-id: svn://svn.chromium.org/blink/trunk@175458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/318583002

git-svn-id: svn://svn.chromium.org/blink/trunk@175457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Replace RefPtrs to Document in core/{accessibility,animation,fetch} with Oilpan transition types.

BUG=357163

Review URL: https://codereview.chromium.org/313023003

git-svn-id: svn://svn.chromium.org/blink/trunk@175456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=379483

Review URL: https://codereview.chromium.org/318573002

git-svn-id: svn://svn.chromium.org/blink/trunk@175455 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This cl introduces setNavigatorContentUtilsClientMock() and NavigatorContentUtilsClientMock class in order to simulate registerProtocolHandler(), unregisterProtocolHandler(), and isProtocolHandlerRegistered(). Thus, navigator content utils can test if defined functions can work correctly.

Besides this cl updates all navigator content util's tests so that the functions can work correctly.

BUG=none

Review URL: https://codereview.chromium.org/293403002

git-svn-id: svn://svn.chromium.org/blink/trunk@175454 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/312073002

git-svn-id: svn://svn.chromium.org/blink/trunk@175453 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=junov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/301133002

git-svn-id: svn://svn.chromium.org/blink/trunk@175452 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/313603003

git-svn-id: svn://svn.chromium.org/blink/trunk@175451 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175434

BUG=378489
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/313803005

git-svn-id: svn://svn.chromium.org/blink/trunk@175450 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175436

TBR=ojan@chromium.org

Review URL: https://codereview.chromium.org/312083003

git-svn-id: svn://svn.chromium.org/blink/trunk@175449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TimelineTraceEventBindings is renamed to TracingTimelineModel. All logic related to timeline-specific trace events will be moved from TracingModel into TracingTimelineModel. TracingModel will be a lower level model which works with generic trace events.

In the next patch I'm going to move inspectedTargetEvents to TracingTimelineModel.

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/310313003

git-svn-id: svn://svn.chromium.org/blink/trunk@175448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds the blink_heap_unittests and blink_platform_unittests target, bringing
Source/platform/BUILD.gn to parity with Source/platform/blink_platform_tests.gyp.
These fail to link on mac with missing symbols in libjpeg_turbo due to a missing
yasm target but should otherwise be functional.

Review URL: https://codereview.chromium.org/317583004

git-svn-id: svn://svn.chromium.org/blink/trunk@175447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Due to a bug in RedirectToFile functionality of Chromium, the
optimization CL was reverted
(http://src.chromium.org/viewvc/blink?view=revision&revision=168993).

This CL reenables the optimization as
https://codereview.chromium.org/82273002/ fixed the bugs.

BUG=347663

Review URL: https://codereview.chromium.org/311593002

git-svn-id: svn://svn.chromium.org/blink/trunk@175446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Replace RefPtrs and raw pointers to Node and its subclasses in core/frame and core/page with Oilpan transition types.

Also, this CL replaces SmartClipData::m_node with m_isEmpty.

BUG=357163

Review URL: https://codereview.chromium.org/310353003

git-svn-id: svn://svn.chromium.org/blink/trunk@175445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175423

BUG=370366
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/312083002

git-svn-id: svn://svn.chromium.org/blink/trunk@175444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Resolve conflicts
- Correct entries for terminate-during-sync-operation-*.html

BUG=
TBR=jshin@chromium.org

Review URL: https://codereview.chromium.org/312073003

git-svn-id: svn://svn.chromium.org/blink/trunk@175443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A newer version of CLDR/ICU uses ',' as a delimeter between Date and Time
in en-US locale leading to the failure of a bunch of date-time-related
layout tests on Linux/Android where ICU is used to format date/time.

In addition, date time format and month names have changed in several locales,
Hindi, Russian, Arabic, and so forth.

For most of tests, rebaseline after rolling ICU to 52 would work.
They're marked as such in TestExpectations.

For the following 3 tests, a bit more changes are required.

1. fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html
 - Add *-expected.txt for Linux (will also be used by Android) with a
   comma.
 - Marked as FAILURE in TestExpectation.

2. fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html
 - Adjusted the expected result hardcoded in the test depending on whether
   the formatted field text has a comma or not.
 - Add *-expected.txt for Linux (will also be used by Android) with a
   comma.
 - Marked as FAILURE in TestExpectation.

3. LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html
 - Adjusted the x-coordinate of the mouse click depending on whether the
   formated field text has a comma or not so that it can pass
   regardless of whether a comma is present or not.

BUG=378919,379365,132145
TEST=datetime* and calendar-picker-related layout tests run as expected (fail or pass). After ICU roll to 52, some would pass unexpectedly.

Review URL: https://codereview.chromium.org/302323004

git-svn-id: svn://svn.chromium.org/blink/trunk@175442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It hasn't been implemented since it was added in r41907 ~5 years ago.

Review URL: https://codereview.chromium.org/314823003

git-svn-id: svn://svn.chromium.org/blink/trunk@175437 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This lays the groundwork for removing scheduleLayerUpdate calls in
RenderLayerCompositor for iframes. Instead of changing the layer
type when the frame is composited, change it so that the layer
type remains ForcedLayer, but the isSelfPainting bit respects
the m_compositing bit on RenderLayerCompositor.

This exposed a bug in RenderBox::nodeAtPoint where it wouldn't
recurse correctly because the child now has a layer, but isn't
self-painting. Before we'd never hit this code path with
a non-self-painting layer.

The rebaselines are all just cases of things getting a layer
where they didn't used to.

Review URL: https://codereview.chromium.org/302083002

git-svn-id: svn://svn.chromium.org/blink/trunk@175436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a rough port of Zalan Bujtas' patch on https://bugs.webkit.org/show_bug.cgi?id=112227

Due to pixel snapping/truncating, we prematurely truncate some rtl content when
text-overflow: ellipsis is enabled. One piece of this puzzle is a hack to fix old
multi-column code, which didn't work well with sub-pixel layout. The other
is unnecessary pixel snapping in ellipsis line layout. Both of these issues need to
be fixed to address the bug in rtl ellipsis content.

This changes old-multicolumn layout by one pixel when compared to the (better)
region-based multicolumn on 2 ref tests.

BUG=378489

Review URL: https://codereview.chromium.org/303673007

git-svn-id: svn://svn.chromium.org/blink/trunk@175434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

marginY1 is supposed to be an inclusive endpoint, however, maxY() is an
exclusive endpoint. To fix this, subtract one from maxY() before
assiging to marginY1 so that we don't walk off the end of the intervals
vector.

BUG=379108
R=betravis@adobe.com,pdr@chromium.org,inferno@chromium.org

Review URL: https://codereview.chromium.org/318443004

git-svn-id: svn://svn.chromium.org/blink/trunk@175433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, they were not taking into account child stacking contexts of the
layer being reflected.

BUG=372837

Review URL: https://codereview.chromium.org/313653004

git-svn-id: svn://svn.chromium.org/blink/trunk@175432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r175404 broke oilpan builds, because r175404 switched GeolocationController from being a Page (which is on-heap) supplement to a LocalFrame (which is not yet on-heap) supplement.

As a quick fix, this CL moves GeolocationController back to off-heap.

BUG=340522

Review URL: https://codereview.chromium.org/314873002

git-svn-id: svn://svn.chromium.org/blink/trunk@175430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This Cl re-enables Repaint-After-Layout as the default.

BUG=371856,320139

Review URL: https://codereview.chromium.org/311873002

git-svn-id: svn://svn.chromium.org/blink/trunk@175429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change is in preparation for re-writing the path
through which tokens are handled on the main thread
to allow them to be batched and deferred until more
important work is done:
https://codereview.chromium.org/258013009/

Currently the threaded parser uses the main thread's
MessageQueue as its work-queue and we'll commonly
queue 10 chunks of work in the main thread MessageQueue
even if the first chunk takes a long time we'll still have to
process the next 9 before we can do more important things
like put up a frame because we don't have a separate
queue for parser work.  258013009 will fix that.

http/tests/security/script-crossorigin-loads-correctly-credentials-2.html
originally started failing with this change and it
turns out that always-preloading found a real bug
in CORS handling with preloads. The ResourceFetcher
was incorrectly always reusing an in-flight preload
request, even if the CORS state didn't match. Nate
helped me re-order the calls in requestResource to fix it.

This change also discovered 2 other bugs in the preloader.
1. a preload request != LinkPrefect request
and one will cancel the other. crbug.com/379893
2. The preloader has no concept of script type and will
blindly issue preloads for all <script href> regardless
of <script type>.  I decided this didn't matter in practice.
Making the <script type> handling threadsafe isn't
worth the trouble.

I would anticipate that this change might make some
speed-index scores better (we'll now be preloading
all tokens slightly sooner, especially those
which are in the same chunk as a long inline
script block for instance), but may make non-network
PLT scores lower (due to extra mallocs required
to process every chunk since more loads will
be preloaded just before their actually loaded).

BUG=356292

Review URL: https://codereview.chromium.org/302063002

git-svn-id: svn://svn.chromium.org/blink/trunk@175427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There's no need to compute the exact target-relative coordinates for
simulated mouse events, e.g those fired by HTMLElement.click().

The offsetX/Y properties are not supported by Firefox.

This CL merges http://trac.webkit.org/changeset/164871/ by kling, which made
WebKit go fast on Speedometer.

BUG=380173

Review URL: https://codereview.chromium.org/316733004

git-svn-id: svn://svn.chromium.org/blink/trunk@175426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=fmalita

Review URL: https://codereview.chromium.org/310953003

git-svn-id: svn://svn.chromium.org/blink/trunk@175425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On clang we enable -Wglobal-constructors which bans static initializers. This
is correct for all targets except unit test binaries, which need static initializers
since that's how the gtest TEST{,_F,_P} family of macros work. This splits that
warning into a separate config and avoids adding it to the unit test targets.

Review URL: https://codereview.chromium.org/318503002

git-svn-id: svn://svn.chromium.org/blink/trunk@175424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a nested RenderView isn't composited, it acts like a repaint
boundary, but then relies on repaintViewRectangle to translate
the repaint coordinates into the coordinate space of the actual
repaint container. This patch overrides repaintTreeAfterLayout for
RenderView to simply repaint the viewRect. It also pushes some
repaint logic out of RenderObject and into RenderView.

BUG=370366

Review URL: https://codereview.chromium.org/271803002

git-svn-id: svn://svn.chromium.org/blink/trunk@175423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduce XMLHttpRequest.responseURL as specified in [1].

1: http://xhr.spec.whatwg.org/#the-responseurl-attribute

BUG=377583

Review URL: https://codereview.chromium.org/312493004

git-svn-id: svn://svn.chromium.org/blink/trunk@175422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These synchronous calls to layout aren't necessary.

This CL merges http://trac.webkit.org/changeset/164319 by rniwa, which made WebKit go
fast on Speedometer.

BUG=380173

Review URL: https://codereview.chromium.org/315663006

git-svn-id: svn://svn.chromium.org/blink/trunk@175421 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was not possible to write this assertion because == did not work
for ServiceWorker instances, which were created anew each time they
were marshalled to Blink. That works now.

BUG=361907

Review URL: https://codereview.chromium.org/311573002

git-svn-id: svn://svn.chromium.org/blink/trunk@175420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There's no reason to call a functiont that only ASSERTs in release builds. Also,
clean up some minor style issues.

Review URL: https://codereview.chromium.org/316513002

git-svn-id: svn://svn.chromium.org/blink/trunk@175419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, do not include squashed layers when computing repaint
rects including descendants. Squashed layers paint separately
with a different origin.

BUG=370664

Review URL: https://codereview.chromium.org/309093002

git-svn-id: svn://svn.chromium.org/blink/trunk@175417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prior to this change --iterations=10 would fail about 50%
of the runs of this test.  After this change I see 0 failures.

Unclear if this test still tests exactly what it set out to
but it seems like it should.

R=japhet@chromium.org

Review URL: https://codereview.chromium.org/318523002

git-svn-id: svn://svn.chromium.org/blink/trunk@175416 bbb929c8-8fbe-4397-9dbb-9b2b20218538