- 04 Feb, 2020 40 commits
-
-
Johannes Henkel authored
"Remove the JSON parser and revamp Value::parseBinary." Upstream review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2026351 "Add JsonEncoder tests for lone surrogates" https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2017303 In addition to the upstream changes, this PR includes the necessary tweaks to the blink inspector (now taking the detour via CBOR to parse Javascript). New Revision: 0e0a1995497511008864546c094e885f3f1e13a3 Change-Id: I1449d3a76c6a946a8bc321dd8d0cb111ce1bf303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021290Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#738228}
-
Robert Liao authored
ScopedBstr::Get provides a migration pathway away from operator BSTR() const, a violation of the implicit conversion rule in the C++ style guide. https://google.github.io/styleguide/cppguide.html#Implicit_Conversions BUG=1034666 Change-Id: Idacb984b3c97b6deafbd91b3dd0d8928a12f932b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036522 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#738227}
-
David Benjamin authored
Note this is a behavior change. Previously, these requests would send cookies, although not save them. This isn't a particularly coherent notion privacy-wise, and the discussion thread at [0] suggests the fetches do not require cookies. If this fetch does indeed require cookies, do not approve this CL. [0] https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4/edit#heading=h.d3td7t6q4ppy Bug: 799935 Change-Id: I314f9fa1cf7bd7ae64c58651f8071e0e8bea776b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965866Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Rob Schonberger <robsc@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#738226}
-
Nikita Podguzov authored
This is shown to the users if a non-whitelisted extension calls chrome.printing.submitJob(). If user clicks "Accept" button, the print job is sent to the printer. If they click "Deny" button, the dialog is closed and nothing happens, extension receives REJECTED status. Bug: 996785 Change-Id: Idf9cbc5af4ae740252ac32d2a64f6928c61eb955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007277 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#738225}
-
Roman Aleksandrov authored
Animate the ripple to deactivated state if the backspace button becomes disabled. This speeds up the fading away of the ripple. Bug: 1021834 Change-Id: I1285a4644a81e62b2b5bf371574bb1eccd350e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036059Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f5d877847fae..2fca97168bfe git log f5d877847fae..2fca97168bfe --date=short --first-parent --format='%ad %ae %s' 2020-02-04 nisse@webrtc.org Delete header file mock_vcm_callbacks.h Created with: gclient setdep -r src/third_party/webrtc@2fca97168bfe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idadda601e5301de6b00e59db0d48d8f2af88e6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037416Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738223}
-
Wez authored
Some tests need to run the message loop until a particular condition becomes true, but have no direct signal from the code under test to use to trigger the check & terminate the run. RunUntilConditionForTest() runs the loop and repeatedly calls a supplied callback until it returns true, or the Run()-timeout expires. The helper returns true if the condition was met before the timeout. Bug: 1021777, 976740 Change-Id: I18f887431a68cb73cc77a445f3b915284b111cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033162 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#738222}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/842c4bc2..4460b2d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic8e7c63a6e78dd4eabdb679114e627ebe664ef55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037385 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738221}
-
Tibor Goldschwendt authored
Also, do the same if clicking mic button in retry state. Bug: 1042534 Change-Id: I00b846fda24d263bd0c9493fd865fc3300541482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036384Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#738220}
-
Olivier Li authored
Change-Id: I79e1153db46c9d12b6bf774914a46b095eeb3ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025947Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#738219}
-
Yann Dago authored
Create a snapshot manager that takes snapshot of some files and directories from the user data directory on browser update, and restores it on version rollback. All this happens when the browser is in an enterprise environment. Change-Id: If8373dd4c41edbf41ce9d6271300f7cd7a5ce575 Bug: 958893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992265 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#738218}
-
Maggie Chen authored
Some content unit tests create GpuDataManagerImpl in the IO thread. PeakGpuMemoryTrackerImpl needs GpuDataManagerImpl and GpuDataManagerImpl is created it when PeakGpuMemoryTrackerImpl is running on the IO thread. This will cause a crash (sequence checker) if the DisplayChange observer is added. This CL makes sure GpuDataManagerImpl is created first in the test setup so GpuDataManagerImpl will run on the main thread later. Bug:1042989 Change-Id: I825937f800dfeeddf2d25b03e5e50bf418e6942e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019882 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738217}
-
Joanmarie Diggs authored
BrowserAccessibility::GetTargetNodesForRelation was converting the correctly-ordered vector of AxIds into a set, causing the target order to be based on when the accessible object was created. This order does not necessarily correspond to the position in the accessibility tree, let alone to the author-provided order. This situation wasn't problematic because of the few ARIA properties whose value is an ID reference list, none were likely being used for assistive technology navigation. Because aria-details is changing to support multiple targets for which ATs will be expected to provide navigation, we need to start preserving the author-specified reference order. There are only a few properties for which there are multiple targets, and the list of referenced IDs for those properties is expected to be quite small. Thus converting the vector to a set doesn't buy us much. Therefore, return the target nodes as a vector, checking for duplicate AxIds. Bug: 1047988 Change-Id: I8352a073b71cc1863cbd25326d0cd48a4abd3d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034690Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#738216}
-
Maria Kazinova authored
The FormData extraction code was racing against new page load even though FormData was already passed into a function in string format. Now the FormData is extracted from a passed in string. This is a fix for a reverted change. Bug: 418827 Change-Id: Ic2d65d40a34183302a200ccf07a3d0070fdc2bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033517 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#738215}
-
Vadym Doroshenko authored
Bug: 1042196, 1045431 Change-Id: I0648dacaa8396ff167ea2b189a00d64fdbf04389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012031 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738214}
-
Paul Moy authored
Add the first interactive routine, AC power, to cros_healthd. This routine checks the power supply's status and type against the routine inputs. --gtest_filter=CrosHealthdServiceConnectionTest.* Bug: chromium:1046452 Test: chromeos_unittests Change-Id: I26a317c681781bed096513502240ba4663253fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033809 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#738213}
-
Becca Hughes authored
Remove timestamp_ms field from playbacks table since we have moved it to the sessions table. BUG=1024368 Change-Id: Ie7de911bc6b728fbea633a433b40f4584d9bee2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036812Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#738212}
-
Jeremy Roman authored
This is intended to mitigate concerns about data:, chrome://, or other surprising URLs being loaded. While there are existing mitigations for many of these cases, this provides with more confidence that these restrictions apply specifically to portals. See security review comments on crbug.com/1040212. Since this means that the throttle has some enforcing functions even when cross-origin portals are enabled, PortalNavigationThrottle is refactored slightly to exist whenever Portals are enabled, but to limit the origin checking to kPortalsCrossOrigin disabled. Bug: 1008989 Change-Id: Ia66723867731e88995b7e7d03ef72c78bcb96fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036776Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738211}
-
Ewann authored
A new page info is going to be implemented. Bug: 1038919 Change-Id: I4cba76a06144784cee46ebd637b7281f7107e5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036177Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#738210}
-
Tarun Bansal authored
No longer needed with NoStatePrefetch. Also, verified using the histograms dashboard that this enum is not getting populated. Bug: 1038057 Change-Id: I4fede4f1d10bf9723d6adf65f6b58a042f708794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995995 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#738209}
-
Marc Treib authored
This reverts commit 897d08bf. Reason for revert: Still breaks ARC boot, see crbug.com/1048710 and crbug.com/1046881 Original change's description: > Reland "[PM] Add support for dedicated workers" > > This is a reland of dec0aa0b > > The fix for the failure is in this CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2036479 > > Original change's description: > > [PM] Add support for dedicated workers > > > > The WorkerWatcher observes dedicated workers through the > > DedicatedWorkerService interface. > > > > Change-Id: If62d911e500def7ebb905311485a8d89eeaca8df > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992208 > > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > > Commit-Queue: Patrick Monette <pmonette@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#736411} > > Change-Id: I40b86ea7de8fa4b252ffe805ec5992020dffc515 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028214 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738160} TBR=pmonette@chromium.org,siggi@chromium.org Change-Id: Ibc5ac277917d191b1033d45e2201e11b653e754e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035965Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738208}
-
Anthony Vallee-Dubois authored
This CL moves EnrollmentStatus to a platform agnostic location so that it can be used on non-ChromeOS desktop platforms as support for device accounts is added on those platforms as well. Bug: 1026261 Change-Id: I47d60c8a033fb45730565b95bf6f5030b1d99fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998746Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#738207}
-
Lukasz Anforowicz authored
When an extension message is received, we check `MessageSender.id` to disallow requests from unknown clients. Unfortunately, `MessageSender.id` is currently not trustworthy (issue 982361) and therefore this CL switches to using `MessageSender.origin` instead. Bug: 10321587 Change-Id: I3cc65cb4105cfc8caf0f98f5cd42cec5dacca4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035864Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#738206}
-
Marc Treib authored
This reverts commit df3250dd. Reason for revert: Suspected of causing crashes, see crbug.com/1047879 Original change's description: > Sync cleanup: Remove DEPRECATED_EXPERIMENTS ModelType > > It has been deprecated and unused for a while. > The specifics proto itself can't be removed yet because it's still used > on the server. > > Bug: 1009361 > Change-Id: Ic183a6e244435cfce60ccdda34bff3e22a032ff3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022670 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736397} TBR=treib@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1009361, 1047879 Change-Id: I762fbf6f1b4b752a47b34e6a101a066d0c78aebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036005Reviewed-by:
-
Matt Menke authored
This was only used by an (unused) URLRequestContextBuilder method, some URLRequest LoadTimingInfo tests, and in the Cronet test fixture. This CL removes the first two uses, and moves the class over to Cronet. This CL also removes two other unused methods from URLRequestContextBuilder. Bug: none Change-Id: Id850440993e5b69b1ac5412a23243ece1200333a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033693 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738204}
-
Takumi Fujimoto authored
A tab mirroring source from a Cast SDK enabled website (e.g. Google Slides) uses the mirroring app ID rather than the tab mirroring URN. We need to set the tab ID in CreateRoute() for those cases. An alternative way to do this would be making IsTabMirroringSource() return true for those cases, but there's code that assumes support for the audio mirroring app (separate ID from the mirroring app) if IsTabMirroringSource() is true, which wouldn't make sense given the app ID would not be the same as one specified. Bug: 1047788 Change-Id: I100ccbd881854ddbae33b94474761a816061573c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033926Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#738203}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2543c5cbffca..11cc3e8ebc7e git log 2543c5cbffca..11cc3e8ebc7e --date=short --first-parent --format='%ad %ae %s' 2020-02-04 aerotwist@chromium.org [e2e] Implements waitFor helper 2020-02-04 tvanderlippe@chromium.org Migrate snippets/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@11cc3e8ebc7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1047671 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I263c3e3b7d618737481d3d9cfc9c1fd8e89ef129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036829Reviewed-by:
-
Mark Yacoub authored
BUG=987274 TEST=DrmOverlayValidatorTest, HardwareDisplayControllerTest, HardwareDisplayManagerTest Change-Id: I693464b560384bf42cc9bed9fbe2e68cea5474ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036641 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#738201}
-
Jeremy Roman authored
These are guaranteed to be valid, non-null strings. Getting a null string here indicates that UTF-8 decode failed, in which case propagating a null string is not the right thing to do. Test included. This test would trigger the DCHECK in the linked bug without this fix. Bug: 1047753 Change-Id: I9e31d50176563d339b07883bbc2e5b52c4ff7641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033568 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#738200}
-
Renato Silva authored
Changes the color of the dropdown arrow to switch between users to Google Grey 200. Fixed: 1006436 Change-Id: Ie4c1151e4dee2dc201378cdb111667e7b1b89680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036175 Auto-Submit: Renato Silva <rrsilva@google.com> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
John Delaney authored
Bug: 1045468 Change-Id: I5f581a84466270258186b9b4b2ddd73ce91970f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036652Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738198}
-
Jiaqi Han authored
In component build cast_shell from the chromecast:all target, transitive dependencies are not considered from deps, therefore gn desc output does not include them. Add cast_shell to data_deps. Bug: b/143469595 Test: CQ Change-Id: Icbe7afb962a61535da6d166d579aaaf75d2a9faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036768 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#738197}
-
Abhijeet Kandalkar authored
This CL uses downcast helper for below media classes, - InbandTextTrack - TrackBase - AudioTrack - VideoTrack Bug: 891908 Change-Id: I1c2e68211be3bc60891c3666c6e044f78f3f74ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037271Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#738196}
-
Rohit Agarwal authored
Focusing on Omnibox when incognito tab opening intents are handled, results in partially hiding incognito NTP text and totally hiding incognito tabs count. These two elements are used to warn user about scope of incognito and possibility of prior state. Since 1p apps go through a privacy review and can be enforced to have an interstitial before opening an incognito tab, this feature would be limited to them, given that they would show a suitable interstitial before opening an incognito tab. Bug: 1030188 Change-Id: If031ee8e57ae4ef34c263a7bbc3f8ca996b3971b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012026 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#738195}
-
Samuel Huang authored
This reverts commit 77cffbd1. Reason for revert: This causes compile error in linux-chromeos-chrome. Original change's description: > [test] Clean up some incorrect use of ScopedRunTimeout in //chrome. > > ScopedRunTimeout is intended to be used to fail tests if a loop is Run() > for too long, rather than to Run() the loop for a specific length of > time. > > Clean up some tests which were using ScopedRunTimeout inappropriately. > > Bug: 1021777 > Change-Id: If6b2ee5f3eab498698d09fdee103e759fff51ead > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033445 > Auto-Submit: Wez <wez@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738180} TBR=xiyuan@chromium.org,wez@chromium.org,gab@chromium.org,eroman@chromium.org,mmenke@chromium.org Change-Id: I919d3ce3bdf4430b05664849f8f57b31a21cc3df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037315Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#738194}
-
John Budorick authored
DPAD_CENTER appears to have been unreliable and caused test flake. This CL also limits forms to a single autofocus element. Bug: 1048365 Change-Id: I6d1c29f8fc50c4e70e57fe3c65d6f6b59a0fc694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036644Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#738193}
-
Ken MacKay authored
Merge-With: eureka-internal/359612 Merge-With: nest-camera-internal/53240 Bug: internal b/139311908 Test: cast_audio_backend_unittests Change-Id: I318d6030effce41bc5c9cd30fe3759a96800716f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036636Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#738192}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e86a6a616ab..3a1145d2eb00 Created with: gclient setdep -r src-internal@3a1145d2eb00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5c74bf435d0fe9a305b010d4953c61e43a8ba559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036828Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738191}
-
Vasiliy Telezhnikov authored
Currently SurfaceControl takes color space of overlay from GLImage. This CL fixes missed setting color space from SharedImageBackingAHB to OverlayImage. Change-Id: If0c53160a1bfdfb99d8dc40a2e44e1ba04962018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037311 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#738190}
-
Christoph Schwering authored
- |ignore_text_changes_| was not used anywhere. - |provisionally_saved_form_| was a std::unique_ptr<FormData> only to model optionality. Bug: 1007974 Change-Id: I1369b1d98e639acb8068ef7c5e51bc494a6b43ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036061Reviewed-by:
-
