GitLab

Added is_view_source boolean to VisibleSecurityState.
GetSecurityLevelForRequest now checks that flag and returns 'NONE' for
pages that would return SECURE or EV_SECURE without the flag.
Added tests that validate the new behavior

Bug: 712482
Change-Id: Ic23c20ffdb92262987dae2119148932cb9d187a6
Reviewed-on: https://chromium-review.googlesource.com/773218
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517886}

Bug: 718413
Change-Id: I51a6a4b65c51495098778226d8976d2a7136cb78
Reviewed-on: https://chromium-review.googlesource.com/779183
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517885}

Bug: 783977
Change-Id: Ib9977a73f9f8021bf9204cd594a9e40fd8d03341
Reviewed-on: https://chromium-review.googlesource.com/777553
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517884}

Also stop observing the MessageCenter, which is in another process (in
--mash).

The UMA is a little wonky, even before this change, because manually
closing the notification is not explicitly logged. It will need to be
reworked in the new style of notifications because if closing doesn't
count as "decline" then nothing does. For now this more or less
maintains existing behavior.

Bug: 783018
Change-Id: I69278c0653d8548ccd1fe6a66015b7cf08a0d08c
Reviewed-on: https://chromium-review.googlesource.com/777739Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517883}

Since we switched to error prone to do static analysis, fixing warnings
introduced by my changes.

Bug: None
Change-Id: I9b4e2593f217b424658e344957f8f4aadff2d2cd
Reviewed-on: https://chromium-review.googlesource.com/777947Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517882}

SSIA.

This is a follow up of https://crrev.com/c/644946.

TBR=spang@chromium.org
BUG=786761

Change-Id: I23b278b0e32b00b8fbfccbe0cbc89a5cc9ca4833
Reviewed-on: https://chromium-review.googlesource.com/779779
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#517881}

Currently, InstantAppsSettings.shouldShowBanner will never allow a
banner to be shown if the instant app is default, so this change allows
the banner to show even if the app is installed.

This won't change the behaviour as it stands, because we currently
launch the instant app if it's installed before we launch a banner.
The shouldLaunchInstantApp method is added for the purpose of
overriding downstream to avoid launching an instant app when we want
to launch a banner.

Bug: 781003
Change-Id: I430e29839f2592517d2583c5d7589d3044b0174e
Reviewed-on: https://chromium-review.googlesource.com/772809
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517880}

Fixes an issue where fullscreen video wasn't positioned correctly in the
low power tree for some sites, and a longstanding issue where clipped
videos become un-clipped in the fullscreen low power tree.

Made possible by two changes:

- Black and transparent backgrounds are no longer rendered as IOSurfaces
  for color correction. For macOS to consider a layer solid black, it
  needs to actually have a black background color (and no contents).
  Note: I think we can avoid IOSurface replacement by setting a flag or
  two on the CAContext. See https://crrev.com/c/742663.

- Instead of constructing a new layer tree for fullscreen low power,
  just make the root layer black and match its size to the background to
  meet the "opaque black superlayer" requirement for detachment. A nicer
  solution could be to send the browser a color, since it already has a
  solid color superlayer, in which case no special handling for
  fullscreen layer detachment would be needed at all, it would "just
  work". It still needs to be determined whether that would comply with
  the HTML fullscreen spec. See https://crbug.com/785001.

Bug: 781637
Change-Id: I94abb1ade9c58c218296a27f9a7bc3630d4a0c64
Reviewed-on: https://chromium-review.googlesource.com/775139
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517879}

Attempt to use adb_gdb on an app that is not debuggable fails with
cryptic "Could not copy gdbserver to the device!" error. The real
cause is failing run-as when getting APP_DATA_DIR.

This CL handles run-as errors in that case and fails with more
actionable message.

Change-Id: I5053c6209425cf3e6321b70ffc6d40015341d2c7
Reviewed-on: https://chromium-review.googlesource.com/777765Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517878}

BUG=

Change-Id: I1a9c81887aa57f5c06f7ba69bfa775a793adb10c
Reviewed-on: https://chromium-review.googlesource.com/779705Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517877}

The only operations carried out on form_controls_ are insertions, removals
and iterating through the entire list. Insertion and removal can be done
faster with a DoublyLinkedList.

Since the nodes for the DoublyLinkedList are Oilpan objects, this CL
introduces HeapDoublyLinkedList that uses Member for the head and tail
pointers, and traces the pointers.

This improves the performance of HTMLInputElement::InsertedInto and
HTMLInputElement::RemovedFrom by ~15%.

Bug: 
Change-Id: I5b4cd20737e0276bece2430edfb7ec9609690f04
Reviewed-on: https://chromium-review.googlesource.com/758877Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517876}

Update call sites that were manually scrolling to find Tools
menu items to use this new shared method.

Bug: 638674
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I144e8c5872ae350e2697f8da474bfd110ae145cb
Reviewed-on: https://chromium-review.googlesource.com/779040Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517875}

Reland commit 26bf6f9f. Fixed
the WebContentsVideoCapture device test, it is the only other
class directly creating a TestRenderViewHost which caused a
CFI failure.

SetFocus for non-proxy frames are sent input message over mojo.
RenderFrameProxyHost based messages are still sent via
InputMsg_SetFocus chrome IPC since there is no widget input handler
for these situations.

In order to grab the mojo input message we are required to subclass
the RenderWidgetHostImpl to be able to provide a mock interface.

BUG=722928
TBR=nick@chromium.org

Change-Id: I80e2fd8fee12619b87031ea18fe869de70ce01ac
Reviewed-on: https://chromium-review.googlesource.com/779242Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517874}

Bug: 786074
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I63330a3ababd79f58fb19faa3531411d179122a4
Reviewed-on: https://chromium-review.googlesource.com/768525Reviewed-by: Ben Greenstein <bengr@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517873}

ChromeEarlGrey has utilities to navigate back and reload.

Bug: 638674
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I78f7dc7af7e2f9e8a7d1585cafc91987ff6ec2aa
Reviewed-on: https://chromium-review.googlesource.com/777603Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517872}

Bug: 
Change-Id: Iddc38fc951d51d1c2f1d7f59132ffae9cd209dbc
Reviewed-on: https://chromium-review.googlesource.com/779100Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517871}

The test calls ConnectivityManager.getActiveNetwork() which is an Android M API.

Bug: 786423
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id26b4eb49294a35129fc9cc300084ee293403ca5
Reviewed-on: https://chromium-review.googlesource.com/777299Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517870}

No user-visible change, just modernizing the code behind the
chrome://accessibility Accessibility Internals page.
We were calling CallJavascriptFunctionUnsafe, which was unsafe because
the page might not have been ready. Switch to using a WebUIMessageHandler
so we can call AllowJavascript() when we get a message from the page,
indicating we're sure it's ready, then future calls to CallJavascriptFunction
will succeed. See https://goo.gl/qivavq for details.

Bug: 785493
Change-Id: I1623aae2be16b968ae8d7b17058348980637f02c
Reviewed-on: https://chromium-review.googlesource.com/772876Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517869}

R=ojan@chromium.org

Change-Id: Idbbd5e7bed12d41c8b53dd99233386d502bd8da3
Reviewed-on: https://chromium-review.googlesource.com/778323Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517868}

CustomNotificationBuilder is not used on N+.
BUG=779228

Change-Id: Ic8bf59e6b6e2d58306dbb53eb26a26f878e9b4e8
Reviewed-on: https://chromium-review.googlesource.com/777420Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517867}

LogEvent computes the time between the current event and navigation
start. It gets the navigation start time from WebPerformance::
NavigationStart() which is a wall time (i.e. base::Time), but before
this CL, it got the current time from base::TimeTicks::Now(). This CL
fixes that by using base::Time::Now() instead and also cleans up the
code a bit.

I believe this is a pure cleanup, though I'm not entirely sure if the
old way always delivered well-defined results.

Bug: 777568
Change-Id: I81ed3e1fae2650a6bbc053ae8a4917a8e6c91f5e
Reviewed-on: https://chromium-review.googlesource.com/776854
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517866}

SimpleCache: Revert temporary DCHECK -> CHECK conversion + extra checks from https://chromium-review.googlesource.com/c/chromium/src/+/728344

It's been a month (and it didn't catch anything), new branch should be
coming up soon, and there is some DCHECK-enabled testing happening in
canaries, too.

Bug: 774652
Change-Id: I1866b49fd0cbe906215555be496cbf9a61df73f9
Reviewed-on: https://chromium-review.googlesource.com/779224Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517865}

The initiator is used for checking cookies.
And it is mising from the URLRequest when URLLoader is used.
For example, DownloadContentTest.DownloadAttributeSameOriginRedirect will redirect
a link click to a download with a different origin.
Download should pass the initiator in the URLRequest,
but missing it causes the wrong cookie to be passed.
This CL sets the intiator in the URLRequest so the above test can partially work.

BUG=786598

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I4efffd41fc9ca26063d853ce03e7c7ff817a917c
Reviewed-on: https://chromium-review.googlesource.com/777552Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517864}

Change adds support for installing Debian Stretch sysroot for mips64el.

BUG=751812

Change-Id: Iaa32d0b0701b17a49e0ac735134ad85cf746fe23
Reviewed-on: https://chromium-review.googlesource.com/776873Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517863}

https://skia.googlesource.com/skia.git/+log/f9ec4707ee13..b842703085a9

$ git log f9ec4707e..b84270308 --date=short --no-merges --format='%ad %ae %s'
2017-11-18 benjaminwagner Add Linux IntelHD405 Vulkan jobs.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: If2063ed60838aa9e07ca660f143007f4a511ad8b
Reviewed-on: https://chromium-review.googlesource.com/779301Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517862}

This is important because otherwise there will be a race between the virtual
time budget expiring and the side effects of asynchronous dom storage methods.

Bug: 777763
Change-Id: I41481070958a0e47232c8d5f22fbfbe5894ec605
Reviewed-on: https://chromium-review.googlesource.com/730711
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517861}

This name better matches what we do else where.

BUG=none
TEST=none

Change-Id: I8e820ec89c45b09844caba3f8b450a23449c108f
Reviewed-on: https://chromium-review.googlesource.com/775879
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517860}

Adds a flag to webrtcLoggingPrivate's RequestInfo that causes the API
functions to look up the render process id for a webview in the caller's
web contents.

There are 2 ways webrtcLoggingPrivate functions can be called.

  1. From a whitelisted component extension on behalf of a page with the
  appropriate origin via a message from that page. In this case, either the
  guest process id or the tab id is on the message received by the component
  extension, and the extension can pass that along in RequestInfo as
  |guest_process_id| or |tab_id|.

  2. From a whitelisted app that hosts a page in a webview. In this case,
  the app should call these API functions with the |target_webview| flag
  set, from a web contents that has exactly 1 webview .

Case 1 was already supported before. This change adds support for case 2.

Bug: 777933
Change-Id: I02f6d011fc7a6f1589c10aff19dc6e6e8f2e24a8
Reviewed-on: https://chromium-review.googlesource.com/763911
Commit-Queue: Adrian Elder <aelder@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517859}

When premultiplyAlpha is set to "none" in ImageBitmapOptions, we should never pass through premul
format in color managed ImageBitmap code.

Bug: 781908, 785313
Change-Id: I3a2fc1664dd57530bdc31694c5f9d61e95a9501b
Reviewed-on: https://chromium-review.googlesource.com/759116
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517858}

- This method returns a WebNotificationManager so updated the
method to reflect this.

- This avoids confusion with the NotificationManager (a subclass of
WebNotificationManager living outside of blink).

Bug: 
Change-Id: Id9d1746d31cafa7ee68bfdd5b996c625b6834057
Reviewed-on: https://chromium-review.googlesource.com/775198Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517857}

NOTRY=true

Bug: 769401
Change-Id: Id963e057735613afd481658c1fa566f0b792dd49
Reviewed-on: https://chromium-review.googlesource.com/779085
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517856}

This reverts commit 6d8b790a.

Reason for revert: All those tests are failing on:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak

Sorry for the revert, but since they are new tests, please fix or mark them off for this bot before submitting.

Original change's description:
> Media Controls: Double tap on either side to jump
> 
> Add double tap gesture recognition to MediaControlOverlayPlayButton so
> it can detect double tap gestures on the side and jump accordingly. Adds
> LayoutTests as a virtual test suite so they are tested with the modern
> media controls flag on.
> 
> BUG=779989
> 
> Change-Id: I6e62f88bc51794b21132ec0532cdbd8c5ccbb677
> Reviewed-on: https://chromium-review.googlesource.com/757138
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517839}

TBR=jbroman@chromium.org,mlamouri@chromium.org,beccahughes@chromium.org,steimel@chromium.org

Change-Id: If381e9ad02782008083d78b24edfd92042f63818
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 779989
Reviewed-on: https://chromium-review.googlesource.com/779226Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517855}

Change-Id: I9ba559836293512cfcc71632cb40917a98dfa4ef
Reviewed-on: https://chromium-review.googlesource.com/777028Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517854}

Bug: 764441
Change-Id: Iea755b93f9f6506603dee28f10cf06c88a63d109
Reviewed-on: https://chromium-review.googlesource.com/775145Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517853}

Nothing in the spec [1] mentions having to convert JS null to a
null/empty string internally and the wpt test indicates we should
just do the default, i.e. stringify to "null", so remove the
TreatNullAs extended attribute.

Behavior matches Firefox and Edge.

[1] https://html.spec.whatwg.org/#dom-tdth-headers

Bug: 651762

Change-Id: I400d86bfa19702cef4607c2ae0d21a2becf7ee0a
Reviewed-on: https://chromium-review.googlesource.com/776237Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#517852}

Provide friendlier-sounding suggestions that are more efficient for screen reader use.

Bug: 785436
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifbf93609bc274f445e8ae81cccb5cb60a705da2e
Reviewed-on: https://chromium-review.googlesource.com/772316
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517851}

The original CL added a javatest and its dependencies to the apk_under_test.
This causes the dependencies to be stripped from the instrumentation_apk, which
causes issue. This CL updates the build configuration so that the javatest and
its dependencies are only added to the instrumentation_apk.

This is a reland of e0b4355f
Original change's description:
> Add Android OOP HP end-to-end tests.
>
> This CL has three components:
>   1) The bulk of the logic in OOP HP was refactored into ProfilingTestDriver.
>   2) Adds a java instrumentation test, along with a JNI shim that forwards into
>   ProfilingTestDriver.
>   3) Creates a new apk: chrome_public_apk_for_test that contains the same
>   content as chrome_public_apk, as well as native files needed for (2).
>   chrome_public_apk_test now targets chrome_public_apk_for_test instead of
>   chrome_public_apk.
>
> Other ideas, discarded:
>   * Originally, I attempted to make the browser_tests target runnable on
>   Android. The primary problem is that native test harness cannot fork
>   or spawn processes. This is difficult to solve.
>
> More details on each of the components:
> (1) ProfilingTestDriver
>   * The TracingController test was migrated to use ProfilingTestDriver, but the
>   write-to-file test was left as-is. The latter behavior will likely be phased
>   out, but I'll clean that up in a future CL.
>   * gtest isn't supported for Android instrumentation tests. ProfilingTestDriver
>   has a single function RunTest that returns a 'bool' indicating success. On
>   failure, the class uses LOG(ERROR) to print the nature of the error. This will
>   cause the error to be printed out on browser_test error. On instrumentation
>   test failure, the error will be forwarded to logcat, which is available on all
>   infra bot test runs.
> (2) Instrumentation test
>   * For now, I only added a single test for the "browser" mode. Furthermore, I'm
>   only testing the start with command-line path.
> (3) New apk
>   * libchromefortest is a new shared library that contains all content from
>   libchrome, but also contains native sources for the JNI shim.
>   * chrome_public_apk_for_test is a new apk that contains all content from
>   chrome_public_apk, but uses a single shared library libchromefortest rather
>   than libchrome. This also contains java sources for the JNI shim.
>   * There is no way to just add a second shared library to chrome_public_apk
>   that just contains the native sources from the JNI shim without causing ODR
>   issues.
>   * chrome_public_test_apk now has apk_under_test = chrome_public_apk_for_test.
>   * There is no way to add native JNI sources as a shared library to
>   chrome_public_test_apk without causing ODR issues.
>
> Finally, this CL drastically increases the timeout to wait for native
> initialization. The previous timeout was 2 *
> CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL, which flakily failed for this test.
> This suggests that this step/timeout is generally flaky. I increased the timeout
> to 20 * CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL.
>
> Bug: 753218
> Change-Id: Ic224b7314fff57f1770a4048aa5753f54e040b55
> Reviewed-on: https://chromium-review.googlesource.com/770148
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Brett Wilson <brettw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517541}

Bug: 753218
TBR: brettw@chromium.org
Change-Id: Ic6aafb34c2467253f75cc85da48200d19f3bc9af
Reviewed-on: https://chromium-review.googlesource.com/777697
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517850}

Bug: 786995
Change-Id: Ifd48a214d84503e571abd6da6884dd17cfa90a3b
Reviewed-on: https://chromium-review.googlesource.com/779639Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517849}

WebRTC api:video_frame_api is splitting into two targets, and all
targets that include i420_buffer.h must depend on a new target
api:video_frame_api_i420. This CL fixes that for Chromium.

Bug: webrtc:7504
Change-Id: Ic383a5592a5b01a4463565326fe4fecd2fc96829
Reviewed-on: https://chromium-review.googlesource.com/776715Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517848}

* Remove duplicate includes.
* Include spdy_session.h for SpdySession::TimeFunc.
* s/NULL/nullptr/
* Ever since https://crrev.com/199633019 landed three and a half years
  ago, |expected_status| argument of CreateSpdySessionHelper() is
  unused.  Remove it, and remove the inaccurately named
  TryCreateSpdySessionExpectingFailure().
* Move |this_header| and |this_value| declaration closest to their first
  use in AppendToHeaderBlock().  The compiler should be smart enough to
  optimize this.
* In the same method use implicit pointer to bool conversion in DCHECKs.
* Purge naked news in favor of MakeRefCounted<> or make_unique<>.
* s/expected_error/expected_status/ for consistency.
* Use TestCompletionCallback::GetResult() [1] in
  CreateSpdySessionHelper() instead of inlining it.

[1] https://cs.chromium.org/chromium/src/net/base/test_completion_callback.h?l=72

Bug: 
Change-Id: Id5bc3f37f068f78901afbf8fb027cc6c63744b22
Reviewed-on: https://chromium-review.googlesource.com/775868
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517847}