Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 28 Jul, 2018 38 commits
  3. 27 Jul, 2018 2 commits
    • Jordy Greenblatt's avatar
      [CrOS MultiDevice] Feature toggle element for controlling prefs · c8df356d
      Jordy Greenblatt authored 
      Toggle button that controls a given pref.

The element uses the SettingsBooleanControlBehavior, which causes its
behavior to parallel that of settings-toggle-button. However, the
settings-toggle-button has a few disadvantages for the MultiDevice Settings
UI use case that made it expedient to create this new element to use
instead:

(1) The settings-toggle-button is designed as an entire row (as opposed to
just a toggle) and it does not allow a button to replace the feature toggle
in the DOM. Because the type of user input varies depending on the state of
the user's GAIA account, this UI would have either have to completely detach
and reattach its items when they switched input types or else it would have
to change the settings-toggle-button to allow it to detach or at least hide
its toggle.
(2) In order to match the pattern of the network-summary-item used for the
Instant Tethering feature our items have SVG icons, which would require
further refactoring of the settings-toggle-button to accommodate.
(3) We need toggles to control the unified MultiDevice feature suite and
toggles for individual features. The latter case requires more explanation
and as a result has some identifying features that do not necessarily
apprear in the former case.


Bug: 824568
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I986382a8aac31781e3d27c1f44397ddb048761f4
Reviewed-on: https://chromium-review.googlesource.com/1149001
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578869}
      c8df356d
    • Daniel Murphy's avatar
      Revert "[DOMStorage] Moving cached namespaces to std::map" · 198b861b
      Daniel Murphy authored 
      This reverts commit 080fe17e.

Reason for revert: The corruption is still there, but now failing on Windows.

Bug: 865393

Original change's description:
> [DOMStorage] Moving cached namespaces to std::map
> 
> There has been a bunch of memory-corruption-smelling crashes around this
> area. Changing the container to a std::map should give us more
> information about where this is happening, and maybe cause it to crash
> somewhere else.
> 
> R=​mek@chromium.org
> 
> Bug: 845400,821371,857464
> Change-Id: Ife8cb10336a4f0752db89e2bca836ed873f7c711
> Reviewed-on: https://chromium-review.googlesource.com/1129849
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573452}

TBR=dmurph@chromium.org,mek@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 845400, 821371, 857464
Change-Id: Ie120acf347713d9c6172f26082ed9b18c3cc38bc
Reviewed-on: https://chromium-review.googlesource.com/1153987
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578868}
      198b861b