GitLab

To maintain synchronous scripting backward compatibility, v8 arrays should
always be converted to object vars when allowed. I have added a comment
explaining the conversion of objects in more detail.

This CL also adds a check to ensure that when we convert an object var to
a v8 value that it is never nested inside of an array or dictionary. Before
we switched from NPObject to gin, this was never possible so there is no
need to add this functionality now and we should restrict this case from
ever happening.

BUG=411445

Review URL: https://codereview.chromium.org/566463002

Cr-Commit-Position: refs/heads/master@{#294785}

https://skia.googlesource.com/skia/+log/8e45c3777d886ba3fe239bb549d06b0693692152..e6cb48382db869f8e194b83aec80fd495be76db7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/570963002

Cr-Commit-Position: refs/heads/master@{#294784}

This reverts commit 80931e51.

Linux GN build failed:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12251

BUG=
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/571853002

Cr-Commit-Position: refs/heads/master@{#294783}

Revert of PPAPI: Fix GetBrowserInterface race conditions (patchset #6 id:100001 of https://codereview.chromium.org/568793002/)

Reason for revert:
Sorry to revert but I randomly noticed this to be causing a top crasher e.g. go/crash/75090c1e31f33cfd

The reason is because the patch explicitly calls PluginGlobals::SetPluginProxyDelegate with NULL from PpapiThread::Shutdown but the pointer is used immediately inside the function.

I guess it should be a simple fix. I was going to put up a fix which just reset the browser_sender_ to NULL in that case, but then I noticed there were cases where we call GetBrowserSender() and use it without checking whether it is NULL (e.g. https://code.google.com/p/chromium/codesearch#search/&q=%22PluginGlobals::Get()-%3EGetBrowserSender()-%3ESend%22&sq=package:chromium&type=cs)

I felt it would be better to just revert for now, sorry :(

Original issue's description:
> PPAPI: Fix GetBrowserInterface race conditions
>
> BUG=413513
>
> Committed: https://crrev.com/d1b2c8f719b0ab471a476bf53911a3657bb4c06a
> Cr-Commit-Position: refs/heads/master@{#294715}

TBR=teravest@chromium.org,piman@chromium.org,dmichael@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413513

Review URL: https://codereview.chromium.org/566243004

Cr-Commit-Position: refs/heads/master@{#294782}

https://skia.googlesource.com/skia/+log/abaef86f2b37d8a939506a2076da07f6db456951..8e45c3777d886ba3fe239bb549d06b0693692152

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/557833005

Cr-Commit-Position: refs/heads/master@{#294781}

BUG=

Review URL: https://codereview.chromium.org/477923004

Cr-Commit-Position: refs/heads/master@{#294780}

This change:
- Adds running the GC until the v8 heap size reaches steady state during
  ModuleSystemTest::TearDown. This is necessary to ensure that
  gin::Wrappable objects are freed, as finalizers for JS objects aren't
  run during isolate shut down.
- Removes a racy check that failed under valgrind.

BUG=389016,406487

Review URL: https://codereview.chromium.org/502893002

Cr-Commit-Position: refs/heads/master@{#294779}

graph.py in dmprof needs to support policies without l2

R=dmikurube@chromium.org,kouhei@chromium.org
BUG=413999

Review URL: https://codereview.chromium.org/567173002

Cr-Commit-Position: refs/heads/master@{#294778}

This CL splits the common drop_target_ member of AppsGridView into
reorder_drop_target_ and folder_drop_target_. This more clearly shows
the purpose which a drop target is being used for.

This also slightly changes the behavior when dropping an app into a
full folder as the latest reorder drop target will be used for
reordering instead of the common drop target which would have pointed
at the folder.

BUG=411775

Review URL: https://codereview.chromium.org/557673002

Cr-Commit-Position: refs/heads/master@{#294777}

Revert of Clean up GestureEventDetails constructors (patchset #4 id:100001 of https://codereview.chromium.org/565583005/)

Reason for revert:
This seems to fail the following tests in "athena_unittests" on "Linux ChromiumOS Tests (dbg)(3)"

- HomeCardGestureManagerTest.Basic
- HomeCardGestureManagerTest.StartCentered

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36778

Original issue's description:
> Clean up GestureEventDetails' constructors.
>
> In one of the GestureEventDetails' constructors, the arguments
> delta_x, delta_y sometime are not used, so we should make a new
> constructor which only takes one argument EventType.
>
> BUG=350942
>
> Committed: https://crrev.com/b5e408e7bffd3d1e6b60612f65c0538a90329c59
> Cr-Commit-Position: refs/heads/master@{#294760}

TBR=tdresser@chromium.org,jdduke@chromium.org,sadrul@chromium.org,sky@chromium.org,lanwei@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=350942

Review URL: https://codereview.chromium.org/572593002

Cr-Commit-Position: refs/heads/master@{#294776}

Currently, if a JS connector is left to be garbage collected, the handle
and the WaitingCallback both become ready to be collected at the same
time. If the handle is collected first, this results in an asynchronous
wait on a closed handle. With this change, WaitingCallback registers
itself as an observer to be notified when the handle it's watching is
closing and cancels the wait if the handle closes while the wait is in
progress.

BUG=406487

Review URL: https://codereview.chromium.org/534953002

Cr-Commit-Position: refs/heads/master@{#294775}

Mac creates a mini-framework in `ui_unittests Framework` so that ui
tests can get a resource bundle without depending on the Chrome
framework.

The way it generated locale information was causing build flakes since
two instances of repack_locales.py could be writing to
out/../gen/repack. Tests always use en-US, so instead just repack the
strings made for ui_test.pak to en.lproj/locale.pak and roll it into the
mini-framework bundle.

Note we can't simply copy ui_test.pak because Mac system libraries will
annoy valgrind with leaks when they encounter unexpected things in it.

BUG=410468, 413034

Review URL: https://codereview.chromium.org/565063002

Cr-Commit-Position: refs/heads/master@{#294774}

Revert of Remove deprecated extension notification from content_settings (patchset #6 id:240001 of https://codereview.chromium.org/276573011/)

Reason for revert:
Becuase this CL seems to break linux asan test
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/882

Original issue's description:
> remove deprecated extension notification from content_settings.
>
> Use ExtensionRegistryObserver instead.
>
> R=bauerb@chromium.org
> BUG=354046, 354458
> TEST=unit_tests
>
> Committed: https://crrev.com/76ad58487578183de69a8caeb48b8a22dccad652
> Cr-Commit-Position: refs/heads/master@{#294768}

TBR=bauerb@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=354046, 354458

Review URL: https://codereview.chromium.org/553263004

Cr-Commit-Position: refs/heads/master@{#294773}

https://chromium.googlesource.com/chromium/blink/+log/abf5ffe757e0da9eb3fdf1d1929c319fb8d74705..3f1bcc4d1f8057a7da5bc204180939f7fbc4e7d9
TBR=

Review URL: https://codereview.chromium.org/568353002

Cr-Commit-Position: refs/heads/master@{#294772}

https://chromium.googlesource.com/chromium/blink/+log/30ae3179e00e720c07a838db244e93ebd8bb995c..abf5ffe757e0da9eb3fdf1d1929c319fb8d74705
TBR=

Review URL: https://codereview.chromium.org/563163003

Cr-Commit-Position: refs/heads/master@{#294771}

https://chromium.googlesource.com/chromium/blink/+log/191f7180a839d03a8b19dbb03d15701f875ad800..30ae3179e00e720c07a838db244e93ebd8bb995c
TBR=

Review URL: https://codereview.chromium.org/557583003

Cr-Commit-Position: refs/heads/master@{#294770}

TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/573583002

Cr-Commit-Position: refs/heads/master@{#294769}

Use ExtensionRegistryObserver instead.

R=bauerb@chromium.org
BUG=354046, 354458
TEST=unit_tests

Review URL: https://codereview.chromium.org/276573011

Cr-Commit-Position: refs/heads/master@{#294768}

Cr-Commit-Position: refs/heads/master@{#294767}

BUG=
TBR= dpranke@chromium.org

Review URL: https://codereview.chromium.org/572533002

Cr-Commit-Position: refs/heads/master@{#294766}

Revert of Fix some more for= usage. (patchset #7 id:120001 of https://codereview.chromium.org/539383003/)

Reason for revert:
breaks linux_chromeos on try runs here and on buildbot

Original issue's description:
> Fix some more for= usage.
>
> Also fix some controlled settings indicators.
>
> BUG=409938
> R=dbeam@chromium.org
>
> Committed: https://crrev.com/ce80b519af00bb6259e8c63f91fee5263d818124
> Cr-Commit-Position: refs/heads/master@{#294681}

TBR=dbeam@chromium.org,estade@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409938

Review URL: https://codereview.chromium.org/562023003

Cr-Commit-Position: refs/heads/master@{#294765}

This reverts commit 711d923e.

flaky a bunch of times. as an example, see
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%282%29/builds/22538/steps/content_browsertests/logs/AccessibilityFrameset
DumpAccessibilityTreeTest.AccessibilityFrameset (run #1):
[ RUN      ] DumpAccessibilityTreeTest.AccessibilityFrameset
Testing: E:\b\build\slave\Win7_Tests__dbg__2_\build\src\content\test\data\accessibility\frameset.html
c:\b\build\slave\win_builder__dbg_\build\src\content\browser\accessibility\dump_accessibility_tree_browsertest.cc(252): error: Value of: is_different
  Actual: true
Expected: false
[3080:2208:0913/171203:4867433:WARNING:channel.cc(211)] WriteMessage() while shutting down
* Line Expected
- ---- --------
     1 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
     2     ROLE_SYSTEM_CLIENT FOCUSABLE
     3         IA2_ROLE_SCROLL_PANE
     4             ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
     5                 IA2_ROLE_PARAGRAPH
     6                     ROLE_SYSTEM_STATICTEXT name='My favorite browser is '
     7                     ROLE_SYSTEM_STATICTEXT name='ABC'
     8                     ROLE_SYSTEM_STATICTEXT name='Chrome'
     9                     ROLE_SYSTEM_STATICTEXT name='!'
    10     ROLE_SYSTEM_CLIENT FOCUSABLE
    11         IA2_ROLE_SCROLL_PANE
    12             ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
*   13                 IA2_ROLE_PARAGRAPH
    14                     ROLE_SYSTEM_STATICTEXT name='This test is to check '
    15                     ROLE_SYSTEM_STATICTEXT name='mark tag'
    16                     ROLE_SYSTEM_STATICTEXT name='.'
    17 \u003C-- End-of-file -->

Actual
------
ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
    ROLE_SYSTEM_CLIENT FOCUSABLE
        IA2_ROLE_SCROLL_PANE
            ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
                IA2_ROLE_PARAGRAPH
                    ROLE_SYSTEM_STATICTEXT name='My favorite browser is '
                    ROLE_SYSTEM_STATICTEXT name='ABC'
                    ROLE_SYSTEM_STATICTEXT name='Chrome'
                    ROLE_SYSTEM_STATICTEXT name='!'
    ROLE_SYSTEM_CLIENT FOCUSABLE
        IA2_ROLE_SCROLL_PANE
            ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE

[  FAILED  ] DumpAccessibilityTreeTest.AccessibilityFrameset, where TypeParam =  and GetParam() =  (1903 ms)

BUG=

Review URL: https://codereview.chromium.org/567223002

Cr-Commit-Position: refs/heads/master@{#294764}

BUG=412086
TBR=lfg@chromium.org

Review URL: https://codereview.chromium.org/569083003

Cr-Commit-Position: refs/heads/master@{#294763}

BUG=none
TEST=none
TBR=fukino@chromium.org

Review URL: https://codereview.chromium.org/569663002

Cr-Commit-Position: refs/heads/master@{#294762}

BUG=413006
TEST=manually tested

Review URL: https://codereview.chromium.org/563253002

Cr-Commit-Position: refs/heads/master@{#294761}

In one of the GestureEventDetails' constructors, the arguments
delta_x, delta_y sometime are not used, so we should make a new
constructor which only takes one argument EventType.

BUG=350942

Review URL: https://codereview.chromium.org/565583005

Cr-Commit-Position: refs/heads/master@{#294760}

Restoring the previous behavior of nacl_io regarding utime,
such that it pretends to succeed when a mount doesn't implement utime.

BUG=https://code.google.com/p/chromium/issues/detail?id=414058
TEST=trybots
TBR=binji@chromium.org

Review URL: https://codereview.chromium.org/571773002

Cr-Commit-Position: refs/heads/master@{#294759}

Adds a new API function, chrome.usb.getConfiguration, that returns all
the data from the device's configuration descriptor instead of just the
interfaces as chrome.usb.listInterfaces does. Each level of the
descriptor hierarchy also gets an "extra_data" field which contains all
of the miscellaneous descriptors assocated with a configuration,
interface or endpoint.

BUG=382908

Review URL: https://codereview.chromium.org/558373002

Cr-Commit-Position: refs/heads/master@{#294758}

Previously, if exact_matches was True but there were no exact matches,
it would return fuzzy matches instead. This is not what the caller asked
for.

GPU test names are changed to match the buildbot config, since they were
previously relying on fuzzy matching.

SHERIFFS: May cause errors like:

  No test named "some_test_name".

  Available tests are:
    ...

If so, this CL can be safely reverted.

BUG=413334,413442

Review URL: https://codereview.chromium.org/560153004

Cr-Commit-Position: refs/heads/master@{#294757}

We already have the same msvs_disabled_warnings declared at line 172. No
need to have it twice.

BUG=331829
TEST=gfx_unittests
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/555543003

Cr-Commit-Position: refs/heads/master@{#294756}

Revert of Cleanup: Remove base/file_util.h. Convert remaining references. (patchset #1 id:1 of https://codereview.chromium.org/568873004/)

Reason for revert:
Broke some internal builds. Need to give them a chance to fix their builds.

Original issue's description:
> Cleanup: Remove base/file_util.h. Convert remaining references.
>
> TBR=brettw@chromium.org
>
> Committed: https://crrev.com/6d63c4898c2da5a286d01f80229baeb914f99f18
> Cr-Commit-Position: refs/heads/master@{#294729}

TBR=brettw@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/565803006

Cr-Commit-Position: refs/heads/master@{#294755}

This is needed for the work to drop GCM sign-in enforcement. Since
we no longer wipe out the GCM data when the user signs out, we need
to give user a chance to clear the data if he or she wants.

BUG=384041
TEST=Manual test by selecting "Cookies and other site and plugin data"

Review URL: https://codereview.chromium.org/562423002

Cr-Commit-Position: refs/heads/master@{#294754}

https://chromium.googlesource.com/chromium/blink/+log/9cb8a59cf2f63b817c4c4929dd0ba33b4c2ee7e1..1c10331d9ed2cb8073d44563b1c6e243971b7557
TBR=

Review URL: https://codereview.chromium.org/573533002

Cr-Commit-Position: refs/heads/master@{#294753}

All current versions of host and client support capabilities, we
no longer need to keep support for older versions.

Review URL: https://codereview.chromium.org/565263006

Cr-Commit-Position: refs/heads/master@{#294752}

In the baseline policy, we restrict the |clk_id| parameter allowed in
clock_gettime(). This applies to all sandboxed process types.

In the renderer policy, we similarly restrict the |clk_id| parameter for
clock_getres().

BUG=413469, 413855

Review URL: https://codereview.chromium.org/566083002

Cr-Commit-Position: refs/heads/master@{#294751}

[MIPS64] Add build support for MIPS64 in libjpeg_turbo
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo/+log/3963fbcd6c16..034e9a9747e0

TBR=rmcilroy@chromium.org
BUG=400684

Review URL: https://codereview.chromium.org/559963004

Cr-Commit-Position: refs/heads/master@{#294750}

These functions should set needs commit, but didn't. This lead to stale
pointers in the impl tree.

BUG=413743,403866

Review URL: https://codereview.chromium.org/572483002

Cr-Commit-Position: refs/heads/master@{#294749}

BUG=
TBR= jianli@chromium.org

Review URL: https://codereview.chromium.org/571553004

Cr-Commit-Position: refs/heads/master@{#294748}

BUG=78512
TEST=no change

Review URL: https://codereview.chromium.org/568163004

Cr-Commit-Position: refs/heads/master@{#294747}

Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

It's a follow up patch to https://codereview.chromium.org/414423002/. We already restructured WebContents
functionalities from ContentViewCore. In this patch we are removing unwanted ContentViewCore methods,
so that ContentViewCore stake holders can directly call these methods.

BUG=398263

Review URL: https://codereview.chromium.org/481803004

Cr-Commit-Position: refs/heads/master@{#294746}