- 21 Aug, 2020 40 commits
-
-
Maksim Sisov authored
Wayland may supply xkb layout engine with a keymap that it creates from a buffer. However, when I ran events_unittests with asan, it noticed a memory leak, which was caused by not freed keymap object. As long as we can have only one keymap from buffer at a time, store each keymap after a new context is created as unique_ptr that will be freed with a custom deleter on either dtor or when another keymap is created. Bug: 1120270 Change-Id: I741a6cb74713424f54dd858f84c0fec413cd6c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367938Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#800708}
-
Yicheng Li authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/8125d936f9e0..fa27bc456b38 $ git log 8125d936f..fa27bc456 --date=short --no-merges --format='%ad %ae %s' 2020-08-20 jiejiang system_api: bluetooth: Add AddressType constants 2020-08-19 yichengli system_api: Add start/end fingerprint auth session method constants Created with: roll-dep src/third_party/cros_system_api Change-Id: I3470f9706149ade42c7026f769246ad522eca3b4 Bug: b:156258540, b:144861739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369001 Commit-Queue: Yicheng Li <yichengli@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800707}
-
Lambros Lambrou authored
WebRTC provides a native C++ API for getting notified of changes to the selected ICE candidate-pair. This CL uses it to notify the HostStatusObserver of route changes, which enables the HostEventLogger to log the connecting client's IP address. Bug: 1119960 Change-Id: Ifa22faaeeddbf4f19e8ed422a581b840ec4caa33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368428 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#800706}
-
Pranav Batra authored
This is a reland of 81e8107c. An extra colon in the PPD string for one of the unit tests that resulted in the CUPS PPD API using an uninitialized value and being terminated by MSAN has been removed. Original change's description: > Add Linux support for printer resolutions > > Add Linux support for PPD resolution options. > > Test: ./printing_unittests > Change-Id: I15d2245567e37938633c72daa2edc66cfa6f4b22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360472 > Commit-Queue: Pranav Batra <batrapranav@chromium.org> > Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800424} Change-Id: I0ec422f96e2b8df1a5e6829110f87fde7d7dbe8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369371 Commit-Queue: Pranav Batra <batrapranav@chromium.org> Auto-Submit: Pranav Batra <batrapranav@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800705}
-
Dan Sanders authored
WebCodecs expects AVC-formatted H.264 streams, but our decoders expect Annex B. Bug: 1119947 Change-Id: I8a0d92450890a9d625d1b2a67b1ea20377bdfd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368162 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#800704}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/74161f485b5d54fe963cbd3d081b718ec84d2e00..c947efabcbc38dcf93e8ad0e6a76206cf0ec8072 Bug: none Change-Id: Ide8b6736f47d363190082cacf23ac52794107086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365093Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#800703}
-
Tommy Li authored
In the omnibox, if you mouse your mouse fast off of a row, while exiting via a child View, sometimes the whole row would stay hovered. This manifested itself by both exiting near the remove button, the suggestion button row, and the expand/collapse chevron button for header rows. This CL creates a new OmniboxMouseEnterExitHandler that generalizes the robliao/ssigwart solution to all of the row controls. It's also the same pattern used by: ArcNotificationContentView::MouseEnterExitHandler So maybe the Views team wants take over this utility class in the future. Bug: 1109473, 893183 Change-Id: Ibf3118c3cbe2231c1356778050764c93c93eb016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367396Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#800702}
-
adoneria authored
Bug: 1109373 Change-Id: Ia86eb8fd1811948e765a3ceb80acb02de85f76ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368450Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#800701}
-
Jesse Schettler authored
PrintSessionImpl checks every 100ms for a subframe that has a PDF extension loaded. When it finds the subframe and sees that it's done loading, it waits 100ms for the PDF to finish rendering and then launches print preview. Recent changes increased the amount of time it takes for the PDF to render, so slower devices are launching print preview too early. Increase the time to wait for the PDF to render from 100ms to 500ms to ensure slower devices can render the PDF before launching print preview. Bug: b:165927343 Test: arc.Print Change-Id: If3e20fc2ffa3feb74e112e1e88c8248f164e80bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369613Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ea7fbfb9665b..bce19cd0eefc 2020-08-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4591d36d..6cc8efac (800155:800536) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4ab4b27db6d0b5841411a69262c31707a5121146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800699}
-
Xinghui Lu authored
Currently the help button is linked to the general Chrome help center. We'd like it to be linked to the Safe Browsing help page directly. The Safe Browsing help page was already added in go/mobilehelprecs. To reuse more code, create an abstract class named SafeBrowsingSettingsFragmentBase. This class handles help and menu related logic. SecuritySettingsFragment, StandardProtectionSettingsFragment and EnhancedProtectionSettingsFragment inherit from this base class. Bug: 1115758 Change-Id: I0fbe28eb21c46e6a0171ea987f1f1f5595111d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353563Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800698}
-
Jose Dapena Paz authored
It is not enough to make StrongAlias noexcept. TokenType needs to also provide noexcept move constructor. Bug: 819294 Change-Id: Ib85faa18f66b41053fb71ecee32e818e05685080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369180Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#800697}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598010867-4aa503022e102f1aa007637f80b234f543663e29.profdata to chrome-mac-master-1598032222-bdae3e34bfdfdc02a739bd58b074dbcf46af85d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I893db2b8c433894570d038d445d4fd3c090c038c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369552Reviewed-by:
-
Chris Lu authored
This change also removes a DCHECK since a test is more robust. Bug: 1030357 Change-Id: I939a4ec7ed4d4e60ef3518d293cd91f4d759c138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368141 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#800695}
-
Ankit Kumar 🌪️ authored
Update PDFEngineExports to use gfx::Rect instead of pp::Rect. Update callers to expect gfx::Rect as return value instead of pp::Rect. Bug: 1101101 Change-Id: Id549e93bfa361d61eceb058c98b1e20daa4ab8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367132 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#800694}
-
David Black authored
Previously, the UI would show something like: "Good morning ," Now, the UI will show something like: "Good morning," Bug: b:165663569 Change-Id: Ie8ee966380723ce5bfc3cac3227a071046a7b611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365293Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#800693}
-
David Black authored
Feature deprecated, this code is unused. Bug: b:157510970 Change-Id: Ie6b0c6f7d75d2b11a41056b7811ff596c000569d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368417Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#800692}
-
Ankit Kumar 🌪️ authored
Update pdf/draw_utils to use gfx::Rect instead of pp::Rect. Update callers to expect gfx::Rect as return value instead of pp::Rect. Noteworthy point: Most methods in pp::Rect match gfx::Rect. One method which doesn't work the same way is Intersect(). In pp::Rect, Intersect() is a utility method which takes in two rects and returns the intersected rect. In gfx::Rect, IntersectRects() is the utility method which takes in two rects and returns the intersected rect, while Intersect() is a class method which takes in a rect and modifies the original rect to the intersected rect in place. The usage of Intersect() from pp::Point has been modifed based on whether the intent of Intersect() was to modify a rect to the intersected rect or we want to assign the intersected rect to a new variable. Bug: 1101101 Change-Id: I021c10d94c918eebe88885a2e7f5051d687ff0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366444 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by: -
cfredric authored
MediaSource.IsTypeSupported, and HTMLMediaElement.canPlayType. This is intended to collect metrics on how much entropy about the users' cross-site identity is leaked by these APIs. Bug: 973801 Change-Id: I5563fd24548e7f6e1de0062697d80951fb80e09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359568 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
George Steel authored
https://drafts.csswg.org/css-transitions/#interface-globaleventhandlers-idl Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dxDGBFKvO3A Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1797226 Original Revert: https://chromium-review.googlesource.com/c/chromium/src/+/1816818 Bug: 868224 Change-Id: I1f83765f31ba7f0902b0fdb1688e206f509f5664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258467Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#800689}
-
Richard Townsend authored
Removes an unnecessary state-assertion DCHECK. The consequences of doing this are relatively small (since PumpTokenizer checks IsStopped() anyway). Bug: 901056, 1112544 Change-Id: Ie59b6d3ba34afc0de63aa3780e6ee889f8f93c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366893Reviewed-by:
-
Justin Cohen authored
Bug: 1120723 Change-Id: Id1a510e5bd318df12207169a06c58dd2090ff297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369437 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#800687}
-
Ian Kilpatrick authored
As above. There should be no behaviour change. Change-Id: I3848546f7e634e40bb06a327b21497f45052f22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369453Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9d8fd36d3b95..682f9141d174 2020-08-21 jmadill@chromium.org Remove feedback loop support from back-end. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I36479a4e58127a37908c2befe15b3cc11d33d7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369295Reviewed-by:
-
Owen Min authored
Also fix an issue in the presubmit script when supported_on is empty. Change-Id: Ic72f06e05e11052fecba8dd013f28ba77a37848c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368174 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#800684}
-
Jie Dai authored
Test: On device with both silent and normal boot Bug: internal b/165025541 Change-Id: I20fdbf94399daa5c1c4e843539685a1027d5ff37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363370Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Jie Dai <jied@google.com> Cr-Commit-Position: refs/heads/master@{#800683}
-
Andrey Kosyakov authored
This reverts commit 5a809a08. Reason for revert: I don't think the test failure is related. Please note it stopped before the revert landed (build no 91007 vs. 91010). This must have been a flake, or a independent failure that has been fixed by one of the front-end rolls. Original change's description: > Revert "Add more checks for chrome.debugger extensions" > > This reverts commit 4838b76a. > > Reason for revert: 1119297 > > Original change's description: > > Add more checks for chrome.debugger extensions > > > > Bug: 1113558, 1113565 > > Change-Id: I99f2e030f9a38f1ffd6b6adc760ba15e5d231f96 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342277 > > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#799514} > > TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,yangguo@chromium.org,sigurds@chromium.org > > Change-Id: I01ad12ca99ac75197f9073e2c6c9d0eaa0d95147 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1113558 > Bug: 1113565 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362920 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799558} TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,yangguo@chromium.org,sigurds@chromium.org,dullweber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1113558 Bug: 1113565 Change-Id: Ic98fc037028a210204b7935b0b8e50e4e36e2397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368446Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#800682}
-
dpapad authored
Bug: 1062154 Change-Id: Ibdba6f78836ac153f2ce4bbe905891a25e759cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368083Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#800681}
-
Garrett Beaty authored
Bug: 1120401 Change-Id: If45c62f4959968fb020520632c5d73008ad49339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368448Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800680}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/85132f3cbf67..a0cf0214eefa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,nektar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041781,chromium:1075562 Tbr: xhwang@google.com,nektar@google.com Change-Id: I598e071f930217d3ff57f7e18985c3efa1c3120c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368148Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800679}
-
Xianzhu Wang authored
"Full screen within tab" [1] is to let an element requesting full screen to fill the tab space instead of the screen space. It allows the user to operate the tab (e.g. switching to another tab, dragging the tab) using the non-full-screen browser UI when capturing a screenshot or video of the full screen rendering of a web page. These capturers are operated by the user to capture a visible tab. They start capturing by calling WebContents::IncrementCaptureCount(size, /*stay_hidden*/false). These capturers are called "visible capturer" in WebContents. Internal capturers capture tab rendering (either visible or invisible) for internal use (e.g. to generate a tab thumbnail), without user awareness, so they should never have side-effects, thus should never cause full screen to enter the "within tab" mode. These captures start capturing by calling WebContents::IncrementCaptureCount(size, /*stay_hidden*/true). These capturers are called "hidden capturer" in WebContents. This CL prevents the tab from entering the "full screen within tab" mode when there is no visible capturer. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/exclusive_access/fullscreen_within_tab_helper.h;drc=4f51d5d775713e1b428ad8fa5ee131c411753f3c;l=15 Bug: 1112607 Change-Id: I1b910eeb68077f02be00c56c86f9a5bf0f0bcfc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365226Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800678}
-
Yue Zhang authored
http://crrev.com/c/2242222 sets the dialog visibility into false in TabGridDialog constructor as a default value for this field. Setting this in PropertyModel will emit a signal to hide the dialog, but the signal should be no-op as the dialog is not showing. Otherwise this will break a assumption in ScrimView and crash. http://crrev.com/c/2242222 enforces this is no-op by ignoring the signal when mScrimPropertyModel is not setup. The assumption here is that the dummy signal will always arrive earlier than the mScrimPropertyModel setup, which happens when dialog is first shown. However, this assumption no longer holds for StartSurface, because for StartSurface, the initialization of TabGridDialog (which is controlled by the initialization of TabSwitcher) can happen later than the first show of TabGridDialog. Such a flow can be: Step1) Open dialog from strip and dismiss. (This is when mScrimPropertyModel sets up.) Step2) Click the tab switcher button to enter tab switcher. (This is when the dummy hide dialog signal is sent out.) This CL fixes this issue by switching to a more stable way to filter out dummy signal: whether the dialog is showing. This way we make sure that the signals that should be no-op on dialog side are in fact no-op. Bug: 1096358 Change-Id: I6847b3d2545238933a42a6b610c07e4a9623d066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362970 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800677}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008210800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/vM9bho-P099cq08wxl7KsIWL5LU4hoPBEucxexnc_0IC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I26d45b72323c47de47d307f9e4da05554454d9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369168Reviewed-by:
-
Daniel Classon authored
Adds deep links to the People page and 6 subpages, missing only the old sync page which is in another CL. Bug: 1084154 Change-Id: I5acad5040eac889e25705c1eef29ed717e546a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358310 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#800675}
-
Juanmi Huertas authored
The clear method in CanvasResourceProvider (that ensures that buffers are initialized correnctly) was being called from the constructor in several places. Now the clear method is going to be called internally when creating a CanvasResourceProvider, so it has been removed from the places where it was called to ensure the buffer was initialized. The method CanvasResourceProvider::Clear was kept as a public method as there is still an instance of Clear in Canvas2DLayerBridge, in a method that seems to explicitly clear the canvas: Canvas2DLayerBridge::EnsureCleared() This CL addes a new parameter that can be set to kCallClear to initialize the Provider on creation. Reordering some parameters of the Creator of ResourceProvider to make all methods more similar among themselves. Bug: 1090081 Change-Id: Ibc130af381523173a40a962054645d60fa8971c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236462Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#800674}
-
Yuke Liao authored
Add an example to show how to use the test runner with xvfb Change-Id: I8ccf0750024e8ae4a8e68e8178faf38d9aa37974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368415 Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#800673}
-
Xing Liu authored
We nearly never check these metrics any more, so remove them as they expired. Bug: 1109824,1089721,1088736,1052968 Change-Id: I183912ed813b0d0fa1a56f6da108fb0568d8f358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364129Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800672}
-
Francois Doray authored
This is a pre-requisite for Beta and Stable experiments. Bug: 1101731 Change-Id: Ib127de8a4e67b2ea55b87b6053ce2ae4673566be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364819Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#800671}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a4e145832a9..be1455850c3c 2020-08-21 rmistry@google.com Temporary workaround for Canary-Chromium finishing too early If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I8fc0b5bc629996ba0ed3f6d0bbd1f806187c9419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369293Reviewed-by:
-
Vladimir Levin authored
The spec has changed to ensure that 'auto' content-visibility intersection observations are synchronous (after lifecycle) on the first frame. The test change is to expect new behavior as well as test previous behavior by making a container off-screen first. R=chrishtr@chromium.org, jarhar@chromium.org Change-Id: I0ef3182b04a2a8731a80a044689581f2a5ac3c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368509Reviewed-by:
-
