GitLab

NOTRY=True

Review URL: https://codereview.chromium.org/389433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/387003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282676 0039d316-1c4b-4281-b951-d872f2087c98

This is causing tabs to get stuck white. Removing before today's
Canary gets cut. The fix for the stuck white issue is being worked
on at
https://codereview.chromium.org/388793003/

> Mac ÜC: Make resize smooth
> 
> Add helpers to RenderWidgetHelper to associate a NSView with
> a given RenderWidgetHelper (process and widget routing id), so
> that browser compositor swaps can be received while pausing
> waiting for correctly sized frames.
> 
> BUG=388005
> TBR=cevans
> 
> Review URL: https://codereview.chromium.org/370513002

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/387863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282675 0039d316-1c4b-4281-b951-d872f2087c98

GL_TEXTURE_2D is used by x86 non-OSX platforms and by software fallback.
GL_TEXTURE_RECTANGLE_ARB will be used on OSX hardware.
GL_TEXTURE_EXTERNAL_OES is used on ARM ChromeOS.

BUG=281689

Review URL: https://codereview.chromium.org/354763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393231
R=frankf@chromium.org
TEST=Dr.Memory

Review URL: https://codereview.chromium.org/388863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282673 0039d316-1c4b-4281-b951-d872f2087c98

This is causing tabs to get stuck white. Removing before today's
Canary gets cut. The fix for the stuck white issue is being worked
on at
https://codereview.chromium.org/388793003/

> Mac: Enable delegated renderer by default
> 
> Delegated renderer disabled for layout tests (as on other platforms).
> 
> BUG=314190
> TBR=piman
> 
> Review URL: https://codereview.chromium.org/374643002

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/386943008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282672 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/366933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/382193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282670 0039d316-1c4b-4281-b951-d872f2087c98

The two linked bugs both describe situations where the user types
a URL but that URL does not appear first because the top-scoring
provider that returned the URL set it incorrectly as not allowed to
be the default match.

This changes fixes those issues by making providers (namely
HistoryQuick, Search, and Shortcuts) mark a match as
allowed_to_be_default_match if it is UWYT match for this input, or (even
if not identical) it would be dedupped against the UWYT match.
The changes to HistoryQuick and Search fix the attached
bugs.  Shortcuts does the identical part of the test, not the de-dupping part
of the test.  The Shortcuts change to handle dedupping is not to fix a
known bug; rather it's simply to make Shortcuts behave as it should
and in parallel with the other providers.

I don't think changes in other providers beyond these three are
necessary.

This change necessitated some changes to AutocompleteMatch to make a
statically-available version of ComputeStrippedDestinationURL() so we
can strip URLs (such as the UWYT URL) that isn't going to be a
AutocompleteMatch in the relevant provider.

Also removes the IsInlineable() function in BaseSearchProvider::Result,
which is only used in one place and not actually necessary in that place.
(It's computing the same thing that code there is already computing.)

BUG=383065,388397

Review URL: https://codereview.chromium.org/353223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282669 0039d316-1c4b-4281-b951-d872f2087c98

This updates Chromium to use the one-at-a-time SkPicture
clone interface since Skia is moving towards removing 
SkPicture's default and copy constructors.

Review URL: https://codereview.chromium.org/380323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282668 0039d316-1c4b-4281-b951-d872f2087c98

kContextualSearchEnabled should be a string instead of an integer, to be consistent with the calling code.

This pref was never set (ever!) on people's profiles, only registered in profile.cc. I verified with gab@ that moving to String at this point will not mess things up.

BUG=341761
R=noms@chromium.org

Review URL: https://codereview.chromium.org/386893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/385083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282666 0039d316-1c4b-4281-b951-d872f2087c98

R=beaudoin@chromium.org, beaudoin@google.com
TBR=jered
BUG=374932

Review URL: https://codereview.chromium.org/389663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282665 0039d316-1c4b-4281-b951-d872f2087c98

This is the first working CL of <appview>. This CL implements the basic permission API with the onAppEmbeddingRequest event.

BUG=364141

Review URL: https://codereview.chromium.org/354483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282664 0039d316-1c4b-4281-b951-d872f2087c98

This moves the intermediate grit files:
ui/ui_resources -> ui/resources
ui/ui_strings -> ui/strings
in the GYP build to put it in line with the GN one (and also what one would expect).

R=ajwong@chromium.org
BUG=

Review URL: https://codereview.chromium.org/381113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282663 0039d316-1c4b-4281-b951-d872f2087c98

The surface builds up a list of overlays as they come in and HDC
is modified to do the page flip + present all overlays in one go.

BUG=380861
NOTRY=true

Review URL: https://codereview.chromium.org/371813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282662 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943

Review URL: https://codereview.chromium.org/385213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282661 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/385133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282659 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282658 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177921:177947&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/389643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282657 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Android] Add heap_profiler_unittests to Android bots. (https://codereview.chromium.org/351183003/)

Reason for revert:
It seems to be breaking some internal bots. :-/


Original issue's description:
> [Android] Add heap_profiler_unittests to Android bots.
> 
> Add proper coverage to heap_profiler.
> 
> BUG=382489
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282626

TBR=aurimas@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/386073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282656 0039d316-1c4b-4281-b951-d872f2087c98

Removes the "ShouldRunMigrationTest()" check from the migration tests.
This check was preventing the tests from being run, but did not cause
them to emit any errors.

Sets these tests to use the legacy python server, since the in-process
server does not yet support migration.

Removes a DCHECK in StatusChangeChecker, since the MigrationChecker
won't work when that condition is enforced.  We can look into
re-enabling it at some later point.

Disables many of the migration tests.  They've been broken by changes
made to the code since they were disabled.

BUG=392989

Review URL: https://codereview.chromium.org/387763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282654 0039d316-1c4b-4281-b951-d872f2087c98

Make also complained about some broken links and stopped w/
warnings as errors.

I assume a bunch these went away w/ the really old proxy switch =)

BUG=266395
NOTRY=true

Review URL: https://codereview.chromium.org/383523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282653 0039d316-1c4b-4281-b951-d872f2087c98

We'll only export files from ui/ozone/public to other, higher-level
components. In particular the files from ui/ozone/common and
ui/ozone/platform are private.

BUG=none
TEST=desktop build with use_ozone=1 chromeos=1

Review URL: https://codereview.chromium.org/379233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282652 0039d316-1c4b-4281-b951-d872f2087c98

Now that the embedder side landed, this patch follows-up on
https://codereview.chromium.org/356043002 and allows to use all 20
renderer services on Android.

BUG=325842

Review URL: https://codereview.chromium.org/388803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282651 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/371033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282645 0039d316-1c4b-4281-b951-d872f2087c98

This is a followup to http://crrev.com/282419 .

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/383863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282644 0039d316-1c4b-4281-b951-d872f2087c98

See http://lists.w3.org/Archives/Public/public-touchevents/2014Apr/0005.html for details.

BUG=354460
TEST=TouchEventQueueTest.TouchAbsorptionWithConsumedFirstMove, TouchEventQueueTest.TouchCancelOnScroll

Review URL: https://codereview.chromium.org/228973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282642 0039d316-1c4b-4281-b951-d872f2087c98

In transition to let RenderPass take responsibility to allocate
DrawQuads, Copy method from DQ is moved to RP.

In drawquad_unittest, no RenderPass is present, thus it takes advantage
of default copy constructor.

Follow 368403003.

BUG=344962

Review URL: https://codereview.chromium.org/380893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282640 0039d316-1c4b-4281-b951-d872f2087c98

The previous implementation of the directory-based file templates (like {{source_out_dir}}}) was overly simplistic. It did not allow these templates to be used in the outputs section of a target since the directories were relative to the build directory (it was only useful for actions).

This new implementation changes the expansion of these values depending on where they're used, so they can be absolute when used in the outputs section, but relative to the build directory when used in the args section.

The implementation of outputs was changed to allow the use of these expansions. The previous implementation stored them as SourceFiles which didn't allow the use of directory expansions, since that happens after converting the input to a SourceFile. This new patch stores the outputs as a list of strings to allow this to be late-bound properly (and it turns out that almost all users of this wanted the strings anyway).

Changes the function that checks that files are in the output directory to optionally handle templates. Adds a test for this function.

Fixes a bug in get_target_outputs that it didn't work for copy() targets that contained templates. Fix this and add a test.

BUG=
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/387663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282639 0039d316-1c4b-4281-b951-d872f2087c98

There are some PPAPI dev interfaces that should not be added to the SDK, so it
is better to warn instead of making it a presubmit error.

BUG=none
R=teravest@chromium.org
TEST=made change to ppapi/cpp/buffer_dev.h, ran git cl presubmit

Review URL: https://codereview.chromium.org/379923010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282637 0039d316-1c4b-4281-b951-d872f2087c98

As per spec update:
https://github.com/slightlyoff/ServiceWorker/issues/353

Now the active worker is set to REDUNDANT when unregistered. If it has a
controllee, this happens when it no longer has a controllee.

This patch adds a Doom function to ServiceWorkerVersion which takes
care of setting REDUNDANT and purging resources once there's
no controllee. This obviates the need for ServiceWorkerStorage to
listen for NoControllees and purge resources then.

BUG=388095

Review URL: https://codereview.chromium.org/377153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282636 0039d316-1c4b-4281-b951-d872f2087c98

Convert githash to chromium revision instead of blink revision while doing a blink bisect (with -l option) in _FetchAndParse.Even though we are doing the blink bisect http://commondatastorage.googleapis.com/chromium-webkit-snapshots/index.html still stores the builds by chromium revisions.

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/383903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282635 0039d316-1c4b-4281-b951-d872f2087c98

They are always "true" for now, due to the way BLE devices work under Windows 8.

BUG=388016

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282286

Review URL: https://codereview.chromium.org/378293007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282634 0039d316-1c4b-4281-b951-d872f2087c98

We have to use the SetupDIGetDeviceProperty API to retrieve this specific property, as the "connected" status is something common to many PnP devices.

BUG=388016

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282212

Review URL: https://codereview.chromium.org/379943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282633 0039d316-1c4b-4281-b951-d872f2087c98

This should enable NULL deref and wild memory access detection!

TBR=rnk@chromium.org
BUG=345874
NOTRY=true

Review URL: https://codereview.chromium.org/387013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282632 0039d316-1c4b-4281-b951-d872f2087c98

This adds a test for the bug fixed in https://codereview.chromium.org/373083002/, and also extends the existing tests to check the GAIA given name.

BUG=none

Review URL: https://codereview.chromium.org/386733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282631 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282630 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177910:177920&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/386933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361809
TBR=dtu@chromium.org,chrishenry@google.com
NOTRY=True

Review URL: https://codereview.chromium.org/383963006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282628 0039d316-1c4b-4281-b951-d872f2087c98