- 04 Nov, 2019 40 commits
-
-
Sigurd Schneider authored
This CL enables a layout test with updated expectations after landing crrev.com/c/1891417. Bug: chromium:1004203 Change-Id: I27d6bc861c41f4d931e4a7a9c216f8c763bf1ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895343 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#712158}
-
Rune Lillesveen authored
With flat tree style recalc enabled, we need to update the new flat tree ancestors with ChildNeedsStyleRecalc() when the slot assignment changes. SetNeedsStyleRecalc() will only do that if the node was clean. Otherwise it assumes the child-dirty bits are already marked. If we are already dirty, call MarkAncestorsWithChildNeedsStyleRecalc() to update the child-dirty chain on FlatTreeParentChanged(). Also, added an early return for disconnected elements. Bug: 972752 Change-Id: I5bc76ee70eb310f2d2bc1765dcfcd15e4883f0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893060Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#712157}
-
Sadrul Habib Chowdhury authored
Measure the peak gpu-memory usage during scrolls. Report it in the rendering benchmark too. BUG=908462 Change-Id: Iecbadca9d96e74998ae4820c112443ed7b4d2588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864320 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#712156}
-
Fredrik Söderquist authored
Per: https://svgwg.org/svg2-draft/types.html#__svg__SVGLength__valueAsString Bug: 928015 Change-Id: I2dd2cd707fb01d18f2ca01d0f3488cce3d06fd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1451927 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Eric Stevenson authored
Helpful for debugging issues via. -whyareyounotinlining. Bug: 993421 Change-Id: Ie57afc9132b37f18e2200ab68d469f04d2637c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869674 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#712154}
-
Sadrul Habib Chowdhury authored
Add a story to measure throughput that has only main-thread raf-animations, but no impl-side animations. BUG=790761 Change-Id: I570c8e3b23c8f8336ae20a82bae2370a52f59453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893522 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#712153}
-
Xiaocheng Hu authored
This patch adds usage counter for glyph relative length units, so that we know how often font loading actually changes the computed value of any CSS property as per spec. This is for investigating how likely we can fully eliminat the style recalc following a web font loading. Bug: 441925 Change-Id: If649508c9c049613403b0a347871b9f8fe3ce712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894107 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712152}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/feac94f2761d..e36d03001695 git log feac94f2761d..e36d03001695 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 brianosman@google.com SkColorMatrix cleanup Created with: gclient setdep -r src/third_party/skia@e36d03001695 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I8ea1489f4d73558e86ea97e58708e215cf6ad01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896765Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712151}
-
Denis Kuznetsov authored
Also adds parts required to show update-required screen Bug: 692763 Change-Id: I233e38ca3ba4051a582c80badc176f98f582956a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893288 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712150}
-
Andy Paicu authored
This reverts commit cc4f1e5f. Reason for revert: Suspect CL for buildbot failure Breaks "Windows deterministic" build: https://ci.chromium.org/p/chromium/builders/ci/Windows%20deterministic First build breakage: https://ci.chromium.org/p/chromium/builders/ci/Windows%20deterministic/15095 Original change's description: > Pdf a11y: Populate AXNode with new text style info > > This change fills the font-family, font-size, font-weight, italic, bold > and color attributes of the AXNode with exposed values from the PDFium > APIs. > > I've also added a PDF accessibility tree dump test using the filter > properties to dump those attributes in the expected file. The test file > is "text-style.pdf". > > Somehow, I added in a previous change text-format-expected-blink.txt. > This file should have never been committed. I removed it in this CL. > > Bug: 985604 > Change-Id: I70a4729269aea69e184e61710d7977425b431704 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755412 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711942} TBR=raymes@chromium.org,bbudge@chromium.org,thestig@chromium.org,tsepez@chromium.org,iapres@microsoft.com,benjamin.beaudry@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 985604 Change-Id: I021810bfe76c64591c7ed99ea0a6efcd66db6032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895349Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712149}
-
Oleg Davydov authored
Report cache status (hit/miss/outfated version) for each extension failed to install within first five minutes. This will give us a broad picture about cache effiencity, especially how often happens that we have some cache entry, but still have to download CRX archive from scratch because it's an old version. Bug: 1015817 Change-Id: I3467fd4b0319fcf92a84660a23d7fe1d7920c03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868960 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#712148}
-
Yusuf Sengul authored
Bug: 1020914 Change-Id: I355d1d00419267779a0fad4d992d4a7dee8c50ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896141 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#712147}
-
Peter Wen authored
Some generated .pb files embed the absolute path of a bundle's resources and cause the resulting .aab file to be non-deterministic due to these resources being stored in a temp directory. Make an explicitly named temp directory as a sibling directory to the output so that the resulting .aab is deterministic. An upstream fix is tracked in b/131222965. Tbr: ntfschr@chromium.org for android_webview/tools/apk_merger.py Bug: 939984 Change-Id: I80a8bb082393ede4f92bf70a4857de994363567a Fixed: 939984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891433 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712146}
-
Mohamed Heikal authored
Reset limit back to 0 for 'ForTest' check and only check dex symbols since those are actionable vs native symbols which are much less so. Bug: 1012373 Change-Id: I725f50068c2f433b30000ed16e999ff7c31e06ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896119Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/557cb1d3..580a95b0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaaf1c9e8659cad58845413c8a4b2b6c659145876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897775Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712144}
-
Koji Ishii authored
This patch Implements computing ink overflow. The logic is is copied from the current LayoutNG. Regresses ~90 tests but fixes ~260. I will update FlagExpectations later to avoid conflicts. Bug: 982194 Change-Id: I5e2eaaec858cfb6ee7eec5b515b82a3e71dad46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771360Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712143}
-
Stephen Roe authored
Fuchsia ModuleCache population on arm64 is disabled, so it should not be tested. Bug: 1020766 Change-Id: I3373f24e644fc63b48442957a6dac59a1e9aca21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896301Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#712142}
-
Friedrich Horschig authored
Initialize the bool member PasswordsAndMetadata::uses_account_store to false which caused msan failures. Reenable the tests covering this. Bug: 1020257 Change-Id: I72b74797d0a2309320a814c4c6d4b4ab4dc347d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897660 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712141}
-
Marc Treib authored
Mostly terminology cleanup, like using more specific terms (e.g. "instance_id_token" instead of "token", "topic" instead of "id"). Also a bunch of related comment updates. The only behavior change is that some errors get slightly more specific messages. Bug: 1021092 Change-Id: I5529ef83fd9409f4f683bf4b5ea6b57a0b908e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893064 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#712140}
-
Denis Kuznetsov authored
Bug: 1017109, 1017158 Change-Id: I9f2feb2a8080cf19dd636f4696d120fd54990b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892965Reviewed-by:
-
Raul Tambre authored
* Normal strings can't be used for operations with a file opened in binary mode. Fixed by using bytestrings. * Due to being opened in binary mode bytes are read instead of strings in Python 3. Thus use ord() only in Python 2. Still works with Python 2. Fixed errors: Traceback (most recent call last): File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 79, in <module> Main() File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 72, in Main models = [ReadSerializedData(data_path) for data_path in args.data] File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 72, in <listcomp> models = [ReadSerializedData(data_path) for data_path in args.data] File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 28, in ReadSerializedData linebreak = data.index('\n') TypeError: argument should be integer or bytes-like object, not 'str' Traceback (most recent call last): File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 82, in <module> Main() File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 75, in Main models = [ReadSerializedData(data_path) for data_path in args.data] File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 75, in <listcomp> models = [ReadSerializedData(data_path) for data_path in args.data] File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 37, in ReadSerializedData tree_serialized = [ File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 38, in <listcomp> sum((ord(tree_bytes[i+b]) << (8*b)) if i+b < len(tree_bytes) else 0 File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 38, in <genexpr> sum((ord(tree_bytes[i+b]) << (8*b)) if i+b < len(tree_bytes) else 0 TypeError: ord() expected string of length 1, but int found Bug: 941669 Change-Id: Ib540c21eb63fc9407596a49e5114b8ab7e9a5a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857123 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:Alexandre Frechette <frechette@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#712138}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cc9bf6398c03..2b9317ad76b3 git log cc9bf6398c03..2b9317ad76b3 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 brandtr@webrtc.org Stop checking VP8BaseHeavyTl3RateAllocation field trial on every frame. 2019-11-04 terelius@webrtc.org Return status instead of CHECKing in event log parser. Created with: gclient setdep -r src/third_party/webrtc@2b9317ad76b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Id0d6f1591b0732ecdb99141b93e522b80ff11f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896762Reviewed-by:
-
Tomasz Wiszkowski authored
Change-Id: If5802f43bfe72982e38b47b7b1487536a6250aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895889Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#712136}
-
Elly Fong-Jones authored
This change follows the pattern of the CL adding SetExtraView. The few easy overrides are removed in this CL as well, but followup work will be needed to tackle the remaining ones individually and eventually get rid of CreateFootnoteView. Bug: 1011446 Change-Id: I1cb7e2f7bc6ffb1ace067d205475e0f8dee86b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894033Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712135}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a18bfc96038..8abbd40c2a27 Created with: gclient setdep -r src-internal@8abbd40c2a27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I6fd7fc4444e4f9c56a8abecb98725564f4601658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896763Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712134}
-
Dmitry Gozman authored
We currently reset transition type to ui::PAGE_TRANSITION_LINK in DidCommitProvisionalLoad, but not in DidFinishSameDocumentNavigation. This makes future usages of the stored transition type depend on whether the initial navigation was same-document or cross-document, which seems like a bug. This patch adds one more transtion type reset to DidFinishSameDocumentNavigation for browser-initiated ones. After this change, WillSendRequest retrieves transition type, which is always equal to ui::PAGE_TRANSITION_LINK. This is because no request happen before navigation commit, and we reset transition to ui::PAGE_TRANSITION_LINK immediately after commit. Therefore, we can just use link transition and simplify GetTransitionType. Bug: none Change-Id: I3aa71519300258d1357b4c66af3289b4111175d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887652Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#712133}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5321943693c5..70d4ef304416 git log 5321943693c5..70d4ef304416 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 dproy@chromium.org Implement timeout and retries for dev server tests 2019-11-04 perezju@chromium.org Reland "[Telemetry] Stop doing metric computation." Created with: gclient setdep -r src/third_party/catapult@70d4ef304416 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:1015942,chromium:981349,chromium:1019888 Change-Id: Icc7eba3795b97e619b8cbea9252d4e7cbcc64eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896764Reviewed-by:
-
David Van Cleve authored
This patch adds the ability to resolve ESNI (TLS 1.3 Encrypted Server Name Indication, draft 4) results concurrently with A and AAAA records during connection establishment. This is behind a base::Feature, disabled by default. When the feature is enabled and DNS over HTTPS is in use, the built-in resolver will make an additional ESNI transaction concurrently with the usual ones of type A and AAAA. It also starts a timer (initially set to the 50ms recommended by the spec) past which to abandon the ESNI transaction without failing the DNS task. R=ericorth Bug: 1003494 Change-Id: Ia73b5e910f2a466b6384c7c73f09705e770ea39d Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879430 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#712131}
-
Michael Lippautz authored
- Use struct for AdjustPointerTrait. - Replace TraceIfEnabled with TraceIfNeeded - Avoid nullptr checks where the next call would anyways crash on dispatch Bug: 1019191 Change-Id: Ib28d3b6c125623bac9a0bbbeda87dfa37528aa48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893061 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712130}
-
Nigel Tao authored
Bug: 1014044 Change-Id: I6361907375c981a567e12c95262bbd02d55c31f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895260 Commit-Queue: Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712129}
-
Dominik Röttsches authored
When font scanning finished, Blink receives a Mojo IPC callback that local font matching is now available in notifies all WeakPtr's to LocalFontFaceSource's if those WeakPtrs are individually still valid. After consulting with haraken@ it turns out that using a WeakPtr and WeakPtrFactory on a heap object is bad practice, as an object may remain allocated for a little while after being marked for GC - but the WeakPtr state does not reflect that yet. So when we have callbacks bound to the WeakPtr they still get executed. Instead, use WrapWeakPersistent() to in the Bind call in order to drop the callbacks if the target object for the callback has been collected by GC. This should address the assumed GC race condition which is most likely the underlying issue for issue 1017078. FontUniqueNameLookupWin: :ReceiveReadOnlySharedMemoryRegion, then it Bug: 1017078 Change-Id: I9812ec292f2986fc15a3d14cbbfe5381788634d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895334Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#712128}
-
Roman Sorokin authored
* Fix width of the dialog * Move the next button to the bottom * Adapt fonts according to specs * Make content paddings adaptive Bug: 1002102 Change-Id: Iad0a84d11ae20104685e4768a8c3805617b8978f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893880Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712127}
-
Roman Sorokin authored
Bug: 1020514 Change-Id: Ifb16d619fa1fbd526073366ee749447ccaf7c9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894009Reviewed-by:
-
Ben Kelly authored
This CL adds the CacheStorageHighPriorityMatch feature. When enabled and a cache.match() is sent from a FetchEvent with a matching request URL the resulting operation will be executed at high priority. This means the operation will be placed at the front of the cache_storage scheduler queue. This CL also adds a histogram for measuring cache match time in the browser when the call was initiated from a related FetchEvent. Note, this CL will result in some match operations completing in running and completing in a different order than the methods were called in. For example, cache.add(url); cache.match(url); The match may run before the add if you are in a relevant FetchEvent. Order of execution and completion was never guaranteed, however. In this example the add would likely always write to disk after the match runs because it has to buffer the response body in the renderer. In addition, ordering became even less deterministic when we shipped executing operations in parallel. To enforce ordering in this example the site can await the add promise before proceeding to the match call. Note, we believe these ordering changes are acceptable since the API does not really provide transactions. See here for some spec discussion: https://github.com/w3c/ServiceWorker/issues/823#issuecomment-417788337 Bug: 1018920 Change-Id: Ia1991a33db39568f98f0d40a110550174fa53bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884932 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712125}
-
Olivier Li authored
Change-Id: I16dd76160de8cec0642f395a87acb2191ba38733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894419 Auto-Submit: Oliver Li <olivierli@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#712124}
-
Avi Drissman authored
897636c9 removed its contents. Bug: 958255 Change-Id: I6deab12399254f839385654814f8116aa2dbabd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896860 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712123}
-
kylechar authored
This reverts commit fb110ec7. Reason for revert: Widespread failures on GPU FYI waterfall. Original change's description: > Test Dawn on the chromium.gpu.fyi waterfall > > The following bots: > Linux FYI Debug (NVIDIA) > Linux FYI GPU TSAN Release > Linux FYI Release (AMD R7 240 / Intel [U]HD 630 / NVIDIA) > > Mac FYI Debug (Intel) > Mac FYI Retina Debug (AMD / NVIDIA) > Mac FYI GPU ASAN Release > Mac FYI Release (Intel) > Mac FYI Retina Release (AMD / NVIDIA) > Mac Pro FYI Release (AMD) > > Win10 FYI x64 Release (NVIDIA GeForce GTX 1660) > Win10 FYI x64 Debug (NVIDIA) > Win10 FYI x64 Exp Release (Intel HD 630) > Win10 FYI x64 Release (AMD RX 550 / Intel [U]HD 630 / NVIDIA) > > Will run the following tests: > dawn_end2end_tests > dawn_end2end_validation_layers_tests > dawn_end2end_wire_tests > > On the DEPS version of Dawn > > Bug: chromium:1016948 > Change-Id: I91029164d935e4d91d28eb3b802232a358645b0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873288 > Commit-Queue: Austin Eng <enga@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711908} TBR=kbr@chromium.org,enga@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1016948 Change-Id: I872eb71444d311919c81e81b0abf268a3c49f50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897806Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#712122}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6c7208f93d6e..b9ddfd577a20 git log 6c7208f93d6e..b9ddfd577a20 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader fda994c63075..aaa64b76c0b4 (8 commits) 2019-11-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 618ee509421f..f1e5cd73f658 (3 commits) Created with: gclient setdep -r src/third_party/angle@b9ddfd577a20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None,chromium:None Change-Id: I53c85b0cef183e2cec60543c1fdcf53a005e8730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897481Reviewed-by:
-
Jan Wilken Dörrie authored
This change introduces base::CheckedContiguousRange, which similarly to base::span is a light-weight wrapper around a contiguous container performing bound CHECKs. However, in contrast to base::span this class keeps a pointer to the underlying container, and thus is able to respond to changes to data() and size(), which base::span can't do. Furthermore, this change provides a constexpr overload of base::data() for std::array and fixes a bug in CheckedContiguousIterator::operator-=. Bug: 990059 Change-Id: I3fef91c7ef7874bf495ac2ab6dbaf3a8b02dab35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893858 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#712120}
-
Andy Paicu authored
This reverts commit d1531b9a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 711796 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QxNTMxYjlhYzVhNDlkMTlmOTQ5ZTlkOGY0MmRhZjM0NzBkMzEzMmEM Sample Failed Build: https://ci.chromium.org/b/8897957936228871696 Sample Failed Step: browser_tests Original change's description: > CrOS Shelf: Start moving some hotseat logic into the hotseat widget > > The general idea here is to encapsulate more of the hotseat's behavior > into its own class rather than have it all over the shelf layout > manager. Eventually, I hope to get rid of the huge > "CalculateHotseatState" method by setting the hotseat state to the > appropriate values from the relevant places. > > Change-Id: I03bf50bc9f6fb68f7f22f1b6ec966f08f48220da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893997 > Commit-Queue: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711796} TBR=xiyuan@chromium.org,manucornet@chromium.org Change-Id: I7dd2357dd075bee067c3bad1aa58db788ba1039e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893885Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712119}
-
