- 17 Sep, 2019 24 commits
-
-
Andrew Xu authored
With the flag of scrollable shelf enabled, when adding a shelf item, scrollable shelf is notified when the shelf view's bounds animations end. Tests should wait for bounds animations to finish. Otherwise, they will fail. This CL fixes such an issue. Bug: 1002576 Change-Id: Ib2e80916a11a2b90f248886992f7221b1dce6563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808189 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697030}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eb8f5aa220f6..b19a360c1269 git log eb8f5aa220f6..b19a360c1269 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 ntfschr@chromium.org Devil: IsApplicationInstalled API Created with: gclient setdep -r src/third_party/catapult@b19a360c1269 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1002774 Change-Id: I25fb405a04d46177fd178d014d433978dfd097cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808222Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697029}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae8010776652..b47704b0bd34 git log ae8010776652..b47704b0bd34 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 brianosman@google.com Fix license comment in skottie_ios Created with: gclient setdep -r src/third_party/skia@b47704b0bd34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Ia04cf72df2f6b8293da3922eefc1a6744b74b5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808219Reviewed-by:
-
Glen Robertson authored
Resets state_ ABM to INACTIVE in ResetCurrentPageData (called in DidFinishNavigation). This fixes a race possible when there are multiple navigations in quick succession. More info: There is no guarantee about the ordering of Did{Start,Finish}Navigation and DidFinishLoad for multiple navigations [1], so it is possible to get the order: [DidStartNav(url1), DidFinishNav(url1), DidStartNav(url2), DidFinishLoad(url1), DidFinishNav(url2), DidFinishLoad(url2)] The state_ in ABM is reset to INACTIVE on DidStartNavigation and checked (expected to still be INACTIVE) in DidFinishLoad. In the case of unusual call order, the state was no longer INACTIVE (usually it is COMPLETE) in DidFinishLoad(url2). This fix wouldn't help in the even-more-unusual order: [DidFinishNav({url1,url2}), DidFinishLoad({url1,url2})] I'm not sure how possible/likely that is. [1]: https://cs.chromium.org/chromium/src/content/public/browser/web_contents_observer.h?rcl=c954302bbe18174ce8a54242282eace7f25644e3&l=166-168 Bug: 991832 Change-Id: I0f04a5b26ee396557b56d9e1dca7570d3355f0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797527 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#697027}
-
Fergus Dall authored
TBR=grt@chromium.org Bug: 1004568 Change-Id: Ia54998fa290e42b5b13b83d9d65d86e8f093a9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808285Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697026}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I5df128161982a1a18084188aac4262499460a52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808095Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#697025}
-
Shimi Zhang authored
FirstLayoutDone state was removed long time ago in https://chromiumcodereview.appspot.com/14787005, change the comment to reflect the current states. Bug: None Change-Id: Idac41a01e3f85d8187eae8c8ea89ba1a576f3096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802522 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#697024}
-
Jack Lynch authored
This is a reland of 1da9c254 The test has been slimmed down the the minimum complexity necessary to test this part of the UI in order to avoid future CI timeouts. Original change's description: > DevTools: Add axe test for Changes drawer > > This adds an axe test for the accessibility changes in #1659355. The > test is in a separate PR from the changes because of the flaky axe test > issue which should be fixed by #1638125. > > Bug: 963183 > Change-Id: Ibc3dbd8dd954e2493521bef48abdb65a802a91ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666445 > Commit-Queue: Jack Lynch <jalyn@microsoft.com> > Reviewed-by: Joel Einbinder <einbinder@chromium.org> > Auto-Submit: Jack Lynch <jalyn@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#677600} Bug: 963183 Change-Id: Ie537409e0b740a5c39b67dd5a280e4fcb330997f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713441Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697023}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/09feed378ddc..e65bb926f1f3 git log 09feed378ddc..e65bb926f1f3 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 tcwang@google.com afdo: Prepare orderfile generate and verify builders on branch. 2019-09-16 dhanyaganesh@chromium.org Make coral critical Created with: gclient setdep -r src/third_party/chromite@e65bb926f1f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I024c80fe5ce886de1fb2f7af320941db09558eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808004Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cec6a1f798c4..c0326d5a977f git log cec6a1f798c4..c0326d5a977f --date=short --no-merges --format='%ad %ae %s' 2019-09-16 treehugger-gerrit@google.com Merge "Remove 'disabled-by-default' categories prefix" Created with: gclient setdep -r src/third_party/perfetto@c0326d5a977f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I6c7c86185323ae3d8f8e907c9694d0d6d8f5c0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808220Reviewed-by:
-
Yue Li authored
Update legacy code names and comments to use 'Assistant'. Remove obsolete logics. Bug: b/140823590 Test: Run existing tests Change-Id: Ie5647e85b0030c2cddfa1dfeab86c752ab6148f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808091Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#697020}
-
Khushal authored
For usages that are now handled by shared images, remove unused provider types and clean up some of the setup code. R=fserb@chromium.org Bug: 900706 Change-Id: Ibc3c3795dc7bd7620378acc2c874f445f136c333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753698 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#697019}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7720ac9d..8647f945 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c6e541585eff398385c0f274a01e2dbc6081ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807718Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697018}
-
Fergus Dall authored
TBR=jrummell@chromium.org Bug: 999421 Change-Id: Ia76454c22fef6b94e6e4679c6e440dc86f0a17d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808283Reviewed-by:
-
nancy authored
This CL is the follow up for crrev.com/c/1802776 based on review comments, to create AppServiceTest, and integrate AppService to LauncherContextMenuTest only. There will be one or a few separate CL(s) to integrate AppService to other UI unit tests. BUG=1002351 Change-Id: I60e7fb4e7b48b2431ac0a3e3398e6ae1ffe8ace5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804095Reviewed-by:
-
Rakib M. Hasan authored
The test is very flaky on the CQ. Bug: chromium:1003776 Change-Id: Iba048e05b26213272b9f74375cedd7d62adf117f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808162Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#697015}
-
Fergus Dall authored
TBR=xiyuan@chromium.org Bug: 1004561 Change-Id: If13eb2ba89d0719cc782441741c3b30466273de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808282Reviewed-by:
-
Chris Palmer authored
We do it unconditionally in DCHECK builds to catch bugs, but let's occasionally do it in release builds too. Frequency is tunable. This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/1761578, which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1797642. Bug: 984742 TBR: haraken Change-Id: I8f9a36389b2d58f6a11b324b59dd47727e4b91fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808181Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697013}
-
Ken MacKay authored
IOBufferPool is a class that allocates fixed-size IOBuffers. There is an optional limit on the maximum number of buffers that will be allocated. Buffers from the pool can be used as usual; when they are deleted, the memory will be returned to the pool to be reused. Buffers can be safely used and freed even after the IOBufferPool instance is destroyed. IOBufferPool is optionally threadsafe (defaults to non-threadsafe). When thread safety is enabled, the pool and allocated buffers can be used from any sequence. If thread safety is not enabled, the pool and buffers may only be used from the sequence that created IOBufferPool. Change-Id: I901c70bbb0f7dca1395886246209e0aeb6805151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805866 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697012}
-
Andrey Kosyakov authored
... by tracking pending frames in ExternalBeginFrameSourceMojo. The hang may occur in case DisplayScheduler decides not to produce a frame because some surfaces are still pending even after all frame sinks have processed beginFrame signal. TBR=kylechar@chromium.org (for mechanical changes under components/ui_devtools/viz/ and in content/browser/compositor/gpu_process_transport_factory.cc) Bug: 997946 Change-Id: I05fb832100471bd6daeeb6b060a95649370f9c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774299Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#697011}
-
Tibor Goldschwendt authored
This simplifies instantiating new feature modules. Bug: 950056 Change-Id: Ic06aef2f99d9c08fe23c6df202948f72bba87593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804275 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697010}
-
Fergus Dall authored
TBR=karandeepb@chromium.org Bug: 1003598 Change-Id: I3e6afa685223ea09caa8e261ecf9e15773d898b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808281Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the mojom::ProcessInternalsHandler interface. Bug: 955171 Change-Id: I61c50a66af2bbf9976baf665f6185eb3e7edb79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795427Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#697008}
-
Paul Dyson authored
Bug: 998763 Change-Id: I5c2281390f90fa86cb35920fd377468dd880ead2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804701Reviewed-by:
-
- 16 Sep, 2019 16 commits
-
-
Willie Koomson authored
ArcInstanceThrottle records the duration that the effective observer was active. This duration is emitted to an UMA histogram (one for each kind of observer). Test: Run ArcInstanceThrottleTest.RecordCpuRestrictionDisabledUMA unittest Bug: b:133417350 Change-Id: I00e38b1517712f56d07a87d7e39f84f569662baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778633 Commit-Queue: Willie Koomson <wvk@google.com> Auto-Submit: Willie Koomson <wvk@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#697006}
-
rbpotter authored
- Modify polymer.py to handle cr.define(), assuming only 1 cr.define per file, and that nothing after #cr_define_end is needed (similar to js_modulizer.py). - Move Polymer() call inside cr.define() in cr_toast_manager, and add a setInstance() method. - Autogenerate Polymer 3 versions of cr-toast-manager and tests - Add cr-toast-manager to the Polymer 3 demo page Bug: 965770 Change-Id: I29079b0a07986cba84deaaaaf53a39b788fdf1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802661 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#697005}
-
Victor Hsieh authored
Test: build, method call from local change works Bug: chromium:893332 Change-Id: Ice4072d878a91707bf86f3ba3a738068646977be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765656Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Auto-Submit: Victor Hsieh <victorhsieh@chromium.org> Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Cr-Commit-Position: refs/heads/master@{#697004}
-
Matt Simmons authored
* Added Tasks-only mode to StartSurface * Moved padding handling out of TabSwitcherMediator. * Use Start Surface flag to display omnibox on start surfaces. * Create a basic mediator for tasks surface. * MV tiles only show on tasks-only currently until fully implemented. Bug: 985386 Change-Id: Ib7972815448924a2c839990d487d728bcd6471dc Binary-Size: Increase in method count is due to interface implementation and cannot be avoided. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799383Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#697003}
-
John Budorick authored
Bug: 976218 Change-Id: Iab9b235eeee16612504fbfb8dce611617ed057fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807072Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#697002}
-
Yun Liu authored
Bug: 731759 Change-Id: Ic05571ebffa95bf08bae2b16be846d934e8cc7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807778Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#697001}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79e09388b11e..4b35cce04ad4 Created with: gclient setdep -r src-internal@4b35cce04ad4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ie2f2d8be63661633d47bca0d1b716965713c07ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807137Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697000}
-
Kyle Horimoto authored
Change-Id: I27d9381b47497a583152753e7b6a8cdc6d4bac02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803798 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#696999}
-
Yannic Bonenberger authored
Change-Id: I467765c4c532c0527863445deb68c00cc2b77393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803917 Commit-Queue: Dominic Farolino <dom@chromium.org> Auto-Submit: Yannic Bonenberger <yannic.bonenberger@gmail.com> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#696998}
-
Sergey Ulanov authored
Previously SysmemBufferWriter::GetRecommendedConstraints() was using has_per_packet_buffer_bytes_recommended() result as min_size_bytes, i.e. min_size_bytes was set to 1, which is obviously incorrect. Bug: 1003651 Change-Id: I64cc94b3dcc46d226d7fd6432aa91dcb49b76902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808092 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/64d4a375c810..f73f0f401a6b git log 64d4a375c810..f73f0f401a6b --date=short --no-merges --format='%ad %ae %s' 2019-09-16 ehmaldonado@chromium.org Revert "Reland "depot_tools: Bootstrap Python 3 on Linux/Mac"" Created with: gclient setdep -r src/third_party/depot_tools@f73f0f401a6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: Ic0b388d3dddbef08a3f2cd61480263911b1388a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808003Reviewed-by:
-
Joe DeBlasio authored
This CL swaps the lightbulb icon for the new hybrid shield-bulb and switches to the "big icon" infobar. This CL also removes the lightbulb icon from Android, since nothing is using it anymore. Bug: 1000337 Change-Id: Iabacf98e0a568bfaff03e8e6a0318f055cfe74a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783279Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#696995}
-
Adam Langley authored
The “Random” subgroup will alternate between offering CECPQ2 and CECPQ2b at run-time for each connection. This will allow the tail of slow clients to be better measured at the server. Installs in this subgroup will not send the PQ signal extension and thus will not record client-side metrics in the Net.SSL_Connection_Latency_PostQuantum histogram. Bug: 801302 Change-Id: I3ddbf65de87588e8de92b42dcf0e9a0522049a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804049Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#696994}
-
Andrew Xu authored
Some bugs are exposed by enabling scrollable shelf during tests: (1) In ScrollableShelfView::OnGestureEvent, event should be stopped from propagation if it gets handled. (2) In ScrollableShelfView::ShouldShowTooltipForView, it should check that the shelf item is not removed from the shelf model, (3) In FindFirstFocusableChild/FindLastFocusableChild, it should return early if the view model is empty. Bug: 1002576 Change-Id: I35a96d002bae88157e56622a880b6b3256e3e4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807562Reviewed-by:
-
John Delaney authored
Updates the expriy of this histogram. This histogram is still used for tracking behavior of display video creatives in Chrome. Bug: 990969 Change-Id: I973b18e9178ff1d10d006a0b9e26d9d366b33799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806078 Commit-Queue: John Delaney <johnidel@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Gavin Williams authored
-Created a new variable in cr_input.html to control the placeholder's text spacing. Without this change it would inherit the input field's custom spacing which is too wide. Bug: 1002860 Change-Id: I6ad08bf800df733ec2c8db71e5d1930fd907a61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806102Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#696991}
-
