- 09 May, 2018 40 commits
-
-
Greg Kraynov authored
Got rid of cc::OrderedSimpleTaskRunner dependency and slightly cleaned TaskQueueManagerImpl unittests while adjusting the code. Bug: 783309 Change-Id: Ibc31281b1dcdf6750b2fcc9e07bc7d7dfe1e85af Reviewed-on: https://chromium-review.googlesource.com/1037144 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557230}
-
Philip Rogers authored
This is a small cleanup to use the size directly, if available, rather than creating the rect and then just getting the size. Found while working on https://crbug.com/838111 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I678fc42b76bcda168b8e5f68fd9c357ad57dca42 Reviewed-on: https://chromium-review.googlesource.com/1050969 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557229}
-
Derek Cheng authored
- Don't depend on external resources for presentation URLs. Changed the url in the test from https://google.com to a local page. - One-UA no-receiver tests need to fire up a EmbeddedTestServer in order for presentation URLs to resolve to https: scheme. Bug: 840059 Change-Id: If5c4bc7e00b75a37d5df94e05b1ebad49e7cdd67 Reviewed-on: https://chromium-review.googlesource.com/1050885Reviewed-by:
Adam Parker <amp@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557228}
-
John Budorick authored
Change-Id: Ife4a5f712ad0f054ffa7dbe3681142a6da94326e Reviewed-on: https://chromium-review.googlesource.com/1042532Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#557227}
-
Edward Lemur authored
LUCI Chromium Trybots seem to work fine with the change. This will unblock ANGLE and other projects that might want to test their changes with Chromium, which is the main use case. Bug: 643346 Change-Id: I1649fda2773e4346cf48bdc6b364fe884a0e4e5e Reviewed-on: https://chromium-review.googlesource.com/1050802Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#557226}
-
Eugene But authored
This could be useful during debugging. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idddc32b00128a46ae2db2cabbdc69a4ed5e2fcbe Reviewed-on: https://chromium-review.googlesource.com/1050442 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#557225}
-
https://webrtc.googlesource.com/src.git/+log/c6c44268bcb5..a29b148557b0 $ git log c6c44268b..a29b14855 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:826914,chromium:841193,chromium:851187,chromium:839860 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia175141797bf07db2094a2b43e74a71db4377ecc Reviewed-on: https://chromium-review.googlesource.com/1052216 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557224}
-
Allen Vicencio authored
Adds SmbUrl class which is used to represent Smb URLs. Includes unit tests. Bug: 757625 Change-Id: I2105f08a0df55dbaa0d50b1637d419a6cf5335f7 Reviewed-on: https://chromium-review.googlesource.com/1048745Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Allen Vicencio <allenvic@chromium.org> Cr-Commit-Position: refs/heads/master@{#557223}
-
Ian Swett authored
Merege internal change 195881570 R=rch@chromium.org Bug: 840734 Change-Id: I2002111d42876e8c2b0d66850be67dea3c67cfdb Reviewed-on: https://chromium-review.googlesource.com/1051728Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#557222}
-
Robert Ogden authored
This allows the config server to send an empty config in order to effectivly turn off DataSaver if needed. Bug: 840978 Change-Id: I7b5e57728737401c286da29ccbd7cc4564c73732 Reviewed-on: https://chromium-review.googlesource.com/1050805 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#557221}
-
Fady Samuel authored
This CL introduces RequestNewLocalSurfaceId API to LayerTreeHost so that LocalSurfaceIds can be allocated on the compositor thread. A request will be only made once for a given commit. This request is plumbed from LayerTreeHost to the pending tree and active tree on the impl thread and then onto the LayerTreeFrameSink. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I68ad2e9092f68e17033aa81dc4f1e392149bc720 Reviewed-on: https://chromium-review.googlesource.com/1050735 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#557220}
-
Jérôme Lebel authored
This patch extracts code to display an avatar with an email and an optional name from IdentityPickerView into IdentityView. This code can be share between IdentityPickerView and the identity chooser dialog in this mock: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQNtxfU4ytJv/files/MCHtA7U1iMGr62Mmhjs3q0iDhQHgIuNdWV0 Bug: 827072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib7df934aa678c35b42b8a37c71dfac6fd52ca5c4 Reviewed-on: https://chromium-review.googlesource.com/1044373 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#557219}
-
Yuki Shiino authored
Re-implements NodeFilter based on CallbackInterfaceBase. Major changes are the followings: a) Custom implementation V8NodeFilterCondition is gone in this patch as we have auto-generated V8NodeFilter. b) NodeFilter.h is also gone. V8NodeFilter provides IDL constants directly. c) The old implementation didn't perform any type check. Passing 0 (zero) as NodeFilter was okay and it was treated as if |null|. With this patch, the generated code performs a regular type check. Bug: 778580 Change-Id: Ifb95aa78ead36081ece9bd6616ffb23d0704b67b Reviewed-on: https://chromium-review.googlesource.com/1011864 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#557218}
-
Pavel Yatsuk authored
BUG=799180 R=gayane@chromium.org Change-Id: I83d0a362b9f52cfdf0db4e9eba48c6494dfcdad7 Reviewed-on: https://chromium-review.googlesource.com/1050978Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#557217}
-
Zhenyao Mo authored
BUG=838970 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I28a0a55d4fb1d248a53ced7f721df128d470c34f Reviewed-on: https://chromium-review.googlesource.com/1041164 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557216}
-
Elly Fong-Jones authored
The bulk of these tests depend on having a Cocoa browser window and the related infrastructure. Bug: 834754 Change-Id: I304222489cf28fb8e69914f24ae646198aeca352 Reviewed-on: https://chromium-review.googlesource.com/1050194 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#557215}
-
Helen Li authored
Use network-service-reviews@chromium.org to watch for network service CL reviews. Change-Id: I4894e393a8933be05dd8e10021346b328598ba3d Reviewed-on: https://chromium-review.googlesource.com/1052309Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557214}
-
Finnur Thorarinsson authored
Bug: 839981, 656015 Change-Id: I086a8c448c4192317538d4994ccceb65ba20ef0a Reviewed-on: https://chromium-review.googlesource.com/1050249Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#557213}
-
Fernando Serboncini authored
Bug: 838328 Change-Id: I3b0ba96d4351bdd48467e58a2a58d6dbfe11b163 Reviewed-on: https://chromium-review.googlesource.com/1052167Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557212}
-
Ethan Kuefner authored
This reverts commit f3f89493. Reason for revert: Causing failures Original change's description: > [Perf] Enable system_health.* for histogram uploads > > This CL switches all system_health benchmarks to the histogram pipeline. > > Bug: 744736 > Change-Id: Icb97397ec417d27220e489651cc51591757d8c9e > Reviewed-on: https://chromium-review.googlesource.com/1048626 > Reviewed-by: Emily Hanley <eyaich@chromium.org> > Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556842} TBR=eakuefner@chromium.org,eyaich@chromium.org Change-Id: I53f1788cc1f488b207a0718e8fbe14e2899af5b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 744736 Reviewed-on: https://chromium-review.googlesource.com/1052407Reviewed-by:
Ethan Kuefner <eakuefner@chromium.org> Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Cr-Commit-Position: refs/heads/master@{#557211}
-
David Benjamin authored
This is long long *long* overdue. Bug: none Change-Id: I9e72f5229ebfb3ea7676bd5e3b37d74b102fa6ee Reviewed-on: https://chromium-review.googlesource.com/1052307Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#557210}
-
Francois Doray authored
This CL enforces that a tab is frozen prior to being proactively discarded. This will allow the website to have enough time to persist any state prior to being proactively discarded. Urgent discard behavior is unchanged. Bug: 775644 Change-Id: Ia3ec9e8f53f80d2c940edd065090415cbcdd1f6c Reviewed-on: https://chromium-review.googlesource.com/1041138 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#557209}
-
Friedrich Horschig authored
This is a reland of dc92f9db With this reland, only one of the tests is reenabled again. The one that doesn't fail and is unrelated to the other two. (Therefore, the font changes are not needed anymore - this will follow in a second reland CL). Original change's description: > Reactivate deflaked keyboard accessory tests > > After having landed https://crrev.com/c/1028230, the problems of the > linked bug seem to have gone (as assumed). > > I removed the Disabling and RetryOnFailure annotations to test on 3 > devices (one physical, two emulator with different screen sizes and OS) > and couldn't find a single broken test. > Edit: I changed the font size recently (not finally) which seems to > bother some bots - unrelated from the filed bug. Changed that back. > > This CL now reenables all the tests but keeps the RetryOnFailure > annotation. That way, I can test whether the tests start failing on > some bots again without making the sheriffs life harder. > If the bots don't notice any flakiness, I will remove the > RetryOnFailure annotation as well and mark the linked bug fixed. > > Bug: 838922 > Change-Id: I9781e6d820ac39e43435ad1529da817601967ed4 > Reviewed-on: https://chromium-review.googlesource.com/1044371 > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556798} Bug: 838922 Change-Id: I18dda9ed9df416a796fa1748032f37adb0224dd0 Reviewed-on: https://chromium-review.googlesource.com/1051831Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#557208}
-
Paul Miller authored
This change designed for easy revert. BUG=678288 Change-Id: I85b5a9e997237671567d65cd8ff40aa6aadcdae3 Reviewed-on: https://chromium-review.googlesource.com/1050931Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557207}
-
Kouhei Ueno authored
No change in behavior expected. - ScriptRunner::GetPendingScriptIfAsync is now renamed to GetPendingScriptOfAsyncScript() and DCHECKs if the script loader is actually async. - ScriptRunner::IsAsync() is introduced for an existing call-site which called the func just to see if the ScriptLoader is async. Bug: 838761 Change-Id: I0cbe73c36706e1e4ae053dd3c438d2eb77c62699 Reviewed-on: https://chromium-review.googlesource.com/1036712 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557206}
-
Helen Li authored
When p2p socket type is IsPseudoTlsClientSocket(), P2PSocketHostTcpBase constructs a jingle_glue::FakeSSLClientSocket() and calls Connect() on the tcp socket which is already connected. This triggers a DCHECK error, because it's illegal to call Connect() twice on the same tcp socket (in this case on the ProxyResolvingClientSocket). This CL fixes P2PSocketHostTcpBase to not call Connect() twice and adds a regression test. BUG: 840797 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic936939bb58c32fc92bcad71929cf7f88af89eff Reviewed-on: https://chromium-review.googlesource.com/1050188 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557205}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9e8570d9. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17190 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/resources yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=danyao No-Export: true Change-Id: Ib2ff7641384e0783f634cfa9f7978c2b7b74c3e0 Reviewed-on: https://chromium-review.googlesource.com/1052089 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557204}
-
danakj authored
This removes the class, replacing it with uses of the cc scrollbar layer types: cc::PaintedScrollbarLayer, cc::PaintedOverlayScrollbarLayer, and cc::SolidColorScrollbarLayer directly. The scrollbar layer map needs to maintain ownership of these along with a wrapping WebLayer (for now), and a raw pointer to a base cc::ScrollbarLayerInterface* for changing the element id that the scrollbar controls the view of. So we add a ScrollingCoordinator::ScrollbarLayerGroup that holds these three things together. The cc_blink::ScrollbarImpl, which is a subclass of cc::Scrollbar, moves from cc/blink/ to platform/scroll/ beside the ScrollingCoordinator, and is renamed to ScrollbarLayerDelegate. It still makes use of Web* types like WebScrollbarThemePainter and these can be removed to use the platform/scroll/ types directly instead. R=bokan@chromium.org, jbroman@chromium.org Bug: 838693, 738465 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I021fc69a2c8fd90a21bf406cd08d968e0335506a Reviewed-on: https://chromium-review.googlesource.com/1048247Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#557203}
-
Guido Urdaneta authored
AVFoundation calls made by the video-capture service on its main thread require a CFRunLoop which is provided by a UI message loop. This fixes a number of regressions related to detection of plugged/unplugged devices that appeared when the default message loops on Mac were changed from CFRunLoop to Default. Bug: 834581 Change-Id: If565f400e52407c2f71e32f93e9472556051bad1 Reviewed-on: https://chromium-review.googlesource.com/1049931Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#557202}
-
Katie D authored
First, the touch event and stylus event both have the same ID on Dru, so we also need to track the pointer type to differentiate. Second, we need to still cancel search key up even after inactive state has been set by the extension. Bug: 753018 Change-Id: I7245af21a1a7fb8089a7da339b973d149b57a1dd Reviewed-on: https://chromium-review.googlesource.com/1050424Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#557201}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3806b7fbd0ea..afec759dca62 $ git log 3806b7fbd..afec759dc --date=short --no-merges --format='%ad %ae %s' 2018-05-09 agrieve Revert "bot_update: Fetch references to be synced." Created with: roll-dep src/third_party/depot_tools BUG=chromium:840445,chromium:841306 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If27bec2d6daff4a7f207adb0eddbd6cbabbb94f8 Reviewed-on: https://chromium-review.googlesource.com/1052168 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557200}
-
https://pdfium.googlesource.com/pdfium.git/+log/df1298a228ab..5f7c5be8b707 $ git log df1298a22..5f7c5be8b --date=short --no-merges --format='%ad %ae %s' 2018-05-09 hnakashima Filter out "Type" and "DecodeParms" from trailer keys. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib0978db093c1d0b35201c8d1c43aefd85e628944 Reviewed-on: https://chromium-review.googlesource.com/1051871Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557199}
-
arthursonzogni authored
NavigationMojoResponse has been launched and the old code path has been removed. The current and sole NavigationURLLoader implementation is now the NavigationURLLoaderNetworkService. The CL renames it into NavigationURLLoaderImpl. Bug: 705744 Change-Id: I982f024c9318d6e03d63d73452f75b5f38b1e495 Reviewed-on: https://chromium-review.googlesource.com/1039488Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#557198}
-
vitaliii authored
Disable org.chromium.chrome.browser.contextualsearch ContextualSearchManagerTest testTapGestureFollowedByScrollClearsSelection because flaky. TBR=donnd@chromium.org Bug: 841017 Change-Id: I0faca09f286ea776ce54d70c411ff61a7649132e Reviewed-on: https://chromium-review.googlesource.com/1052129Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557197}
-
vitaliii authored
This reverts commit f4a598ff. Reason for revert: Does not compile on Win 64, see https://ci.chromium.org/buildbot/chromium/Win%20x64/22249 Original change's description: > [Zucchini] (raw) Apply fuzzer > > This is part of a series of Fuzzers to be added to Zucchini for > security review. This tests the raw data patch application logic > exercising the patch reader and apply process. It only covers ~20% > of code in 100000 executions as the bulk of the remaining code is > associated with the much more complex and expensive to fuzz reference > related code. > > With the supplied seed corpus the fuzzer reaches approximately 11000 > execs/s. > > This found a couple bugs which are fixed in: > https://chromium-review.googlesource.com/c/chromium/src/+/1028575 > > > Bug: 835341 > Change-Id: Idc1d862bfaa6eb6313f39e10536f4750c05ab863 > Reviewed-on: https://chromium-review.googlesource.com/1028570 > Commit-Queue: Calder Kitagawa <ckitagawa@google.com> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Jonathan Metzman <metzman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557185} TBR=huangs@chromium.org,mmoroz@chromium.org,grt@chromium.org,metzman@chromium.org,ckitagawa@google.com Change-Id: Ia1790a01d3f31f25b243ce6e4ec5b52e423e3f6e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835341 Reviewed-on: https://chromium-review.googlesource.com/1052287Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557196}
-
Eric Orth authored
Minor cleanup in NetworkErrorLoggingService by making non-filtered cleanup an explicit separate method. Bug: 824997 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iaa7b9fa25a7463a7294d93759dca0b0ee06187a0 Reviewed-on: https://chromium-review.googlesource.com/1044359 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557195}
-
Paul Irish authored
Change-Id: If85c60d7f52cdc0a3acc8addf9d7e1995195295b Reviewed-on: https://chromium-review.googlesource.com/1046106Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#557194}
-
Bailey Berro authored
This change updates the SmbService setup flow so that setup is not run when SmbService is created on the LockScreen and adds a call to SetupKerberos for ChromAD users. Bug: chromium:757625 Test: verified on local ActivceDirectory test network Change-Id: I36ca8f48368be33e740ee1128e8cc5cc23ca8e5d Reviewed-on: https://chromium-review.googlesource.com/1045130Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#557193}
-
nednguyen authored
NOTRY=true # tests are covered by PRESUBMIT Bug: 840008 Change-Id: I7292978d28cdf0c662d78d6dfb2dadbc103ec178 Reviewed-on: https://chromium-review.googlesource.com/1052215Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#557192}
-
Nasko Oskov authored
The isolation of error pages has caused at least one functional regression described https://crbug.com/840485 and causes various renderer process terminations. This CL disables the isolation functionality so these can be investigated and fixed before re-enabling. Bug: 838161, 840485, 840794, 840701 Change-Id: Id25937f6f400578c7c8bf315551b3878b4a4937c Reviewed-on: https://chromium-review.googlesource.com/1050431 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#557191}
-