- 20 Feb, 2020 40 commits
-
-
Jonah Chin authored
This reverts commit 2a3b1189. Reason for revert: crbug.com/1054408 Original change's description: > Add a PaintRecorder to CanvasResourceProvider > > This CL is the first step in creating a PaintRecord backed resource > provider for canvas OOP-R. > > Changes of ownership: > - PaintRecorder entirely moved from Canvas2DLayerBridge to > CanvasResourceProvider. > - Management of needs_flush_ for MemoryManagedPaintRecorder moved to > CanvasResourceProvider. > - RestoreCanvasMatrixClipStack logic centralized to CanvasResourceHost > and can be accessed via callback > - Backing SkiaPaintCanvas now private to CanvasResourceProvider with no > external access. Any users of the backing SkiaPaintCanvas in > Canvas2DLayerBridge had their functionality moved to > CanvasResourceProvider (ie. new RestoreBackBuffer() function) > > Updates to test files: > - Addition of explicit FlushCanvas() calls in tests that used to expect > SkiaPaintCanvas to immediately update. > - Some tests expected the CanvasResourceProvider to be created on first > draw. This expectation has been changed since the > CanvasResourceProvider now gets set up on SetCanvasResourceHost(). > > Other new functionality: > - Display Item List now has a bit that tracks if it contains any draw > operations. This is used to see if there are draw ops to flush. > > Bug: 1019288 > Change-Id: I717b18e22d6699dc876d8f8121a25d147738579d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891292 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743002} TBR=senorblanco@chromium.org,fserb@chromium.org,khushalsagar@chromium.org,aaronhk@chromium.org,juanmihd@chromium.org,jochin@microsoft.com Change-Id: Icd1e97d26d3b4b46598f02c03b163ba31a1c2881 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067239Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743213}
-
Nicolás Peña Moreno authored
This CL adds a test for FID that tests equality between the JS value and the value reported in UKM and in UMA. Change-Id: I00de8c947895700d86788ee4a95ea228458bb25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067077 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#743212}
-
David Black authored
In response processing v2, the pending response will be committed at the earliest opportunity so that it can begin rendering. This CL should *not* affect response processing v1. Follow up CLs will make additional changes to processing logic and rendering logic to accommodate this new streaming model. Bug: b:129411551 Change-Id: I86c22929eb24945f104a06fbbe5ae0b1468caa5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063264 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#743211}
-
Oystein Eftevaag authored
R=ssid@chromium.org Change-Id: I83081fc50722f30217ce10f689f197372dc6e636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065408 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#743210}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2156c444568a..b4357d46c6c6 git log 2156c444568a..b4357d46c6c6 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 courtneygo@google.com Update expectations after swiftshader fix 2020-02-20 cnorthrop@google.com Vulkan: Update ES 3.1 test expections 2020-02-20 jmadill@chromium.org Const-ify the validation layer. 2020-02-20 xinyi.he@arm.com Vulkan: Implement eglWaitNative function 2020-02-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 113d07a6ebda..c12493ff69e2 (3 commits) 2020-02-20 tobine@google.com Vulkan:Skip appendToStartedRenderPass() 2020-02-20 wez@chromium.org [fuchsia] Migrate to SDK-provided FIDL & package targets. 2020-02-20 jmadill@chromium.org Vulkan: Fix image queue changes with graph disabled. 2020-02-20 syoussefi@chromium.org Update status of ANGLE conformance 2020-02-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 8def9063c4fd..74d3f371f201 (1 commits) Created with: gclient setdep -r src/third_party/angle@b4357d46c6c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050703 Tbr: cwallez@google.com Change-Id: Id3154867665a8d4c323b259863d20c1133042ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067078Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743209}
-
Demetrios Papadopoulos authored
This is in preparation of further refactoring of the settings-site-settings-page UI element. Bug: 1032584 Change-Id: I0b93a853d97d1141eb7bca215ad23e2a36e27851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065913 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#743208}
-
Wez authored
Blink's heap tracing has been fixed to scan safe-stack stacks correctly so we can now defer to the toolchain default setting. Bug: 821951, 1050703 Change-Id: Iaa3204fcd8f22e8f2334e4b4b3a7adc3dad612c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064938 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743207}
-
Jose Lopes authored
This is meant to be called at most once if the CDM creation fails: https://cs.chromium.org/chromium/src/media/base/cdm_factory.h?rcl=35ac0b549d21e712319c0bc304fd9de6cba74ecf&l=20 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I1e7bfb134fe90a9f3e239b8dd45a69d6253347d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047188 Auto-Submit: Jose Lopes <jabolopes@google.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743206}
-
Victor Costan authored
This CL should not introduce any functional change. introduced that blocks its usage. Its occurrence in AppCacheURLLoaderJob blocks upcoming changes to the class. mojo: :DataPipe was documented as deprecated, and a presubmit check was Change-Id: Ib0213d83d41ad2149a7928bcad9180482efb7ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066299 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#743205}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a9f14d4ed59b..eed27fa60f1b Created with: gclient setdep -r src-internal@eed27fa60f1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050094 Tbr: jbudorick@google.com Change-Id: I03b70c01eb2e87c3c2c497fccd6f19e487f80742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067120Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743204}
-
Ella Ge authored
Test is flaky. TBR=benwells@chromium.org No-try: true Bug: 1054196 Change-Id: I0d82f7d1b3c1350bf0d97b22fc2388d5de8a0b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067281 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#743203}
-
Omer Katz authored
Bug: 1053542 Change-Id: Ifb2fa71cb1a806187663a0f393103f20cff73711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066839Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743202}
-
Matt Wolenetz authored
Renames HTMLMediaSource (in core/html/media) to be MediaSource, and renames MediaSource (in modules/mediasource) to be MediaSourceImpl. This follows more recent practice in core/html/media. See also related code review comment [1]. [1] http://crrev.com/c/2003402/9/third_party/blink/renderer/core/html/media/html_media_source.h#50 BUG=878133 Change-Id: I143718c2b9bf8a2e32ad29e31c15094ae32da3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065421Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743201}
-
Victor Costan authored
This CL breaks down a long if/else if/.../else block into smaller blocks, using early returns. No functional changes are introduced. Change-Id: I329599ac5a8bb54408e8c0c657b40d330b76765f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065357 Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Victor Costan authored
The base::SupportsUserData::Data superclass seems to be left over from a previous architecture. It adds cognitive overhead, as it implies that AppCacheRequestHandler may be used in a base::SupportsUserData container. Change-Id: Ibe61b6cec71ebd513eb8ccd896845d4c04b47f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066104 Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bf2de16258dc..8ef250cfe144 git log bf2de16258dc..8ef250cfe144 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 tvanderlippe@chromium.org Remove typedefs from {perf_ui,persistence,protocol}-legacy.js 2020-02-20 tvanderlippe@chromium.org Add e2etest for cacheable responses in the network panel 2020-02-20 tvanderlippe@chromium.org Add test for utf-8 character encoding Created with: gclient setdep -r src/third_party/devtools-frontend/src@8ef250cfe144 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie96e85bdabc6c432b4ab251cc069912b827a782a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066089Reviewed-by:
-
Ella Ge authored
TBR=kyleju@chromium.org No-Try: true Bug: 856601 Change-Id: I08b33a249252e2615cd26fb26ac43e1113d1a028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067243Reviewed-by:
-
Changwan Ryu authored
Currently, it takes 120 seconds for 2,000 Hz sampling, and it takes more than 5 minutes for 10,000 Hz sampling. This is slow because of the use of double loops. This can be avoided by using a hashmap (dict) and a single loop with a more lenient pattern matching. (ntfschr@'s idea) With this change, the address matching part takes < 1 second. Also, this adds some more logging to understand what is going on, and adds a test case around the address that was not recognized. Test: run_simpleperf_test covers this Test: output result looks correct. Bug: 1048428 Change-Id: I795c83133baeb07f8b78342d94e6d3b227eebd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063811 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#743196}
-
Toni Barzic authored
Back button tests - update test setup to set accessibility setting that forces the back button to be shown (as the tests verify actual button functionality). ShelfLayoutManagerWindowDraggingTest.DraggedMRUWindow - for drag from bottom tests, use the shelf bottom directly instead of current test case widget bounds (to handle the case where navigation widget is hidden, and thus has 0 size). ShelfLayoutManager.PressHomeButtonOnAutoHideShelf, and ShelfViewTest.HomeButtonMetricsInTablet- the tests verify the button functionality, so set accessibility setting to force it to be shown. BUG=1051714 Change-Id: If6f65ef16530af2ca655101698a8a00857dc6da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063730 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743195}
-
Kenneth Russell authored
Per request on https://chromium-review.googlesource.com/2029236/ . Bug: 1048907 Change-Id: If19466721c616114affbde9d65cdd19bd69c5980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040445Reviewed-by:
-
Ben Pastene authored
The script was removed in crrev.com/c/1867257, so (hopefully) the wheels only it needed are no longer necessary. Incidentally, this will help certain tests on CrOS which use the root vpython spec, but don't have the room for the whole venv. By removing scipy, there will now be enough room. Bug: 1053547 Change-Id: I8cda733283ff379c93ec027c97935cb8c6ff915c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065419 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#743193}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cdda76d1c88e..d881983a38b4 git log cdda76d1c88e..d881983a38b4 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 mbonadei@webrtc.org Change faq.md titles. 2020-02-20 mbonadei@webrtc.org Add FAQ page for git repo. 2020-02-20 hta@webrtc.org Remove old-style OnFailure callbacks Created with: gclient setdep -r src/third_party/webrtc@d881983a38b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:589455 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia49c58395a9f5adfcccd07d810e64f3b428b471a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067118Reviewed-by:
-
Mitsuru Oshima authored
Next step: * Consolidate string grd file into single shortcut_viewer_strings.grd * Remove NewWindowDelegate::ShowKeyboardShortcutViewer and open it directly. * Remove KSV_EXPORT Bug: 1046624 Change-Id: I4241bd00d5c27520ac11c09e7264e8c8c9729a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065852 Commit-Queue: Mitsuru Oshima (OOO) <oshima@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#743191}
-
Steven Bennetts authored
Bug: 1047454 Change-Id: I9cd74e14d66ed9018c48dee4c711e85c456c1610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044874 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#743190}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings crostini subpage from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I0b04d2eb1b079c1a4a8e3ef5aedcd86766f737cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062942 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#743189}
-
Mark Yacoub authored
Revert to previous version (pre crrev.com/c/2039752). |plane| is shared state between previously submitted frame and the current frame. We can't rely on that state since generating the new frame would have updated the plane state. It's existence in the |old_plane_list| is sufficient to signal that |plane| was previously used. BUG=1045743,1053603,1053839 TEST=ozone_unittests Change-Id: I08cdb1ae7962debf7ec35eea6f00291995454d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062684Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#743188}
-
Mario Sanchez Prada authored
Original: r743081 http://crrev.com/c/1991446 Revert: 743086 http://crrev.com/c/2065671 The previously landed CL included changes in RenderAccessibilityImpl that made more sense in previous iterations of that CL where that class was not implementing AccessibilityModeChanged(). Those changes forced us to adapt a few unit tests (accessibility_ipc_error_browsertest.cc, autofill_browsertest.cc, cross_platform_accessibility_browsertest.cc) that would otherwise no longer pass. Unfortunately, it seems that those changes in RenderAccessibilityImpl broke tests in some platforms (ChromeCast and ChromeOS) so, making the most of the fact that the final code in RenderAccessibilityImpl is much closer to the original one than in previous versions, we can drop those changes and avoid even touching those unit tests we had to adapt before to fix those build failures, which is what we have added in this CL. And as a plus, the delta compared to origin/master is much smaller now, since RenderAccessibilityImpl is now practically unchanged. Original description: Based on crrev.com/c/1847304, by Colin Blundell <blundell@chromium.org> This CL starts the process of converting accessibility IPC to Mojo. We start off by converting the message FrameMsg_SetAccessibilityMode which, while not strictly a message from accessibility_messages.h, it's very important in that it's responsible of getting accessibility enabled in the renderer side, when the ui::AXMode::kWebContent is specified. Also, it's important to migrate this message first and doing it using an associated channel for the new mojom::RenderAccessibility interface since we need to make sure that this new RenderAccessibility::SetMode() method gets processed in the expected order relative to other messages already being sent using Mojo between the browser and renderer process, such as those for mojom::NavigationClient, for instance. Not doing it in this way would lead to race conditions during the migration period, since the ordering of some messages from accessibility_messages.h being migrated to Mojo could not be processed in the expected order compared to this new RenderAccessibility::SetMode() method, which is required to happen first to get the RenderAccessibilityImpl object created in the renderer. Specifically, this CL does the following: - Adds render_accessibility.mojom with the RenderAccessibility interface. - Adds a new class RenderAccessibilityManager implementing the new mojom::RenderAccessibility interface, which will also manage the lifecycle of the object that will be handling accessibility in the renderer (i.e. the RenderAccessibilityImpl object). - Sets up the plumbing for RenderFrameHostImpl to be able to connect to the mojom::RenderAccessibility implementation via RenderFrameImpl, using an associated channel to connect to the receiver side, implemented by RenderAccessibilityManager. - Changes how RenderAccessibilityImpl gets created, so that its existence is now manager by RenderAccessibilityManager, which is permanently connected to the browser process for the entire lifetime of the RenderFrameImpl object. - Uses this infrastructure to replace the sending and handling of FrameMsg_SetAccessibilityMode. - Updates RenderFrameImpl::SetAccessibilityModeForTest() to rely on RenderAccessibilityManager::SetMode() from now on. - Updates tests as needed. Future work will incrementally convert the rest of the accessibility messages, including introduction of the Mojo interface for methods that go from the renderer to the browser. TBR=dcheng@chromium.org,dtapuska@chromium.org,arthursonzogni@chromium.org,haraken@chromium.org,rockot@google.com Bug: 1010831 Change-Id: I323c7875a77d05fecf4ae57c61a24fa8268ce463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066758Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#743187}
-
Wez authored
NetworkChangeNotifierFuchsia #includes the fuchsia.netstack FIDL header in a header that is published by the //net target, requiring that the fuchsia.netstack dependency is itself public. TBR=mmenke Bug: b/149757507, 1050703 Change-Id: I6bc7088817fd0180b1da85d3c40c0ca7a548fc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066719Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#743186}
-
Mason Freed authored
*** SHERIFFS: if this CL triggers a flaky layout test, PLEASE do not *** revert this CL. Instead, please disable the offending test(s) and *** add them to the crbug.com/1053725 section of TestExpectations. I *** will then take care of them as I fix up the remainder of these *** tests. Feel free to cc me if you create a bug. Thanks. This CL enables the FormControlsRefresh flag by default on all Desktop platforms. The launch bug is crbug.com/1051552. Because many layout tests use form controls, including tests that are not directly testing form controls, this CL requires many tests to be rebaselined. The bug at [1] tracks the effort to re-baseline all of these tests and remove these new lines from TestExpectations. This will be done in pieces, to reduce the code review burden. The bug at [2] tracks cleaning up some of these tests eventually, as there are new tests (see [3]) that directly test the appearance of the new form controls, and those likely supersede many rebaselines in this CL. However, I would like to get this landed first, as it might require several Revert/Reland cycles to get landed for good, and then I can come back and do the cleanup. [1] https://crbug.com/1053725 [2] https://crbug.com/1034611 [3] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/virtual/controls-refresh/ Bug: 1012108, 1053725, 1034611, 1051552 Change-Id: I2d6da06c21567506cf1fc601b90c686c74310376 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063530 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#743185}
-
David Van Cleve authored
This CL bumps the expiry milestone for the reduced-referrer-granularity about flag to M85, so that it can be around during an M82 rollout of the new default referrer policy and two milestones' worth of subsequent enterprise policy lifetime. Change-Id: If8fe6fed2691c1dafea45bb891f15abd2b702eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043130 Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#743184}
-
Mustafa Emre Acer authored
This CL adds a new bucket to Download.InitiatedByWindowOpener to indicate that a download is initiated by a same-site but cross-origin opener of that tab. E.g., if a tab subdomain1.example.com opens another tab subdomain2.example.com and then navigates it to a download, this CL will now record the download as kSameSite instead of kCrossOrigin. This is added because latest number from Canary for the kCrossOrigin bucket is unexpectedly large. I suspect this is caused by sites serving their downloads on subdomains. This would previously go to the kCrossOrigin bucket but it now goes under kSameSite bucket. Bug: 121259 Change-Id: Idf142448b052a342df057982cfb79b0669fbd229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065252 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743183}
-
Christopher Thompson authored
Enables LegacyTLSEnforced feature in the testing config, for the new study name (to fix server side config errors). Previously crrev.com/c/2056936 updated the feature flag but not the study name. Change-Id: Ibf55717fe10c87f9ea264c2e8fcc9355c537abc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065407Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#743182}
-
Weilun Shi authored
Extend the expiry date of UMA.LowEntropySourceValue to 2020-09-01. Bug: 1043734 Change-Id: If3eef672679dfed159e807b19458d22a831e32a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066101 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Donn Denman authored
Extends the expiry of two histograms that we expect to be critical in the Longpress and Translation experiments. BUG=1053120 Change-Id: If9bfaa1defc88ed1bb5e6b3d5e6ac47bbe93c35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063357 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#743180}
-
Robert Kaplow authored
Bug: 1053153, 1037311, 1037121 Change-Id: Ia5347d3279f2ab52cf21591f7ac9b8ac30321cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062939Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#743179}
-
Tanya Gupta authored
This prevents the app from crashing when the user navigates to the setting page. Change-Id: I4c48d8996694a681d27bf423e5212eaf82de29ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046711 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#743178}
-
Allen Bauer authored
Bug: 648382 Change-Id: I4db6eb8cfd081c1dde3998db2f1264f0adf42cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065350 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#743177}
-
Kevin McNee authored
SwapWebContents is implemented by WebContentsDelegates and is used in portal activations as well as having several chrome/ layer uses. We'll need portal specific code in this method, so we now have the WebContentsDelegate method be specific to portals, instead of bloating the content API. The chrome/ implementations can then add portal specific code and then swap. Other callers in chrome/ can call chrome/ implementations' swap methods directly without going through the content API. Bug: None Change-Id: I12106a43e5b7dc510f0f044fea378e0b66df2afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053400 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743176}
-
Martin Šrámek authored
This experiment was enabled in fieldtrial_testing_config, because it was being rolled out in Chrome M80. However, the experiment with a same name is being reused in M81/M82 code, where it's disabled again for the time being, and so it should be disabled in fieldtrial_testing_config too. Bug: 1032584 Change-Id: Ic903f1c082350d7067aaadbafee49b73772a21a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064998 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#743175}
-
Alex Ilin authored
These histograms are still useful until we update AccountManagerFacade to cache account ids together with emails. Fixed: 1053141 Change-Id: Ifcf2208d15b0692789d8ebdd5f20863397d1e641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066742 Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#743174}
-
