GitLab

When this flag is given, the new surfaces system will be used to display the browser contents.

BUG=

Review URL: https://codereview.chromium.org/307693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377408
R=jar@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/303253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274112 0039d316-1c4b-4281-b951-d872f2087c98

With this CL, the encoded handles will comply with the restriction that
"If handle X is prior to handle Y in the depth-first traversal order and both of
them are valid, then the value of X should be smaller than that of Y."

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/303163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274111 0039d316-1c4b-4281-b951-d872f2087c98

With this the ui/gl target compiles on mac and fails to link with some skia
thingy.

R=brettw@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/303273009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274110 0039d316-1c4b-4281-b951-d872f2087c98

These need to balance out the calls to LoginState::Initialize().

BUG=chromium:379140
TEST=unit tests pass
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/310493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274109 0039d316-1c4b-4281-b951-d872f2087c98

This hasn't been used since we removed the old SRPC-based PPAPI proxy.

BUG=none
TEST=trybots

Review URL: https://codereview.chromium.org/310473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274108 0039d316-1c4b-4281-b951-d872f2087c98

Referring to https://code.google.com/p/chromium/issues/detail?id=379470,
This is causing significant stability on trunk.  reverting.

> Refactor external_install_ui
> 
> Refactors ExternalInstallUI to have determinate lifetimes.
> This is likely the first of multiple patches targeting this area of code; the
> next one will concentrate on pulling the related logic out of ExtensionService.
> 
> BUG=378042
> 
> Review URL: https://codereview.chromium.org/300853008

TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/309483012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274103 0039d316-1c4b-4281-b951-d872f2087c98

Referring to https://code.google.com/p/chromium/issues/detail?id=379472,
This is causing significant stability on trunk.  Reverting.

> Block content scripts from executing until user grants permission
> 
> Prevent extensions with <all_urls> from running content scripts without user
> consent if the scripts-require-action switch is on.
> 
> BUG=362353
> 
> Review URL: https://codereview.chromium.org/288053002

TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/307933008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274102 0039d316-1c4b-4281-b951-d872f2087c98

Referring to https://code.google.com/p/chromium/issues/detail?id=379469
this is causing significant stability on trunk.

> Defer SpdySession destruction to support closing writes
> 
> Replace the STATE_CLOSED availability state with STATE_DRAINING, where:
>  * The read-pump will not run, and no frames can be read.
>  * No new frames may be queued in the sessions's write_queue.
>  * However, the write-pump will continue to run.
> 
> SpdySession's write-pump will destroy the session iff it's draining, the
> write queue is empty and no in-flight writes remain. As this (and
> ~SpdySessionPool()) are now the only locations where SpdySessions may be
> destroyed, session lifetime is more know-able and some WeakPtrs are
> removed.
> 
> Some tests have been updated to include closing RST_STREAMS sent by the
> session. This reflects current behavior. A future CL will add GOAWAY
> frames upon session errors.
> 
> BUG=375033
> 
> Review URL: https://codereview.chromium.org/305823003

TBR=jgraettinger@chromium.org

Review URL: https://codereview.chromium.org/310563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371530
NOTRY=true
TBR=sievers

Review URL: https://codereview.chromium.org/302063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274091 0039d316-1c4b-4281-b951-d872f2087c98

 * Fix a regression so that once again the time range selector combo-box is in focus initially.
 * Clean up the code that determines which controls should be enabled/disabled/hidden on the dialog.
 * Reduce the number of controls that flicker (i.e. change state from disabled->enabled visibly) on opening the dialog in the most likely use-case, i.e., instead of starting with everything disabled, only have the commit button initially disabled.
 * Fix a regression so that once again some checkboxes can be disabled by policies. (I think this was also broken.)

BUG=365206

Review URL: https://codereview.chromium.org/275483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274090 0039d316-1c4b-4281-b951-d872f2087c98

Because we already do necessary checks during the validation stage.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/293983026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274089 0039d316-1c4b-4281-b951-d872f2087c98

> Revert of Properly prioritize the sources of an accessible name on Android. (https://codereview.chromium.org/303113003/)
> 
> Reason for revert:
> Broke android bots it looks like:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/20683
> 
> Original issue's description:
> > Properly prioritize the sources of an accessible name on Android.
> > 
> > This spec covers the right order: http://www.w3.org/TR/wai-aria-implementation
> > 
> > Now Android basically matches Windows, the difference is that Android has
> > to pick just one accessible name while Windows can have both a name and
> > a description.
> > 
> > There were existing cross-platform tests; I updated the Android
> > expectations.
> > 
> > BUG=359216
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274017
> 
> TBR=aboxhall@chromium.org,dmazzoni@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=359216
> 
> Review URL: https://codereview.chromium.org/304293006

TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/302243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274088 0039d316-1c4b-4281-b951-d872f2087c98

A grep for gpu reveals that only ui/aura/bench includes from gpu.

Change aura_bench to depend on gles2_implementation.

That should simplify the conversion of Aura to GN.

BUG=None
TEST=green trybots
TBR=ben@chromium.org,brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/308043007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274087 0039d316-1c4b-4281-b951-d872f2087c98

Add code to make the aura::WindowObserver interface crash
when it's destroyed without having unregistered its interest
in all aura::Windows that it was observing. This will
hopefully help track down the source of crashes that are
seen when closing video windows on Google Play.

https://codereview.chromium.org/303163003/ hopefully fixes
the test crashes that resulted in this change being reverted
earlier.

BUG=365364

Review URL: https://codereview.chromium.org/309573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274086 0039d316-1c4b-4281-b951-d872f2087c98

This is what shows up in Explorer > Details.

TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/301313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274085 0039d316-1c4b-4281-b951-d872f2087c98

This also removes --apps-use-native-frame.

This is a second attempt at https://codereview.chromium.org/251993002/.
There was an underlying bug which caused crashes on 10.7 when native
frames are enabled (http://crbug.com/378581). It's fixed by
https://codereview.chromium.org/307843002/.

BUG=339558

Review URL: https://codereview.chromium.org/308583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274084 0039d316-1c4b-4281-b951-d872f2087c98

Add support for [inline] autocomplete of about:blank.
The support handles fixup of the scheme separator.
Add BuiltinProviderTest.AboutBlank and do related cleanup.
Update OmniboxViewTest.UndoRedo and do related cleanup.

BUG=92577
TEST=about:blank is suggested in the omnibox; unit tests.
R=mpearson@chromium.org,pkasting@chromium.org

Review URL: https://codereview.chromium.org/290333015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274083 0039d316-1c4b-4281-b951-d872f2087c98

libtinfo is needed to build GDB on the NaCl toolchain builders.  We
previously built only i686-linux versions, but now build x86_64-linux
versions too, so we need the 64-bit version of this library package.

BUG= none
TEST= none
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/309503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274082 0039d316-1c4b-4281-b951-d872f2087c98

Currently if no response headers are passed into the plugin in OOP PDF then the
headers fetched URLLoader that loaded the stream URL will be used, but the
MIME type for the blob URL is always plain text, which causes the document
loader to refuse to load the document. Currently, if no headers are passed
to the in process plugin, we always try to load the document, so this just
mimics that behavior in the OOP plugin. When the in-process plugin is removed
we can change the document loader and remove the hack.

This also removes blob: URLs from the MIME type check in document loader
because they are no longer ever passed in.

BUG=303491

Review URL: https://codereview.chromium.org/301223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274081 0039d316-1c4b-4281-b951-d872f2087c98

For Kitkat, we can play video in immersive mode without the navigation bar.
Maybe we should do the same for other elements?

BUG=378412

Review URL: https://codereview.chromium.org/303263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274080 0039d316-1c4b-4281-b951-d872f2087c98

This is being done to remove use of a deprecated API in net/

BUG=81979

Review URL: https://codereview.chromium.org/302573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274079 0039d316-1c4b-4281-b951-d872f2087c98

browser_tests require xdisplaycheck to run, but the target does not list
xdisplaycheck as a dependency.

R=mseaborn@chromium.org, vadimsh@chromium.org
BUG=359338

Review URL: https://codereview.chromium.org/305053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274078 0039d316-1c4b-4281-b951-d872f2087c98

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/301033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274077 0039d316-1c4b-4281-b951-d872f2087c98

A changed to Textfield broke OnFocus/OnBlur behavior of PassphraseTextfield.
This provides an expedient fix until the class is deprecated completely.

BUG=378914
TBR=kevers@chromium.org, msw@chromium.org

Review URL: https://codereview.chromium.org/308933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365352
TEST=none
NOCHECK=true

Review URL: https://codereview.chromium.org/303423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274075 0039d316-1c4b-4281-b951-d872f2087c98

This allows targets that do not wish to depend on net
to use the MetricsService code.

Also, moves compression code to be in the net/ directory
of the metrics component.

BUG=375771,374295
R=isherman@chromium.org,blundell@chromium.org,davidben@chromium.org
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/291153013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274074 0039d316-1c4b-4281-b951-d872f2087c98

Gapless support for AAC is similar to MP3 but unlike
MP3 which only has padding in the first frame, AAC may
require discarding data across multiple frames.

Unfortunately this means we can't just discard the padding
frames wholesale without changing what's decoded from the
first non-padding frame.

Testing reveals we need to decode the padding frame prior to
the first non-padding frame in order to correctly decode the
non-padding frame.

We accomplish this by introducing the concept of a preroll
buffer which is to be played out prior to the current buffer
but must be entirely discarded.  Luckily this is easily done
with the infrastructure in place for the gapless MP3 playback!

While we need to support post splice buffers with preroll for
gapless playback, for simplicity, pre-splice buffers are not
allowed to have preroll.

In sum, this change:
- Adds SetPrerollBuffer() and preroll_buffer() to the
StreamParserBuffer.
- Refactors splice frame handling into a new
HandleNextBufferWithSpliceFrame() method, introduces
HandleNextBufferWithPreroll()
- Modifies the frame processor to use the frame prior to the
partial append window discard as the preroll.

BUG=371633
TEST=new unittests!
R=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/276573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/308513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274072 0039d316-1c4b-4281-b951-d872f2087c98

Windows has a fancy backgrounding mode which lowers IO priority.
Sadly it can only be set from within the process to be backgrounded.
So add a new ChildProcessMsg to tell child processes when they should
enter and leave background mode.

This reduces glitching during background tab load. This should only be
landed along with https://codereview.chromium.org/298253004/ which
removes backgrounding for active audio tabs.

I expect this will reduce CPU and I/O load significantly for background
processes which will lead to power savings.

This is only done on Windows since ChromeOS / Linux require privileges
only available to the browser process for setting background mode.

BUG=362294
TEST=Play audio. Load background tabs. Observe less/no glitching.
R=jam@chromium.org, luken@chromium.org, nasko@chromium.org

Review URL: https://codereview.chromium.org/305533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274071 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/304163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274070 0039d316-1c4b-4281-b951-d872f2087c98

pushState/replaceState should always report as a GET, even if they happen in a
document that was the result of a POST.

Currently, POST->replaceState->reload sends a GET (as the spec
requires), but we incorrectly show a form resubmission warning.

BUG=239907
TEST=NavigationControllerTest.PostThenReplaceStateThenReload

Review URL: https://codereview.chromium.org/306033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274069 0039d316-1c4b-4281-b951-d872f2087c98

There are no web sites currently using this feature, but it causes
all multichannel users to waste resources unnecessarily upmixing,
generating, and transferring empty channel data.

Further this breaks fancy OSX multichannel users which have non
standard channel layouts.  Mostly because we don't want to deal
with the plethora of ways OSX wants to map channels ourselves.

Instead we can require that MSE users which want to change channel
counts, must specify the maximum number of channels in the first
initialization segment.

This also fixes use cases where clients routed multichannel streams
into WebAudio for processing instead of actual playout.

BUG=266674,379288
TEST=Only 2 channels are created for stereo sources when a 7.1
device is connected.

R=rileya@chromium.org, wolenetz@chromium.org

Review URL: https://codereview.chromium.org/304233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274068 0039d316-1c4b-4281-b951-d872f2087c98

Added a second configuration that can support two http proxies and one https proxy. In the process, added a new DataReductionProxyParams object to encapsulate static configuration details and made DataReductionSettingsAndroid a BrowserKeyedContextService.

BUG=370039

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273810

Review URL: https://codereview.chromium.org/286013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274067 0039d316-1c4b-4281-b951-d872f2087c98

LevelDB sometimes returns Status::InvalidArgument() when it encounters
corruption. But LevelDB doesn't provide a Status::IsInvalidArgument()
accessor so we need to indirectly detect it.

This patch revealed that IndexedDBDatabaseOperationTest.CreatePutDelete
had been passing by accident. In order to make it continue to pass, this
patch adds a method to IndexedDBFakeBackingStore.

BUG=322707

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273757

Review URL: https://codereview.chromium.org/303073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274066 0039d316-1c4b-4281-b951-d872f2087c98

This micro benchmark will used in a follow-up patch to generate various
kinds of invalidations (viewport, random, full layer) from the telemetry
repaint benchmark.

R=vmpstr@chromium.org
BUG=376379

Review URL: https://codereview.chromium.org/298723013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274065 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw

Review URL: https://codereview.chromium.org/269313006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274064 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Properly prioritize the sources of an accessible name on Android. (https://codereview.chromium.org/303113003/)

Reason for revert:
Broke android bots it looks like:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/20683

Original issue's description:
> Properly prioritize the sources of an accessible name on Android.
> 
> This spec covers the right order: http://www.w3.org/TR/wai-aria-implementation
> 
> Now Android basically matches Windows, the difference is that Android has
> to pick just one accessible name while Windows can have both a name and
> a description.
> 
> There were existing cross-platform tests; I updated the Android
> expectations.
> 
> BUG=359216
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274017

TBR=aboxhall@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=359216

Review URL: https://codereview.chromium.org/304293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274063 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Mojo: Specify/check alignment of pointers more carefully. (https://codereview.chromium.org/304303006/)

Reason for revert:
Broke the windows bots:
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/builds/40269
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/26580

Original issue's description:
> Mojo: Specify/check alignment of pointers more carefully.
> 
> Improve the verification routines especially in the case that no count
> is necessary.
> 
> Also add a test.
> 
> R=darin@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273936

TBR=darin@chromium.org,viettrungluu@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/312463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274062 0039d316-1c4b-4281-b951-d872f2087c98

Introduce NewTabButtonTargeter, a derived class of 
MaskedViewTargeter, to define the custom hit-test 
region of the new tab button.

BUG=377551
TEST=none

Review URL: https://codereview.chromium.org/299353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274041 0039d316-1c4b-4281-b951-d872f2087c98