- 21 Feb, 2020 40 commits
-
-
Victor Costan authored
AppCacheURLLoaderJob is the only subclass of AppCacheJob. This is a vestige of the Network Service migration, which introduced the AppCacheJob base class with two implementations. This CL merges AppCacheJob and AppCacheURLLoaderJob, and renames the result to AppCacheURLLoader. The new name is more appropriate in a Network Service-only world, and removes the potential for confusion with AppCacheUpdateJob. The following replaces were done mechanically over the entire repository: * AppCacheURLLoaderJob -> AppCacheURLLoader * AppCacheJob -> AppCacheURLLoader * appcache_url_loader_job.h -> appcache_url_loader.h * appcache_job.h -> appcache_url_loader.h * GetDerivedWeakPtr -> GetWeakPtr * appcache_url_loader_job -> appcache_url_loader AppCacheJob::AsURLLoaderJob() was removed, as it became a no-op after the class merger. The mechanical replaces above removed AppCacheURLLoaderJob::GetDerivedWeakPtr(), which became a synonym for GetWeakPtr(). When relevant, job / Job was replaced with loader / Loader in local variable names and method names. This CL does not introduce any functional change. Change-Id: I5a508a8dcb14ec77da05dd345d280ea27fa12fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066298 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#743485}
-
Rushan Suleymanov authored
Each node that has children must be a folder or a permanent node. Bug: 1051614 Change-Id: I6fcabab85d7d2a1ec6e1d824735c509582ca7fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064943 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#743484}
-
Armando Miraglia authored
Fixed: 1053026 Change-Id: Ic324fdb4c406cbbb5b29e2e14b0c173782fb3a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062437 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#743483}
-
rajendrant authored
This CL records the coverage when image hints are unavailable: whether the hints fetched within 5 seconds of page navigation and the image URL was found in the hint list or not. UKM privacy review doc: https://docs.google.com/document/d/1u8CbXHHqUvhcFaYGsLAvTbITUmbEukW-FxQPujLHuIo/edit Bug: 1044798 Change-Id: Ifc9f416df1878d3cfc6a8b844f7b2912d2304659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063832 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#743482}
-
Hajime Hoshi authored
Before this CL, the time when the peak CPU usage occurred was measured as the time delta between the navigation start and the time when that happens. This didn't consider the background state and back-forward cache. If the tab was in background for a long time, the measure time was longer than we expected. This CL fixes this by recording the CPU usages only when the tab was not backgrounded in the window. Bug: 1014174 Change-Id: Ib15d8f189b1ce9a0329498da9883d54d54ac8bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050295 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#743481}
-
Side Yilmaz authored
incognito. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates EphemeralTabCoordinator class. This CL creates a profile object based on isIncognito param to pass the current profile(i.e., regular or off-the-record profile) for TrackerFactory and FaviconLoader,while the profile always regular profile in current usage. This CL changes the behavior of code to make it run with correct profile. Bug: 1041781 Change-Id: Ia412cb5bdf28a269d2b75fac7c8cbf559c36a51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051985 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#743480}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates EditorDialog class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I322a8a21f92a911d85d8f4378c16a0b67c5f0ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064936Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743479}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 496b728d. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" c07550c4 "Fix ResolvedUnitType() in CSS min/max with both integers and floats" 86c2cff8 "Don't make anchor clicks cancel form submission when href=#" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I93de8f09be7c8fb3afd352618dafa7d0ad25ce2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066580Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743478}
-
Steve Becker authored
Adds an immediate flag to unregister jobs for service worker registrations. When set, the immediate flag enables unregister jobs to run the "Clear Registration" algorithm immediately without waiting for the active worker's controllees to unload. After an immediate clear, the registration's controllees become uncontrolled. The controllees receive the 'controllerchange' event when the navigator.serviceWorker.controller is set to null. This change updates ServiceWorkerContextCore::DeleteForOrigin() to set the immediate unregister job flag to true. All other callers set the immediate flag to false. The storage quota manager uses ServiceWorkerContextCore::DeleteForOrigin() when clearing data for the origin. In addition to evicting origins to free up storage quota, this code path is used by scenarios like the Clear-Site-Data network header and the "clear browsing data" privacy UI setting. The change adds a new function to the ServiceWorkerRegistration class, DeleteAndClearImmediately(), which is used by ServiceWorkerUnregisterJob when the immediate flag is true. DeleteAndClearImmediately() is very similar to the existing function, ClearWhenReady(), but it does not wait to clear the registration when the active worker has controllees. ServiceWorkerContextCore::DeleteForOrigin() is also updated to call DeleteAndClearImmediately() on the origin's uninstalling registrations. Registrations stuck in the uninstalling state are waiting for the active worker's controllees to unload. ServiceWorkerContextCore::DeleteForOrigin() must stop waiting and clear the registration immediately. GetUninstallingRegistrationsForOrigin() is added to the ServiceWorkerRegistry to enable ServiceWorkerContextCore::DeleteForOrigin() to find the uninstalling registrations it needs to clear. For testing, the change adds a new unit test that sets the immediate flag to true in ServiceWorkerJobTest. The change also adds a new service worker WPT test, unregister-immediately.https.html. The new WPT test uses the Clear-Site-Data network header to unregister service workers with the immediate flag set to true. The WPT test adds a test case for each service worker state. For example, one test case uses Clear-Site-Data to clear a registration with a service worker in the 'parsing' state. Other test cases cover the other service worker states like 'installing', 'installed', 'activating' and 'activated'. Additional test cases verify controllee state, which includes verifying what happens to pending fetch events when the controller clears. Bug: 1014114 Change-Id: I3baee1117e6dbd349ec4c98c796d4e1b2bddde96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040533Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743477}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5e4f0910c1bf..4b6120a066eb git log 5e4f0910c1bf..4b6120a066eb --date=short --first-parent --format='%ad %ae %s' 2020-02-21 yangguo@chromium.org Update design review guidelines Created with: gclient setdep -r src/third_party/devtools-frontend/src@4b6120a066eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I20e5e1a34e6d475c8bcfd45a25f2ebf6601c0872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743476}
-
Omer Katz authored
Bug: 1053542 Change-Id: I01dbd7df946770044ac7c824a55c1ebcaf350a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066744Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743475}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c5d36f253374..b88007fbbbc3 git log c5d36f253374..b88007fbbbc3 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 abennetts@google.com Revert "Fixing dashboard & sheriff-config push-on-green" 2020-02-21 abennetts@google.com Fix minor issues in staging job templates, and add a README. Created with: gclient setdep -r src/third_party/catapult@b88007fbbbc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: crouleau@google.com Change-Id: Id1938f622e5134749dadb4bb21f2c026ccd99f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068178Reviewed-by:
-
Michael Lippautz authored
The marking verifier assumes that any marked backing stores contains pointers to only live objects. In case a backing is removed after the table has been added for later processing, buckets were not cleared if they were trivially destructible. The fix clears weak pointers when marking is on as well. Bug: 1054363 Change-Id: If082a518d39b97d1d04661e784ac8b5fbb05c069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066918Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743473}
-
Igor Makarov authored
- added .style.yapf files - reformat *.py files in third_party/blink/public Bug: 1051750 Change-Id: Ibf90a409f235cbdd96991c6c67a21cecea5f1547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057304Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#743472}
-
Jasmine Chen authored
This CL skips the wait for 3A-convergence (AE, AF, AWB) when Zero-Shutter Lag (ZSL) is enabled. When configuring streams, camera HAL adapter would add a private usage flag to the configured still capture streams. Video Capture Device (VCD) would then use this private usage flag to determine if ZSL is enabled. If ZSL is enabled, we skip 3A when trying to construct a capture request. This is a reland of crrev.com/c/1919530. In Camera3AControllerTest.Stabilize3AForStillCaptureTest, we didn't initialize zero_shutter_lag_enabled causing 3A stabilization to be skipped randomly, failing postsubmit. BUG=b:130851309 TEST=Tested on kukui and verified VCD is able to get ZSL availability through the private usage flag && capture_unittests. Change-Id: I8717dec6210151242240502ebd37c68c43c530ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066410 Auto-Submit: Jasmine Chen <lnishan@google.com> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#743471}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c7aa5ac7..6684a9fe Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6caed97924472d332a774b15b157353a7bbab3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067359Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743470}
-
Nikita Podguzov authored
Display the difference in behavior of printing.submitJob() for extensions listed in PrintingAPIExtensionsWhitelist policy. Bug: 996785 Change-Id: I197b2fd386fad90c731b50f995ce463a5ade6beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062411 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743469}
-
Jose Lopes authored
This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ic6d5627e79a10a86e1fe3847494b2ca45b60ff06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047246 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#743468}
-
Kent Tamura authored
Also, move NextSelectableOptionPageAway() to ListBoxSelectType. This CL has no behavior changes. Bug: 1052232 Change-Id: Icc0d4e3c3f651473170c9904dbf6db47bb66a6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068070Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#743467}
-
Nikita Podguzov authored
Include chrome.printing html documentation to the list of available APIs. Bug: 996785 Change-Id: I4868fb3737133c614297353c393d013f6492caff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050378 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
-
Toby Huang authored
This CL responds to Mark Goldstein's comments on commit_checklist.md. Mark Goldstein was my instructor for the Technical Writing One course, and as a follow-up exercise, he asked us to include him as a reviewer on a documentation-related change. This doc will also form the basis of my upcoming talk "Life of a CL" at Chrome University, so I want to make sure it's in tip-top form! Bug: None Change-Id: I0aeefcbb149929969f15d375f55ea2d2d44684f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045051Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743465}
-
Nikita Podguzov authored
This extension demonstrates how chrome.printing API can be used to submit print jobs to the printers. This extension will be used for external documentation as well. Bug: 996785 Change-Id: Idb221bb99f2e157983edfb0356ae87ca655a9e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050780Reviewed-by:
-
Simon Zünd authored
Asynchronous source mapping makes {rawLocationToUILocation} asynchrounous. This CL adds async/awaits to all affected test helpers and methods in http/tests/devtools/sources/* web tests. Note: The inline-breakpoint-with-source-map.js test is re-written using a newer test utility that helps with flakiness. Note 2: The live-edit-breakpoint.js web test is disabled for now, as it requres a 3-way change. The new baseline is already committed with this CL. Bug: chromium:1032016 Change-Id: I77a98faff99c02c40df46b115a1da0f228282844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064214Reviewed-by:Mathias Bynens <mathias@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#743463}
-
Hajime Hoshi authored
This CL adds a new UMA BackForwardCache.Eviction.TimeUntilProcessKilled to measure the time duration between the last time when the page goes to the back-forward cache and the time when the process is killed. This information helps us to know how often unexpected evictions happen and improve the coverage of back-forward cache. Bug: 1052793 Change-Id: I603cda73f5b892d6b9c61062e7dd1d8c4f47dba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060209 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Daniel Vogelheim authored
The current code (erroneously) checks for the 'experimental CSP features' flag when processing Trusted Type related CSP directives, while the majority of TT checks TrustedDOMTypes enabled/disabled. This patch removes the extra check. (This was introduced erroneously in crrev.com/c/1993351, when reworking the TT CSP directives.) Bug: 1054387 Change-Id: Iad04f0f80b30874c61e5819b6319b85358bd4631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066545 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#743461}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ce4918f18f73..c58458e633e1 git log ce4918f18f73..c58458e633e1 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 jmadill@chromium.org Vulkan: Remove CommandGraph code. 2020-02-21 jmadill@chromium.org Run debug callback in perf render tests. 2020-02-21 lexa.knyazev@gmail.com Reland "Move sampleAlphaToCoverage out of blendState" 2020-02-21 syoussefi@chromium.org Vulkan: Update shader compilation documentation 2020-02-21 spang@chromium.org Pass ContextVk instead of gl::Context to internal methods 2020-02-21 cnorthrop@google.com CaptureReplay: Emit unused resources Created with: gclient setdep -r src/third_party/angle@c58458e633e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I957cde5e374e9eef14d8d1610d0ae0e0fe3d89ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068157Reviewed-by:
-
Stefan Zager authored
RemoteFrameView::GetCompositingRect uses geometry mapping code that relies on a clean layout state; but it is called from RenderFrameProxy::SynchronizeVisualProperties, which is called from many places, including in response to IPCs. With this change, the compositing rect is calculated and cached during each lifecycle update, and GetCompositingRect returns the cached value. BUG=1033746 Change-Id: I29c50c954829ef856d667b1948e1ea840904004a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028863 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#743459}
-
Darwin Huang authored
Mechanical find/replace from "Trace(blink::Visitor*" to "Trace(Visitor*" Refactoring change only. No functional changes intended. Bug: 1051193 Change-Id: Ia1a150929998758687187c82289a9d5646ad9b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068040 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch marks fast/forms/date/date-appearance-basic.html flaky because it is failed on Mac debug. TBR=masonfreed@chromium.org Bug: 1043488 No-Tree-Checks: true No-Try: true Change-Id: I98f54c0042aa4661b5bf541f2daa4fce7c3caf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067765Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d76b0f8e4596..5e4f0910c1bf git log d76b0f8e4596..5e4f0910c1bf --date=short --first-parent --format='%ad %ae %s' 2020-02-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@5e4f0910c1bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If07a0c44ed147956e08f19a5e8c012640a6faf7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068159Reviewed-by:
-
Daniel Libby authored
Keyboard arrow scrolling and scrollbar button scrolling should also scroll a percentage of the scrollable area when percent based scrolling is enabled. This CL adds plumbing from the base::Feature to blink, and uses 1/8th as the percentage to use for directional scrolls via keyboard arrows or scrollbar buttons. Adds a test suite that runs scrollbar tests in percentage mode. Keyboard is currently handled on the main thread so we just use the runtimeFlag toggling via javascript and eventSender. Bug: 1008153 Change-Id: I7ea7c5471298187da757cf22748620c4accaf192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057501 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743455}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/518e466ec497..c5d36f253374 git log 518e466ec497..c5d36f253374 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 fancl@chromium.org Fixing dashboard & sheriff-config push-on-green Created with: gclient setdep -r src/third_party/catapult@c5d36f253374 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: crouleau@google.com Change-Id: I1a13271becdfeac815886bbd4b70a67704f9a732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068162Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ccc1f15fb915..8adb09deb15b Created with: gclient setdep -r src-internal@8adb09deb15b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049646 Tbr: jbudorick@google.com Change-Id: Icff0039bb98b36e2fbced587fe895996a12ab4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068004Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743453}
-
Hirokazu Honda authored
Bug: 1035788 Bug: b:145961243 Test: HW encoder is used on https://appr.tc/?debug=loopback&vsc=h264&vrc=h264 Test: CtsVideoTestCases Change-Id: Id461857ea2ec2ce3382a5a72fc554951454bb582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041983Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#743452}
-
Eriko Kurimoto authored
This CL adds browser tests for 'module' type shared workers in WorkerTest.WorkerInBackgroundPage. Bug: 824646 Change-Id: I4500087be534bb384bcf4171437b50312b2a7da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061578Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#743451}
-
Miyoung Shin authored
This is a precursor CL to replace ExternalPopupMenu class by a mojo connection, and replace blink::TextDirection with base::i18n::TextDirection. Bug: 1044268 Change-Id: I0b6802201b05c48abaf19de78e81a848d5dc94b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061985 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Lei Zhang authored
Also reassign one of their TODOs. Change-Id: Id38eced079effbb4616e8fc6b94e925cb6b99330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067925Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#743449}
-
Rachel Sugrono authored
Change-Id: I424c2222de164cb58b5e46cea2be4b5c9d16bddb Bug: 992824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067764 Commit-Queue: Rachel Sugrono <rsugrono@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#743448}
-
W. James MacLean authored
This CL attempts to revert r707164 (https://chromium-review.googlesource.com/c/chromium/src/+/1863512) on ToT. It was slightly complicated through collisions with other CLs: Also reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1865530 Preserved: https://chromium-review.googlesource.com/c/chromium/src/+/1918262 Bug: 1050635 Change-Id: I426d45b44733a5fedd9c9a66c602e228051bafa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051206Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#743447}
-
btolsch authored
This change moves the current remaining OSP platform implementation files into //components/openscreen_platform in preparation for being used in //components/cast_channel. There are several additional fixes that were unittests + future integration work correctly: - Fixed a reversed sense of addresses (local vs. remote). - Began passing DER certificate back to caller when a TLS connection succeeds. - Fixed several use-after-moves that were dependent on argument evaluation order. Bug: 1050913 Change-Id: Ie5db314ffca1b5917ea85f17ae0614cdef8bee74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048916 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
