- 22 Jun, 2020 40 commits
-
-
Andrey Kosyakov authored
Mark external/wpt/editing/other/white-spaces-after-execCommand-delete.tentative.html as flaky t/o on Mac10.13 Bug: 1097810 Change-Id: I0d5cc6ba6ab908968c14cd59f3e5e6a8f7570299 TBR: behdadb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257456Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#780878}
-
Xing Liu authored
This CL reads DownloadSchedule from in progress download db. Bug: 1078454 Change-Id: Icec7eed9edb38ce526cd60b72de90aaeac817335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253150Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780877}
-
Jan Wilken Dörrie authored
This change updates the comments in util/ranges to refer to the previously filed tracking bug as well as updating the section tag for Mutating sequence operations. Bug: 1071094 Change-Id: I6d888a22cde1fc10f9e26e433f4eb70c21bec8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255612 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#780876}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ib79304ed1121bc142a92aafca92451eeec129337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255653Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780875}
-
Alison Maher authored
As resolved by the CSSWG, non-URL background-images should be reverted in Forced Colors Mode. https://github.com/w3c/csswg-drafts/issues/4916 Bug: 970285 Change-Id: I24c903f96da1921bb3da0388100062091afbb507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254441Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780874}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/aee0c3f1ebcc..f48a33827db6 $ git log aee0c3f1e..f48a33827 --date=short --no-merges --format='%ad %ae %s' 2020-06-19 jdrago Consider the absence of an av1C box to be a decode error 2020-06-19 jdrago Make local variables referencing heights unsigned 2020-06-19 jdrago Fix NEXTARG macro to always cleanup before exiting 2020-06-19 jdrago Simplify a few UV height checks 2020-06-19 jdrago Fix mistaken suggested renaming of numBits to sevenBits 2020-06-19 jdrago Cleanup inputFilenames in avifenc 2020-06-19 jdrago Reorganize parseSequenceHeader() local variables to satisfy static analysis 2020-06-19 jdrago Bail out on unexpected/unsupported image formats in aom decoder 2020-06-19 jdrago Lots of cleanup 2020-06-16 jdrago Disable forced keyframe interval by default; the arbitrary number in there wasn't helping anyone (...) 2020-05-19 E.M.terHoeven Ext: Update to libaom v2.0.0 2020-05-14 E.M.terHoeven GitHub Actions: Use GCC 10 2020-05-18 jdrago Pass alphaRange through when decoding an image grid 2020-05-18 jdrago Rename confusing decoderOwns* to imageOwns* and invert logic 2020-05-18 jdrago Change AVIF_RANGE_FULL's value to be decoupled from implementation details 2020-05-18 jdrago avifenc: add --ignore-icc 2020-05-18 jdrago avifenc: Correctly signal MC:1 by default (as that is how we'll convert by default anyway) 2020-05-11 wtc Add 'const' to some pointer parameters 2020-05-11 jdrago Change AVIF_LOCAL_AOM logic to match the same pattern of AVIF_LOCAL_RAV1E 2020-05-11 jdrago Update avifRGBImage usage in README Created with: roll-dep src/third_party/libavif/src The main changes that affect us are: - AVIF_PIXEL_FORMAT_YV12 is removed. - AVIF_PIXEL_FORMAT_YUV400 (monochrome) is added. However, since media::VideoPixelFormat does not have a monochrome or YUV 4:0:0 format, we still need to report a monochrome AVIF image as media::PIXEL_FORMAT_*420*. - All image metadata (in particular, whether the image is monochrome) is available in decoder_->image after avifDecoderParse() returns. As a result, decoder_->containerWidth, decoder_->containerHeight, and decoder_->containerDepth are replaced by decoder_->image->width, decoder_->image->height, and decoder_->image->depth. Test: 1. blink_platform_unittests --gtest_filter=*AVIF* 2. Run chrome with --enable-features=AVIF and visit https://resources.link-u.co.jp/avif/images.html. R=dalecurtis.chromium.org@chromium.org,pkasting@chromium.org Bug: 1092694 Change-Id: I98f1bc63bfb15a85ebcb437b23d09485d6f2e9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255523Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
-
Tarun Bansal authored
For some reason, cache-control no-transform bucket does not show up on the metrics dashboard. This is an attempt to fix it. Change-Id: I78001ab52a795ffaac5fdc83cb4a1cb4321441e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257542Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#780872}
-
Nina Satragno authored
Add support for getPinUvAuthTokenUsingPinWithPermissions. getPinToken has been deprecated and should not be used with CTAP 2.1 authenticators that report `pinUvAuthToken` support. This patch also undoes crbug.com/1090551 - we now default to default credential management and biometric enrollment commands when supported. Bug: 1087419 Change-Id: I247cb871f722f050ed35115f9fe4a10b71aee67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250507 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#780871}
-
Christian Biesinger authored
<picture> does not currently let you specify an aspect ratio per source: https://github.com/w3c/csswg-drafts/issues/5212 https://github.com/whatwg/html/issues/4968 So this just tests setting a single aspect-ratio on the <img> element for now. Bug: 1045668 Change-Id: I89f5132322f8131bf346ea663b889e3b1d740e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254454 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#780870}
-
Leonid Baraz authored
Its purpose is to accept, store, upload and remove individual encrypted reporting records from any OS and/or Chrome components (Storage treats them as opaque blobs of various size, limited by Options settings). Records are placed into the individual FileSets (queues) based on the specified priority. Each queue supports adding new records asynchronously, maintains strict records order (including the case when Storage module has restarted after crash or reboot), uploading records in batches periodically or immediately after write (in the future uploading on request is planned to be supported too). Uploading is performed by creating an uploader sink, which accepts series of individual records and then completion call - all are non-blocking asynchronous calls, with actual implementation of the uploader sink provided by the caller. The Storage also accepts a confirmation request for a specific queue (priority) with sequencing number, after which all records with lower numbers (inclusively) are assumed to have been processed and no longer included in future uploads from that queue. Bug: b:153364303 Change-Id: I8bfd0bbb367aa69f9914345b7927ce933eef38be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236990 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#780869}
-
Lucas Furukawa Gadani authored
Now that it has rolled out to stable, the feature used to launch can be removed. Bug: 1032139 Change-Id: I6b5fe013d15ed4eabaa4c3803c7829b9ebcaf106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250666Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#780868}
-
Andrey Kosyakov authored
This reverts commit 4f4b6cb6. Reason for revert: build breakage that is likely caused by https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2247646 (the culprit reverted as well, so next roll should work) Original change's description: > Roll DevTools Frontend from 1dccfa608557 to dbb8f3185736 (2 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1dccfa608557..dbb8f3185736 > > 2020-06-22 tvanderlippe@chromium.org Reland "Add rollup_entrypoint to rollup entrypoints in front_end" > 2020-06-22 alexrudenko@chromium.org Add additional assertions to styles pane tests > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1011811,chromium:1061037,chromium:1096473,chromium:946975 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I4c76e044980cb5e2096b9428539362ccbb2759a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257439 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#780794} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5f7c7e89dc166ec39bdb88e1a44b4c57c4b8180 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1011811, chromium:1061037, chromium:1096473, chromium:946975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256446Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Bug: 1069048 Change-Id: I468486a738e9c112417ab00dd73a44c182d0f6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252945Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#780866}
-
Brian Sheedy authored
Removes usage of //third_party/pymock from //android_webview in favor of the version provided by vpython. This is so that //third_party/pymock can eventually be removed. Bug: 1094489 Change-Id: Ibf1898bfdf891632f23f9399f060fcd02a6fbc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255565Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#780865}
-
Bailey Berro authored
This change adds DisplayAlignmentController, a class that manages a set of DisplayAlignmentIndicators to be shown when the mouse repeatedly hits the edges of a display within a short period. Note: This is a continuation of crrev.com/c/2146794 Bug: 1070122 Change-Id: I8ab7a84754c750f41824b535b2a30105e409f47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159620 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#780864}
-
Andy Paicu authored
This is an "educated guess" fix for flaky tests that I was unable to reproduce locally. Bug: 1092176, 1094585 Change-Id: I2789c903b96443b7004f578dff14b8e6ac522c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257326Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#780863}
-
Dana Fried authored
Previous to this CL, the hit test area for a tab group header would extend past the separators on either side of the header to the edge of the view, which is not the case for other tabs (which use their stroke shape to clip the event targeting area). Since group headers are only highlighted during drag, there's no need to use the curvilinear tab border path; we can just use the rectangle between the tab separators to mask mouse events. Bug: 1097303 Change-Id: I910e464df6323d3c2915a2a06c1d10d70a84a66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255742Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780862}
-
Xing Liu authored
The download later check is after the intermediate file rename, right before MaybeComplete. If any other interrupt reason happens, we use the existing logic to handle. When Resume() is called, we clear the DownloadSchedule struct. Since only auto resumption handler or the user will trigger it. Bug: 1078454 Change-Id: I0f442b662e94fb55991796a99fb226d2c8cc7998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249039Reviewed-by:
-
Yoav Weiss authored
Bug: 1052948 Change-Id: Ib2cfa0cdd516ad698530149d2696b0db2956fb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255600Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#780860}
-
Xing Liu authored
The UI string should be sentense case. So "Scheduled for later" section header and "Just now" section header can match. Bug: 1078454 Change-Id: Iedf457c3dd60da07b29b559d2e5082b0b35bd5a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256742Reviewed-by:
-
Chris Lu authored
Bug: 1071914 Change-Id: I000b685b8e62725125d47523b61bfd47992d8ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257453Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#780858}
-
Christopher Cameron authored
The SharedImageBackingFactoryGLTexture is responsible for ensuring that whenever a GLImage-backed SharedImageBacking has GL access requested, the GL texture be updated to reflect the GLImage. On macOS, for YUV 420 video (basically all video), this requires copying the biplanar video into an RGB texture, because there is no mechanism for sampling from biplanar IOSurfaces exposed on macOS. Note that this copy can usually skipped because those IOSurfaces can be used as overlays directly. The GLRenderer takes a GL read lock when scheduling overlays. This should trigger this copy unnecessarily, but, fortunately for us all, SharedImageBackingFactoryGLTexture is a bugfarm and skips updating GL textures in many different and interesting ways. Unfortunately, SharedImageBackingFactoryGLTexture can't stay a bugfarm forever. This adds GL_SHARED_IMAGE_ACCESS_MODE_OVERLAY_CHROMIUM, which will act like a GL lock, but will skip doing any GL texture copying or binding. With this in place, we can make SharedImageBackingFactoryGLTexture do the appropriate copies that it should be doing, without causing any regressions. R=zmo TBR=raymes (ppapi autogen) Bug: 1092155 Change-Id: Ia16360cdb3fd616a8f92a4f56cb4f130b4b02b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255674 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#780857}
-
Dominique Fauteux-Chapleau authored
This is a temporary fix to the crash issue, the long term fix will be to delete the manager a the appropriate time when the browser shuts down. Bug: 1096536 Change-Id: I68fe2e16b581d2bfe4b30eed339c6108311cf1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254518Reviewed-by:
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I3f6402a9d9187a95f1d5cb298d8beb44729db9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254148 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#780855}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1301bce532cb..113c5e29298b 2020-06-22 lehoangq@gmail.com Metal: deferred render command encoder creation. 2020-06-22 geofflang@google.com Roll zlib and cpufeatures from the ndk into Android. 2020-06-22 xiaoxuan.liu@arm.com Vulkan: Skip Texture2DArrayCopy.SnormFormats on Mali GPU. 2020-06-22 cwallez@chromium.org Suppress TransformFeedbackTest failure on Mac AMD. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I404c4b46d2f16e9d5a93d0e9225d32ed874101e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257733Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780854}
-
Mansi Awasthi authored
This CL refactors TextField struct to have a base struct FormField. This change is needed so that other form fields can be populated in future. Bug: 1030242 Change-Id: I4e6f45ca2bcb0e4a5e57de35622d12d29889c8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251615 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780853} -
Alex Rudenko authored
Disabled in https://chromium-review.googlesource.com/c/chromium/src/+/2256199 for the DevTools change in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2253898 Bug: 946975 Change-Id: I1d0e30004104bf12cb66f4b6e5b54e8f6b324e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257060 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#780852}
-
Andy Paicu authored
The script inside the page is not guaranteed to execute before the script injected via `runJavaScriptCodeInCurrentTab` which introduced a race condition causing the test to be flaky. I've updated the tests to use a function for clearing cookies that is manually called. Bug: 1090274 Change-Id: I1a714ac9053bec47aa4ad108f0493fd6ede607a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247763Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If3d7c78cbd245f775054038491ce2fe65cb346eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257734Reviewed-by:
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I161278f3bf0b77eef2d98b2819ba0c46676b94f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254125 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#780849}
-
Joel Einbinder authored
Key events emulated with DevTools can now use the commands option to send editing commands that will be executed if the event is not canceled. This is important for shortcuts like Meta+A = SelectAll to work on a Mac. See https://github.com/puppeteer/puppeteer/issues/1313 and https://github.com/microsoft/playwright/issues/1067 Change-Id: Id258668bfc71ef9f7f47477ef9de3422ada1d4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211929 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#780848}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I95573a0dab0a5ae62f8f88004e198bd0a6ef5319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254760 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#780847}
-
Andrey Kosyakov authored
This reverts commit 26d83272. Reason for revert: suspected cause of build failure on linux (https://ci.chromium.org/p/chromium/builders/ci/linux-ozone-rel/124191) Original change's description: > Remove/replace unnecessary includes of logging.h (ipc/) > > If the file just needs the CHECK/CHECK_OP/NOTREACHED > macros, use the appropriate header for that instead. > Or if logging.h is not needed at all, remove it. > > This is both a nice cleanup (logging.h is a big header, > and including it unnecessarily has compile-time costs), > and part of the final step towards making logging.h no > longer include check.h and the others. > > Bug: 1031540 > Change-Id: Ic0d59407e28200355332852d290f18441d6f678e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253980 > Auto-Submit: Hans Wennborg <hans@chromium.org> > Commit-Queue: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780828} TBR=hans@chromium.org,tsepez@chromium.org Change-Id: I780f92bca95aabcc845393ed4635e837e47aeb50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257738Reviewed-by:
-
Andrew Grieve authored
Bug: 1095654 Change-Id: Iaf820c43e56f3f8680c34981b9d1bc3cb70b6284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257732 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#780845}
-
Gavin Williams authored
For USB printers,the printer status in print preview will reflect if the USB printer is currently connected or disconnected to the device. The IPP printer status request mechanism does not work for USB connected printers. A later enhancement will add ability to detect when printers are connected or disconnected to the device while print preview is open and update the status accordingly. Bug: 1059607 Change-Id: Ia3835dac5d080d98d3834c76a1ede5cb0397601b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249384Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#780844}
-
Findit authored
This reverts commit ce50ad19. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 780827 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NlNTBhZDE5ZWY2YzQ3ZDZmMjgzMmFkMDc5NjNiZDMxM2NmZTA3OGYM Sample Failed Build: https://ci.chromium.org/b/8876774719528263456 Sample Failed Step: compile Original change's description: > Move JSONParser-specific enums out of JSONReader > > JSONReader is the API. JSONParser is *an* implementation, and we would > like to experiment (in future commits) with different implementations > (crbug.com/1069271). Doing so is easier if they don't also have to match > exact error code values for invalid JSON input. In practice, API callers > don't care about the error code value (if less than 1000). > > Also swap the order of the JSON_SYNTAX_ERROR and JSON_INVALID_ESCAPE > enum values so that JSON_SYNTAX_ERROR takes the enum value 1, the same > as the new kErrorCodeInvalidFormat enum value. > > Also update a switch statement in > components/policy/core/common/config_dir_policy_loader.cc to also catch > JSON_TOO_LARGE, JSON_UNREPRESENTABLE_NUMBER and any future enums added. > > Bug: 1069271 > Bug: 1070409 > Change-Id: I786c5d7ffc77e4d7927614a133bf1e7aae7eda5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251561 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780827} Change-Id: I5bbe9bb80563dafd59bff48fdf61ab593f1ccc6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257457 Cr-Commit-Position: refs/heads/master@{#780843}
-
Adam Rice authored
Permit an "options" argument to be supplied to the QuicTransport constructor providing a list of certificate fingerprints that are permitted to be used for the handshake. Add a unit test and browser test for the new feature. BUG=1011392 Change-Id: Ia98ab05d0d5e6fc34ae57472119f1444dab7b330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251869 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#780842}
-
Steven Bennetts authored
This moves the ONC Import UI from chrome://net-internals#chromeos (which is a deprecated page) to chrome://network (with the rest of Chrome OS networking debug UI). This also fixes an issue where the ONC importer was being destroyed early, breaking ONC import in general. Bug: chromium:921726 Change-Id: Ideb4e6b037e9be249cbd3e7360ac6c25b143046b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252849Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#780841}
-
Clark DuVall authored
This creates a new "client_certificate" directory in components/browser_ui to hold the Android client certificate picker. This will be shared with WebLayer. Tested this in Clank manually after the changes. Bug: 1025606 Change-Id: Ib3189454e5b4ad556e04eecd7b0ccd3c0e78466b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253031Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#780840}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592808845-5ecd6c23d23a299e7b02af052540dc3d30072113.profdata to chrome-win32-master-1592830246-d0465e2a89f6ad20ad72129fb481528f24bd31c6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I93d83a77cc8781e6b85610b4bd392ae0926aa530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257446Reviewed-by:
-
