- 06 Jun, 2014 21 commits
-
-
https://codereview.chromium.org/321473002/dcheng@chromium.org authored
Reason for revert: Broke the build. Original issue's description: > Implement enableFastMobileScrolling web api. > > The effort needs to be done in 3 steps: > 1. Create the runtime flag interface in blink; > 2. Enable the flag for Android from chromium even it does not do anything in blink; > 3. Replace compile time guard with runtime flag in blink and remove ENABLE_FAST_MOBILE_SCROLLING in gyp file. > > This is the 1st set of changes. > > BUG=381391 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175621 TBR=tkent@chromium.org,adamk@chromium.org,c.shu@samsung.com NOTREECHECKS=true NOTRY=true BUG=381391 Review URL: https://codereview.chromium.org/317313002 git-svn-id: svn://svn.chromium.org/blink/trunk@175622 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
c.shu@samsung.com authored
The effort needs to be done in 3 steps: 1. Create the runtime flag interface in blink; 2. Enable the flag for Android from chromium even it does not do anything in blink; 3. Replace compile time guard with runtime flag in blink and remove ENABLE_FAST_MOBILE_SCROLLING in gyp file. This is the 1st set of changes. BUG=381391 Review URL: https://codereview.chromium.org/321473002 git-svn-id: svn://svn.chromium.org/blink/trunk@175621 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
This method has been renamed already, so it's not a strict revert, but it restores the original behavior. BUG=none TEST=browser_tests --gtest_filter=WebViewTest*Auto* TBR=ojan@chromium.org Review URL: https://codereview.chromium.org/316373005 git-svn-id: svn://svn.chromium.org/blink/trunk@175620 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
This method is all sorts of badness. It leads to strange chicken-egg bugs because people don't think that you will need to update layer state after the layout has completed. FrameView::updateLayoutAndStyleIfNeededRecursive needs to do a second style recalc and layout just for this and in theory it should probably do a while loop there to get this right. Now that we've removed all the non-SVG filter callers of this function, rename it to something scary so that people won't add new callers. Review URL: https://codereview.chromium.org/319613004 git-svn-id: svn://svn.chromium.org/blink/trunk@175618 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
BUG=380167 R=japhet@chromium.org Review URL: https://codereview.chromium.org/316313002 git-svn-id: svn://svn.chromium.org/blink/trunk@175617 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
whitespace-length.html is timing out consistently on Webkit XP: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/svg/whitespace-length.html BUG=377503,339899 TBR=ed@opera.com Review URL: https://codereview.chromium.org/319883002 git-svn-id: svn://svn.chromium.org/blink/trunk@175616 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
This timed out on the waterfall and is failing on unrelated tryjobs runs as well. TBR=jsbell@chromium.org BUG=380910 Review URL: https://codereview.chromium.org/316383002 git-svn-id: svn://svn.chromium.org/blink/trunk@175615 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
TBR=eae@chromium.org Review URL: https://codereview.chromium.org/316373002 git-svn-id: svn://svn.chromium.org/blink/trunk@175614 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
https://src.chromium.org/viewvc/blink?view=rev&revision=175416 BUG=none TBR=peter@chromium.org Review URL: https://codereview.chromium.org/315423002 git-svn-id: svn://svn.chromium.org/blink/trunk@175613 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
http://src.chromium.org/viewvc/blink?view=revision&revision=175388 BUG=371640 TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/314283004 git-svn-id: svn://svn.chromium.org/blink/trunk@175612 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ch.dumez@samsung.com authored
Rename ElementData's attribute related methods for clarity: * length() -> attributeCount() * isEmpty() -> hasAttributes() * getAttributeItem(name) -> findAttributeByName(name) * attributeItem(index) -> attributeAt(index) * getAttributeItemIndex(name) -> findAttributeIndexByName(name) * addAttribute(name, value) -> appendAttribute(name, value) * removeAttribute(index) -> removeAttributeAt(index) This is inpired by the following WebKit revision by benjamin@webkit.org: http://trac.webkit.org/changeset/162394 R=esprehn@chromium.org, adamk@chromium.org Review URL: https://codereview.chromium.org/313973003 git-svn-id: svn://svn.chromium.org/blink/trunk@175611 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Oilpan: Prepare to move AbstractSQLStatement, SQLStatement, and SQLCallbackWrapper<T> to Oilpan heap. SQLCallbackWrapper has code to call ExecutionContext::deref() in the origin thread. This is unnecessary in Oilpan because implementation classes of ExecutionContext are already on-heap and they are always destructed in their origin threads. This is a prepration to make ExecutionContext GarbageCollected. BUG=357163 Review URL: https://codereview.chromium.org/311273005 git-svn-id: svn://svn.chromium.org/blink/trunk@175610 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
Keep a traced Member reference to the Element that's recorded as the Document's CSS target. When that Element is removed from the tree, the Member will be explicitly cleared. R= BUG=357163 Review URL: https://codereview.chromium.org/315333002 git-svn-id: svn://svn.chromium.org/blink/trunk@175609 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
estade@chromium.org authored
Since rAc was adopted into the standard, we revisited this and decided to do it a different way. This "revert" does keep the minor change about removing the extra param to WebAutofillClient::didRequestAutocomplete. BUG=354897 Review URL: https://codereview.chromium.org/293853002 git-svn-id: svn://svn.chromium.org/blink/trunk@175608 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
BUG=381364 TBR=peter@chromium.org Review URL: https://codereview.chromium.org/322443003 git-svn-id: svn://svn.chromium.org/blink/trunk@175607 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ckocagil@chromium.org authored
This allows the file to be compiled with C++11. BUG= Review URL: https://codereview.chromium.org/316113002 git-svn-id: svn://svn.chromium.org/blink/trunk@175606 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
BUG=381471 TBR=peter@chromium.org Review URL: https://codereview.chromium.org/317283002 git-svn-id: svn://svn.chromium.org/blink/trunk@175605 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
BUG=381464 TBR=peter@chromium.org Review URL: https://codereview.chromium.org/314113004 git-svn-id: svn://svn.chromium.org/blink/trunk@175604 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
skobes@chromium.org authored
This fixes cases where a node that previously had a >1 multiplier ceases to have direct text children. This can happen if its text content is removed in script, or if its 'display' style is changed from inline to block. (There are probably other ways for it to happen also.) Previously such a node would have a "stale" multiplier, since the autosizer only updated multipliers on text nodes and their immediate parents. In theory the stale multiplier should not have affected the rendering, but: - it is observable through the lineHeight property, and - due to http://crbug.com/380903 the stale multiplier on an ancestor might be used to render text, even when the text node has the correct multiplier BUG=378959 Review URL: https://codereview.chromium.org/319013003 git-svn-id: svn://svn.chromium.org/blink/trunk@175603 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
michaeln@chromium.org authored
TBR=dominicc NOTRY=true Review URL: https://codereview.chromium.org/319093002 git-svn-id: svn://svn.chromium.org/blink/trunk@175602 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
japhet@chromium.org authored
Not having this can cause problems in the test harnass, where some of the FrameLoaderClients do substantially more work than they do in a non-test environment. BUG=357283 Review URL: https://codereview.chromium.org/317513002 git-svn-id: svn://svn.chromium.org/blink/trunk@175601 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 05 Jun, 2014 19 commits
-
-
jsbell@chromium.org authored
The IDB spec defines that transactions are created 'active' and become 'inactive' when control returns to the event loop. The way this was implemented, transactions created within microtasks (e.g. Promise callbacks) were not deactivated. Flip the order of microtasks and deactivation, and add tests. BUG=380910 R=adamk@chromium.org Review URL: https://codereview.chromium.org/321433002 git-svn-id: svn://svn.chromium.org/blink/trunk@175600 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
wangxianzhu@chromium.org authored
Some async layout tests use waitUntilDone() and notifyDone() by themselves, without setting window.testIsAsync to true. This may be either unnecessary or incorrect, depending on which of the test's notifyDone() and text-based-repaint.js's notifyDone() executes first. If the latter executes first, the test may finish before it's done causing what the test want to test not fully executed. BUG=381242 Review URL: https://codereview.chromium.org/316193003 git-svn-id: svn://svn.chromium.org/blink/trunk@175599 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
BUG=381451 TBR=peter@chromium.org Review URL: https://codereview.chromium.org/321493002 git-svn-id: svn://svn.chromium.org/blink/trunk@175598 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
This was added in http://src.chromium.org/viewvc/blink?view=revision&revision=80584. It didn't have tests, so I'm not sure how to test this. But plugins always have a RenderLayer, so there should be no need to schedule a layer update anymore. Review URL: https://codereview.chromium.org/318773003 git-svn-id: svn://svn.chromium.org/blink/trunk@175597 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
gavinp@chromium.org authored
R=falken@chromium.org,jkarlin@chromium.org BUG=374822 Review URL: https://codereview.chromium.org/311233007 git-svn-id: svn://svn.chromium.org/blink/trunk@175596 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
zeeshanq@chromium.org authored
needed to be updated. Long press on text will no longer show a context menu. BUG=381152 Review URL: https://codereview.chromium.org/320453002 git-svn-id: svn://svn.chromium.org/blink/trunk@175595 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eae@chromium.org authored
TBR=dcheng@chromium.org Review URL: https://codereview.chromium.org/319813003 git-svn-id: svn://svn.chromium.org/blink/trunk@175594 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
BUG=381373 TBR=peter@chromium.org Review URL: https://codereview.chromium.org/319803002 git-svn-id: svn://svn.chromium.org/blink/trunk@175593 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
TBR=peter@chromium.org BUG=381364 git-svn-id: svn://svn.chromium.org/blink/trunk@175592 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eae@chromium.org authored
TBR=ojan@chromium.org BUG= Review URL: https://codereview.chromium.org/314243002 git-svn-id: svn://svn.chromium.org/blink/trunk@175591 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
acolwell@chromium.org authored
This fixes a bug where the load gets blocked by preload == 'none' eventhough JavaScript has called play() after setting the src attribute. This particular bug only appears if play() is called before the JavaScript code relinquishes control back to the UA. Tests cases were added to make sure that immediate load() and play() calls both trigger loading. Before this change, only immediate load() calls ignored the preload == "none" state. BUG=177870 TEST=LayoutTest/media/video-preload.html Review URL: https://codereview.chromium.org/313173008 git-svn-id: svn://svn.chromium.org/blink/trunk@175590 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
c.shu@samsung.com authored
BUG=380054 Review URL: https://codereview.chromium.org/317813003 git-svn-id: svn://svn.chromium.org/blink/trunk@175589 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eae@chromium.org authored
The virtual mac-antialiasedtext and windows-directwrite test suites both test antialiased text and both use the same subsets of text. Merge both into a new antialiasedtext test suite now that directwrite is always enabled (for tests) on windows. BUG=379590 R=dpranke@chromium.org Review URL: https://codereview.chromium.org/303133007 git-svn-id: svn://svn.chromium.org/blink/trunk@175588 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hush@chromium.org authored
For example, android can set the background color of a WebView to be transparent. This sets the mainframe base background color to be transparent. The internal bug is b/15373310 BUG=375864 Review URL: https://codereview.chromium.org/315763003 git-svn-id: svn://svn.chromium.org/blink/trunk@175586 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ajuma@chromium.org authored
The contents of 'will-change: contents' elements are expected to change frequently (e.g. every frame). Consequently, the creation of composited layers within a 'will-change: contents' subtree should be avoided where possible. This CL suppresses compositing for animations and for will-change in descendants of elements with 'will-change: contents'. BUG=365885 Review URL: https://codereview.chromium.org/298723011 git-svn-id: svn://svn.chromium.org/blink/trunk@175584 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ch.dumez@samsung.com authored
Add iterator object to iterate efficiently over an Element's attributes instead of using ElementData::length() / ElementData::attributeItem(index). This is a bit more efficient as it avoids implicitly calling ElementData::isUnique() for each loop iteration. This is based on the following WebKit revision by benjamin@webkit.org: http://trac.webkit.org/changeset/162394 R=esprehn@chromium.org, adamk@chromium.org Review URL: https://codereview.chromium.org/298253009 git-svn-id: svn://svn.chromium.org/blink/trunk@175583 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
peter@chromium.org authored
This test was already marked as flaky on release retina bots, but is flake on other Mac bots as well. TBR=dcheng@chromium.org BUG=380167 Review URL: https://codereview.chromium.org/317783011 git-svn-id: svn://svn.chromium.org/blink/trunk@175582 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
http://src.chromium.org/viewvc/blink?view=revision&revision=175562 BUG=374119 TBR=davve@opera.com Review URL: https://codereview.chromium.org/316193002 git-svn-id: svn://svn.chromium.org/blink/trunk@175581 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ricea@chromium.org authored
BUG=381035 Review URL: https://codereview.chromium.org/317843002 git-svn-id: svn://svn.chromium.org/blink/trunk@175580 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-