- 13 Jan, 2021 40 commits
-
-
Rushan Suleymanov authored
The interested data type list will be sent on each change. Before this CL, if sending of interested data types was just enabled, then the new field containing the list wouldn't have been sent to the server after the next browser startup. Bug: 1155030 Change-Id: I50ffb01b8592432128f3929abd554d874023d47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598908 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843087}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6cbcce5b..5f223d7f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6c2ca51b7361135ba190163d6db4c73e1aa2c42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627139Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843086}
-
Daniel Rubery authored
This CL refactors the CheckClientDownloadRequestBase into two separate classes. The CheckClientDownloadRequestBase is responsible for request logic, such as checking the allowlist and networking operations, while the DownloadRequestMaker is responsible for assembling the actual request proto. Bug: 1165815 Change-Id: Iaaa43ddf65a9c808f2d50bb86800c9667f5e5d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623708Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#843085}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bcd6b5c3ff8a..c593077f725b 2021-01-13 morlovich@chromium.org Device emulation: re-apply changes after edit 2021-01-13 jacktfranklin@chromium.org Migrate String#compareTo to utilities 2021-01-13 jacktfranklin@chromium.org Use custom CSS property rather than string interpolation 2021-01-13 tvanderlippe@chromium.org Inline and remove peekLast() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549,chromium:1158834,chromium:1166108 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6dc9151ac3d80547b117a75de4e83ca4698c8877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627616Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843084}
-
Brian Sheedy authored
Sets up gpu.fyi's "Android FYI Release (Pixel 4)" and its manual-only trybot mirror "gpu-fyi-try-android-r-pixel-4-32". Bug: 1165876 Change-Id: Iaa4c39eda29f1ad9813c945a0aacc00a546e52af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625827 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#843083}
-
Domenic Denicola authored
942aca88 performed the minimal updates to the implementation to shift from "origin isolation" to "origin-keyed agent clusters" for the web-observable API surface. This followup also renames much of our internal implementation references to the concept. Specifically, it takes care of all the Blink-side infrastructure supporting the window.originAgentCluster getter, as well as document.domain restrictions. This includes all the navigation-params plumbing to get the value from the browser process into the renderer process. This does not yet tackle any renaming for code that is entirely within the browser process. The only observable effect of this is changing the console warning message for document.domain to mention "origin-keyed" instead of "origin-isolated". Bug: 1158853 Change-Id: I8feb507eee17db53e58b70e4ee5820c555ba962f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617583Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843082}
-
Colin Blundell authored
In general, I don't have enough expertise in this code to be able to do meaningful OWNERS reviews for substantive changes to the implementation, and I redirect such changes to mark@. However, thanks to my refactoring of the IPC to Mojo I seem to still be the person with the second-most knowledge of this code on the team :P. This CL adds comments to the OWNERS file to make my expertise here explicit. Change-Id: I262d4da3c1abb2ebbc2c2c6b1d0f1425d4cd3674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617925Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843081}
-
Kevin Ellis authored
Underlying problem that lead to the earlier revert fixed in: https://chromium-review.googlesource.com/c/chromium/src/+/2614365 Bug: 389359 Change-Id: I0c688430e8a1df0f2af6711d58e883f2cd179fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625290Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#843080}
-
Gordon Seto authored
Fix unnecessary blink of ripple effect seen at back arrow in Wi-Fi details screen. This was caused because both settings_subpage and internet_detail_page were focusing their own UI elements, causing a flickering. This is solved by setting the settingId param in the url so then settings_subpage does not attempt to focus its back button. Fixes: 1150806 Change-Id: I9cc1a50188b76f32fb7b7ac2f2f489b197c963df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625330Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#843079}
-
Jeroen Dhollander authored
This CL is part of a migration of all interactions with the Libassistant 3rd party library to a mojom service. Currently Libassistant is invoked directly from the browser thread. This specific CL focuses on the audio input, aka the microphone. Libassistant needs to open the microphone both for hotword detection and for listening to actual user queries (for example 'ok google; set a timer for 5 minutes'). The idea behind the mojom interface is that we tell Libassistant - What audio devices to use. - When it is allowed to open the microphone (for example we don't want Libassistant listening if the lid of the device is closed). We also want to keep creating the |AudioStreamFactory| instances on the browser thread, so this mojom API contains a delegate to allow our service to request a |AudioStreamFactory| from the Browser thread. Bug: b/171748795 Test: N/A Change-Id: I3b75d9424e78fe5af8793395e25485168bc3c999 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600332 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Meilin Wang <meilinw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843078}
-
Tim Volodine authored
The following tests appear to be flaky on android-10-arm64-rel: WebXrVrPermissionTest#testPermissionPersistsAfterReload__CustomTabActivity WebXrVrPermissionTest#testPermissionPersistsAfterReload__WebappActivity BUG=1166223 TBR=bsheedy@chromium.org Change-Id: I6ea1649e7a1f90b274b6b82941a7e6c8982bf747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627399Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#843077}
-
Matt Mueller authored
Stable rollout is targeting M88 now, update ending milestone to match. Change-Id: Iec905a97847df21bbaa8d19b22051643d79919d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624152 Auto-Submit: Matt Mueller <mattm@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#843076}
-
Scott Violet authored
We don't support synchronously exiting fullscreen when fullscreen is entered. The code currently CHECKs in the native side. This patch throws an exception in hopes of better identifying why the java side is synchronously exiting. It doesn't seem the embedder has a synchronous path that exits, but perhaps it's because of a config change/retain issue? BUG=1142101 TEST=none Change-Id: Ia41dd9018c210a0b300223329a650cb0651030b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626191Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#843075}
-
Mitsuru Oshima authored
Replace two methods in AshTestBase as a first step. Bug: None Change-Id: I9826897319b19b967d5f07d6ac9ef22f280570e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609588 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#843074}
-
Wez authored
NetworkChangeNotifier was mis-reporting the failure status as ZX_ERR_INVALID_ARGS. Move the failure logging into the GetExistingInterfaces() call so that the status can be logged properly. Bug: 1165716 Bug: b/177088778 Change-Id: I2e0db22ee27b93d1c5b3d199c6286d9898c2adf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623012 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#843073}
-
Eugene But authored
According to Stability.iOS.UTE.MobileSessionAppWillTerminateWasReceived UMA it's not uncommon to have a UTE after appWillTerminate callback. Bug: None Change-Id: I20b9e581b8dadb11d2b3e8b7f1c770f5ae1df650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627049 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#843072}
-
Tarun Bansal authored
This is no longer needed. Bug: 1090417,1159182 Change-Id: I4c0fc0e8a2b63f4b4b2fd8403b362b0d94998400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613486 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843071}
-
Aaron Leventhal authored
When aria-labelledby is used, any element directly pointed to with a value should not contribute a value to the name. However, when the value is is part of an element that is deeper in a subtree, and the element is contributing via recursion, then the value can contribute to the name. Bug: 1159567 Change-Id: Idcf89b012896377d41c8689e61b4b7833f9322e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605481 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#843070}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610528340-b101588b91e5587ca53d6a4d812cdea4439c3876.profdata to chrome-win32-master-1610538373-fd44620c77870a58d7cfe6c95cdad1d7eb2cbcb8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia161a3d341a5d166bc657e53cf3860bbf07ebb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627560Reviewed-by:
-
Ramin Halavati authored
Adds "Profile.Guest.SigninTransferred.Lifetime" and "Profile.Guest.BlankState.Lifetime" for comparison of Guest profile lifetime when its initialized by a signed in token and when it starts from blank state. Bug: 1157764 Change-Id: Iea3a8cce12bddd8fed19b9a1c01c7c8c4c68dd2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623009Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#843068}
-
Hiroki Nakagawa authored
This CL makes window.open() fail in prerendered pages and return a null object like other restriction cases (e.g., window.open() in sandboxed iframes). This doesn't cancel prerendering. Bug: 1158252 Change-Id: I49fa64c8653fab898076eb91ace3c8386c7cf3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589060 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#843067}
-
Toni Barzic authored
Defers item validity checks for Android file until connection to ARC file system service is ready. Without this, there was a race condition between holding space service and ARC initialization, where item validity checks were performed before the backing file system was ready. Also, given that ARC is only initialized for primary profiles, makes holding space file system delegate ignore Android files in non-primary profile - they are kept in the persistent storage, but are kept out of the holding space model. BUG=1165890 Change-Id: I1d93289ce176c2c396b6925ca0f5b5ab8414816d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625453Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843066}
-
Vasiliy Telezhnikov authored
We suspect that in rare cases some clients trigger some kind of loop failures when Reshape fails, generates context loss, but after reinitialization it fails again. This CL adds CHECK for this case to crash and get more info from crash reports. Similar logic that was implemented in SkiaOutputDeviceGL earlier in https://crrev.com/c/2416749 Change-Id: Ifa1dca0ee19423f5ba532644ec45cd373e712b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626771 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843065}
-
Oriol Brufau authored
When navigating to #foo, the element with id="foo" is scrolled into view and is focused if focusable. This patch makes it receive the caret too, in case caret browsing is enabled. Bug: 1011934 TEST=editing/caret/caret-browsing-fragment-anchor.html Change-Id: I044e6b48545426afdb0c5ee766d4ee3a218aa95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463308 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843064}
-
Raymond Toy authored
Extend the expiry date by 6 mo. The response length is still useful for knowing how people use it and for guiding possible optimizations. Bug: 1165239 Change-Id: Iab745c5f8b3e736dc1a176eae47aa078e5061965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625048Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#843063}
-
James Cook authored
The wait_for_completion parameter is unused. Remove it. Bug: none Change-Id: Ifef5cb2a3fab2cd96d7ce0515384b15c262c399d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625982 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#843062}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/44ba8e1708ab..8fccd82e4e02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ieb4ed688f0e333606ea3331815ef05c8ef7cf886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627137Reviewed-by:
-
Wenyu Fu authored
Wait on the welcome page if policy exists on device. This applies to all the FRE scenarios, and paves the road for the following pages to load enterprise policies without additional logics to wait on loading. This change also makes |BrowserSignin| policy works as expected. First run fragments will be added to pager after policy services is initialized, so SignInManager#isSyncAllowed will be populated with value that matches the policy setting. If the |BrowserSignin| is set to disabled, the sign in fragment will not be added into FRE. Change-Id: I88942f50093bc77432981ebc78042d777bb0bcaf Bug: 1155715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601329 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#843060}
-
Maxim Kolosovskiy authored
Bug: 946711 Change-Id: I40e15f1a31a2c3e92ff2a145ca7aaa50ebfd9ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627157 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#843059}
-
Clark DuVall authored
This was introduced in http://crrev.com/c/2623118 but will only show up in non-bundle builds. Bug: 1105096 Change-Id: Iadcdae745df6a54fe1d969ada113fafb6c25bce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627140 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#843058}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101130600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/08lersZsKT6EkUmpNzG2SgRB6TA4BrTuJsDXDGzdVrIC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/170162419 Tbr: help-app@grotations.appspotmail.com Change-Id: Ib95d962dd211c036f4c617c7bae6a4d4b49ff01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627558Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843057}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/62b8364eafc7..215834139a79 2021-01-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e59ae1af7571 to 50bcbaad4cbf (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I7234f53464e5aba327a3c36060a565c927e6b426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627554 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Elaine Chien authored
Bug: 1145666 Change-Id: I745032bf28e1e0313c0ad6c5c47a5e41e85e4d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626193Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Elaine Chien <elainechien@chromium.org> Cr-Commit-Position: refs/heads/master@{#843055}
-
Jérémie Boulic authored
JS module generation for //ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js Bug: 1133186 Change-Id: I013f805433134151426473d6746904a7296fe358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626706 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#843054}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610528340-1fc68c0c17222e2254fe428312433be61c378c49.profdata to chrome-win64-master-1610538373-76fca52980f687d249587bbfe52df46587227f16.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If4c5076ab531e8a9efd195fe164169c8fe1baa0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627290Reviewed-by:
-
Colin Blundell authored
This is an unchanged reland of r#842942. That CL was reverted due to suspicions of it causing SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite to flake. However, it turns out that that test was already flaky, as can be seen on the flake portal. For example, this run shows it failing on a CQ run of r#842899: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tester%20(Ozone%20Wayland)/4088/overview Original CL description: This CL continues with the abstraction of dependencies on signin and sync from //components/safe_browsing's access token fetching flow in order to enable reuse by WebLayer. The concrete step taken here is to abstract the dependencies on //components/safe_browsing/core/browser/sync from RealTimeUrlLookupService, passing these dependencies in via the constructor. There are no behavioral changes in this CL: - //chrome and //ios/chrome's factories glue the relevant parameters from //components/safe_browsing/core/browser/sync - //weblayer's factory passes in values for the parameters such that access token fetching for URL lookups continues to be disabled in WebLayer Followup work will bring up support for access token fetching in WebLayer. Bug: 1080748 TBR: kolos@chromium.org Change-Id: I373f970373de7c5d14568a165365fe5a445aef08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627489Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843052}
-
Yao Xiao authored
In the patch where the DCHECK was added (https://chromium-review.googlesource.com/c/chromium/src/+/2595595), the kFlocIdComputeTimePrefKey is also updated. This has caused a one-time DCHECK failure for some client when Chrome was updated. The impact scope is small (i.e.should occur at most once per client and on M89 Canary only, as the PrefKey was initially introduced in M89), but should still be fixed. Bug: 1161160 Change-Id: I0fa226fd902ef732710fbfd0ec1d9a050166922d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625569Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#843051}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9846ef0a828..41a30fd36cbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com,fdoray@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com,fdoray@google.com Change-Id: I7c24efc7fea5708d93ed99e148d4a0417b996338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627561Reviewed-by:
-
Michael Ludwig authored
This was pulled from https://chromium-review.googlesource.com/c/chromium/src/+/2527768 to keep that CL clearer. Bug: skia:9310 Change-Id: Ie49c491638f3f859c11257e1b3dc0658a95caabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610286 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b577a78d937c..d46475f87758 2021-01-13 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-13 tcwang@google.com Revert "toolchain_util: Add function to modify kernel afdo metadata" 2021-01-13 vadimsh@chromium.org gen_luci_scheduler: Add "realm" field. 2021-01-12 sfrolov@google.com licensing: improve error messages 2021-01-12 victording@google.com flash-ap: Convert SSH port to string 2021-01-12 lamontjones@chromium.org git: add GetCurrentBranchOrId 2021-01-12 richardfung@google.com Add hatch-arc-s If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I89d0c043af2f05798605a81fca131ae2519af4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627062Reviewed-by:
-
