- 01 Nov, 2017 40 commits
-
-
Steve Kobes authored
Bug: 755401 Change-Id: Ica41e281b77f3b3625e65f883aedd394470c2a6d Reviewed-on: https://chromium-review.googlesource.com/740292Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#513194}
-
Weidong Guo authored
Changes: The gray ring is shown only when search box is selected and it is not active. BUG=779693 Change-Id: I10fdd7238361ea8320c4a74697a7d7015863d36e Reviewed-on: https://chromium-review.googlesource.com/748310Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#513193}
-
Weidong Guo authored
BUG=780355 TEST=AppListViewFocusTest.SetFocusOnSearchboxWhenActivated Change-Id: I257897049a58ffb93e55e6890ab6e3a7b533e4a1 Reviewed-on: https://chromium-review.googlesource.com/748561Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#513192}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/0b78a6912eba..206bda5b7931 $ git log 0b78a6912..206bda5b7 --date=short --no-merges --format='%ad %ae %s' 2017-11-01 robertphillips Update the texture flip GM to include subsets & scales 2017-11-01 brianosman Plumb internal helper to enable more GPU GMs w/SkColorSpaceXformCanvas 2017-11-01 brianosman Fix bookmaker compile warning 2017-11-01 caryclark streamline doc menus 2017-10-31 egdaniel Update GrTextureMaker to handle mips when copying for npot 2017-11-01 angle-deps-roller Roll skia/third_party/externals/angle2/ e88ec8eed..206a58d1f (1 commit) 2017-10-31 jvanverth More attempts at clipping perf. 2017-11-01 mtklein fix typo in SkJpegCodec.cpp Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: If7bc90abbdb08177c172317ef2d9366ec40e3533 Reviewed-on: https://chromium-review.googlesource.com/749447Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513191}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3cc27b2b9fe91e561095bc8d87651ae44070b208 Reviewed-on: https://chromium-review.googlesource.com/749452 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513190}
-
Weidong Guo authored
Changes: Hitting Enter when search box is not active and search box is focused activates the search box. BUG=780339 TEST=AppListViewFocusTest.HittingEnterWhenFocusOnSearchBox Change-Id: I16d3b32d0d163badc11fc921926b2b174480c11e Reviewed-on: https://chromium-review.googlesource.com/748164Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#513189}
-
Philip Rogers authored
Based on a trybot run as well as Szager's test tool, 18 tests are failing and 8 tests are passing. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: I04880039367d9896a87467f8196d5510d6aec7db Reviewed-on: https://chromium-review.googlesource.com/748703Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#513188}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I632ceceb83fb1c8403e0dd58be5d1ebdcd5a6dd0 Reviewed-on: https://chromium-review.googlesource.com/748911 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513187}
-
Peter Kotwicz authored
This CL fixes NullPointerException when showing notifications in WebAPK. BUG=779960 Change-Id: Icc4721995b57503e74071d7a1ae92f875d5de649 Reviewed-on: https://chromium-review.googlesource.com/748802Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#513186}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I58cb3b0d31f8ffc3e28ce643b24db99b4ac4f77d Reviewed-on: https://chromium-review.googlesource.com/748915 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513185}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6c1f5f714a545acc62a0e056defcfeea24d90ef1 Reviewed-on: https://chromium-review.googlesource.com/749249 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513184}
-
Dominik Röttsches authored
And execute it for the set of previous UseCounter.cpp changes. Bug: 780487 Change-Id: I3fbf840d5693f18d55306efc440d3f9a2120fbd2 Reviewed-on: https://chromium-review.googlesource.com/749382Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#513183}
-
Scott Graham authored
TBR: wez@chromium.org Bug: 780508 Change-Id: Ib5325a3b0e7bb9fbbc9b1b8c9b18837b63dd0d95 Reviewed-on: https://chromium-review.googlesource.com/749247 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#513182}
-
Caleb Rouleau authored
Remove legacy broken media_cns_cases. Also remove media measurements since media_cns_cases was the only user of it. Bug: 676345 Change-Id: If3659e3ba0d57f6ef1a73d55ef4022a3f5bf797f Reviewed-on: https://chromium-review.googlesource.com/747820Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#513181}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I283a52d5f0acef7f81363f340333c0a31b805445 Reviewed-on: https://chromium-review.googlesource.com/749248 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513180}
-
Eugene Ostroukhov authored
Moves refresh and clear button from the bottom toolbar to the top for consistency with other Application panel tabs. Bug: Change-Id: I942814bc93b2537223c3bb95f940b62d679762c4 Reviewed-on: https://chromium-review.googlesource.com/731580 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#513179}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5481e16c7cc340fdf92d649884f4df189f247f39 Reviewed-on: https://chromium-review.googlesource.com/748970 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513178}
-
Xing Liu authored
CancelDownload can be called before content layer persist the record in history db, the canceled download will be recognized as external and thus block all background download. This CL filtered the canceled download with an existing cache in download driver. TBR=phajdan.jr@chromium.org Bug: 776716 Change-Id: Ib6476180a4b7db728fa6750264f0893384eb6633 Reviewed-on: https://chromium-review.googlesource.com/738589 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#513177}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib25ac8f53f4e968aa483657809402c2b7fdce8c2 Reviewed-on: https://chromium-review.googlesource.com/749445 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513176}
-
Donn Denman authored
The ContextualSearchManagerTest testSecondTapWithSmartSelection was just checking if the panel was closed rather than waiting for it to close after hiding the panel due to Smart Selection on the second tap. BUG=778693 Change-Id: Ib403321ec3ac5b4d7a0995bcbd2216bd86c3c9b6 Reviewed-on: https://chromium-review.googlesource.com/742124Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#513175}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/7172ea13c029..c4a14324e29c $ git log 7172ea13c..c4a14324e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I88fd4716ef5f70d011fd7020b2805a3b63ff6bf1 Reviewed-on: https://chromium-review.googlesource.com/749441Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#513174}
-
Scott Chen authored
Bug: 722788 Change-Id: I3235f1245587720bea79ee91cd28aac5cfa60928 Reviewed-on: https://chromium-review.googlesource.com/739386Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513173}
-
Zijie He authored
This looks like a very common issue when using os.rename() on Windows. https://www.google.com/search?q=python+os.rename+cannot+create+a+file+when+that+file+already+exists&oq=python+os.rename+cannot+create+a+file+when&aqs=chrome.0.0j69i57.12521j0j7&sourceid=chrome&ie=UTF-8 Bug: chromium:778370 Change-Id: I7132a2614fe9361c6860ae9598e994d7dbd00c5b Reviewed-on: https://chromium-review.googlesource.com/748306Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#513172}
-
Kenneth Russell authored
Windows: conformance/limits/gl-max-texture-dimensions.html deqp/data/gles3/shaders/functions.html Linux: deqp/functional/gles3/fbocompleteness.html BUG=680754, 703779, 712469, 715001 TBR=jmadill@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2357bf311f49680a3a640c4645dfef8d1ab069dc Reviewed-on: https://chromium-review.googlesource.com/748918 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#513171}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/206a58d1fbc7..63458a3ed819 $ git log 206a58d1f..63458a3ed --date=short --no-merges --format='%ad %ae %s' 2017-10-30 geofflang CopyTextureCHROMIUM: Validate the texture target enums first. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I35bfff7cdb3a47470bc0893f06bbef5384819eab Reviewed-on: https://chromium-review.googlesource.com/749446Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513170}
-
John Z Wu authored
It used to return a pointer to the base class SigninClient. Since this is a factory specific for //ios/web_view, it makes sense to return the //ios/web_view specific subclass. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I27d726d7dab7e5ef2193928a2ffd0796cee0351c Reviewed-on: https://chromium-review.googlesource.com/744738Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#513169}
-
Quinten Yearsley authored
This expands the method test_multiple_builders_and_platform_specifiers so that there is a line for a configuration macro ("Mac") and different results for different specific versions. This verifies that lines shouldn't be removed as long as there is some version for which the test is still flaky/failing even if it's passing on other versions. Change-Id: Ic57751644f4dd520b45768c0a32ad03e66a92bbf Reviewed-on: https://chromium-review.googlesource.com/747368Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#513168}
-
Eric Seckler authored
In full-pipe mode, we don't want to skip BeginFrames. Bug: 646774 Change-Id: Ibc1ed9a7e9866d150f4f16755a824b22d4586e29 Reviewed-on: https://chromium-review.googlesource.com/749383Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#513167}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ea01f412..92b9b498 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I51c8d884b83b190acaa1e1bf4e2586d148d00b54 Reviewed-on: https://chromium-review.googlesource.com/748808Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#513166}
-
Dirk Pranke authored
The "WebKit Mac 10.11 (dbg)" and "WebKit Mac Retina" builders are still running the layout tests locally. This CL should switch them to run under swarming (and switch the corresponding trybots). R=qyearsley@chromium.org BUG=524758 Change-Id: I06297fc45dce187b02cef83d3df80d2638d51fbb Reviewed-on: https://chromium-review.googlesource.com/747843 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#513165}
-
Dominic Mazzoni authored
This reverts commit 625b0fa0. Reason for revert: The underlying bug, 778905, is now fixed, so it won't crash anymore. Original change's description: > perf: Disable wikipedia stories which are crashing on Windows > > TBR=perezju@chromium.org > > Bug: 777931 > Change-Id: I487a6c7335e310adbf395c51597980f756fef656 > Reviewed-on: https://chromium-review.googlesource.com/735546 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#511268} TBR=skyostil@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 777931 Change-Id: I0f49ec2b22312b29532a48e7613748ab25500201 Reviewed-on: https://chromium-review.googlesource.com/749246Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#513164}
-
Raymond Toy authored
Move the implemetation completely to the AudioParamTimeline class so we can lock the event list completely to prevent the audio thread from mutating the event list. The original implementation had two function calls: one to find an event index and another to print the warning. However, the audio thread could have mutated the event list between these calls, so the event index could be invalid. Bug: 778927 Test: Repro case doesn't fail DCHECK in debug build Change-Id: Ied1d8d5128a316aba3c8d59589e1f305a5a2a26b Reviewed-on: https://chromium-review.googlesource.com/741450 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#513163}
-
Mounir Lamouri authored
This is adding a user action metric that records when site data are cleared and a histogram that record the reduction in MEI score when history is cleared. Bug: 778701 Change-Id: Iec07a068a9230b15b8fa52aeed00ab9ef573dfe2 Reviewed-on: https://chromium-review.googlesource.com/739389 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#513162}
-
Gyuyoung Kim authored
scoped_refptr can be used in blink now. This CL is to replace all of remaining uses of WTF::RefPtr with scoped_refptr in public/ and Tools/. Bug: 763844 Change-Id: I288722eb51f5f8186862c36c692c4169b07bca1e Reviewed-on: https://chromium-review.googlesource.com/746441 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#513161}
-
kylechar authored
Switching to VT2 on Chrome OS with --mus or --mash was broken on some boards due to copy and paste errors calling the wrong function. Bug: 777571, 772023 Change-Id: I4f77ae795bd5cd19b767e6bb9e40c4a28d08c2c3 Reviewed-on: https://chromium-review.googlesource.com/748812Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#513160}
-
Tom Anderson authored
On Peter's notification generator [1], creating a notification with "Action" set to alert() and everyting else set to default settings, notification->clickable() is false when I expected the notification to be clickable. This CL always makes notifications clickable regardless of the clickable() state. [1] https://tests.peter.sh/notification-generator/ BUG=676220 R=peter@chromium.org CC=thestig@chromium.org Change-Id: I326b6fa5b64e8a18aa95ea47dfbcbe5caaaa9bdc Reviewed-on: https://chromium-review.googlesource.com/748213Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#513159}
-
Simon authored
This enables histogram output on: dummy_benchmark.stable_benchmark_1 dummy_benchmark.noisy_benchmark_1 https: //github.com/catapult-project/catapult/issues/4008 Bug: catapult:#4008 Change-Id: I27fb8f12089d9e654d0ad6a7c447803a008db018 Reviewed-on: https://chromium-review.googlesource.com/746379Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ben Hayden <benjhayden@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#513158}
-
Evan Stade authored
ShouldShowSettingsButton() and the return value for SettingsClick() are replaced by an enum in Notification (by way of RichNotificationData). Bug: 776187 Change-Id: I7f3a04b855f3c6a9871f8eb71639add2722f1088 Reviewed-on: https://chromium-review.googlesource.com/729331 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#513157}
-
Hidehiko Abe authored
Rewrite GetProperties test with fake. BUG=234463 TEST=Ran bots. Change-Id: I624f6a88bb8f9f5ef4bf31b778f70894e91c3ee2 Reviewed-on: https://chromium-review.googlesource.com/747641 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#513156}
-
Koji Ishii authored
This patch fixes line breaking of a block that meets all following conditions: 1. Has the 'text-indent' property set. 2. Is in an anonymous block. 3. Is not the first child of its parent element. The spec[1] defines not to apply 'text-indent' in this case. LayoutBlockFlow honors this definition, but LineBreaker did not. In this patch, LayoutBlockFlow, LineBreaker, and NGLineBreaker shares the logic. [1] https://drafts.csswg.org/css-text-3/#text-indent-property Bug: 779921 Change-Id: Iae81a7a96c1be1b787eb53b4b4a2001b8a68c526 Reviewed-on: https://chromium-review.googlesource.com/748821Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#513155}
-