GitLab

Design doc: go/caebn

This is dependent on a number of CLs:
- https://codereview.chromium.org/2147783002/
- https://codereview.chromium.org/2140343002/
- https://codereview.chromium.org/2143073003/
- https://codereview.chromium.org/2116033002/

BUG=625251

Review-Url: https://codereview.chromium.org/2148573002
Cr-Commit-Position: refs/heads/master@{#407654}

TBR=dominickn@chromium.org

BUG=631190

Review-Url: https://codereview.chromium.org/2184503002
Cr-Commit-Position: refs/heads/master@{#407653}

https://chromium.googlesource.com/skia.git/+log/56586b6f3dc8..0f7748ab388c

$ git log 56586b6f3..0f7748ab3 --date=short --no-merges --format='%ad %ae %s'
2016-07-25 mtklein DM: print which task caused the crash.
2016-07-25 bungeman Add test for typeface style round trip.
2016-07-25 mtklein Have SkRasterPipelineBlitter take over for F16 when it can.
2016-07-25 reed lock special-raster while the caller's bitmap is in-scope

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2184483002
Cr-Commit-Position: refs/heads/master@{#407652}

Revert of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (patchset #4 id:60001 of https://codereview.chromium.org/2170133004/ )

Reason for revert:
Speculative revert for bug 631246.  Have no better ideas.

Apologies if this wasn't the cause.

Original issue's description:
> HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes.
>
> We were using HexStringToInt to parse chunk size, which returns a
> 32-bit int.  This CL switches to using HexStringToInt64, which uses
> 64-bit ints, so we can now support chunks up to 2^63-1 bytes.
>
> That should be enough for anybody. [Cue dramatic music]
>
> BUG=630680
>
> Committed: https://crrev.com/8ea249f8b70f154f9995ed538fc853fe9cf46503
> Cr-Commit-Position: refs/heads/master@{#407549}

TBR=eroman@chromium.org,mmenke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630680

Review-Url: https://codereview.chromium.org/2183433003
Cr-Commit-Position: refs/heads/master@{#407651}

This adds option to use location service into OptIn flow and fix
similar backup and restore consent.

BUG=631264
TEST=Manually on device together with Android side CL. On fresh device
     go through OptIn flow and set use location service off. Start
     Play Store and install Google Maps app. On start, Google Maps
     asks permission to activate usage of Location service. Disable
     and re-enable Arc and go throug OptIn flow but set this feature
     on and repeat Google Maps installation. On start, Google maps
     app does not ask permission to modify usage Location service.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2179803002
Cr-Commit-Position: refs/heads/master@{#407650}

This change updates the SecurityKeyAuthHandlerLinux class to run its
socket operations on a task_runner which allows blocking IO.

The first part of the change is plumbing through the file_task_runner
from the Me2Me host (which owns the context with the task runners)
down to the auth handler class which requires it.

The second part of the change was to move the file delete operation
to the file thread and then post back to the main thread.

I've also updated the unit tests for the affected class since it now
needs to handle synchronization between two threads.

BUG=591739
R=sergeyu@chromium.org
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2168303003
Cr-Commit-Position: refs/heads/master@{#407649}

NOTRY=1
TBR=yhirano@chromium.org

BUG=630996

Review-Url: https://codereview.chromium.org/2174423003
Cr-Commit-Position: refs/heads/master@{#407648}

If the overlay processor emits a CALayerOverlay with a valid render_pass_id
member, then the GLRenderer needs to copy the contents of the render pass to an
overlay resource. The GLRenderer uses a ResourcePool to allocate and reuse
overlay resources.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2162193002
Cr-Commit-Position: refs/heads/master@{#407647}

Since widget bounds were updated using coordinates relative to the root
window, windows on secondary displays would snap back to the primary
display after resizing.

BUG=631136
TEST=Drag weston-terminal to secondary display and resize.
TEST=ARC apps can still be dragged and maximized.

Review-Url: https://codereview.chromium.org/2176293002
Cr-Commit-Position: refs/heads/master@{#407646}

BUG=

Review-Url: https://codereview.chromium.org/2183573002
Cr-Commit-Position: refs/heads/master@{#407645}

BrowserAssociatedInterface can be implemented in conjunction with
BrowserMessageFilter in order to provide browser-side Mojo bindings
which dispatch on the IO thread and maintain FIFO with respect
to legacy IPC messages on the same channel.

BUG=612500,619202
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2164783005
Cr-Commit-Position: refs/heads/master@{#407644}

Just dead code cleanup.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2176203004
Cr-Commit-Position: refs/heads/master@{#407643}

This is a change in preparation for modyfing the timings of the component updater.

R=waffles
BUG=630732

Review-Url: https://codereview.chromium.org/2169323003
Cr-Commit-Position: refs/heads/master@{#407642}

Use the default SecureRandom constructor instead. Per
http://android-developers.blogspot.com/2016/06/security-crypto-provider-deprecated-in.html,
SHA1PRNG is going away.

BUG=none

Review-Url: https://codereview.chromium.org/2176883002
Cr-Commit-Position: refs/heads/master@{#407641}

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume incognito download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable(bad naming) field in DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need an isResumable(correct naming)
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613

Review-Url: https://codereview.chromium.org/2160063002
Cr-Commit-Position: refs/heads/master@{#407640}

The mobile emulator was triggering a layout before it had reapplied the
original viewport parameters when it was being disabled, which with
use-zoom-for-dsf enabled was causing the wrong viewport size to be given
to various components, like plugins and scrollbars.

BUG=628501,628185
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/2168313002 .

Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f
Cr-Original-Commit-Position: refs/heads/master@{#407294}
Cr-Commit-Position: refs/heads/master@{#407639}

These metrics will allow us to compare acceptance rates for permission
prompts based on whether the prompt had a user gesture or not.

BUG=614599

Review-Url: https://codereview.chromium.org/2124703002
Cr-Commit-Position: refs/heads/master@{#407638}

The cursor renderer on Mac, takes the chrome window based coordinate
as web contents based coordinate.

This CL fixes that bug.

BUG=625237

Review-Url: https://codereview.chromium.org/2166953002
Cr-Commit-Position: refs/heads/master@{#407637}

This change adds the rest of the strings of the feedback form we'll be using. These strings are copied from the current feedback form; we opt to create new strings in case they're modified in the future, as to not disrupt the current feedback flow.

The remaining missing strings (i.e. for file upload) correspond to components that are not planned for the redesign.

No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog.

BUG=615535
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2163753003
Cr-Commit-Position: refs/heads/master@{#407636}

Added a unittest that verifies that it's safe to tear down connection
synchronously in response to a message. Also fixed issues that were
causing crashes in that scenario. Particularly added
PeerConnectionWrapper that wraps PeerConnection for WebrtcTransport
and allows closing it asynchronously.

Review-Url: https://codereview.chromium.org/2172153005
Cr-Commit-Position: refs/heads/master@{#407635}

Now that webkit_patch and multi_command_tool are merged,
(http://crbug.com/621181) it may be confusing that the mock version
of WebKitPatch is called MockTool.

This renaming also resolves a FIXME comment.

BUG=621181

Review-Url: https://codereview.chromium.org/2127343003
Cr-Commit-Position: refs/heads/master@{#407634}

Add a null check for m_runs[i]->m_fontData in ShapeResult::fallbackFonts
to ensure that isTextOrientationFallbackOf is only called when it's set.

TBR=pdr@chromium.org
BUG=629005

Review-Url: https://codereview.chromium.org/2177163003
Cr-Commit-Position: refs/heads/master@{#407633}

Mac routes vsync parameters differently than other platforms.  Other
platforms go directly through BrowserCompositorOutputSurface, which then
routes it to the vsync manager (without begin frame scheduling) or just
to the root BeginFrameSource for that BrowserCompositorOutputsurface
(with begin frame scheduling).

Mac is different in that the RenderWidgetHostViewMac gets the vsync info
from the DisplayLink, which forwards it to the BrowserCompositorMac.
This would then forward that to the ui::Compositor's vsync manager which
would then be used to tick the browser and then indirectly would forward
to the begin frame source for the BrowserCompositorOutputSurface to tick
the display.

--enable-begin-frame-scheduling turns off the vsync manager, which
previously left the browser and then display compositors to tick at
default intervals and timebases on Mac, leading to power regressions.
OOPS.

This patch adds an additional route where the BrowserCompositorMac
forwards vsync info to the BrowserCompositorOutputSurface's
BeginFrameSource via ui::Compositor's ui::ContextFactory (aka
GpuProcessTransportFactory).  As the BrowserCompositorOutputSurface's
begin frame source is the source of all frames when using
--enable-begin-frame-scheduling, this fixes the regression.

Once --enable-begin-frame-scheduling becomes the default, all of the
vsync info and vsync manager plumbing can be removed.

With this patch, power usage on one test laptop for h264 video when
using --enable-begin-frame-scheduling goes from 2.00W -> 2.05W instead
of from 2.0W -> 2.3W.

R=ccameron@chromium.org

Review-Url: https://codereview.chromium.org/2170053002
Cr-Commit-Position: refs/heads/master@{#407632}

This CL makes WebAPK handle NOTIFICATION_PREFERENCES intents. The intent is
forwarded to the host browser. A NOTIFICATION_PREFERENCES intent is sent
when the user long presses on a notification on L+ and taps on the "gear icon".

BUG=610156

Review-Url: https://codereview.chromium.org/2169743002
Cr-Commit-Position: refs/heads/master@{#407631}

This is needed for clients that need to address some special
behaviors of ChromeOS.

This is intended to be a cherry-pick for older releases, where
GYP is used

BUG=chromium:628040

Review-Url: https://codereview.chromium.org/2180803003
Cr-Commit-Position: refs/heads/master@{#407630}

PathBuilderKeyRolloverTest.TestMultipleRootMatchesOnlyOneWorks shouldn't depend on trust store ordering.

BUG=631139

Review-Url: https://codereview.chromium.org/2183513002
Cr-Commit-Position: refs/heads/master@{#407629}

https://chromium.googlesource.com/skia.git/+log/8fe485b793f6..56586b6f3dc8

$ git log 8fe485b79..56586b6f3 --date=short --no-merges --format='%ad %ae %s'
2016-07-25 halcanary SkPDF: re-work SkPDFUtils::FloatToDecimal
2016-07-25 mtklein Google3 <functional> has a global "using std::plus"...

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2182653003
Cr-Commit-Position: refs/heads/master@{#407628}

https://chromium.googlesource.com/chromium/src/+/faa507ce5

BUG=627844
TBR=mpearson@chromium.org

Review URL: https://codereview.chromium.org/2183613002 .

Cr-Commit-Position: refs/heads/master@{#407627}

BUG=614551

Review-Url: https://codereview.chromium.org/2148243004
Cr-Commit-Position: refs/heads/master@{#407626}

BUG=631015
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2177203003
Cr-Commit-Position: refs/heads/master@{#407625}

isInternalFlag is used by DevTools internally and we don't need to expose it to public blink API.

BUG=none
R=haraken@chromium.org,dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2179943002
Cr-Commit-Position: refs/heads/master@{#407624}

BUG=627647

Review-Url: https://codereview.chromium.org/2145613003
Cr-Commit-Position: refs/heads/master@{#407623}

Remove the extra effort being made to avoid replication of ICC profile
data across object instances. With the two separate structures, we will
always know when we have the "heavy" version.

Add plumbing to pass ColorSpace as part of cc::TransferableResource.

Note that the functionality to convert between ICCProfile and
ColorSpace is not present in this patch.

BUG=622133
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2161293002
Cr-Commit-Position: refs/heads/master@{#407622}

Short circuiting in 342dc8a7 skipped writing the stamp file if no work was
to be done.

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/2181113002 .

Cr-Commit-Position: refs/heads/master@{#407621}

BUG=522043

Review-Url: https://codereview.chromium.org/2051913002
Cr-Commit-Position: refs/heads/master@{#407620}

The build ID reading code is based on:
src/native_client/src/untrusted/minidump_generator/build_id.cc

BUG=chromium:627873
TEST=build successfully

Review-Url: https://codereview.chromium.org/2159013002
Cr-Commit-Position: refs/heads/master@{#407619}

Symantec originally indicated NTT DoCoMo was indepedently operated,
but subsequent investigation revealed it was part of Symantec's MPKI.
Apple's G3 is only audited to WebTrust for CAs, not SSL BRs, so removing
it from the exclusion set.

This adds Apple's CA 8 to the set, after communicating with Apple's PKI
team to receive confirmation that it was created pursuant to the
audited CP/CPS and is part of the same infrastructure.

BUG=620178

Review-Url: https://codereview.chromium.org/2177943004
Cr-Commit-Position: refs/heads/master@{#407618}

BUG=508725,627008

Review-Url: https://codereview.chromium.org/2175383002
Cr-Commit-Position: refs/heads/master@{#407617}

According to https://github.com/ResponsiveImagesCG/picture-element/issues/223#issuecomment-69772765
we seem to be the only browser that loads data URIs immediately (as if they were cached).
It was introduced as part of the move to async image loading: https://codereview.chromium.org/200923002

This is now causing issues: https://code.google.com/p/chromium/issues/detail?id=469131

This CL changes this behavior to be spec compliant and load data URIs asynchronously, like other resources.

This is relanding https://codereview.chromium.org/1492303003

BUG=514206

Review-Url: https://codereview.chromium.org/2173003002
Cr-Commit-Position: refs/heads/master@{#407616}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/61e64edd..f5146b9b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2181763002
Cr-Commit-Position: refs/heads/master@{#407615}