GitLab

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=stevenjb@chromium.org

Bug: 1041419
Change-Id: I2999fd57be53f68bd82b8d431f659d49a4efc436
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998507
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731614}

The PDF Compositor is being updated to perform composition for both PDF
and XPS documents.  Rename the service to more accurately reflect this
expanded scope of the service.

This CL is just to do the rename without any new XPS functionality yet;
that will come in later CLs.

Bug: 1008222
Change-Id: I2233e1590f5862da8f4bc50025f699e4dc1fbad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981135Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731613}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=msarda@chromium.org

Bug: 1041419
Change-Id: I265ecdbd0e4b3524cea50f49592f62540196c490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998355
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731612}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bffadc06..85f423a4

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Icf5f7320e3fcca2a6f11cbb8912f1f7c9bf12412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000522Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731611}

The new X11 codepath also needs to convert gfx::BufferUsage to
GBM flags, so move BuferUsageToGbmFlags to a common location
to avoid duplicating it in 3 places.

BUG=1031269

Change-Id: I23a6438fe6b01479a941dbb0393984494282f61f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981051
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731610}

All calls of |-dismissInfobarModal:animated:completion:| from an infobar
modal UIViewController passed YES for |animated| and nil for
|completion|, so these parameters were removed.  Additionally, none of
the implementations of any selectors in the delegate protocol used the
|sender| argument, so that was removed as well.

Several InfobarCoordinator subclasses utilized the dismissal using a
completion block, however, so a base implementation was added to a
subclassing category for InfobarCoordinator.

Bug: 1030357
Change-Id: I7e4b06294a5dce28131f6c2a95430fbae62a97fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996167
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731609}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=isherman@chromium.org

Bug: 1041419
Change-Id: If21b7c662aec1842884b84302e09c2c0ff79b9a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995788
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731608}

R=ssid@chromium.org

Change-Id: I2a981762ce1d46300488dfdbcfcb1ba87420b557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999324Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731607}

R=dpapad@chromium.org

Bug: none
Change-Id: I6db701fbabe50ad5acb094c91c5bbba923fa6afc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999282
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731606}

mmap fails on some platforms when trying to map
a dmabuf with a non-zero offset.

Instead of passing in the offset to map to, get the
base address and add the offset afterwards.

BUG: none
TEST=./ozone_gl_unittests --gtest_filter=GLImageNativePixmap/GLImageBindTest/5.BindTexImage --gtest_also_run_disabled_tests

Change-Id: Ie20e460e4099f937452a96a6e64b39ec56f1cc3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979096
Auto-Submit: Fritz Koenig <frkoenig@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731605}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=rmcelrath@chromium.org

Bug: 1041419
Change-Id: I3ed2eccb81e26ef4a1b51fe0eb9e0ec584c8012b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998881
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731604}

On ChromeOS, the panel's physical rotation can be different from
logical one. That is, the panel's original orientation can be
portrait, but the default orientation is landscape, which leads
to wrong cursor rotation. This CL fixes the issue by using panel's
orientation to rotate cursor.

For other platforms, they're the same and this doesn't change the
behavior.

Bug: 1027832
Test: covered by unit tests. Also teseted manually. See bug for repro case.
Change-Id: If70076a3a8a1b9b0893a31827bc767f2dd512489
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995060Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731603}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=wutao@chromium.org

Bug: 1041419
Change-Id: I0ae4ba3bd6daae16e7b81963afa8d5d1726a0d26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998738
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731602}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=kkhorimoto@chromium.org

Bug: 1041419
Change-Id: I319d7a1fbb3caa71709cce240011a758a598a38f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998798
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731601}

SafeBrowsingDataManager::CanCheckResourceType takes an argument of
type content::ResourceType but only the Android-specific override in
RemoteSafeBrowsingDatabaseManager uses the value of this argument.

This CL forward-declares content::Resource type in database_manager.h.
With this change, components/safe_browsing/core/db no longer depends on
content/public/common.

This is a step towards removing content/ dependencies from
components/safe_browsing/core.

Change-Id: I8b227a2c04594db8965a3ef1db4008a381a0965d
Bug: 1028755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995333
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731600}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=mlamouri@chromium.org

Bug: 1041419
Change-Id: I37d869acfd366097bf4c1b2c2fc84d49f82c3bfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998349
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731599}

Gather display and graphics related metrics in DeviceStatusCollector so
that they can be exposed by the CDM API.

BUG=chromium:1017893
TEST=Cherry pick https://crrev.com/c/1779132 and ensure that the values
reported match that found on chrome://gpu or task manager (for GPU
process memory).

Change-Id: Idbc88fddf16b52f342cf92d0a0fe6060b4ee0e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933563
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731598}

Rapid blocking of javascript popups can cause a crash as simultaneous
snapshots are triggered. Do not take snapshots when consecutive infobars
are popup blocking infobars.

Bug: 1018285
Change-Id: I46bca7fd8cc1f4d3f43ff28800b37c41a247f7e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999084
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731597}

Add a basic Web UI at chrome://media-history
for viewing Media History data. At the moment
it just shows the row count per table but in
the future we will add more.

BUG=1024353

Change-Id: Ifb4190ba4266806ae6c07b07c77144c71907e87d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988733Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731596}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=manukh@chromium.org

Bug: 1041419
Change-Id: I77d816e1495a2d404919fb2d0c83162df088af0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998306
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731595}

https://chromium.googlesource.com/angle/angle.git/+log/683dd1d6a863..feb3b6cc6f2b

git log 683dd1d6a863..feb3b6cc6f2b --date=short --first-parent --format='%ad %ae %s'
2020-01-14 syoussefi@chromium.org Vulkan: Remove row->col major shader transformation
2020-01-14 jie.a.chen@intel.com Add P010 stream test
2020-01-14 jmadill@chromium.org Invoke the standalone test harness runner.
2020-01-14 jmadill@chromium.org Fix test harness running disabled tests.
2020-01-14 jmadill@chromium.org Fix and improve UWP build.
2020-01-14 syoussefi@chromium.org Vulkan: Add test that exposes sampler refactor bug

Created with:
  gclient setdep -r src/third_party/angle@feb3b6cc6f2b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1033416
Tbr: jonahr@google.com
Change-Id: I976aa5a885ba380971e3e9696d0934ac4989d81b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001106Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731594}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=gambard@chromium.org

Bug: 1041419
Change-Id: I6f350b5690afb17554d191b71a2e1d51b87734d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998202
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731593}

Follow-up to crrev.com/c/1994168

Bug: 1039873
Change-Id: I2d86cc07fc2684886313fd454c733a40b9959df1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998965Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731592}

Change-Id: I7a1d9bc15bf04da61bba97f105303639ffd34f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999239
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731591}

This CL gets the estimated data savings due to SaveData and updates as
LiteMode savings. The savings are retrieved from field trial as json.

Relanding the revert in https://crrev.com/c/1990989 after renaming the
failing test class LazyLoadDisabledBrowserTest, due to some naming
clash.


TBR=ryansturm@chromium.org

Bug: 923551
Change-Id: Idf09151ea69218065b52b83e39eb84a0b7ae6cc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996270
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731590}

Increase the padding to align the opaque bg with the button.

Bug: 1041771
Change-Id: I04c5c89a4694a0d358b2bc5ccf143934ef30242a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001387
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731589}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=kerrnel@chromium.org

Bug: 1041419
Change-Id: Ib705be1fc7ef6116a8c385209e07b1d9eb4e2107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998698
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731588}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=eugenebut@chromium.org

Bug: 1041419
Change-Id: I0a0e14d9aa856ed807837915fbd99d38d465b255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998574
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731587}

This change makes Chromecast keep playing media in background on
Android devices, to follow the typical behavior or media apps.

      apps keep playing in background (e.g., when a user is in the Home
      screen)

Bug: internal b/147370574
Test: Built and installed on Android TV device, verified that Cast audio
Change-Id: Ied7ecf4653814573b2511ffb7b419264504e768a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001086
Commit-Queue: Maxim Novikov <csbubbles@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731586}

This delegate mocks out the presentation and dismissal callbacks for
use in tests.

Bug: none
Change-Id: If6dd38ca262fb94b29c283d8a85e872d8fcf5457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994148
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731585}

This CL defines a CreateTestTaskEnvironment utility function that can be
used to create a TaskEnvironment in tests. This function creates a
BrowserTaskEnvironment for content/ clients, and creates a WebTaskEnvironment
for ios/.

This CL makes tests within components/safe_browsing/core use the new utility
function rather than directly constructing a BrowserTaskEnvironmnent.

This is a step towards removing dependencies on content/ from
components/safe_browsing/core.

Bug: 1028755
Change-Id: I7f819f733bcde7121e11f656d53ba4ac08370495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993873
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731584}

Due to some broswer-state related flakiness, the
"accept-ch-lifetime.tentative.https.html" test was split
into several different files. Also, all mentions of "lifetime"
in the tests was removed to keep up to date with the Client Hint
spec.

Change-Id: I1c06b82d8cbe8bd6e304f5c1fa1d058b100a825c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994422Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731583}

The dep on //components/viz/service is no longer used.

Bug: 936425
Change-Id: I22315f95f007a11968a4c800b846864340b0191b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000957Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731582}

This is purely the interface used by SessionTabHelper.

Next patch will move SessionTabHelper to components/sessions/content.

BUG=1033924
TEST=none

Change-Id: I351ec7c46d9c0fc68fec9dfb3ca5c30727abefb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999335
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731581}

Previously, we showed an outline. Changed per UX request.

Bug: 1040256
Change-Id: I23115e42361634c42bcb7a43e81638af2b88c6db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995946
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731580}

Update the wording of forced-colors-mode-printing-02.html to match the
expectation of the test.

Bug: 970285
Change-Id: I1eda50b8a566bf733cb62fbd1d2c0c02ab14486a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994013Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#731579}

A few tests are surprisingly sensitive to screen size.

Bug: 1030919
Change-Id: I2bdf22dc99e6b02041bc10998140bf0c8491e655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998706
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731578}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=battre@chromium.org

Bug: 1041419
Change-Id: Ie1681cb457450139c09ee8651c002ef475744c08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998318
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731577}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=kkhorimoto@chromium.org

Bug: 1041419
Change-Id: I71c61acd9230f6260aaf72c0755ff6d5394be95e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998644
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731576}

I recently added the settings-sync-account-control element to the
Chrome OS build:
https://chromium-review.googlesource.com/c/chromium/src/+/1978844

The "Clear browsing data" WebUI dialog contains that element. Its
Polymer attached() method calls PeopleHandler::GetStoredAccountList
which crashes in guest mode because no IdentityManager exists.

This didn't crash before because the Polymer element wasn't
included in the Chrome OS build, so the DOM element did nothing.

Make the C++ handler work in guest mode by returning an empty list.
This fixes the crash.

Also use a dom-if to remove the settings-sync-account-control from
the dialog footer. The Chromium Polymer style guide recommends dom-if
when a hidden section contains custom elements.

Bug: 1040476
Test: added automated tests
Change-Id: Id2f703d0c37784c6525dc9127281530d87231421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999238
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731575}