- 25 Mar, 2020 40 commits
-
-
Thomas Lukaszewicz authored
Added an activation check to WebContentsModalDialogHostViews. This check is necessary to ensure a created Dialog gets activation and doesn't disappear behind the parent window. Bug: 1058737 Change-Id: I4448e0c7334056a6c45120a675087ddf193b92b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098767 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#753295}
-
Paulo Warren authored
This small CL introduces an addition to the SharedImageUsage enum: SHARED_IMAGE_USAGE_VIDEO_ACCELERATION. It will be used in the shared image factory to determine the correct type of factory (interop_backing_factory) to be used in video decoding. Separate CL: https://chromium-review.googlesource.com/c/chromium/src/+/2083662 BUG=1058103 TEST=None Change-Id: Ia2215aba5b786ab69327d922b7ffa7afda06f8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103068 Commit-Queue: Paulo Warren <pwarren@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#753294}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/84639a15fe70..7379c493206b $ git log 84639a15f..7379c4932 --date=short --no-merges --format='%ad %ae %s' 2020-03-24 fayang Stop running third_party/quic/core/http:end_to_end_test with PCC and different priority tags. 2020-03-24 bnc gfe-relnote: Refactor SetMaxAllowedPushId() method, add DCHECKs. Not protected. 2020-03-23 renjietang Send Goaway after receiving too large stream count in QuicStreamsBlocked frame. 2020-03-23 renjietang Move QuicDataReader::ReadVarIntU32 to QuicFramer for more detailed framer errors. 2020-03-23 wub Internal QUICHE change 2020-03-23 fayang gfe-relnote: In QUIC, use QuicNetworkBlackholeDetector which detects both path degrading and network blackhole. Protected by gfe2_reloadable_flag_quic_use_blackhole_detector. 2020-03-23 vasilvv Record encryption level for ACK and LOSS events in QUIC traces. 2020-03-23 bnc Remove unnecessary QuicSpdySession::SetMaxAllowedPushId() calls in tests that are not run with IETF QUIC versions. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ia916e3ae03293a7b06818d546edb40dc2a041bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120276Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753293}
-
Klaus Weidner authored
In AR mode, ARCore's blocking update() method was being called too early, blocking processing for the current frame. Use a delayed PostTask with an estimated arrival time for the next frame to avoid blocking the GL thread while waiting. Also improve event tracing by adding frame numbers and timing counters, inspired by those used for the GVR device's VR mode. Change-Id: Ifece617d6f489366834b96a04f002969bbaea7ed Bug: 1064629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118585 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#753292}
-
Richard Knoll authored
This adds support for indeterminate progress in native Windows notifications. Progress values outside the [0-100] range will now show a spinner instead of a bar set to 0. Bug: 1064584 Change-Id: I70c483bdd37d717393486cc7c9519aab8787f8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120493Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753291}
-
Dominique Fauteux-Chapleau authored
Bug: 1059780 Change-Id: I301efc26f40ba894c437f377924506499f2fd196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107604Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753290}
-
bttk authored
This reverts commit ccb4217d. Reason for revert: crrev.com/i/2797930 has rolled in with commit 51b4afd9 Original change's description: > Revert "metrics: Remove CachedMetrics" > > This reverts commit 1231840e. > > Reason for revert: Causing build failures in android-internal-chromium-tot > https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot > > Original change's description: > > metrics: Remove CachedMetrics > > > > Bug: 1048429 > > Change-Id: Ib5b5ee1d07492eb30b754320f6527acd5cda60f4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079255 > > Commit-Queue: bttk <bttk@chromium.org> > > Reviewed-by: Filip Gorski <fgorski@chromium.org> > > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#752614} > > TBR=yfriedman@chromium.org,fgorski@chromium.org,pavely@chromium.org,bttk@chromium.org > > Change-Id: I3af9a0200e42e332c647ccb3d73f2cd756b0dc04 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1048429 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117153 > Reviewed-by: Salvador Guerrero <salg@google.com> > Commit-Queue: Salvador Guerrero <salg@google.com> > Cr-Commit-Position: refs/heads/master@{#752641} TBR=yfriedman@chromium.org,fgorski@chromium.org,pavely@chromium.org,salg@google.com,bttk@chromium.org Change-Id: If85fd446d24b74452af55747ad432041e11afa2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117056Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: bttk <bttk@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#753289}
-
Nicolás Peña Moreno authored
This is a reland of 38d5e420 The main fix is adding actual content (a paragraph) to the website being loaded to ensure that the input is not ignored. In addition to this, some additional improvements are added to this reland: * Use content::SimulateMouseClick() since we do not care about the coordinates. * Use GetMergedEntriesByName() because PageLoad is singular. Original change's description: > Add FirstInputDelay integration test > > This CL adds a test for FID that tests equality between the JS value and > the value reported in UKM and in UMA. > > Change-Id: I00de8c947895700d86788ee4a95ea228458bb25f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067077 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Steve Kobes <skobes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743212} Change-Id: Ifb520d97b4bfc0374a24efc5057bee7edc6a3017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078834 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#753288}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae58199380dd..f11e33152460 git log ae58199380dd..f11e33152460 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 brianosman@google.com Validate per-vertex vertices data against effect in SkCanvas 2020-03-25 bsalomon@google.com Revert "Reland x3 "Drawing YUVA images does not flatten for bicubic."" 2020-03-25 bsalomon@google.com Fix GrFillRRectOp to not combine AA and non-AA draws. 2020-03-25 borenet@google.com [infra] Update go.sum 2020-03-25 mtklein@google.com add a color management page to skia.org 2020-03-25 borenet@google.com [infra] Update infra dep 2020-03-25 bsalomon@google.com GrAALinearizingConvexPathRenderer can't batch across view matrix changes 2020-03-25 bsalomon@google.com Reland x3 "Drawing YUVA images does not flatten for bicubic." 2020-03-25 reed@google.com move ducky images into images Created with: gclient setdep -r src/third_party/skia@f11e33152460 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1060865 Tbr: robertphillips@google.com Change-Id: Iff3316e45ff1bbcc06b1e742b84f76a1f117388c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753287}
-
dpapad authored
Bug: 792774 Change-Id: I0a76f2db35bcbb4977d13cd66084a9b6c7c494f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118774 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#753286}
-
Dave Tapuska authored
The KeyboardEvent was done with issue 692703 a few years ago and encountered no issues. This matches Gecko's definition. Upon analysis of httparchive data. (Feb 01 2020 desktop data). initUIEvent 6455 - Total 3765 - Flowplayer OK 253 - Photoswipe - OK 172 - Autoptimize - (contains flowplayer) - OK 121 - Mjl.js - OK 158 - doofinder - OK 178 - Ink.min.js - OK 122 - oxWbTabs - OK initCompositionEvent - No real usage I could detect. Queries returned _initCompositionEvent which is defined for a JS editor. initMouseEvent 1196 - total 839 - funcript - OK 121 - mjl.js - OK 19 - webcomponents - polymer used a version of it - OK 8 - au/event.js - yahoo - was comment only - OK BUG=692720 Change-Id: I5a5a5a9ca8cbdb97b9f7c42ee545b73ee17fe3aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109818Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#753285}
-
Yang Guo authored
R=dgozman@chromium.org Fixed: 1062535 Change-Id: I5a64b6e0d6be71470a34a007c674dc44347f11fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119859Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#753284}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2fc052ae..1aff54a5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I19df4de11fc998b1654328a09ebdc1c962709dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120852Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753283}
-
Sigurdur Asgeirsson authored
The field trial data is exhausting the per-process user data stash. This makes field trial data incomplete and therefore useless, while also preventing the use of the per-process user data for other instrumentation. Bug: 1003391 Change-Id: I3837076763ba7672040d0223b78978565e472a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115760Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753282}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3685fb977e15..4504b6a42842 git log 3685fb977e15..4504b6a42842 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 hjd@google.com Merge "Add missing function prototype" Created with: gclient setdep -r src/third_party/perfetto@4504b6a42842 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I104c2c76897d7c49d27a26e413783550038a0373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120530Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753281}
-
Yao Xiao authored
What: In FrameView::UpdateViewportIntersection, get the main_frame_scroll_offset from the frame owner’s local root’s intersection_state, instead of from the frame owner’s top Frame. Why: We already store this in the local root's viewport_intersection_state. Use that value, instead of additionally storing it to the top Frame. This is not only a redundancy, but can be a problem in sticky frame tracking when there are multiple subframes such as A(B1(C1(D1)),B2(C2(D2))), because an update in C1 or C2 will override the value that's previously set by the other, which could eventually cause false positively recordings of large-sticky-ads. Storing them in the local root will prevent this racing. Bug: 1013070, 1063760 Change-Id: If7bdc05a1b487bf4cfe70a3823b28d78ef0f938f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110473Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#753280}
-
Alison Maher authored
If the legend sets break-inside to avoid, and we can break before the fieldset, we should do so if it is a more appealing break point. This, however, was not the case because the fieldset content, if empty, would get laid out and override the break appeal of the builder, which is why the fieldset did not know to break before. This change fixes this issue by avoiding laying out the fieldset content if we've run out of space from laying out the legend. Bug: 875235 Change-Id: I2db2554fb1032d8297c6df954d9d8f6194b041d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116834 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#753279}
-
Aaron Leventhal authored
Prevent name calculation from getting out of control on really large regions, e.g. scrollable areas. Bug: None Change-Id: I996a15ba6d6b56df0af7975f1aca861eadf7adfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117454Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#753278}
-
Aran Gilman authored
This CL expands the existing JavaScript bindings to allow storing the theme and font family selected via the in-page appearance settings dialog to the corresponding synced preferences. The ability to persist the font size/scale will be added in a follow-up CL. Storing that setting requires some additional work to convert the font size in pixels used by the desktop UI to the scale relative to base size expected by the pref. Bug: 1016615 Change-Id: Ia7f8c86b8e9fa136b2b18429ba4b9d89272d1893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922788 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753277}
-
Marc Treib authored
This is a first step towards making this logic reusable and customizable for the MultiStorePasswordSaveManager. Bug: 1012203 Change-Id: I5875c083e8b7439677ac315c0be30de61ab08c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116080 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#753276}
-
Thomas Lukaszewicz authored
Bug: 1063511 Change-Id: Ib10bb02f0d34d7b9bd97be55f5692cbfc0c9c417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120912 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#753275}
-
Renjie Tang authored
Change-Id: Ib5fca1d1763f46d4e63b5225674d9b98a97e3efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112832 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#753274}
-
Dave Tapuska authored
The test was temporarily disabled while a feature was fixed in devtools repo. Now that it landed a while ago make sure the test is re-enabled. BUG=1043151 Change-Id: Ia4bc03c375e0b168e0a703899a1dad64de5f0a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120746Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#753273}
-
Liviu Tinta authored
Apply fixes for memory leaks and run memory leak trybots. Bug: 810882 TEST: Successfully ran the test locally on linux machine. Ran the test on trybots. Change-Id: Ie764d9dba3556e34aec93a0f4fae36f7341a0327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119371 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#753272}
-
Rainhard Findling authored
Bug: 1015841 Change-Id: I0acc1ee7bce32f326340d21171f385936a8aa18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116448Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#753271}
-
Rohit Rao authored
BUG=1024115 Change-Id: I1702b5f91f9b3969e7aafdacbcfab1236c91ad64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119217Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753270}
-
Dave Tapuska authored
These tests were disabled for feature rework in the devtools repo but were never re-enabled. BUG=1011466 Change-Id: I3f459e211a0e273ef1dd626e6521f9fe37e37923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120739Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#753269}
-
Maksim Moskvitin authored
This change replaces std::string with std::vector<uint8_t> for representation of raw trusted vault key. It makes tests more aligned with prod code and simplifies some further changes (e.g. exposing test API to Android counterpart). Bug: 1063877 Change-Id: I0cb8edb9df9131180c1d30ca4af0ee093c76a1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116170 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#753268}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4de93855b203..d34983e8718f Created with: gclient setdep -r src-internal@d34983e8718f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie857da2a806fa4f2edb3d1bf706b4372235e664a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120529Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753267}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7cf24988387a2a786672bdec426811de672cead6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120893Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753266}
-
Josh Nohle authored
If a v2 DeviceSync has never successfully completed and there are no pending failure retries, schedule a first-time initialization sync. Previously, we were waiting for an InvokeNext instruction after a v2 Enrollment or a GCM notification before scheduling the first v2 DeviceSync. This change ensures that Chrome OS starts using v2 DeviceSync as soon as the flag is enabled. Bug: 951969 Change-Id: I6ed5330029f943d3cf1ae07eefa9d88f965689f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116227 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#753265}
-
David Maunder authored
Previously non-encryption and encryption were both handled in the same file with a flag passed in. With the new approach they are in separate files and selecting the right file is driven by a configuration offering better separation of concerns. Bug: 1059638 Change-Id: Icdb8ff751295a913123e9b16f36198efcb9785fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106491 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#753264}
-
Becca Hughes authored
Store a maximum of 5 images for a feed item. BUG=1057765 Change-Id: I49b97831d1d4adff0d5c75acb7f218e183948258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115885 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753263}
-
Amr Aboelkher authored
Bug: b/151692396 Change-Id: I3c2830bae15a07dd853ed4ae7ec9e87cad6e3f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119855Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#753262}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/393c564ae0b4..8e26c5f50e85 git log 393c564ae0b4..8e26c5f50e85 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 johnkslang@users.noreply.github.com Merge pull request #2139 from neslimsah/master Created with: gclient setdep -r src/third_party/glslang/src@8e26c5f50e85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I00ba7b9b827e1fd5a2f8afd35d0fd25fc52ed32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120524Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753261}
-
Becca Hughes authored
Adds more fields around fetch state that will be updated when we fetch the feed. BUG=1057765 Change-Id: Ia560644e8057b4339a275b0f2657ed4828fb57b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110391Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#753260}
-
Jun Mukai authored
This is a UI performance test to measure the input latency for dragging window/tab in tablet-mode. However it has been disabled for a while due to flakiness. As I revisited this, I've realized that the expected behaviors have changed significantly due to WebUITabStrip. The test scenario looks irrelevant at all. It would be just okay to simply remove the entire file. Bug: 1031526, 1028386, 1057868 Test: none Change-Id: I3ff5663acf8b65d799ca7490ce3287005cb6efd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118892Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#753259}
-
wutao authored
This patch adds a basic Chrome OS settings page for the ambient mode. Two settings added: 1. A top level toggle to enable/disable the ambient mode. 2. A radio button group to choose the topic source, e.g. Google photos. Bug: b/151372242 Test: new browser tests Change-Id: Ifeda979080b33a5d42643b010e39d5e15b31c2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102008Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753258}
-
Dave Tapuska authored
The changes were landed in the devtools repo but the tests were not re-enabled. BUG=1030746 Change-Id: If7d5184ae6bb1a21ce6241d1391e0b0c981b96e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120742Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#753257}
-
Mark Cogan authored
This CL removes use of TabModelList from the metrics services manager client. Since this was the only use case for TabModelList's IsOffTheRecordSessionActive(), that logic is just reproduced in a static method for this class, using BrowserList. Bug: 1050142 Change-Id: I52090af91a3088cfe8e216c6c0d60f94ec292ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120412 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753256}
-