- 03 Aug, 2020 40 commits
-
-
Peter Kasting authored
Unlike Label, StyledLabel eats events by default. Turn this off, as was already done for the other StyledLabels. Bug: 1111218 Change-Id: Ie2da77d8e3857a24b171624fdfceba222b86de08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333492 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794196}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/382e698da199..fba96e90cf66 2020-08-03 nguyenmh@google.com Add shaders and programs serialization capability 2020-08-03 jmadill@chromium.org Rename RenderPass test to performance counter test. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I0817ccc4dcb614f2820d204ec59f7bf69f5d5788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335268Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794195}
-
Benoit Lize authored
We already use std:: atomics in this file, let's be consistent. This also removes some unnecessary reinterpret_cast<>. No behavior change. Change-Id: I0ef97b6aa702b65cb18f9a1e9a63ed85bdff024b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332662 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#794194}
-
Richard Knoll authored
LeaveTabletModeBecauseExternalMouse leaves an external mouse attached to a global which is not expected by ForDevTabletModeForcesTheButtonShown. This causes the test to fail if run after each other but pass if run in isolation. Bug: None Change-Id: If4af7248fdb984b4c0fc7d138235a8d266e433b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332702Reviewed-by:
Avery Musbach <amusbach@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794193}
-
Caitlin Fischer authored
Also, remove code to stop logging them. Note that a couple of already- obsolete histograms were still being logged, and that code has been removed, too. Bug: 1110301, b/162309838 Change-Id: I56c00c3f2ba620f04630369896237171d12af207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323138Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#794192}
-
Meera Srinivasan authored
Changing the hashing algorithm for hostnameHash to SHA1 Change-Id: I2fac2e8637b71352ef2812c37ff3281d9d89bd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333566Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Meera Srinivasan <msriniv@google.com> Cr-Commit-Position: refs/heads/master@{#794191}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0f08cdebc12b..4b656a010be5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib2a4c1217677d56d3afccaf40c595b6774c93a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334814Reviewed-by:
-
Mohsen Izadi authored
This CL removes studies in fieldtrial_testing_config.json where neither the study name nor any of its enabled/disabled feature names appear elsewhere in the codebase. This is to allow addition of new field trial testing configs. Bug: 993895,1053702 Change-Id: Ia735cb1f504d9ada4387f7e2699f181412c1616f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333368 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#794189}
-
Fabrice de Gans-Riberi authored
The Cast Streaming Receiver app should terminate on focus loss rather than keep running in background. Bug: 1111886 Change-Id: I89890bf24f88f4827b33bb4e1cf5a5846349ef84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332842 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#794188}
-
Regan Hsu authored
This fixes a crash that occurs when users search for cellular search results when Mobile data is toggled off. This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/2334402. Bug: 1110200 Change-Id: Ie2370d4b2143513c239df0516463ab3a8c32b990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335394 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794187}
-
Christopher Cameron authored
Note that IOSurfaceIsInUse is accessed via the function GLImage::IsInUseByWindowServer. This patch description uses the IOSurfaceIsInUse nomenclature. Prior to this patch, a GLImageIOSurface would ignore IOSurfaceIsInUse if it was initialized by specifying a CVPixelBuffer. This is because the IOSurfaces that come from CVPixelBuffer that come from VideoToolbox always return true for IOSurfaceIsInUse. In subsequent patches, we will no longer be directly creating a GLImageIOSurface from a CVPixelBuffer, but rather will be going through the SharedImage interface. Add a mechanism though which these paths can indicate that IOSurfaceIsInUse cannot be trusted, by adding a flag SHARED_IMAGE_USAGE_MACOS_VIDEO_TOOLBOX, and a helper function GLImage::DisableInUseByWindowServer. Bug: 1108909 Change-Id: I06cd6d70d2700080e426844dec30bb8cff13b77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333053Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#794186}
-
Anders Hartvoll Ruud authored
Instead of making in-the-wild assumptions about the number of bits needed to store a CSSPropertyID, provide this information first-hand. I will soon need this number in other places as well, and I don't want to duplicate this logic. Bug: 1112291 Change-Id: I455a70ecb4c5029dde6582aba906555d08bbe701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324845Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#794185}
-
Dominique Fauteux-Chapleau authored
Bug: 1111507 Change-Id: Ie32a02145075cf570d49361d0bc96f1de4e44287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332738 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#794184}
-
Stephen McGruer authored
This builder was removed in https://chromium-review.googlesource.com/c/chromium/src/+/2317705, but the builders.json config, which blinkpy's BuildersList class relies on, was seemingly overlooked. That broke the WPT importer (and any other use of BuildersList). Bug: 1112063, 1104846 Change-Id: I9d08cdde6992fd14147eedbd42ad38187c11b6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333747Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#794183}
-
Dominique Fauteux-Chapleau authored
Bug: 1110334 Change-Id: I88c2d767f16f50b6cf27207327921d2ff75787b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333026Reviewed-by:
-
Koji Ishii authored
When painting floating children, PaintFragment skips descendants of self-painting boxes, but FragmentItem did not. This patch matches PaintFragment logic. Bug: 1109565 Change-Id: I660053e149638bb8728e4405f2d562b795a918f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332093Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#794181}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596451854-145f78432e49c7c6a87ca8a74d340c029916cf4b.profdata to chrome-win32-master-1596459406-112652fc3cbb93a8d59d2edad7ed0033698f8002.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Idaa32434e2b6b0a1a3eac7cce59bd3d3cbad19b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335266Reviewed-by:
-
Adam Rice authored
Class content::WebSocketManager no longer exists. Remove references to it. Change-Id: I64570a2448aa66058fa850c62db2c8e36ac42ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326559Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#794179}
-
Sophie Chang authored
Bug: 1022626 Change-Id: I42f8d2c4260a60f35eaf9a30d883bbc98bb07db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333286 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#794178}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: If5b14fc7d568eea73bc6519e7d922c43c306b213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292873Reviewed-by:
-
Egor Pasko authored
The individual tests: * do not share anything * do not have setUp() even * they create necessary state by themselves * cleanup is only closing handles This means batching (avoiding process creation and teardown between tests) should be safe. More documentation on batching can be found in Batch.java. We will know the time saved after looking at marshmallow-arm64-rel result_details. Currently the running time is ~22 seconds. For reference, the UNIT_TESTS batch can be run locally using: out/.../bin/run_mojo_test_apk -A Batch=UnitTests Bug: 989569 Change-Id: If72c5696a808e203b98f8c9b9e1cc12db7c957cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329636 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#794176}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4b656a010be5..c6f029c304ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I12075eccc0187814ed4ac8f8c3416a4d47e9e34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334667Reviewed-by:
-
David Trainor authored
This patch adds the functionality required for an IPH system to trigger one of three re-engagement notifications. The IPH changes are - - Starting ChromeTabbedActivity will be flagged as engagement. - Starting a CCT will check criteria and decide whether or not to notify the user about Chrome. The feature is integrated into Chrome through the two main RootUiCoordinators and is guarded by an overall feature flag (disabling all added code) in addition to the IPH feature configurations. This CL also adds a OneShotCallback, which makes it easier to get a single value back from an ObservableSupplier. Bug: 1108002 Change-Id: Ia23827337b325550ff16259d97d81bf223de3566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311827 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#794174}
-
Tamir Duberstein authored
Instead, wait for the first event to arrive. fuchsia.netstack.Netstack eagerly sends a synthetic event upon connection. It is necessary to take this approach because Netstack does not guarantee the ordering of events with respect to non-event FIDL calls. This is a known flaw in the API, the replacement for which is being developed in https://fxbug.dev/21154. Bug: 964161 Change-Id: I1a80e254f9ccddc150b256561bda82c3ac1eef42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331860 Auto-Submit: Tamir Duberstein <tamird@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6f029c304ca..b5aa09d7531b 2020-08-03 lalitm@google.com Merge "ui: only draw visible data in tracks" 2020-08-03 lalitm@google.com Merge "tp: cache computed columns in experimental slice layout table" 2020-08-03 taylori@google.com Merge "perfetto-ui: Remove separate scheduling category" 2020-08-03 hjd@google.com ui: Fix "Uncaught ReferenceError: window is not defined" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3769e44d2dbb5c778fc499d38e165aec4bc8a814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335272Reviewed-by:
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Ib7cbb71865828acf58f92013def4dc34dd7aed9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293276Reviewed-by:
-
Thomas Lukaszewicz authored
Defines CrSearchFieldBehaviorInterface for CrSearchFieldBehavior such that uses of CrSearchFieldBehavior with the non-legacy class based Polymer3 syntax are parsable by the Closure Compiler. Bug: 1099917 Change-Id: Ic5257e6ca5f59860cebefdedea378905c3fd0fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333208 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#794170}
-
Daniel Rubery authored
Since binary uploads don't use cookies, we can use the Profile's URLLoaderFactory and set the request to CredentialsMode::kOmit to prevent accidentally persisting user identifiers. Bug: 1049833 Change-Id: I6e73f5912283d3a2e94a01f0e288bb9f47ec9e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327147Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#794169}
-
Jose Leal Chapa authored
Related frontend CL: https: //chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2303292 Bug: 1074732 Change-Id: Ic3998ce1c51d8dfc48243195b619b74afd57b020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259138 Commit-Queue: Jose Leal <joselea@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by:
-
Nodir Turakulov authored
Add an all-purpose "chromium:public" realm where everything is public. Change-Id: I60d98ff828063d024b98d153335a4a36a775c6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335354Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#794167}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98b332f2dbbd..01a0945e034b 2020-08-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I64bbc798cbf4cd8d414836e6d35f59f7cb04453b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335263Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure that the tests are passing when the Request Desktop by default flag is enabled. Bug: None Change-Id: Ic5bbb2b00acb61e075bf6d57aa63c1db8892f28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330052 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#794165}
-
Richard Knoll authored
This hooks up the NotificationHandler with the NotificationManager to respond to notification clicks and close. Bug: 1102348 Change-Id: I300305a09ed651f488b286e8fcaf5d3f69ceb8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329539Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794164}
-
Min Qin authored
the Data directory could be a sim link in recent Android versions. So need to use canonical path when checking if a file is under it. BUG=1104628 Change-Id: I403b9582e09a799e5c51d2687ce4928dea8e7e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320071Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794163}
-
sczs authored
Calling stringValue on a NSString* crashes in iOS12 Bug: 1112103 Change-Id: Ice356b5a6da6e597fad850c3e5cb99e1f9fef52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332992 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#794162}
-
Mason Freed authored
These got missed the last time around, because they pass when the features are disabled. But they are all only testing WCv0 features, so they belong in the web-components-v0-only directory. Bug: 937746 Change-Id: Ifec22f31a69bf4358c4a4a9dfa5d54f7c3005db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335315 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#794161}
-
Omer Katz authored
This CL is dependent on https://chromium-review.googlesource.com/c/v8/v8/+/2327910/ Bug: 1108537 Change-Id: Ie2121ba8e1460a5979ceeba734ca3a516a63903f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327672 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794160}
-
Richard Knoll authored
If a NotificationDelegate calls RemoveNotification in the Close handler we're currently ending up in an endless loop. Instead remove the Notification from the list before calling Close so the next call exits early and is a noop as expected. Bug: None Change-Id: I7ed211ba1bf78a33255211090bfbd11e986dfc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330019Reviewed-by:
-
Dan Harrington authored
Adding ContentSuggestions.Feed.LoadStepLatency.* UMA which record latency for individual steps in loading the feed. Bug: 1044139 Change-Id: I69350a8c9dcec1b0ee2c3260832d865e498bcbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332333 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596434376-e66572c4bd7519ea423a67f597bf938ae289c1f8.profdata to chrome-win64-master-1596455409-191726fecbe6a9b7fc8fb41afab59db6a1bbda42.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifec3ac3a0ca4e33dbed9717fc1f13639f2766020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335259Reviewed-by:
-
