GitLab

Make sure that the magic value can be cast to a char properly.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10541122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141814 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/10539094/.

We weren't holding on to a reference for an
x509Certificate passed to another thread for logging.

BUG=126243

Review URL: https://chromiumcodereview.appspot.com/10534117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141812 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10539099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141810 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130101

Review URL: https://chromiumcodereview.appspot.com/10539122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141809 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141808 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Trybots, grit unit

Review URL: https://chromiumcodereview.appspot.com/10537133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141807 0039d316-1c4b-4281-b951-d872f2087c98

Do not add it to isolate.py yet.

NOTRY=true
R=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10542087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141806 0039d316-1c4b-4281-b951-d872f2087c98

Currently the new tab button is much brighter than the inactive tab background color.

The problem is that the tab strip code draws the new tab button background programatically. This means that the new tab button icon shouldn't have a fill.

This was working correctly but regressed in r134335.

Screenshots:
  before: http://i.imgur.com/iLGLN.png
  fixed: http://i.imgur.com/zVTaq.png

BUG=132333
TEST=


Review URL: https://chromiumcodereview.appspot.com/10544117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141805 0039d316-1c4b-4281-b951-d872f2087c98

Previously chrome.l18n.getString() wouldn't touch $1 within the resource
when substitutions are not specified. This was fixed in crrev.com/141280, and
now it replaced $1 with an empty strings, which broke chromoting host
localization that relied on the previous incorrect behaviour. Fixed
the webapp to correctly handle strings substitutions.

BUG=132146

Review URL: https://chromiumcodereview.appspot.com/10533101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141804 0039d316-1c4b-4281-b951-d872f2087c98

From the 'no free lunch' department: Add a warning when developing an extension that uses old manifest version.

Screen shot: http://imgur.com/dAHVo

BUG=131962
TBR=estade@chromium.org
TEST=Load any extension that uses manifest_version < 2. Should see warning message in chrome://extensions/.

Review URL: https://chromiumcodereview.appspot.com/10536084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141803 0039d316-1c4b-4281-b951-d872f2087c98

Platform app shortcuts on the mac don't work. Until we can properly
support shortcuts on the Mac we need to disable their automatic
creation at install time.

BUG=132161
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10534108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141802 0039d316-1c4b-4281-b951-d872f2087c98

that get tab-specific permissions granted (currently, only via clicking a browser
action, but this will expand) can executeScript and captureVisibleTab on that tab
only, until the next page navigation or refresh.


BUG=93903

Review URL: https://chromiumcodereview.appspot.com/10443105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141801 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141800 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10545146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141799 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131920
TEST=


Review URL: https://chromiumcodereview.appspot.com/10532110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141798 0039d316-1c4b-4281-b951-d872f2087c98

R=cmp@chromium.org
NOTRY=true
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10541083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141797 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131200
TEST=Run chrome with --aura-disable-mouse-events-from-touch --enable-touch-events and navigate the wrench menu, selecting an item.


Review URL: https://chromiumcodereview.appspot.com/10534092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141796 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131611
TEST=added new test


Review URL: https://chromiumcodereview.appspot.com/10545140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141795 0039d316-1c4b-4281-b951-d872f2087c98

Partial rollback of
https://chromiumcodereview.appspot.com/10543015/

TBR=sail@chromium.org
BUG=95425
TEST=browser_tests --gtest_filter=WebUIBidiCheckerBrowserTestRTL.TestSettingsPage (ASAN)

Review URL: https://chromiumcodereview.appspot.com/10540134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141794 0039d316-1c4b-4281-b951-d872f2087c98

Mac 10.6, v8_benchmark: Unclear regression. Probably just slight increase in noise
http://build.chromium.org/f/chromium/perf/mac-release-10.6/v8_benchmark/report.html?history=350&rev=141737

TBR=cmp

Review URL: https://chromiumcodereview.appspot.com/10545145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141793 0039d316-1c4b-4281-b951-d872f2087c98

This makes RequestMediaAccessPermission a part of WebContentsDelegate instead
of ContentBrowserClient. The request UI (or lack thereof) needs to be
controlled by the WebContentsDelegate so that platform apps can grant permission
differently than a normal browser. This also seems appropriate because
each request is made on behalf of a particular web contents.

BUG=130216
TEST=navigator.webkitGetUserMedia still works for normal web pages

Review URL: https://chromiumcodereview.appspot.com/10542092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141792 0039d316-1c4b-4281-b951-d872f2087c98

Reorder functions in AutocompleteActionPredictor so that if A calls B calls C, they're listed A, B, C.  (The existing order seemed kind of random.)

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10548015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141791 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141790 0039d316-1c4b-4281-b951-d872f2087c98

Avoids link error:

[14->2/16 ~0] LINK(DLL) initial\chrome.dll
FAILED: python gyp-win-tool link-wrapper "c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\link.exe" /nologo /IMPLIB:initial\chrome.dll.lib /DLL /OUT:initial\chrome.dll /PDB:initial\chrome.dll.pdb @initial\chrome.dll.rsp
browser.balloon_collection_impl_ash.obj : error LNK2019: unresolved external symbol "public: bool __thiscall chromeos::BalloonViewHost::AddWebUIMessageCallback(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::Callback<void __cdecl(class base::ListValue const *)> const &)" (?AddWebUIMessageCallback@BalloonViewHost@chromeos@@QAE_NABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABV?$Callback@$$A6AXPBVListValue@base@@@Z@base@@@Z) referenced in function
"public: bool __thiscall BalloonCollectionImplAsh::AddWebUIMessageCallback(class Notification const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::Callback<void __cdecl(class base::ListValue const *)>
const &)" (?AddWebUIMessageCallback@BalloonCollectionImplAsh@@QAE_NABVNotification@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABV?$Callback@$$A6AXPBVListValue@base@@@Z@base@@@Z)
initial\chrome.dll : fatal error LNK1120: 1 unresolved externals


R=ben@chromium.org,cpu@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10540128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141789 0039d316-1c4b-4281-b951-d872f2087c98

https://chromiumcodereview.appspot.com/10548003/

Review URL: https://chromiumcodereview.appspot.com/10533109

TBR=robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/10543126

TBR=cpu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10536133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141788 0039d316-1c4b-4281-b951-d872f2087c98

For UMA opted-in users, record the typed_counts of users that show up as omnibox suggestions.

This has been approved by the privacy folks.

BUG=
TEST=using VLOG in the appropriate place in metrics_base.cc


Review URL: https://chromiumcodereview.appspot.com/10544114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141787 0039d316-1c4b-4281-b951-d872f2087c98

CID=104112, 104110, 104109
BUG=None
TEST=
R=jeremya@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10443075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141785 0039d316-1c4b-4281-b951-d872f2087c98

ProxyConfig keeps track of the source of proxy settings. During proxy resolution ProxyService tags the resulting ProxyInfo with the same source information.

BUG=none
TEST=net_unittests


Review URL: https://chromiumcodereview.appspot.com/10310179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131699
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10541121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141783 0039d316-1c4b-4281-b951-d872f2087c98

Previously, Chrome Endure tests would check to ensure that the current
platform is supported by the Deep Memory Profiler (i.e., is Linux) whether
or not Deep Memory Profiling is enabled.  This prevented the endurance
tests from running on other platforms, even if not using the Deep Memory
Profiler.

This CL moves the supported platform check into a codepath that is only
executed if the Deep Memory Profiler is requested.

BUG=None
TEST=None
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10540131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141782 0039d316-1c4b-4281-b951-d872f2087c98

These tests are newly enabled.
I've filed bugs and alerted the test authors.

BUG=132337,132340

R=dennisjeffrey@chromium.org
TEST=
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10544120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141781 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionPrefs for persisting alarm state to disk.

More to come:
- context menus
- omnibox
- declarative webRequest

TBR=brettw
BUG=123366
TEST=extension alarms are still remembered after chrome restart

Change since last time: Fall back to a FailingValueStore if ValueStoreFrontend
can't open the database.

Review URL: https://chromiumcodereview.appspot.com/10545128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141780 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127538
TEST=aura_shell_unittests --gtest_filter="AcceleratorControllerTest.GlobalAccelerator"


Review URL: https://chromiumcodereview.appspot.com/10541127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141779 0039d316-1c4b-4281-b951-d872f2087c98

No idea why these stopped working

TEST=they compile and run
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10532111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141778 0039d316-1c4b-4281-b951-d872f2087c98

  This will be changed to set the wallpaper on all root windows.

BUG=123160
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10545142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141777 0039d316-1c4b-4281-b951-d872f2087c98

On Android, files have to be created in the application directory.

BUG=125059

TEST=


Review URL: https://chromiumcodereview.appspot.com/10543118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141776 0039d316-1c4b-4281-b951-d872f2087c98

ReleaseMouseMoves can be called from a deep stack, possibly while already
dispatching an event. Most of these code paths don't expect another event to be
dispatched from there, so post a task to delay it. Ordering is still ensured
from the existing mechanisms.

BUG=131875
TEST=manual (see bug), also RootWindowTest.HoldMouseMove

Review URL: https://chromiumcodereview.appspot.com/10545129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141775 0039d316-1c4b-4281-b951-d872f2087c98

I renumbered some command IDs in r141609 but neglected to
update the references to them in the NIB file.

BUG=132322
TEST=none (grep for renumbered IDs in chrome/app/nibs and checked that they're correct)


Review URL: https://chromiumcodereview.appspot.com/10533117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141774 0039d316-1c4b-4281-b951-d872f2087c98

These tests seem to be failing on the main waterfall.

BUG=132348
TEST=
TBR:rogerta@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10539120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141773 0039d316-1c4b-4281-b951-d872f2087c98

Also, changes type of SkiaTextRenderer::SetTextSize() to SkScalar to match the underlying Skia type, which is needed for future RenderTextMac implementation.

BUG=126506, 125664, 105550
TEST=Eyeball underlined text in views_examples' text style example.

Review URL: https://chromiumcodereview.appspot.com/10520017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141772 0039d316-1c4b-4281-b951-d872f2087c98