GitLab

This reverts commit e64c72b9.

Reason for revert: This causes the https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests bot to turn red with webkit_layout_tests failures that are empty.

Original change's description:
> Stop running webkit_layout_tests on mac 10.12 and 10.13 w/ GPUs.
>
> And disable http/tests/media/video-load-metadata-decode-error.html,
> which appears to have a dependency on GPUs.
>
> Bug: 854874, 871445
> Change-Id: I254ce21953ac428351203d6479e1936347ce5b4c
> Reviewed-on: https://chromium-review.googlesource.com/1162963
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581074}

TBR=dpranke@chromium.org,kbr@chromium.org,bpastene@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 854874, 871445, 871830
Change-Id: Ia9963a9f3cb6dbaad0f7a8b78723bf0dc034d052
Reviewed-on: https://chromium-review.googlesource.com/1165846
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581297}

Add a block autoplay pref that is available on all
platforms except Android.

BUG=865548

Change-Id: I4b09105da1ed901ac8a8ad8bb9ec984237b0662b
Reviewed-on: https://chromium-review.googlesource.com/1165494Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581296}

TBR=zmo@chromium.org

BUG=angleproject:2761
BUG=angleproject:2760
BUG=795030

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I27b47f2ce8b8b66c9bb0577cf627b5998f043fe8
Reviewed-on: https://chromium-review.googlesource.com/1165587
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581295}

This CL does two things to support the correct SkSurface
orientation for low latency canvas 2D contexts to get promoted
to overlay:

1. CanvasRenderingContext::IsOriginTopLeft() is extended in 2D
canvases to return false if IsAccelerated() (because those refer
to the bottom left) -- but true if it IsSingleBuffered(). This
is needed to support overlays on Intel, which can only be top
left (and other platforms/archs like ARM RockChip are OK with it
anyway).

2. CanvasResourceProvider::Create() gets a new parameter, namely
|is_origin_top_left|, which is by default true (since that's how
Canvases work by default). The callsites where true is not the
right thing are corrected.

Bug: 869161
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia798bd674b3f9e42063e5ae8b4017bfdd9e60d48
Reviewed-on: https://chromium-review.googlesource.com/1160774Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581294}

Following https://crrev.com/c/1154107, the test results JSON no longer
collapses multiple retries if they are all same, so some of the
assumptions in the expectations updater no longer hold. This CL changes
the updater to properly support multiple retries in the "actual"
results.

Besides, add a "--patchset" argument to the tool for easier debugging.

Bug: 870528
Change-Id: Ia6045eac7781708046a7ab8f07eb40c23a9f5897
Reviewed-on: https://chromium-review.googlesource.com/1164027
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581293}

Directories "metrics" and "vr" have errors. All the other directories
are enumerated because gn doesn't support negative list.

Bug: 367595
Change-Id: If009fa36916dacd9d67aea95a6b22b13c9e37919
Reviewed-on: https://chromium-review.googlesource.com/1164579Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581292}

Settings data type is missing from the all the data type to sync. It
should have been added from the beginning.

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idb972d67856c324e9899762c05bfd7c84b07d6b0
Reviewed-on: https://chromium-review.googlesource.com/1158404Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581291}

Temporary disable feature until fixing regression reported in linked bug.

Bug: 870171
Change-Id: Ib66b1d5c820e257f2ade9cd6f492339639a241c6
Reviewed-on: https://chromium-review.googlesource.com/1164364Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581290}

font size property is set on CSS pixel, but it's calculated from
video size, which is in physical pixel after use-zoom-for-dsf enabled
on Android.
This CL applys the page zoom factor to the video track font size.

Bug: 870243
Change-Id: If597e115b8f77395bbd21ac90d0112c7a86ee62f
Reviewed-on: https://chromium-review.googlesource.com/1160775Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581289}

This CL adds a persistent variant of the Snackbar with the following
properties:

- Persistent snackbars do not time out (setting their duration has no
  effect).
- Persistent snackbars appear last (they appear below notification or
  action snackbars).

Bug: TODO
Change-Id: I440373c8b54e90b0709b91b87748ce6eac01c3e1
Reviewed-on: https://chromium-review.googlesource.com/1159173
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581288}

Commit bf7722f9 ('Reland "Fixes
ExtensionWebRequestApiTest.WebRequestBlocking with network service"') caused
the GCC build to hit https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84849,
where having base::NoDestructor<T<U>> and passing an initializer list of Us
does not work.

Explicitly create an std::set<string> to pass to base::NoDestructor, just
like we did in https://chromium-review.googlesource.com/944405 before.

Bug: 819294
Change-Id: I8077b39959d8a53daef40bc33f8293f15c597ce0
Reviewed-on: https://chromium-review.googlesource.com/1165360Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#581287}

Don't show the IPH bubble when on the NTP and post the request to show
the bubble to allow time for a layout pass so the anchor view has a
valid height when the bubble is shown.

BUG=871537

Change-Id: I28b4a5621a332360141b553582ba4f182363d280
Reviewed-on: https://chromium-review.googlesource.com/1165599Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581286}

BUG=846953

Change-Id: Ic354c61147f14f080341aba36220cb81324df81e
Reviewed-on: https://chromium-review.googlesource.com/1165302
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581285}

Change-Id: I22e31b6dd6a5e2a6c809f0563a614b4d3150a969
Reviewed-on: https://chromium-review.googlesource.com/1164390Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Penny MacNeil <pennymac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581284}

Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
exector is good for preventing concurrency errors since it guarantees
serial execution, but bad for performance since the entire app shares
this single queue.

It looks like these callsites are stuck with the SERIAL_EXECUTOR, since
they both call updateAccountRenameData() which is not thread safe.

Bug: 869907
Change-Id: I23ac4430cd10acb61842ee1b37c36d8c36f0f8af
Reviewed-on: https://chromium-review.googlesource.com/1161092Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581283}

This CHECK should be removed since it is being hit in rare cases.
This first CL is to try to gather more information in clustefuzz
reports about the state when the CHECK is hit, since we have been
unable to reproduce it locally.
The CHECK will be removed in a follow-up CL.

Bug: 871714
Change-Id: Iefed096801002e8f4d022723c07c876ff10b0014
Reviewed-on: https://chromium-review.googlesource.com/1165542Reviewed-by: Florent Castelli <orphis@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581282}

- Assistant need to be destructed before voice interaction controller
  client in order to correctly remove the observer.

Bug: b/112273549
Test: Manual Test
Change-Id: I6360dcdca38dd8d50ac6bbf768841f34d375b31b
Reviewed-on: https://chromium-review.googlesource.com/1164411
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581281}

https://webrtc.googlesource.com/src.git/+log/7008287219b6..b3e2c8eb1b16


git log 7008287219b6..b3e2c8eb1b16 --date=short --no-merges --format='%ad %ae %s'
2018-08-07 buildbot@webrtc.org Roll chromium_revision 39d45f08..474eca05 (580730:581204)
2018-08-07 srte@webrtc.org Makes units constexpr when possible.
2018-08-07 titovartem@webrtc.org Move spl_sqrt_floor dep to proper third_party directory


Created with:
  gclient setdep -r src/third_party/webrtc@b3e2c8eb1b16

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Id7e6656b8df57fe0f234221bd46e94f229afc40f
Reviewed-on: https://chromium-review.googlesource.com/1165325Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581280}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I8bd55d5ff4eb7c3078d5d1b8bb075bcfff5a7345
Reviewed-on: https://chromium-review.googlesource.com/1165590Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581279}

Tap to unlock still should work on an empty password, though.

Bug: 839320
Change-Id: Id5fd17c9428ddc2b6823cd3c63a5f21aa486b860
Reviewed-on: https://chromium-review.googlesource.com/1164257
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581278}

This reverts commit 1638e067.

Reason for revert: New tests are flaky and causing problems when submitting code.

Original change's description:
> [heap] Do not revive WeakMember during incremental marking
> 
> Overwriting deleted values with cleared values potentially revives
> buckets in collections. For atomic garbage collections this is not a
> problem as those values are filered out in the visitors already. For
> incremental garbage collections the deleted values may be introduced by
> erasing a value from a container after it has been visited by the
> incremental marker.
> 
> Bug: chromium:870196, chromium:757440
> Change-Id: I1d628f00c2e2ea6e36e880d50a397dcbcc8566d1
> Reviewed-on: https://chromium-review.googlesource.com/1164950
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Keishi Hattori <keishi@chromium.org>
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581238}

TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org

Change-Id: I632b5594d137acd37b4639ebcd46f8d61638dbc0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:870196, chromium:757440
Reviewed-on: https://chromium-review.googlesource.com/1165328Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581277}

BattOr is being removed from Chrome tracing. Before the code for it
can be deleted, we need to do this.

TBR=inferno@chromium.org

Bug: 859514
Change-Id: I3f88e147570e05c4056052aebfc085648231a4f3
Reviewed-on: https://chromium-review.googlesource.com/1162631
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581276}

When the UnifiedConsent view is presented by the ConsentBump, it
shouldn't be interactable: it shouldn't be possible to change the
selected account or to tap the settings link.

Bug: 866506
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I343157986df387382539746e12cca87e0121b413
Reviewed-on: https://chromium-review.googlesource.com/1165148
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581275}

BUG=871740
TBR=tnijssen@google.com

Change-Id: I6c19c03148cdd7f5499d2fba114690a4b258d8c8
Reviewed-on: https://chromium-review.googlesource.com/1165319Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581274}

Reorganizing GoogleServicesSettingsCommandID enum and
<GoogleServicesSettingsCommandHandler> to match the UI layout.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie60468e0d3f2f2ad3b9ad3d515675ab4deafaaa8
Reviewed-on: https://chromium-review.googlesource.com/1163663
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581273}

TabStrip now calls ActiveStateChanged() on tabs when they are removed
from the view model, giving them a chance to update any relevant state
(such as background/text color, etc).

Bug: 859321
Change-Id: Iaad9d3dfa2d378c708a648315e5bdef9e2f2ff5f
Reviewed-on: https://chromium-review.googlesource.com/1162429
Commit-Queue: Ryan Meier <rameier@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581272}

BUG=847623
R=chrishtr@chromium.org

Change-Id: Ib8cefc856ecbeadfdeecabcf7f20b6d3b457db6a
Reviewed-on: https://chromium-review.googlesource.com/1164473
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581271}

Bug: 862308
Change-Id: I2f018ab228eaee5ca3bcbdd9a318d71f05612ca3
Reviewed-on: https://chromium-review.googlesource.com/1164564Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581270}

BUG=870843

Change-Id: I1ae9d16a9238fd5f669ab487eeed02f45068ba92
Reviewed-on: https://chromium-review.googlesource.com/1162708
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581269}

The sidebar was the project which replaced the current system tray but
it was taken over by the unified system tray. So the sidebar was no
longer used. This CL removes the sidebar-related unused code.

Bug: 871665
Change-Id: Iaea91177182bf87d8b09c00a9a38edfa78daedda
Reviewed-on: https://chromium-review.googlesource.com/1164815Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581268}

Remove several tests that have been renamed, and annotate two other sets
of tests with more details and new bugs.

Bug: 769401
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ic8d7b9158ebb6b3c551546c83639e3ad1431db26
Reviewed-on: https://chromium-review.googlesource.com/1164313Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581267}

The maximum scroll offset varies among different screen height. It's
not very reliable to use the hard-coded html body height for testing.
This patch simulates scroll based on the maximum scroll offset from
the RenderCoordinates instead.

Bug: 871305
Change-Id: I983036b8d72d60c4077eea1cbc39b2177e6aebf4
Reviewed-on: https://chromium-review.googlesource.com/1164416
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581266}

This test case has a DrawRecord in the middle of it.  There was some
hope previously that because this fuzzer memset all the memory it
was allocating, then all the unwritten memory could be consistent.
However, because a bunch of other memory gets allocated when serializing
then that memory can have garbage in the padding.  When simple ops
memcpy as a part of serializing or deserializing, they bring along
that garbage, which can cause binary differences.

This was lucky that this has ever worked on Skia serialization, so
remove the binary comparison and just use the logical comparison.

Bug: 870647
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie20097c4df4953bb6503caff81ad811dc69acc63
Reviewed-on: https://chromium-review.googlesource.com/1162746Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581265}

This reverts commit a0c5484d.

Reason for revert: Still causes failures of maps_pixel_test, this time on Nexus 5 device:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205%29/7545 . Previously seen in http://crbug.com/870001 .

Original change's description:
> Reland [blink] Add a time limit to message processing in MessagePort
> 
> In addition to existing limit of 200 messages in a single task also
> limit it to 10 milliseconds to avoid starvation.
> 
> This logic will be removed when message-per-task mojo dispatching
> will be implemented.
> 
> BUG=867133
> R=​mek@chromium.org
> 
> Reviewed-on: https://chromium-review.googlesource.com/1152815
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#579751}
> Change-Id: Idb757ddbc91c3e732e34e834bf8e00cc2292ddb5
> Reviewed-on: https://chromium-review.googlesource.com/1163782
> Cr-Commit-Position: refs/heads/master@{#581184}

TBR=mek@chromium.org,altimin@chromium.org

Change-Id: I9de23aa6fa95b06e5aa47cedc30ecd5f9d6ccaed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 867133
Reviewed-on: https://chromium-review.googlesource.com/1165527Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581264}

Fixes a few things I got wrong in https://chromium-review.googlesource.com/1163932

- Also add win-asan to the chromium.memory standalone console. Main waterfall
  and sub-waterfall consoles are apparently completely independent, so do the
  same bot reordering I did in the above CL here too.

- Also add win-asan to the luci.chromium.try bucket

Bug: 869973
Change-Id: I9e32f15b2869b0adafb4f291e9e4147184baa84a
Reviewed-on: https://chromium-review.googlesource.com/1164645Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581263}

The CL fixes FindConfig implementation to return nullptr for unknown
components.
FindConfig used std::find_if to find a matching component config. For
non-existing elements, find_if returns the last iterator (in this case
std::end(kConfigs)), which is invalid, but non-null.

BUG=None

Change-Id: I53ff08d43131d4f8bfd02c8e02347de095ed6094
Reviewed-on: https://chromium-review.googlesource.com/1164581Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581262}

Change-Id: I4dc93adea48598f3ad98775c3d5235235943ae1b
Reviewed-on: https://chromium-review.googlesource.com/1162390Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581261}

online and offline).

Bug: 868025
Test: Run DemoSetupTest, DemoSetupControllerTest and WizardControllerDemoSetupTest.
Change-Id: Ifca8bc7f4c053d2ff060ee0fc529f38690124a65
Reviewed-on: https://chromium-review.googlesource.com/1157543Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581260}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/06a50f7eab7c..265047706b90


git log 06a50f7eab7c..265047706b90 --date=short --no-merges --format='%ad %ae %s'
2018-08-07 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@265047706b90

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I575a18ba4f053aac43480f476195d7c63828b1fe
Reviewed-on: https://chromium-review.googlesource.com/1165324Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581259}

In a previous CL, we moved the security chip label left by 2dp to align
with URLs in the case where we have an unlabeled lock icon.

However, in doing so, we accidentally un-aligned the indented search
keyword label with the suggestions text.

This CL fixes that.

As far as I can tell, in the old pre-Refresh world, the extra internal
spacing used for the search keyword provider just matched the value of
GetPrefixedSeparatorWidth() as a matter of coincidence.

This CL divorces those two for post-Refresh, because
"something's gotta give".

Bug: 865546
Change-Id: I464cd61f360d6ba1a53bca46a973cd0193ede9fc
Reviewed-on: https://chromium-review.googlesource.com/1164394Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581258}