- 01 Apr, 2020 40 commits
-
-
chromium-autoroll authored
Roll silvermont AFDO profile from 83-4085.6-1584956258-benchmark-83.0.4097.3-r1 to 83-4091.0-1585562740-benchmark-83.0.4099.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie5e8624153411943684cb65e933bf1f40104f7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755562}
-
Peter Kasting authored
Setting up TestScreen too early causes problems with AshTestHelper, which I'll be enabling soon for ChromeViewsTestBase. This restricts it to only be alive for a narrow window of time. Bug: none Change-Id: If6d3b059175cf438a3df00469a8406d24a66b5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132971 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#755561}
-
Peter Kasting authored
The registry only actually uses the latter, so this expresses its dependency more cleary and would allow for easier dependency injection. Bug: none Change-Id: Ibf569055c0afa753c1eee87529c5f977477c59b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132937 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#755560}
-
Guido Urdaneta authored
This CL introduces underlying source and sink classes for encoded audio. The source allows sending frames from WebRTC to a ReadableStream. The sink allows sending frames from a WritableStream to WebRTC. Unit tests in https://chromium-review.googlesource.com/c/chromium/src/+/2132258 Bug: 1052765 Change-Id: Ie9083ad92b0bbabc177c284f0bf482b7bc1555b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132133Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#755559}
-
Mark Schillaci authored
This CL disables AccessibiliEvent throttling, and disables the AccessibilityNodeInfo caching on Android. This CL leaves all the code in place but does not leverage it so that we know M83 will be cut without regressions. We can then revert this change and land them in M84 or later. Change-Id: I405e712431a4b114ab4bebe7924bb7e75d98e989 RelNotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132927 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#755558}
-
Lei Zhang authored
Change-Id: I2839601358a8d3b97778d89463a9c9dab6ac2af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129894Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#755557}
-
danakj authored
The test_runner is part of content/shell/renderer. Move the shared constant that the browser side wants to use out to content/shell/common/web_test/web_test_constants. Because the common/web_test code is a separate build target now, we can have the test_runner and content_shell_lib both depend on it. R=avi@chromium.org Bug: 866140 Change-Id: Ifcc484108e2982284d78977a0c70f24565c7dc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132837Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#755556}
-
Aaron Leventhal authored
If anything tries to advance or rewind the document lifecycle during ProcessUpdates(), a DCHECK will activate providing a stack leading to the exact cause. Bug: None Change-Id: Ib913e4878b24ebfb1154806793910ea95cf4258a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132606Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#755555}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0d258401. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 8fa00285 "[webauthn] Fix resident key credentials.get() WPT" 4f79553f "CookieStore: Add wpt for path behavior" 5954f48b "[css-flexbox] Move canvas-dynamic-change.html test to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I87c14ff71b77ace080b9857275c9aea23202c560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132428Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755554}
-
Antonio Gomes authored
BUG=1063749 R=cbiesinger@chromium.org Change-Id: Id12f61879857b18eef099acdcb7bee2d3741850e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132986Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#755553}
-
Guido Urdaneta authored
This class implements the WebRTC interface for encoded audio insertable streams. It allows receiving encoded frames from WebRTC (e.g., from the encoder or depacketizer) and writing encoded frames back to WebRTC (e.g., to the packetizer or decoder). Bug: 1052765 Change-Id: I548defd3b6abc020a11add797ef7708d9d81f054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132208Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#755552}
-
John Budorick authored
Change-Id: I61205e4a5a80405f8570691fc2c28ac3a0c228ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132593Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#755551}
-
Lei Zhang authored
Printers usually have at least 1 paper size. Add one for this test case and make sure it gets parsed correctly. Since there are now 3 paper sizes to check, also refactor the checking code into VerifyPaper(). In VerifyPaper(), simplify the base::Value API usage. Change-Id: Ib5f101b1eb92cfc79d8dee9c19479be2d1d1ded0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131794 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#755550}
-
Garrett Beaty authored
This will simplify the process of updating the main consoles on branch day. Bug: 922150 Change-Id: Iee6c7a10bb05c60c65a5bf3ca9027b8837c4b3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128242 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#755549}
-
Oriol Brufau authored
Before r747669, both explicit and implicit named lines were stored in NamedGridColumnLines and NamedGridRowLines. But that patch moved the implicit ones into their own ImplicitNamedGridColumnLines and ImplicitNamedGridRowLines fields. However, LayoutGrid::NamedGridLinesDefinitionDidChange was not updated to also look at the new fields. Therefore, a dynamic change in grid-template-areas might not force the grid items to be placed again. BUG=1066679 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-007.html Change-Id: I4b6ff2de1f1c13f985b146169f39283613defc88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132397Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#755548}
-
Antonio Gomes authored
BUG=1063749 R=dgrogan@chromium.org Change-Id: I698cdd287a0da0d7eefee5343c8595a985844c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132431 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755547}
-
Mike Reed authored
These no longer appear in the skia src tree. Change-Id: If5702b671ca5910905b5e685e02ef8624e254734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132832Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#755546}
-
Jeff Yoon authored
The iOS output sets flaky tests to 'actual' = 'FAIL', even though it passes. This is confusing, because the Swarming task passes, but it's reported as a fail. Aborted tests are also simply marked as failures, but should be reported as TIMEOUT. This conforms the output.json to std json format by properly handling flaky scenarios via appending PASS to 'FAIL', and setting is_flaky=True for that test, allowing the isolated merge script to properly handle the result. Aborted tests are marked TIMEOUT as well. Bug: 1064766 Change-Id: I95df0a64efd54923f0ed37dc67e807c08ad43919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121338Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#755545}
-
Abhijeet Kandalkar authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Ibe59ff50182f6dc37dcdbfb436685322200a51f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131812Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755544}
-
Tomasz Wiszkowski authored
This change effectively increases number of search results on Android devices from default (3). Bug: 964049 Change-Id: I46887f88e3f76801d24f7dfdf928397e6a3ae66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132858Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#755543}
-
Jan Krcal authored
This CL stores basic low-entropy info about accounts in a profile in the profile info cache and reports the information into metrics: - Profile.AllAccounts.Categories - Profile.AllAccounts.Names The stored info for a profile is cleared whenever there are no signed-out accounts (such as when cookies get cleared). Bug: 1065011 Change-Id: I88c25f1d7b07d8acc668307f851bd058ec77488f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128129 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755542}
-
Antonio Gomes authored
BUG=1063749 R=dgrogan@chromium.org Change-Id: Id51c1835ca14bb75b64b4bf812c27ca25fdd28ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132429 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755541}
-
sauski authored
The "Block Third Party Cookies in Incognito" selection in the new Cookies page radio selection only takes effect when the related feature is enabled. This CL hides the radio button when the kImprovedCookieControls feature is not enabled, preventing the user from making a no-op selection. As the prefs related to the feature exist independently of the feature being enabled, logic is added to ensure the removed radio button is not selected when the feature is disabled. Test cases are included to cover the above. Bug: 1061947 Change-Id: I9fd4179428eaebce93f9e69a73325ab970ba8183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130352Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#755540}
-
Tom Anderson authored
This appends eg "_wayland" to the test name to prevent duplicate tests on the linux-ozone-x11-and-wayland-rel bot. R=msisov,agable BUG=1060273 Change-Id: Ib83c2394653dd1973ba4ff5da38296d7af94f1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128842Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#755539}
-
Mario Sanchez Prada authored
Add links to the relevant specs and a test assertion describing its purpose, and do some other minor changes as this test can't be migrated to WPT yet, as it tests Blink/WebKit specific behaviour, unfortunately. Bug: 1063749 Change-Id: I1d4048057c1d3d4585efcb0e326e435181b33bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128080 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755538}
-
Guido Urdaneta authored
This CL wires RTCEncodedAudioFrame to the underlying WebRTC frame. Tests coming up in follow-up CLs that implement the rest of the Insertable Streams API. Bug: 1052765 Change-Id: I833139ad89166673ce48af027879f2755206b5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130551 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#755537}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/994bed549663..845b83053018 git log 994bed549663..845b83053018 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 kylixrd@chromium.org Fixed goma_ctl.bat to pipe to nul instead of creating a file called null. 2020-04-01 sokcevic@google.com Fix git-* commands when using python3 on Win Created with: gclient setdep -r src/third_party/depot_tools@845b83053018 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065582,chromium:1066954 Tbr: agable@chromium.org Change-Id: I0052efb1ebb3b05e63c946176e1d8f4e440b6d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132964Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755536}
-
Natalie Chouinard authored
Bug: 1044401 Change-Id: If8aa24a3c036d4367db12b9b2eeeb682677ae9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132767 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#755535}
-
Viktor Semeniuk authored
Due to new compromised password type i.e. phished and leaked at the same time, sorting should be updated to support showing PHISHED and PHISHED_AND_LEAKED above LEAKED. Bug: 1047726 Change-Id: Ie6776df8fb01d384890bc835ee0a21ef76f3ed70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127367 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#755534}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to flex-item-vertical-align.html. Bug: 1063749 Change-Id: I1828355f072ee6c019de79a7ec0e4dafa4555841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131814 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755533}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/77cb6e24f164..822963b8b8b3 git log 77cb6e24f164..822963b8b8b3 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 cfijalkovich@google.com Merge "Add the mm_event trace event to Perfetto ftrace config" Created with: gclient setdep -r src/third_party/perfetto@822963b8b8b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib22e52a5cacaed117596462024387a24ef5db558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755532}
-
wutao authored
This patch adds the Get/Update Settings APIs so that we can show and update it in the Chrome OS Settings ambient mode page, which will be implemented in a follow up cl. Bug: b/148483925 Test: manual Change-Id: Ia74d875813860a6abbfdc01479a67fed0c029fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125685 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755531}
-
Sorin Jianu authored
base::Bind can now bind __stdcall calls and indirection through lambdas is not needed. Bug: 1053729 Change-Id: Id9381a9370db07319f2e0998827b726a722281c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132932Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755530}
-
Sunny Sachanandani authored
SkiaRenderer renders washed out colors when using PQ color space with a RGB10A2 surface. This happens in M81 because the default color space and buffer format for HDR was changed to PQ and RGB10A2 on Windows. The root cause is that the default PQ SkColorSpace uses normalized luminance values whereas Chrome needs to output scaled values based on the white point. The fix is to construct a PQish SkColorSpace using the scaling factor. This CL includes pixel tests for HDR10 and scRGB linear. The HDR10 test fails before this fix. The HDR10 test is temporarily suppressed due to infra issues causing the test to run on different Windows versions. Bug: 1058580, 1066979 Change-Id: I5a6b91631377a300010d045aaf44a9375d8ffa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109254 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#755529}
-
Dave Tapuska authored
User-Agent isn't currently allowed to be set. Mark the TestExceptations against it. BUG=571722 Change-Id: I66e23de22c0cbf4e47c64a2b1f3b0adae9f5d886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132969Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#755528}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to flex-item-z-ordering-001.html. Bug: 1063749 Change-Id: I36a4329db16e6cb805ada486ebbebe565a66c97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131550 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755527}
-
Varun Khaneja authored
This CL does the following: a) Add a new enum policy to set the Safe Browsing protection level. This policy is called: SafeBrowsingProtectionLevel b) Drops a policy named SafeBrowsingEnhancedProtection This policy never shipped. c) Deprecates an existing boolean policy named: SafeBrowsingEnabled. The new policy in a) has three values: 0 - Safe Browsing gets disabled. This is equivalent to setting SafeBrowsingEnabled to false. 1 - Safe Browsing gets enabled in standard mode. This is equivalent to setting SafeBrowsingEnabled to true. 2 - Safe Browsing Enhanced Protection gets enabled. This CL also adds a handler class called SafeBrowsingPolicyHandler the purpose of which is to map the policy being deprecated (i.e. SafeBrowsingEnabled) and the policy being introduced (i.e. SafeBrowsingProtectionLevel) to the appropriate prefs. For details, please see: go/crsb-safer-chrome-policy Bug: 1066371, 1056483 Change-Id: I37115f04e07ba190504b9cac85c5e0694f4aec12 Fixed: 1066371 TBR: blundell (for '+components/strings/grit/components_strings.h' DEPS) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129284 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#755526}
-
Sam Bowen authored
Change-Id: Iecdfb6d697c1aa070618ebe3d9e8d476f746cbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132675 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#755525}
-
Liviu Tinta authored
The 2 tests were failing on wpt.fyi because the coordinates passed to Actions.pointerMove were not integers (like on local run). Since Actions.pointerMove expects integer coordinates, the tests were failing with an exception. Use Math.ceil on coordinates passed to Actions.pointerMove. Apply memory leak fix. Bug: 810882 Change-Id: I399f763fa03ebd98167fd060ad1769e8dd7f9d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132950 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#755524}
-
Gary Kacmarcik authored
BUG: 961064 Change-Id: I14020da7f64f1cc5dd14b4ca89340d554031a82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130486 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#755523}
-