GitLab

new-style WebAPKs have a different activity architecture than old-style
WebAPKs. new-style WebAPKs stack TransparentSplashWebApkActivity (which
runs in Chrome) on top of the SplashActivity (which runs in the WebAPK).
The SplashActivity keeps running till TransparentSplashWebApkActivity
finishes itself.

In order for tapping the app icon of an already running new-style
WebAPK to activate the already-running WebAPK instead of relaunching
the WebAPK, SplashActivity must be running.

This CL:
- Changes the first run experience to send an intent to relaunch the
WebAPK when the user completes the FRE. Previously,
TransparentSplashWebApkActivity was launched when the user completes
the FRE.
- Changes TransparentSplashWebApkActivity not to be singleTop. If
TransparentSplashWebApkActivity is singleTop,
FirstRunFlowSequencer#launch() triggers
TransparentSplashWebApkActivity#onNewIntent() when it relaunches the
activity with FLAG_ACTIVITY_NEW_TASK

BUG=911420

Change-Id: I1a0d648502e525ec133cfb2ef35c9fb2b5afca53
Reviewed-on: https://chromium-review.googlesource.com/c/1367187
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616119}

This change finishes plumbing of device connection events from the devices
to the browser, and fixes handling in the WebXR implementation.

Bug: 789620,778041
Change-Id: Iba9999c0b021261df23add4d1bb2826bd0764ed4
Reviewed-on: https://chromium-review.googlesource.com/c/1364332
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616118}

They are passing consistently (modulo the filter file).

BUG=905430

Change-Id: I2b8fe7cc40e77505eb19e15d41f304b944501f87
Reviewed-on: https://chromium-review.googlesource.com/c/1373874Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616117}

Using wpt-import in Chromium 5879d69c.
With Chromium commits locally applied on WPT:
6e2a70e4 "Reland "Fix SVG-As-Background sizing""
8bb5e943 "Add WPT to verify that 1XX responses are used to provide responseStart timing"
618e62b5 "Align resource timing buffer full processing to spec PR 168 (take 3)"
1c633d48 "Snap the snapped_dest_rect for backgrounds"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I4ae318db56fa23e5a4804552042f5ab200326351
Reviewed-on: https://chromium-review.googlesource.com/c/1374733Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616116}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e76041196062..3d7ef65eef5b


git log e76041196062..3d7ef65eef5b --date=short --no-merges --format='%ad %ae %s'
2018-12-12 mrunal.kapade@intel.com Revert "httplib: Update to 0.11.3"


Created with:
  gclient setdep -r src/third_party/depot_tools@3d7ef65eef5b

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:891505
TBR=agable@chromium.org

Change-Id: Id8af6e42142d9afa2799ec48d998ee28b020304b
Reviewed-on: https://chromium-review.googlesource.com/c/1374532Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616115}

Change-Id: Iad8b0ec1ef4548b2d0cdb684f768bd14d24f9871
Reviewed-on: https://chromium-review.googlesource.com/c/1374355Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616114}

This reverts commit 0ba5ea12.

Reason for revert: Breaks win-rel build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/7800

Original change's description:
> allocator: Add Windows _aligned_* shims
> 
> On Windows we don’t currently hook the _aligned_* allocation APIs, this
> can cause issues because _aligned_realloc can call HeapSize and cause
> GWP-ASan crashes similar to bug 909720. Unfortunately the
> _aligned_realloc API is different enough that it can not be implemented
> using the standard POSIX shims, in particular because _aligned_malloc
> and _aligned_free don't return valid allocation addresses, they are
> offsets into allocations.
> 
> I add new Windows platform-specific shims for _aligned_malloc,
> _aligned_realloc, and _aligned_free and wire them in for all users of
> the allocator shims. I implement these routines on top of the Windows
> Heap* API and leave uncommon _aligned_* shims to crash to ensure that
> any future uses immediately surface why their use fails.
> 
> Bug: 912500, 896019
> Change-Id: Ieaa50b816ab277a6ad4b80ee8519027343fa9878
> Reviewed-on: https://chromium-review.googlesource.com/c/1367485
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616106}

TBR=danakj@chromium.org,chrisha@chromium.org,primiano@chromium.org,alph@chromium.org,erikchen@chromium.org,wfh@chromium.org,siggi@chromium.org,vtsyrklevich@chromium.org,vitalybuka@chromium.org

Change-Id: Ie9e3246f3a70985cef38263e22f8f86a62002b22
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 912500, 896019
Reviewed-on: https://chromium-review.googlesource.com/c/1374909Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616113}

Update network quality based params in resource scheduler every
time there is a change in network quality.

Also, remove NQE (network quality estimator) integration with the
deprecated method DeprecatedOnNavigate() since that method
is going away soon.

Note that this CL does not do a full cleanup which is going to
happen in subsequent CLs.

Change-Id: Id081e6a6aa872235301a6f3e0cc5ac7beb0e8584
Bug: 913980
Reviewed-on: https://chromium-review.googlesource.com/c/1372055
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616112}

Additional CLs have landed that resolve the memory leak in
views_mus_unittests detected by LSAN.

Original description:
>AXTreeSourceAura doesn't exist any more. The tests exercise the
>integration of AXRootObjWrapper with AXTreeSourceViews, so rename the
>tests ot AXTreeSourceViewsRootTest.
>
>Note that the tests lived in //chrome/browser/ui/ash. If we need an
>ash-specific tree source we could introduce an AXTreeSourceAsh either
>in //ash (for mash) or //chrome/browser/ui/ash (for SingleProcessMash).
>
>Bug: 910672
>Test: views_unittests
>Reviewed-on: https://chromium-review.googlesource.com/c/1358972
>Reviewed-by: David Tseng <dtseng@chromium.org>
>Commit-Queue: James Cook <jamescook@chromium.org>
>Cr-Commit-Position: refs/heads/master@{#613308}

TBR=dtseng@chromium.org

Change-Id: Id4dc9b6dd7bedffb6cc1184ac0c1f1e36f51ffc1
Reviewed-on: https://chromium-review.googlesource.com/c/1362193Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616111}

Bug: 879856
Change-Id: Ia0e3da7202f58504d4f6320ea7e817ce24c61269
Reviewed-on: https://chromium-review.googlesource.com/c/1370233
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616110}

The tests were timing out because they would bring up the first
run dialog, which blocks user input and prevents the tests from
continuing.

This CL fixes the tests by suppressing the first run dialog for
the master prefs using a new ForTesting API. Also removes the
kForceFirstRunDialog command-line in favor of the new testing API.

Also cleans up some namespaces in the test code.

Bug: 314221, 910059
Change-Id: I3a366e49c9a115747fe42848146c81c5df8fffee
Reviewed-on: https://chromium-review.googlesource.com/c/1372427
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616109}

https://chromium.googlesource.com/catapult.git/+log/ebff6e2b3d0a..296353761198


git log ebff6e2b3d0a..296353761198 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 lwsong@google.com Split metrics_visualization into two files


Created with:
  gclient setdep -r src/third_party/catapult@296353761198

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia79c341524b8c7eaad6cc6ea14b982ad64e8679d
Reviewed-on: https://chromium-review.googlesource.com/c/1374143Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616108}

In AudioParamTimeline::HandleCancelValues() function, the code expects
the |saved_event| pointer from the next event to be non-null. There are
corner cases where this is not true.

Adding one more check on the saved event pointer fixes the crash.
Locally confirmed the attached web test crashes without this fix.

Bug: 913217
Test: webaudio/AudioParam/cancel-values-crash-913217.html
Change-Id: I4760b939534ef92a2475087540e17c8abc784b3b
Reviewed-on: https://chromium-review.googlesource.com/c/1374492Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616107}

On Windows we don’t currently hook the _aligned_* allocation APIs, this
can cause issues because _aligned_realloc can call HeapSize and cause
GWP-ASan crashes similar to bug 909720. Unfortunately the
_aligned_realloc API is different enough that it can not be implemented
using the standard POSIX shims, in particular because _aligned_malloc
and _aligned_free don't return valid allocation addresses, they are
offsets into allocations.

I add new Windows platform-specific shims for _aligned_malloc,
_aligned_realloc, and _aligned_free and wire them in for all users of
the allocator shims. I implement these routines on top of the Windows
Heap* API and leave uncommon _aligned_* shims to crash to ensure that
any future uses immediately surface why their use fails.

Bug: 912500, 896019
Change-Id: Ieaa50b816ab277a6ad4b80ee8519027343fa9878
Reviewed-on: https://chromium-review.googlesource.com/c/1367485Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616106}

This is part of changes which put as goal removing redundant ChromeAnimation API by moving everything into CompositorAnimator.

Public doc with proposal: https://docs.google.com/document/d/1VL5ntE7vn267IFjE4Zke0GkhVVTHz1bEP672Apj_E2k/edit

This concrete patch is moving default interpolators.

BUG=890643

Change-Id: I162eb117a1989fe78ad400222922652520d5e292
Reviewed-on: https://chromium-review.googlesource.com/c/1359033Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#616105}

Bug: 914180
Change-Id: I4a6fe2c4b984ea6f1aad596a53102b66d08c73d0
Reviewed-on: https://chromium-review.googlesource.com/c/1373014Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616104}

CL uses IdentityManager API instead of using the soon to be
private ProfileOAuth2TokenService and SigninManage APIs.

BUG=903862

Change-Id: Icb817cd1110d777b3cc2ceb8a4888ffe83d93abb
Reviewed-on: https://chromium-review.googlesource.com/c/1372425
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616103}

Bug: 717812
Change-Id: I33dd0fda6b109fbc822e784b3aa490cedef401ca
Reviewed-on: https://chromium-review.googlesource.com/c/1364302
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616102}

This CL moves the data store and store client from bookmarks into cr.ui
and makes them generic so that they can be used by other pages.

Bug: 906508
Change-Id: I578a3e0b308b1d21ad412cf8be7e08db3b402469
Reviewed-on: https://chromium-review.googlesource.com/c/1369444
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616101}

Bug: 824834
Change-Id: I3fd1204a9ad03033d5f7c27d78b8a5a34b6edd92
Reviewed-on: https://chromium-review.googlesource.com/c/1319859Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616100}

Bug: 912767
Change-Id: I872e6809c4bf8af1d68f4e59cd43ff475958db2a
Reviewed-on: https://chromium-review.googlesource.com/c/1370906
Commit-Queue: Suman Kancherla <sumankancherla@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616099}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/17b5749fc223..f70b3cf774f4


Created with:
  gclient setdep -r src-internal@f70b3cf774f4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I65ceede73d897b75ed2d8131ccdbc70fa635e2d1
Reviewed-on: https://chromium-review.googlesource.com/c/1374749Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616098}

Those MediaPlaybackOptions will be cached by RenderFrame and passed to
WebMediaPlayer upon creation, instead of going through WMPIDelegate.

Bug: b/119424112
Change-Id: Ib5c5909e6667cb29a2bb480f710ee6a46e969f97
Reviewed-on: https://chromium-review.googlesource.com/c/1368756Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616097}

And switch to the default of 1hr.

R=aluo, jbudorick

Bug: 907899
Change-Id: I0402ee6350594b6149f9ba95f0822eed0f438b2f
Reviewed-on: https://chromium-review.googlesource.com/c/1374523Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616096}

https://pdfium.googlesource.com/pdfium.git/+log/e79ad68b2984..4c91b17ead5c


git log e79ad68b2984..4c91b17ead5c --date=short --no-merges --format='%ad %ae %s'
2018-12-12 tsepez@chromium.org Return ByteStringViews from xfa_basic_data.cpp functions.


Created with:
  gclient setdep -r src/third_party/pdfium@4c91b17ead5c

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I5415f9e23ecb4373f4b5f39a117e34efc344359b
Reviewed-on: https://chromium-review.googlesource.com/c/1374144Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616095}

Also update all the callers and adapt the unit tests to stop using a custom
FakeSigninManagerBase and PO2TS, using IdentityManager and related test
utilities (e.g. IdentityTestEnvironment, PrimaryAccountMutator) instead,
so that the actual code being ported to can be tested. This means that
the STATUS_CASE_AUTHENTICATING case can't be tested anymore for ChromeOS,
but hopefully that should not be an issue since ChromeOS doesn't support
signin-in/out the primary account anyway.

Bug: 890796
Change-Id: Iadcb5440eef126a801dd6c0cd145cbbe0bfb0b6d
Reviewed-on: https://chromium-review.googlesource.com/c/1362902Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#616094}

Remove RenderWidget::WidgetType, replace it with for_frame(), which can
derive an answer from the presence of owner_delegate_ (for a main frame)
and for_child_local_root_frame_ (for sub frames).

This changes pepper plugin widgets from being considered frames to not,
which seems okay. One piece of code wanted to run only for popup widgets
but its in SetWindowRect which is not used on the pepper widget.

Remove use of IsWebView() and IsWebFrameWidget() on the WebWidget from
RenderWidget. Instead use for_frame() or its derivative parts.

We want to stop checking for the presence of a WebFrameWidget and drop
IPCs early when a RenderWidget is frozen, but there's one bug that
prevents that still as the Frame (and FrameWidget) can be detached
without freezing the RenderWidget (crbug.com/906340#c7).

R=ajwong@chromium.org, avi@chromium.org

Change-Id: I83589e2b0cf5a4c68dde77eaae87404ba1de4cc0
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1373887
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616093}

Previously, the transition column displays the enum's integer representation.
The 'generated' and 'typed' transition values are most common, adjusting the
transition column width to 70px (from 60px) allows these values to be displayed
without eliding.

Bug: 891303
Change-Id: Ic356e9f89541e22fa1cdfd54959a444d0cab6836
Reviewed-on: https://chromium-review.googlesource.com/c/1374489Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616092}

Change-Id: Iee0486cc74130e4b28f60cf9ed9fbddca915e7e3
Reviewed-on: https://chromium-review.googlesource.com/c/1374330
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616091}

Commit 3f40244c had to be reverted due to a
data race between ScopedFeatureList's destructor and a feature in the scheduler.
Sample failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/30398
There is no need for the feature list to be restored with ScopedFeatureList in
the test launcher. Since the scheduler used for test launcher is leaked,
it makes sense to have a singleton feature list instead of a ScopedFeatureList.

Bug: 847501, 846380
Change-Id: I738ebebe5aa04871427399bcf012c072d7f0212c
Reviewed-on: https://chromium-review.googlesource.com/c/1361441
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616090}

This feature breaks pages and doesn't help users save much data
anymore. See bug for more detail.

This CL removes all references to the integration in UMA, Blink,
WebPrefs, and the Android UI.

Bug: 905095
Change-Id: Id6a6a149ffa98f461c892948d5570e5543973ae8
Reviewed-on: https://chromium-review.googlesource.com/c/1363790
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616089}

* Add UsageStatsService, the public interface for usage stats
* Add EventTracker, which allows addition and time range queries
of usage events
* Add TokenTracker and SuspensionTracker, which track token mappings
and suspensions, respectively

Bug:902574, 902499, 902496, 902494

Change-Id: I9831c03d78d90bbd301810bb2df36fd51ba2764e
Reviewed-on: https://chromium-review.googlesource.com/c/1354349Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616088}

This CL uses a console warning instead of error when entryTypes is
invalid, which aligns our implementation with the spec and fixes a
test in Performance Timeline. It also removes a stray .expected file.

Bug: 898791

Change-Id: Ie0a0eb0ab4889a062258aab0f3fd967191f1f430
Reviewed-on: https://chromium-review.googlesource.com/c/1374168Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616087}

This adds possibility to enable/disable ARC and to view ARC storage
usage in case disable-arc-opt-in-verification. This was primarily used
in test before and now is used by some ARC devs for feature
prototyping.

TEST=Manually, corresponded sections appear in settings and work as
     expected.
BUG=b:120556416

Change-Id: I959bcabd729b76e6aa446d1fd85fe6c2b5f5660b
Reviewed-on: https://chromium-review.googlesource.com/c/1374433Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616086}

Change-Id: I88e07b203bf6aca6a62097256c90f1c35ad373f7
Reviewed-on: https://chromium-review.googlesource.com/c/1368840Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616085}

Remove a key from the pressed keys map in the DidProcessEvent call as
in addition to the existing removal in OnKeyEvent. When IME is
active, then sometimes DidProcessEvent gets invoked before OnKeyEvent,
and when that happens we end up with a stuck key in the pressed keys
map.

Bug: 840155
Test: exo_unitests --gtest_filter=SeatTest.PressedKeys
Change-Id: I54bbaaeb5656b4ece8cd10f8b5f7065ddad33813
Reviewed-on: https://chromium-review.googlesource.com/c/1373010
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616084}

Bug: 900941, 902904
Change-Id: I1b374fe1efd9c0612fc6f42a84eefd8bc3b1e320
Reviewed-on: https://chromium-review.googlesource.com/c/1370189
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616083}

This fixes the GCC build after eebbd7f6 ("Introduce
base::trace_event::TraceArguments helper class"):

    ../../base/trace_event/trace_event_impl.cc:61:1: error: function ‘base::trace_event::TraceEvent::TraceEvent(base::trace_event::TraceEvent&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
     TraceEvent::TraceEvent(TraceEvent&& other) noexcept = default;
     ^~~~~~~~~~
    ../../base/trace_event/trace_event_impl.cc:62:13: error: function ‘base::trace_event::TraceEvent& base::trace_event::TraceEvent::operator=(base::trace_event::TraceEvent&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
     TraceEvent& TraceEvent::operator=(TraceEvent&& other) noexcept = default;
                 ^~~~~~~~~~

With GCC, having that noexcept marker requires all members to be marked
with noexcept themselves, and StringStorage was missing it.

clang is fine because we pass -fno-exceptions and it disables the same error
there, while GCC continues to raise it (bug 843143 and its corresponding CL
have a longer discussion on this issue).

Bug: 819294
Change-Id: Ie2eba30dcb6d4a5f9cc1b4b7c961af96d9f55f10
Reviewed-on: https://chromium-review.googlesource.com/c/1374230Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#616082}

Change-Id: I26447006b81184d805527dc3c41bffd1ccf72a59
Bug: 850624
Reviewed-on: https://chromium-review.googlesource.com/c/1374518
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616081}

This animation was removed unintentionally, this CL brings it back.
Also added better comments so the animation's importance is more
obvious.

Bug: 910496
Change-Id: If505bea1683d7ae456dcedbdb0a9e97ea58e02de
Reviewed-on: https://chromium-review.googlesource.com/c/1368604Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616080}