- 28 Jul, 2020 40 commits
-
-
Alex Ilin authored
This reverts commit 596311e0. Reason for revert: causes flakiness in ErrorPageReloadBrowserTest.ReloadOnNetworkChanged test, https://crbug.com/1110192 Original change's description: > [WebLayer] Use NetErrorAutoReloader > > Navigations which fail with network errors may attempt to > auto-reload in some cases, in order to more seamlessly recover > from transient failures. > > This behavior was previously implemented renderer-side and copied > verbatim from Chrome. The Chrome implementation has been moved > browser-side (see bug for why) and also made into a reusable > component. > > This changes WebLayer to use the same component implementation > and deletes all the corresponding renderer logic. > > Fixed: 1098578 > Change-Id: I10c337abcae36f64be47f31b89e36c7393989077 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311371 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792028} TBR=jam@chromium.org,rockot@google.com,cduvall@chromium.org Bug: 1098578, 1110192 Change-Id: I7b05267e5bc9c13528607bebfa35beb485b0c965 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323150Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792215}
-
arthursonzogni authored
The [window.idl] defines CrossOrigin indexed and named 'getter', but it doesn't define their 'setter' counterpart. As a result, we should remove test for them. They were added in excess. [window.idl]: third_party/blink/renderer/core/frame/window.idl Bug: chromium:1090273 Change-Id: I31fb77c65b82fef3d6f44297bfa63a331a9e1b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315694Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792214}
-
Anders Hartvoll Ruud authored
MatchingStyles can apparently be called from from within probe:: AnimationPlayStateChanged. Updating style synchronously here means that new animations can start (via CSS animations). The animations team wants to prohibit starting/updating animations from within the probe call (see bug for details). Therefore we must avoid recalculating style here, since that _may_ trigger new/updated animations. As it happens, we don't actually need to recalculate the style, since this function is only matching selectors. It's sufficient to UpdateActiveStyle() instead, which ensures that information needed for selector matching is up-to-date. Fixed: 1106539 Change-Id: I75eb10ee1792f78ca1e5d44e42a63974af55162a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317795Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#792213}
-
arthursonzogni authored
If we don't, then a crash will happens when whenever the user tries to restore a tab on a URL using Cross-Origin-Opener-Policy-Report-Only (COOPRO). A test depending on this patch will be added on this branch. The current code is still potentially incorrect. Some TODO are added. Bug: chromium:922191 Change-Id: I10c2e08daf3aff3b3de7ee6c0eee90b1f3e777c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317964Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792212}
-
arthursonzogni authored
Run the CrossOriginOpenerPolicyBrowserTest with and with the BackForwardCache. There is one failing test: VirtualBrowsingContextGroup.HistoryNavigation failing. Bug: chromium:1102285,chromium:1109648 Change-Id: I473f559af095069236e80da9849f6fcf6c26b4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317959 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792211}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: If38556a36f3a3145c7ead239dac22797585cc7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322172Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792210}
-
Boris Sazonov authored
Removes ChromeSigninController.get().setSignedInAccountName(null) from IdentityManagerIntegrationTest. Almost all code that was using ChromeSigninController has been migrated to IdentityManager, so resetting sign-in state in this test is no longer necessary. Bug: 1046412 Change-Id: Ibafb9acc8de1ea16d305898d21ac9689787851bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316163Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792209}
-
Maksim Sisov authored
We don't have a fuzzer bot for ozone running and that's why we failed to spot when the fuzzer became broken. However, given that I started to enable use_x11 && use_ozone at the same time, the linux-libfuzzer-asan-rel started to compile the wayland fuzzer, and that revealed some compilation problems. This CL fixes that. The design of initialization of the test env was taken from other fuzzer tests. For example, ui/gfx/render_text_fuzzer.cc Bug: 578890 Change-Id: I1517731dc531cb48934cbdbd35023adea818c7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322706Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#792208}
-
Anatoliy Potapchuk authored
Previouisly, in case of failure to download the terms of service, we were saying "Something went wrong" without a chance for user to redownload the ToS in case they are under flaky network. This cl makes the text on that screen more verbose and adds "Retry" button. Bug: b/156695308 Change-Id: Idd934bcd7572732d2b5b03f8b43c8fd937121ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316202Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#792207}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/8cfc41ae955d..53be1753dea9 2020-07-28 priyeshkkumar@gmail.com Fix `-Wformat' compiler warnings. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ie49cc5010e1466e845d203393aad9ecb478f7306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322076Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#792206}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e8ccc7d7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I71d516c685e96951a2800b8828edd259f10e4460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321452Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792205}
-
Carlos Caballero authored
Make sure we never show a prompt on behalf of a page that is not current for example because it was moved to the back forward cache. For that we need to associate all requests with the originating frame (RenderFrameHost). Before we actually show the prompt we check whether the frame still exists (could have been deleted) and is current. If that is not the case we just cancel the request. This is an extra safeguard on top of what is already done in PermissionRequestManager::DidFinishNavigation, which only clears queued requests at the time of the navigation commit, but does not prevent us from accepting requests after that. Ideally we would not cancel those queued requests but store them on the side in case the frame becomes current again (gets out of the cache). Change-Id: Ib7eaa6b935b96cfe76d9f8cbcd7a3712900855fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307212 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792204}
-
Tim Schumann authored
This reverts commit b9f1aa01. Reason for revert: Suspected to break ProactivelySwapBrowsingInstancesSameSiteTest BUG: 1110281 Original change's description: > Reuse process on history navigations between same-site cross-BI pages > > See crbug.com/1096135 for context. When doing same-site navigations, we > might do a proactive BrowsingInstance swap, but we will reuse the > renderer process whenever we can. On history navigations between pages > that are same-site but have different BrowsingInstances (not only on > cases that are caused by proactive BI swap), we should try to reuse the > renderer process. > > Bug: 1096135 > Change-Id: I58f72bedecbbf94e4e05218bb9c15970a502d8a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282553 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792195} TBR=creis@chromium.org,alexmos@chromium.org,rakina@chromium.org Change-Id: Ibb0391564b89172e0c1080a8efad014b1243886a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1096135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322626Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#792203}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595807480-d17b0499af342f0654e8c059a08be3424e0d8a06.profdata to chrome-win64-master-1595894324-3cfde226a7530b6c961e3b6919ae369552837a05.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4473c0aaee139cbcf0ba4319be05e971ce739ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322068Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792202}
-
Andrei-Laurențiu Olteanu authored
Fix untrusted typo. Bug: b:162261251 Change-Id: Ib477041a7e97b6c4992cc6ef48f354062e7b923a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320610Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#792201}
-
Hwanseung Lee authored
there is unnecessary if statement. because always same code execute regardless of if statement expression. so remove it. Bug: None Change-Id: Ifd921cc0c965cd3249f28a001d9bc633f56bd46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321908 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#792200}
-
Maria Kazinova authored
Bug: 1075444 Change-Id: I229f5ca4c20bae2d4dda248d88bd80002b960a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320269 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#792199}
-
rajendrant authored
This CL adds API to stop the throttling which resumes the paused media responses immediately. Subsequent CL will make use of this to stop throttling on video play stalls. Bug: 1082554 Change-Id: I51137a1158e8aed8bd63e7a6db344aefe94a6720 TBR: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309005 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#792198}
-
Tim Schumann authored
These tests are flaky on multiple platforms: NoAutoReloadWhenContentsHidden AutoReloadWhenContentsBecomeVisible BUG: 1110259 TBR=rockot@google.com Change-Id: I2d59b5464a5ff12edb1c66df593b169039378dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320792 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#792197}
-
Jérôme Lebel authored
Adding APIs declaration to support multi windows with SSO. For ChromeIdentityService: bool HandleSessionOpenURLContexts(UIScene* scene, NSSet*) void ApplicationDidDiscardSceneSessions(NSSet*) => crrev.com/c/2316308 API declarations * crrev.com/i/3182384 Implementing APIs * crrev.com/c/2317321 Switching code to use the new APIs Bug: 1103833 Change-Id: I28b5f6c98c23d9c1424500816bf713756bab4c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316308Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#792196}
-
Rakina Zata Amni authored
See crbug.com/1096135 for context. When doing same-site navigations, we might do a proactive BrowsingInstance swap, but we will reuse the renderer process whenever we can. On history navigations between pages that are same-site but have different BrowsingInstances (not only on cases that are caused by proactive BI swap), we should try to reuse the renderer process. Bug: 1096135 Change-Id: I58f72bedecbbf94e4e05218bb9c15970a502d8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282553 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792195}
-
Ren-Pei Zeng authored
crrev.com/c/2234684 introduces a new buffer usage flag for hardware VEA (SCANOUT_VEA_READ_CAMERA_AND_CPU_READ_WRITE). On Kukui this changes buffer layout, and the camera driver failed to capture correct content into the buffer in the RAW->YUV reprocessing case. Since the reprocessing YUV buffer is not used for video encoding, this CL changes the buffer usage for that use case back to the original (SCANOUT_CAMERA_READ_WRITE). This CL also cleans up places that hard-code buffer usage, or makes it verbose when it has to do so. Bug: 1105154 Test: capture_unittests Test: CCA preview, video recording, take normal/Portrait photo (with #zero-copy-video-capture flag on and off) Change-Id: I1c3d88f361faad43994fbf6fedc9514de7947366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315725Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792194}
-
Ian Kilpatrick authored
When we had a column flex-item, which was also a grid, where the percent template added up to something >100% on each layout the grid would grow larger. This was caused by some logic to fix relative-positioned children in: https://chromium-review.googlesource.com/c/chromium/src/+/2093273 However when this value was read within layout, it could refer to the previous layout. If numerous layouts occurred sequentially, this would cause the layouts to grow unbounded. This patch disables this path when read during layout for a flex-item (in NG). During layout the flex-item should have a BoxLayoutExtraInput set. Bug: 1108928 Change-Id: I4d0d41755c9d33eb2b4c217ee6bfdb1acd48cbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320418Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792193}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id05e6144b0686b0dfa421f20a38e9dda128947f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792192}
-
Tymofii Chudakov authored
This CL fixes the bug in the security_page.html of the chrome privacy settings with the automatic option collapsing while the confirmation dialog pops up. An additional flag is added to the collapse_radio_button.js which disables automatic collapsing. Bug: 1096968 Change-Id: I0dcc56d9ab6f2649ad6e707edbbb631803685c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294802Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792191}
-
Ravjit Singh Uppal authored
Bug: 1096944 Change-Id: If9f17a927771731f8c009a724a3e34d84f73fadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299629 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792190}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3038f8cb5c5..6007f3bd6f36 2020-07-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3f851efa2adc to de309a42385f (16 revisions) 2020-07-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3b2cd31c7400 to 12c9d4ac61f2 (4 revisions) 2020-07-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from d5a4775cfc77 to c11a19145f1f (3 revisions) 2020-07-28 johnstiles@google.com Fix self-assignment error in SkBitSet. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1085700 Tbr: borenet@google.com Change-Id: If9cba9059a5f859a3d27ab3d28960be4f15c3d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322078Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792189}
-
Jan Wilken Dörrie authored
This change modifies the invoke(), begin() and end() function to be constexpr in //util/ranges. This allows making some of the algorithms constexpr as well, which is done in this change for all_of, any_of and none_of. Bug: 1071094 Change-Id: Ic72a5287dfa4623342e5ef5f592b19040797def7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316211 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792188}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/android/signin. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=bsazonov@chromium.org Bug: 1106699 Change-Id: Ifa14602b1dab9f9c965e7e4dd55fac20f5cd68d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315154 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792187}
-
Christopher Lam authored
This CL moves the centralized style sheet to ui/chromeos/colors since it's being used for Views as well as WebUI. A new chrome://resources alias was added so the file can be accessed through chrome://resources/chromeos/colors/cros_colors.generated.css. Bug: 1018654 Change-Id: If7fb5c0aed3fa30746df32587e818a4f420ba49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306140Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#792186}
-
Steve Anton authored
Bug: 1108472 Change-Id: Ifd5c26736460b3c9f615f99a5abaf909a81b6618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321847 Auto-Submit: Steve Anton <steveanton@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792185}
-
Tim Schumann authored
This reverts commit 9c96261a. Reason for revert: This appears to have broken external/wpt/html/cross-origin-opener-policy/reporting/access-reporting/openee-accessed_openee-coop-ro.https.html BUG: 1110254 Original change's description: > [COOP] Access reporting. Fix the python server. > > A python server is used has a communication channel in between documents > from different browsing context group and potentially cross-origin. > > There are two methods: > - one for writing a message. > - one for reading the message. > > I initially supposed we won't need to store more than one message in the > stash. It turns out there are tests doing two write in a row without any > read in the middle. It was throwing an exception when this > happened. > > This patch makes the server to maintain a queue of messages instead. It > doesn't throw errors anymore. > > Bug: chromium:1109194 > Change-Id: I25f8dc2c2a032781a4527a0994e94e46f85e12c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317865 > Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791901} TBR=clamy@chromium.org,arthursonzogni@chromium.org,pmeuleman@chromium.org Change-Id: I87ba2caa07f80f42aa549929ade392485b968d6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1109194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320572Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#792184}
-
Himanshu Jaju authored
IncomingShareTargetInfo is used to encapsulate remote device connection details, and IncomingFramesReader is used to read incoming frames from this target. Supports timeout for reading frames as well as cache for unused frames. Bug: 1085068 Change-Id: I94d6f6453031f1c3172d4fecc7370ca15b0c37c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306032 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#792183}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0dde0b31cf31..1ed85887c9ec 2020-07-28 kahinds@microsoft.com Detect URL-only strings in localizability check script If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iea3b3b7327a12caf7c775321b039a58ff339d141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321955Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792182}
-
Zufeng Wang authored
The pref was registered and set in https://chromium-review.googlesource.com/c/chromium/src/+/2294861/20/chrome/browser/chromeos/first_run/first_run.cc Bug: b/159964708 Change-Id: I5daf159e84fa3ec5ce8a70c95098155a199e8f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321987Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#792181}
-
Gauthier Ambard authored
This CL makes sure to check that there isn't a first responder before setting BVC as first responder. The omnibox can be the first resonder at that point when opened from 3D touch. Fixed: 1103635 Change-Id: I901bebd33ceced169d9848ca8c785d5ef8913ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315035 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#792180}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bdb4051. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I0aa18efc4e8cfc293de2103755faa42d9f6f8abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321451Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792179}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Id381b1f99a320fbf7c5ce121460dd08736ed1e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321947Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792178}
-
Keith Lee authored
The committed text length will be used by InputMethodChromeOS to determine the number of characters committed by users. Bug: 1109604 Change-Id: I476539fc38f35f3986a9a05de22f7b8fa9ecd0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318892 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#792177}
-
Hitoshi Yoshida authored
This reverts commit 414b62b0. Reason for revert: Regresses a test on Mac. Bug: 1110239 Original change's description: > Set initial focus on session restore > > Issue: > - When On startup setting is set to "Continue where you left off", > the initial focus is not set after launching the browser. > - Users have to press Tab to focus the window. > - This affects users who rely on screen readers since the window > information is not announced on launch (on UIA mode). > > More context: > - The line calling SetInitialFocus was previously in the code but got > removed after a startup focus refactor: > https://chromium-review.googlesource.com/c/chromium/src/+/1313728 > - The refactor added the call to RestoreFocus on > BrowserView::OnWidgetActivationChanged if the property > restore_focus_on_activation_ is set to True. This property gets set > during BrowserView::Show, but only in the case of session restore, > Show gets called after OnWidgetActivationChanged so RestoreFocus is > never called. > - The inverted call stack on session restore is because AddRestoredTab > on browser_tabrestore calls Activate before showing the window. > > Fix: > - Similar to what we currently have for MacOS, only call Activate > in AddRestoredTab if it is not |from_session_restore|. This way Show > will be called before Activate and thus focus will be set as > expected. > - This change is only made on Windows due to a couple of reasons > 1) crbug.com/1102685 is only present on this platform. > 2) Making this change on Linux would re-introduce crbug.com/1019048. > > Bug: 1102685 > Change-Id: I6e62ebad7693eb5d908770364ba7c8d755ccaa70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284382 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Maria Villarreal <mavill@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#791950} TBR=xiyuan@chromium.org,sky@chromium.org,fdoray@chromium.org,mavill@microsoft.com Change-Id: I258891124447cb71b163b35452b84b999857cf96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322266Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#792176}
-