- 31 Oct, 2018 40 commits
-
-
Jered Gray authored
Standardize ordering of getters and setters, add const to getters, use explicit with single parameter constructor, and use getter/setter underscore naming convention. Change-Id: I2cba0a3fa317527e1699f1544c7cb184b773f55e Reviewed-on: https://chromium-review.googlesource.com/c/1310558Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Jered Gray <jegray@chromium.org> Cr-Commit-Position: refs/heads/master@{#604433}
-
Ahmed Fakhry authored
In preparation for the VDs work, I noticed some code we can simplify, or needed only for DCHECK, which turned out we can remove completely. BUG=866622 Change-Id: I676194493d263213c0fdd621134dda4efabc408d Reviewed-on: https://chromium-review.googlesource.com/c/1303354 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#604432}
-
Ken Rockot authored
A CHECK was added to disambiguate certain large IPC cases from others. The gist is that BigBuffer fields attempt to use shared memory, but fall back on inlined data when shared memory allocation fails. This can result in oversized IPC messages being sent and causing intentional crashes. This CL removes the CHECK in favor of sending an invalid BigBuffer (tagged with a special union field) in cases where shared memory allocation fails and we think the message is too large to fall back onto inline encoding. The deserialization traits for BigBuffer and BigBufferView will always reject such invalid BigBuffer encodings, resulting in an interface error. Also updates RenderFrameImpl to tolerate its ClipboardHostPtr seeing errors as a result of this validation failure mode. Bug: 900113 Change-Id: Ia66e9cee00819f0d61e198051b53a35c5150b399 Reviewed-on: https://chromium-review.googlesource.com/c/1308095 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#604431}
-
Mitsuru Oshima authored
This reverts commit a9fdf9b7. Reason for revert: due to null reference. I'll revert and land new one with fix to make merge easier. Original change's description: > Overview optimizations > > * Pause occusion tracker during overview animation > * Activate the text filter after animation > * Don't animate backdrop window during overview animation. > * Fix the bounds change issue in WindowGrid. It shouldn't change > the parent window's bounds. > > in both clamshell and tabletmode. > The web contents should load after animations without backdrop animation. > No gap at the bottom of the screen after exiting overview mode. > > Bug: 898077, 897387 > Test: no functional change. Manually tested visual change by entering/exiting overview mode > Change-Id: I60c2709c5394a565bae6d0c4bfdd7006e2e76496 > Reviewed-on: https://chromium-review.googlesource.com/c/1304973 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604206} TBR=oshima@chromium.org,sammiequon@chromium.org Change-Id: Ied4ce4d12abc962bffead6e22bbd7e2a837ad544 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898077, 897387 Reviewed-on: https://chromium-review.googlesource.com/c/1311793 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#604430}
-
Harley Li authored
Hoist this button upward so that a user no longer needs to scroll down to find it if the console is docked at the lower half of the Application panel, providing convenience and less confusion to first-time users. Bug: 825132 Change-Id: I6808695c1c3e00d92553e221169b9d76a2791b2e Reviewed-on: https://chromium-review.googlesource.com/c/1306412 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604429}
-
Morten Stenshorne authored
Previous rebaseline-cl attempt in https://chromium-review.googlesource.com/c/chromium/src/+/1309653 produced something that one Windows bot doesn't like (missing expectations): https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win10-blink-rel/1873 TBR=atotic@chromium.org Bug: 591500, 900469 Change-Id: I9159aecc9efc8a4b13d8956cadcbfa0d5fc9ab7f Reviewed-on: https://chromium-review.googlesource.com/c/1310993Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#604428}
-
Fernando Serboncini authored
- AcceleratedStaticBitmapImage was misusing ThreadChecker by having its own detach logic. Using proper DetachThread is simpler, cleaner and correct. - UnacceleratedStaticBitmapImage didn't destroy the SkImage in the proper thread, leading to GrContext/SkSp problems. Bug: 890576 Change-Id: Ic71e7f7322b0b851774628247aa5256664bc0723 Reviewed-on: https://chromium-review.googlesource.com/c/1307775Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#604427}
-
Mohamed Heikal authored
This is a reland of 86259392 TBR=This is the same cl no changes Original change's description: > [Android] Remove most resource names in resources.arsc > > resource names are stored in the resources.arsc file to allow for > getIdentifier with the string name of the resource to work. This cl > obfuscates all of those resources to one name (and thus stored only > once) for all resources that are not accessed via getIdentifier. > > This improves binary size by about 200KB. > > Bug: 894208 > > Change-Id: I28c440c22b90cd045f53017073fdb88c7410d530 > Reviewed-on: https://chromium-review.googlesource.com/c/1265897 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603229} Bug: 894208 Change-Id: Id023518c91c0c98cf68f15efad286c4874b4976d Reviewed-on: https://chromium-review.googlesource.com/c/1308991Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604426}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3a8f1e2b37f..f3b8abe13293 git log a3a8f1e2b37f..f3b8abe13293 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 fmayer@google.com Merge "profiling: Allow to shut down client." 2018-10-31 hjd@google.com perfetto-ui: A number of small fixes 2018-10-31 primiano@google.com Merge "UI: Add support for /proc/[pid]/status poller" 2018-10-31 hjd@google.com Merge "perfetto-ui: Add counter track" Created with: gclient setdep -r src/third_party/perfetto@f3b8abe13293 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I15c78f0c3be2c53a44b9e92036827c85afa15020 Reviewed-on: https://chromium-review.googlesource.com/c/1310593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604425}
-
Mohamed Heikal authored
Updating third_party/android_build_tools/aapt2 to version 3.3.0-beta01-5013011. This is because the current version has bug with regards to webview resources package ids (see https://crbug.com/899656) Bug: 894208, 899656 Change-Id: I0258c3b9ab0018a9fe01f23d5ab3b81faf3bd49c Reviewed-on: https://chromium-review.googlesource.com/c/1307995Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604424}
-
Tom Sepez authored
This is a longstanding issue where termination checks were not made properly for the SVG case, since they needed to be outside an enclosing if-block. The code now matches what the pre-existing comments above say. Bug: 898105 Change-Id: I55fbcb88fe46428190ff442ef5e98c912e445600 Reviewed-on: https://chromium-review.googlesource.com/c/1310570Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604423}
-
Eric Karl authored
This change corrects some bugs in SharedImage refcounting: - SharedImages now count against a MemoryTypeTracker for a channel that holds a ref. Previously they would keep the original creating channel's MemoryTypeTracker, which could lead to issues if that channel was destroyed but the SharedImage was exported / kept alive by a different channel. - SharedImageBackings now manage ref counts internally, rather than in SharedImageManager. Allows a backing to know which trackers are keeping it alive. - Consumers of SharedImageRepresentations now create them though a SharedImageRepresentationFactory, which bundles a MemoryTypeTracker and forwards it to SharedImageManager. - The creating ref is now managed using a SharedImageRepresentationFactoryRef, rather than a special Register/Unregister pair. This normalizes tracking w/ other representation-based methods. Change-Id: Ia4585e589f96d0d64b00123bdc65ff126bbd32c1 Reviewed-on: https://chromium-review.googlesource.com/c/1298735 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604422}
-
Charlie Harrison authored
This logic is pulled out and looked at by the popup_blocker.cc, since we never want to block these types of popups even if we add additional popup policy. While we're at it, rename ShouldApplyStrongPopupBlocker to ShouldApplyAbusivePopupBlocker, which is more precise. Bug: None Change-Id: Id9f31522f697b4ead95e8e23b89da325c0960f3e Reviewed-on: https://chromium-review.googlesource.com/c/1311260Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#604421}
-
Ehsan Karamad authored
When 'vertical-scroll' policy is disabled in a document, the contents cannot be scrolled (will not be user-input scrollable and targeted for gesture scroll). However, currently disabling 'vertical-scroll' still leaves the vertical scrollbars behind; the bars position cannot be changed however. This CL fixes the issue by hiding the vertical scrollbars for scrollable elements inside documents where the policy is enforced (i.e., disabled). Bug: 898151 Change-Id: If01925e27184a7370d5b12583dc73bc946f2c6e2 Reviewed-on: https://chromium-review.googlesource.com/c/1305878 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604420}
-
Kristi Park authored
Add functionality for reordering custom links. Will initialize if custom links has not been initialized yet. Bug: 851335 Change-Id: I67710b4187f8f5a45d7f96814c17294f87d60b22 Reviewed-on: https://chromium-review.googlesource.com/c/1308899 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#604419}
-
Jimmy Gong authored
- The text field for File Share URL will now initialize to the most recently used share path. Bug: chromium:887133 Test: end to end Change-Id: Ic59f7d34332b25c0e28832c6109060b849e838f2 Reviewed-on: https://chromium-review.googlesource.com/c/1300797Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#604418}
-
Sergey Ulanov authored
Minor fixes in the code that allocates VMOs to pass images to scenic: 1. VMO handle is now dropped immediately after VMO is mapped. 2. Added check to verify that VMO is mapped successfully. 3. Read-only VMO handle is passed to Scenic. Bug: 899348 Change-Id: Ie78261ffc00dd5c9b80cc2b93ad2006a47c5118d Reviewed-on: https://chromium-review.googlesource.com/c/1309301 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604417}
-
Yuke Liao authored
This CL updates the md doc's mailing list to code-coverage@chromium. Change-Id: Ifb620a543b4afb13239cf8736832448047787aba Reviewed-on: https://chromium-review.googlesource.com/c/1311089Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604416}
-
Reilly Grant authored
This change resets the SerialDeviceEnumeratorPtr held by this class after enumeration is complete. This breaks the reference cycle between these two objects, allowing them both to be freed. Bug: 898177 Change-Id: I874c62f89f8bb59a2c41f8c40afd537404f4580b Reviewed-on: https://chromium-review.googlesource.com/c/1311533Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604415}
-
John Rummell authored
It appears that AVC level 5.2 is supported by Chrome for both encrypted and non-encrypted videos, so update MIME checking to indicate that it is supported. BUG=622873 TEST=browser_tests pass Change-Id: I569c1ec64313905ff38ae540c6bf354884959924 Reviewed-on: https://chromium-review.googlesource.com/c/1299909Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#604414}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5ca3e5a0b285..580baf379673 git log 5ca3e5a0b285..580baf379673 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 brandon1.jones@intel.com Recompile D3D11 Blit Shaders 2018-10-31 jmadill@chromium.org Scale down a slow index buffer perf test. Created with: gclient setdep -r src/third_party/angle@580baf379673 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ib72a547f0c9298e510eb330a2440f440fafdc8af Reviewed-on: https://chromium-review.googlesource.com/c/1310602Reviewed-by:
-
Peter Kotwicz authored
This CL: - Introduces H2OTransparentLauncherActivity to handle deep links and share intents - Makes H2OTransparentLauncherActivity launch SplashActivity prior to launching the host browser so that: 1) Launching WebAPK via deep link 2) Tapping app icon brings the already open WebAPK to the front instead of launching a new activity stack - Makes H2OTransparentLauncherActivity update which of SplashActivity and H2OMainActivity is enabled. BUG=817263,817263 Change-Id: I1ff2b66171ae561c804d25257ec54f3d5bda459b Reviewed-on: https://chromium-review.googlesource.com/c/1304222 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604412}
-
Jeremy Roman authored
Change-Id: I8aa29772ece72b8fcf88f1f402746b24740cef9e Reviewed-on: https://chromium-review.googlesource.com/c/1302317Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604411}
-
Lucas Furukawa Gadani authored
This CL also adds an API to retrieve the portal given a portal token. Bug: 865565 Change-Id: Ie8f5e8f5aaea395811e9da3afc04fc89df48196b Reviewed-on: https://chromium-review.googlesource.com/c/1297248Reviewed-by:
-
Mike Klein authored
Change-Id: Idc26e054b44b1d73a322538464bb2549c801e64f Reviewed-on: https://chromium-review.googlesource.com/c/1308016Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#604409}
-
Kristi Park authored
Root cause has been fixed in https://crbug/898941 Bug: 897006 Change-Id: Ie1a6cbb60345c733fe088858870696dcc69a5683 Reviewed-on: https://chromium-review.googlesource.com/c/1310717Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#604408}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9afc6490c148..861640f6c89b git log 9afc6490c148..861640f6c89b --date=short --no-merges --format='%ad %ae %s' 2018-10-31 ehmaldonado@chromium.org metrics: Collect git version. Created with: gclient setdep -r src/third_party/depot_tools@861640f6c89b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=agable@chromium.org Change-Id: I4b44c2cc00e2c84d5b7f6b1f306521a22e322504 Reviewed-on: https://chromium-review.googlesource.com/c/1311055Reviewed-by:
-
Tarun Bansal authored
Add a periodic timer that checks queued requests and may dispatch requests that have been queued for too long. This change is guarded behind a field trial. Change-Id: I43c85bd92b7a34c078f18fb87931806266f32813 Bug: 897371 Reviewed-on: https://chromium-review.googlesource.com/c/1303412 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604406}
-
Martin Kreichgauer authored
WinWebAuthnApi is a wrapper around the native WebAuthn library. The corresponding headers have not made it into the Windows SDK used by Chromium yet, therefore none of this code is currently included in the build. WinNativeCrossPlatformAuthenticator is a FidoAuthenticator implementation that forwards requests to the native library. Bug: 898718 Change-Id: I1c144bdeabe763debaadadad2c4937f9778c1d96 Reviewed-on: https://chromium-review.googlesource.com/c/1298734 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#604405}
-
Xi Han authored
The ChromeMojoProxyResolverFactory may be created in early startup when the ui thread hasn't be promoted to BrowserThread::UI. Therefore, it can't use DCHECK_CURRENTLY_ON(content::BrowserThread::UI) to check whether it is accessed on the same thread. Instead, we could use SequenceCheck for the check and make sure it is accessed sequentially. Bug: 729596 Change-Id: Id31e53e1ec369b029a843656cf86fc605d768a43 Reviewed-on: https://chromium-review.googlesource.com/c/1308667Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/79263ca083e0..22a617f93038 git log 79263ca083e0..22a617f93038 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 thestig@chromium.org Roll third_party/skia/ 728b7f3cd..7258e97e8 (1 commit) 2018-10-31 thestig@chromium.org Roll third_party/skia/ 8dc68c67f..728b7f3cd (88 commits) 2018-10-31 thestig@chromium.org Roll third_party/skia/ 588f8796..8dc68c67 (1 commit) Created with: gclient setdep -r src/third_party/pdfium@22a617f93038 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie39911bb576066a2f81b80558d1a15662c3ff357 Reviewed-on: https://chromium-review.googlesource.com/c/1310555Reviewed-by:
-
Matt Menke authored
We don't support CT on iOS, so this CL removes the relevant NetworkService APIs and objects on iOS. We also don't support it on Android, but removing the APIs there would require a fair bit of work on the net-internals code. Bug: 887122 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I012ea593f1df5a25a9379f57a268225ba2d42381 Reviewed-on: https://chromium-review.googlesource.com/c/1249884Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604402}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c9eace8194dd..06768fc14b7a git log c9eace8194dd..06768fc14b7a --date=short --no-merges --format='%ad %ae %s' 2018-10-31 brianosman@google.com Use std::numeric_limits for SK_FloatNaN and Infinity 2018-10-31 halcanary@google.com SkShaper: Fix a couple of crashes when fonts aren't found 2018-10-31 bsalomon@google.com Make nanobench --mpd flush between canvases. 2018-10-31 herb@google.com Don't allocate space for the unique glyphs. 2018-10-31 halcanary@google.com experimental/tools/generate-unicode-test-txt: update 2018-10-31 caryclark@skia.org docs with more pop 2018-10-31 recipe-roller@chromium.org Roll recipe dependencies (nontrivial). 2018-10-31 herb@google.com Size buffers properly for bulk interface between Painter and SkDraw Created with: gclient setdep -r src/third_party/skia@06768fc14b7a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I7b85222feb2e5c35b99808bef5d4dfce949a6c9c Reviewed-on: https://chromium-review.googlesource.com/c/1310556Reviewed-by:
-
Avi Drissman authored
If a beforeunload dialog is being shown, the commit has to wait for the user's response. Do not allow the commit timeout to fire during that time. This also does some associated cleanup, moving the GPU switching observer to be the RenderViewHost. BUG=891423 Change-Id: Ie2274098ef4de451e17334a9716776242e9c07ee Reviewed-on: https://chromium-review.googlesource.com/c/1303094 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#604400}
-
Stephen McGruer authored
This CL aligns Chromium with the URL spec, such that we consider '#' to mark the end of the content and the start of the fragment section only. GURL::GetContent was updated to reflect this, with a special case for javascript URLs specifically (as their spec mentions including '#' in the URL content). This is a reland of I49c6f4d739a2dd42eecc9947f8e75071b84e9be7. Recent data shows that kDataUriHasOctothorpe is now rare on WebView, and the Chrome side data has also shifted to be a long tail of smaller users. Plan is to land this change again and see if anything breaks. TBR=rdevlin.cronin@chromium.org,mlamouri@chromium.org,pfeldman@chromium.org,boliu@chromium.org Bug: 123004 Change-Id: Ib72b8eef4bd61db4f2488e522d3d4cfcfa8a1a14 Reviewed-on: https://chromium-review.googlesource.com/c/1297172 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#604399}
-
Charlie Harrison authored
Bug: 900062,839190 Change-Id: I0b5ed1f711a221790cfe0f2ee40842a46556e50c Reviewed-on: https://chromium-review.googlesource.com/c/1308034Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#604398}
-
Scott Violet authored
This changes how ExtensionAppWindowLauncherController watches for activation. ExtensionAppWindowLauncherController inherits activation watching from wm::ActivationChangeObserver. The ActivationChangeObserver is added to Shell's root window. This doesn't work for mash. This switches ExtensionAppWindowLauncherController to use a Widget observer. This works in both the mash and non-mash code. I did not promote this logic to AppWindowLauncherController as AppWindowLauncherController is also used for arc/crostini windows, which are created in ash and should continue to use AppWindowLauncherController (at least for the single-process-mash case). For multi-process-mash the arc/crostini launcher code likely does not work at all (because the windows are entirely created by ash) and will need more extensive changes. BUG=826386 TEST=covered by test Change-Id: If5f89d88f782ce452f10889da17210f41189dc77 Reviewed-on: https://chromium-review.googlesource.com/c/1306355Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604397}
-
Ryan Sturm authored
In a refactor from the InfoBar delegate into the PreviewsUITabHelper, we stopped reporting non-opt outs to Previews code. This will break Previews for all users in M71 once they dismiss enough previews (even if we serve them a lot of Previews they do not dismiss). Bug: 900711 Change-Id: I1f0e2da1c7421f3ec8668b79b09ad0367e4dce47 Reviewed-on: https://chromium-review.googlesource.com/c/1311118Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59f591bd4e30..454cfea9e32c Created with: gclient setdep -r src-internal@454cfea9e32c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278 TBR=mmoss@chromium.org Change-Id: I43d9f88d60591c8efc9328a1e13f8127357d1ac5 Reviewed-on: https://chromium-review.googlesource.com/c/1310600Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604395}
-
Carlos Knippschild authored
This change adds a new metrics that works as a mirror of OfflinePages.OfflineUsage, aptly named OfflinePages.OfflineUsage.NotOfflineResilient, that should report exactly the same values but does not accumulate counters in PrefsService, reporting them directly to UMA instead. We want to compare these two metrics to try and assess the loss bias of metrics often reported in offline situations. Bug: 899800, 857134 Change-Id: I90b83ce1da638ca389ef38785a9f5ef1bb4538f3 Reviewed-on: https://chromium-review.googlesource.com/c/1305397 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#604394}
-
