GitLab

BUG=328847

Review URL: https://codereview.chromium.org/441683002

Cr-Commit-Position: refs/heads/master@{#291667}

BUG=chromium:404093

Review URL: https://codereview.chromium.org/492343003

Cr-Commit-Position: refs/heads/master@{#291666}

BUG=chromium:404093

Review URL: https://codereview.chromium.org/497063002

Cr-Commit-Position: refs/heads/master@{#291665}

TBR=haruki

BUG=407063

Review URL: https://codereview.chromium.org/501953002

Cr-Commit-Position: refs/heads/master@{#291664}

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/494213003

Cr-Commit-Position: refs/heads/master@{#291663}

Review URL: https://codereview.chromium.org/377293002

Cr-Commit-Position: refs/heads/master@{#291662}

PasswordSyncableService shouldn't tolerate the situation when 2 or more passwords in the password store have the same sync tag.

BUG=396900

Review URL: https://codereview.chromium.org/493233003

Cr-Commit-Position: refs/heads/master@{#291661}

dbus::Message::GetSignature() was incorrectly renamed to
dbus::Message::GetDataSigature() in
https://codereview.chromium.org/502793002. This CL undoes that.

BUG=None
TEST=dbus_unittests

Review URL: https://codereview.chromium.org/494263003

Cr-Commit-Position: refs/heads/master@{#291660}

TBR=mcasas

BUG=407061

Review URL: https://codereview.chromium.org/502933002

Cr-Commit-Position: refs/heads/master@{#291659}

Update implementations of webrtc::SetSessionDescriptionObserver to use the new OnComplete signature.

Review URL: https://codereview.chromium.org/468783003

Cr-Commit-Position: refs/heads/master@{#291658}

https://codereview.chromium.org/428143002 added a way to enable sync types programmatically, i.e. without user choice. This should be reflected in the sync settings dialog.

BUG=403326

Review URL: https://codereview.chromium.org/494973003

Cr-Commit-Position: refs/heads/master@{#291657}

The abort callback should be set to the last abortable operation.

TEST=browser_tests: *FileSystemProvider*WriteFile*
BUG=405821

Review URL: https://codereview.chromium.org/497013003

Cr-Commit-Position: refs/heads/master@{#291656}

The pref's exclusive user AppWindow will move to extensions/browser

Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h}
Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc

BUG=403726

Committed: https://chromium.googlesource.com/chromium/src/+/3da4417c5baa6b8fe0be9aa012f0fd3294d9dbc7

Review URL: https://codereview.chromium.org/493003002

Cr-Commit-Position: refs/heads/master@{#291655}

Revert of Added PrintingContext::Delegate to get parent view handle and application locale. (patchset #13 of https://codereview.chromium.org/478183005/)

Reason for revert:
PrintJobTest.SimplePrint leaking on Linux ASAN bots since this was checked in:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29?numbuilds=100

This CL looks like the likeliest culprit.

Original issue's description:
> Added PrintingContext::Delegate to get parent view handle and application locale.
>
> BUG=374321
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ee8f4e4029c09ba77e7dbb8fddd85186642b3de8

TBR=noamsml@chromium.org,inferno@chromium.org,yzshen@chromium.org,thestig@chromium.org,jschuh@chromium.org,vitalybuka@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=374321

Review URL: https://codereview.chromium.org/504763002

Cr-Commit-Position: refs/heads/master@{#291654}

Revert of cc: Don't consider tiles at the layers raster_contents_scale incomplete (patchset #3 of https://codereview.chromium.org/484363003/)

Reason for revert:
Unit test added fails all the time.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/6770

Original issue's description:
> cc: Don't consider tiles at the layers raster_contents_scale incomplete
>
> When PictureLayerImpl chooses a scale to raster at, we should accept
> tiles at that scale as complete, and not try wait for tiles at some
> other scale to be filled in. Such a tiling may not even exist.
>
> R=enne, vmpstr
> BUG=406433
>
> Committed: https://chromium.googlesource.com/chromium/src/+/60c7d86bb7685d8ca04ee53ae20fcdd6cd37eb5f

TBR=enne@chromium.org,vmpstr@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=406433

Review URL: https://codereview.chromium.org/505723002

Cr-Commit-Position: refs/heads/master@{#291653}

Revert of Merge apps/pref* to extensions/browser/pref* (patchset #1 of https://codereview.chromium.org/493003002/)

Reason for revert:
Breaks GN:

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/10608

Original issue's description:
> Merge apps/pref* to extensions/browser/pref*
>
> The pref's exclusive user AppWindow will move to extensions/browser
>
> Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h}
> Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc
>
> BUG=403726
> TBR=bartfab@chromium.org for include fix in configuration_policy_handler_list_factory.cc.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3da4417c5baa6b8fe0be9aa012f0fd3294d9dbc7

TBR=benwells@chromium.org,bauerb@chromium.org,bartfab@chromium.org,hashimoto@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=403726

Review URL: https://codereview.chromium.org/499253002

Cr-Commit-Position: refs/heads/master@{#291652}

PromoteDemotedDirtyTrackers() confused demoted dirty trackers and
non-demoted dirty trackers.

BUG=None
TEST=./unit_tests --gtest_filter="MetadataDatabaseIndex*"

Review URL: https://codereview.chromium.org/480683003

Cr-Commit-Position: refs/heads/master@{#291651}

The pref's exclusive user AppWindow will move to extensions/browser

Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h}
Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc

BUG=403726
TBR=bartfab@chromium.org for include fix in configuration_policy_handler_list_factory.cc.

Review URL: https://codereview.chromium.org/493003002

Cr-Commit-Position: refs/heads/master@{#291650}

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/499943002

Cr-Commit-Position: refs/heads/master@{#291649}

The underalying problem is now fixed. See http://crbug/293125 and  https://code.google.com/p/webrtc/source/detail?r=5870

BUG=293125, 362431

Review URL: https://codereview.chromium.org/254713004

Cr-Commit-Position: refs/heads/master@{#291648}

Includes the following CLs:

Don't use <(DEPTH) in the argument to the -include flag.
Review URL: https://codereview.chromium.org/493213002

nss: Remove two files from sources that were removed in all conditionals.
Review URL: https://codereview.chromium.org/482353002

R=kjellander@chromium.org
BUG=

Review URL: https://codereview.chromium.org/501873002

Cr-Commit-Position: refs/heads/master@{#291647}

Move TestingSearchTermsData from template_url_unittest.cc to a new file.
Stop using UIThreadSearchTermsData for tests

BUG=387985
TEST=unit_tests

Review URL: https://codereview.chromium.org/492963005

Cr-Commit-Position: refs/heads/master@{#291646}

Reading may be slow. We should be able to abort it to avoid unnecessary
consumption of resources such as network, cpu and memory.

TEST=browser_test: *FileSystemProvider*ReadFile*
BUG=400574

Review URL: https://codereview.chromium.org/496953003

Cr-Commit-Position: refs/heads/master@{#291645}

Cr-Commit-Position: refs/heads/master@{#291644}

The new MessageReader::GetSignature() method returns the DBus signature
of the value at the current iterator position, which is needed for
implementing automatic de-serialization of complex DBus messages.

BUG=None
TEST=dbus_unittests

Review URL: https://codereview.chromium.org/502793002

Cr-Commit-Position: refs/heads/master@{#291643}

Check the IME component extension's availability on linux_chromeos, so that system fallback VK can be showed.

BUG=405042
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/495593004

Cr-Commit-Position: refs/heads/master@{#291642}

BUG=406935
R=cmp@chromium.org,iannucci@chromium.org

Review URL: https://codereview.chromium.org/502863002

Cr-Commit-Position: refs/heads/master@{#291641}

1. The text is blurry because we use a transform: scale3d(), which on non-retina
desktop Chrome is blurry. I assume there is a reason why CrOS chose a scale3d()
so I only made this change for the desktop.
2. This leads to a webkit bug (crbug.com/406529) where transforms and opacity
transitions do not play well together, so I've removed the opacity transition on
the action-area-box.

Also:
3. Fixed the focus style on the "remove user" button to not be the ugly blue
default but match the gmail style.

BUG=399683, 403784
TEST=Start Chrome with -enable-new-avatar-menu. Click on "Switch person".
The profile names in the user manager should not be blurry, and hovering
over the pods should not be janky.

Review URL: https://codereview.chromium.org/476193003

Cr-Commit-Position: refs/heads/master@{#291640}

Cr-Commit-Position: refs/heads/master@{#291639}

Cr-Commit-Position: refs/heads/master@{#291638}

The branch point has passes so, this patch enables the feature again.

This patch is the revert of r289621.

BUG=305511
TEST=Confirms the cast icon appears when cast is available.
TBR=hirono@chromium.org

Review URL: https://codereview.chromium.org/496493003

Cr-Commit-Position: refs/heads/master@{#291637}

This includes some minor changes which allow tests to when NPObject is replaced
by gin in pepper:
-Add shared library exports for use of PepperTryCatch and ScopedPPVarArray in
tests.
-Add gin as a dependency to content_unittests for use in host_var_tracker_unittest
-Change TestInstanceDeprecated so that it doesn't execute a script from the
ScriptableObject upon destruction. The reason for this is that the garbage
collector is manually run from the destructor of the plugin Instance object.
This results in destruction of the ScriptableObject and then javascript is
re-entered via ExecuteScript. This should never happen outside tests because
the garbage collector won't be run synchronously. Instead of running
ExecuteScript, which just set a variable in the Instance object to verify
that the ScriptableObject was correctly destroyed.

BUG=351636

Review URL: https://codereview.chromium.org/472693002

Cr-Commit-Position: refs/heads/master@{#291636}

BUG=391641
TEST= Run the test on lumpy

Review URL: https://codereview.chromium.org/465293002

Cr-Commit-Position: refs/heads/master@{#291635}

TBR=dsinclair

Review URL: https://codereview.chromium.org/486373004

Cr-Commit-Position: refs/heads/master@{#291634}

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/491223002

Cr-Commit-Position: refs/heads/master@{#291633}

This CL removes the white TileItemBackground from the tiles on the
experimental app list start page.

BUG=349727

Review URL: https://codereview.chromium.org/492153002

Cr-Commit-Position: refs/heads/master@{#291632}

Adds support for Arm64 to 'sandbox/'. This can be used
by future CLs to provide Arm64 policy for Chrome.

BUG=355125
TEST=sandbox_linux_unittests

Review URL: https://codereview.chromium.org/487143003

Cr-Commit-Position: refs/heads/master@{#291631}

Both are valid since depot_tools r291592.

TBR=agable@chromium.org
NOTRY=true
BUG=406934

Review URL: https://codereview.chromium.org/488313003

Cr-Commit-Position: refs/heads/master@{#291630}

BUG=404631

Review URL: https://codereview.chromium.org/493213004

Cr-Commit-Position: refs/heads/master@{#291629}

Adds whitelist to commands API to relax restrictions on:
- global accelerator keys
- maximum number of commands
- override previously taken accelerators

This cl also involved fixing the use of the search key while using the global commands listener. The 'command' modifier was being dropped while making its way to the renderer and back.

BUG=404768
TEST=With a sample extension binding
"Search+Shift+L" and
"global": true

press and verify callback when
focus is inside of web content
focus is on the status tray

Review URL: https://codereview.chromium.org/399783002

Cr-Commit-Position: refs/heads/master@{#291628}